engine-flutter-autoroll
e2ddf5630d
Roll Flutter Engine from b0da68e7e024 to 666bc34c61aa (1 revision) ( #125805 )
...
b0da68e7e0...666bc34c61skia-flutter-autoroll@skia.org Roll Skia from a7f887f344c6 to 1a6a1e905518 (1 revision) (flutter/engine#41633 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-01 16:58:05 +00:00
Viren Khatri
293715a6a4
add support to customize Slider interacivity ( #121483 )
...
design doc: https://docs.flutter.dev/go/permissible-slider-interaction
closes #113370
open questions:
- No, as `SliderInteraction.none` doesn't exist anymore.
- Yes (done)
- Yes.
- SliderInteraction
- SliderAction
- Slider.allowedInteraction
- Slider.permissibleInteraction
- Slider.interaction
- Slider.allowedAction
- Slider.permittedAction
2023-05-01 16:42:05 +00:00
engine-flutter-autoroll
d9ea36ccb7
Roll Flutter Engine from b4551c72487c to b0da68e7e024 (1 revision) ( #125800 )
...
b4551c7248...b0da68e7e0kjlubick@users.noreply.github.com Reland image encoder (flutter/engine#41632 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-01 16:06:37 +00:00
engine-flutter-autoroll
3380c398cb
Roll Flutter Engine from 605528f293d0 to b4551c72487c (1 revision) ( #125795 )
...
605528f293...b4551c7248skia-flutter-autoroll@skia.org Roll Dart SDK from 823a69e2a34d to a433ca08e7e2 (3 revisions) (flutter/engine#41631 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-01 15:03:11 +00:00
engine-flutter-autoroll
fed8cc4a28
Roll Flutter Engine from bba66b658cee to 605528f293d0 (2 revisions) ( #125793 )
...
bba66b658c...605528f293skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from FV1Uu3faXL2llmvaU... to SJOgKviZ-kwWd1Z1u... (flutter/engine#41630 )
2023-05-01 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.1 to 2.3.2 (flutter/engine#41629 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from FV1Uu3faXL2l to SJOgKviZ-kwW
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-01 12:23:33 +00:00
engine-flutter-autoroll
bf6f0af299
Roll Flutter Engine from 2fa61b91d7c2 to bba66b658cee (1 revision) ( #125791 )
...
2fa61b91d7...bba66b658cskia-flutter-autoroll@skia.org Roll Skia from fe0977a822a4 to a7f887f344c6 (1 revision) (flutter/engine#41628 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-01 10:29:32 +00:00
engine-flutter-autoroll
8ecc3d9299
Roll Flutter Engine from 30c91b8180e7 to 2fa61b91d7c2 (1 revision) ( #125789 )
...
30c91b8180...2fa61b91d7skia-flutter-autoroll@skia.org Roll Skia from 5a7d7da47c10 to fe0977a822a4 (5 revisions) (flutter/engine#41627 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-01 09:30:35 +00:00
engine-flutter-autoroll
cbdeec919b
Roll Flutter Engine from d76a22e67eea to 30c91b8180e7 (1 revision) ( #125787 )
...
d76a22e67e...30c91b8180skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from uU98Ene2OeSVt21X_... to NBgD7NzOpwnAULR_g... (flutter/engine#41625 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from uU98Ene2OeSV to NBgD7NzOpwnA
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-05-01 08:31:36 +00:00
Andrew Kolos
9dbd6e6139
[tools] Apply Android Studio version detection logic to explicitly configured installation directory (flutter config --android-studio-dir) ( #125596 )
...
Fixes #121468 (when considered along with https://github.com/flutter/flutter/pull/125247 ).
This applies the pre-existing Android Studio version detection logic to the install configured with `flutter config android-studio-dir`.
2023-05-01 07:10:20 +00:00
engine-flutter-autoroll
4b74232a70
Roll Flutter Engine from f234d5e1dd26 to d76a22e67eea (1 revision) ( #125776 )
...
f234d5e1dd...d76a22e67eskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RzN-C9ZpB2ZsMq9Sn... to FV1Uu3faXL2llmvaU... (flutter/engine#41624 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from RzN-C9ZpB2Zs to FV1Uu3faXL2l
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-30 21:52:39 +00:00
engine-flutter-autoroll
e9b9d0fb00
Roll Flutter Engine from c796390d14cb to f234d5e1dd26 (1 revision) ( #125773 )
...
c796390d14...f234d5e1ddskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from R1rpDA1v0caZl5BFC... to uU98Ene2OeSVt21X_... (flutter/engine#41623 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from R1rpDA1v0caZ to uU98Ene2OeSV
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-30 19:00:25 +00:00
engine-flutter-autoroll
9241329b46
Roll Flutter Engine from e99f31f4437d to c796390d14cb (1 revision) ( #125762 )
...
e99f31f443...c796390d14skia-flutter-autoroll@skia.org Roll Skia from e98b3f40fbf2 to 5a7d7da47c10 (1 revision) (flutter/engine#41622 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-30 10:40:27 +00:00
engine-flutter-autoroll
3ed5f51208
Roll Flutter Engine from 1942b0c2cd9a to e99f31f4437d (1 revision) ( #125758 )
...
1942b0c2cd...e99f31f443skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uapMevjPUC6e5zepp... to RzN-C9ZpB2ZsMq9Sn... (flutter/engine#41621 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from uapMevjPUC6e to RzN-C9ZpB2Zs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-30 09:42:24 +00:00
engine-flutter-autoroll
9fa34e827a
Roll Flutter Engine from 7806f8a4fb4c to 1942b0c2cd9a (1 revision) ( #125757 )
...
7806f8a4fb...1942b0c2cdskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from tz8A3SWVI56hqwnzp... to R1rpDA1v0caZl5BFC... (flutter/engine#41620 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from tz8A3SWVI56h to R1rpDA1v0caZ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-30 08:42:27 +00:00
engine-flutter-autoroll
845c12fb10
Roll Flutter Engine from 8167f909bc8d to 7806f8a4fb4c (2 revisions) ( #125750 )
...
8167f909bc...7806f8a4fbskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from FUOS_QWwsi0RMumuZ... to uapMevjPUC6e5zepp... (flutter/engine#41618 )
2023-04-29 skia-flutter-autoroll@skia.org Roll Skia from 3a037528ab83 to e98b3f40fbf2 (2 revisions) (flutter/engine#41619 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from FUOS_QWwsi0R to uapMevjPUC6e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-29 20:02:06 +00:00
engine-flutter-autoroll
b319b14170
Roll Flutter Engine from 900b8a89b73b to 8167f909bc8d (1 revision) ( #125748 )
...
900b8a89b7...8167f909bcjason-simmons@users.noreply.github.com Exclude Skia's Vello directory from the license crawl (flutter/engine#41617 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-29 19:22:27 +00:00
engine-flutter-autoroll
29b3e66ecb
Roll Flutter Engine from c56ea398b0dc to 900b8a89b73b (1 revision) ( #125747 )
...
c56ea398b0...900b8a89b7jason-simmons@users.noreply.github.com Manual roll of Dart SDK from e8b86b073413 to 823a69e2a34d (flutter/engine#41614 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-29 18:18:07 +00:00
engine-flutter-autoroll
807c55c6b3
Roll Flutter Engine from 0834c886f06a to c56ea398b0dc (1 revision) ( #125746 )
...
0834c886f0...c56ea398b0skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from XeUTCh70VOPbIFXdz... to tz8A3SWVI56hqwnzp... (flutter/engine#41615 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from XeUTCh70VOPb to tz8A3SWVI56h
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-29 17:25:19 +00:00
engine-flutter-autoroll
14981ffc02
Roll Flutter Engine from 68f2ed0a1db5 to 0834c886f06a (1 revision) ( #125736 )
...
68f2ed0a1d...0834c886f0skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from xfKYQ2vkoLvxhBHIf... to FUOS_QWwsi0RMumuZ... (flutter/engine#41611 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from xfKYQ2vkoLvx to FUOS_QWwsi0R
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-29 06:53:29 +00:00
engine-flutter-autoroll
b5a1d9c5b6
Roll Flutter Engine from 0079bb4a20d0 to 68f2ed0a1db5 (1 revision) ( #125735 )
...
0079bb4a20...68f2ed0a1dskia-flutter-autoroll@skia.org Roll Skia from c7b3371bcd48 to 3a037528ab83 (2 revisions) (flutter/engine#41609 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-29 06:02:26 +00:00
Dan Field
e1e8ad8038
Fix crasher in DragableScrollableSheet when controller is animating and switching widgets ( #125721 )
...
We were failing to dispose of animation controllers created by `animateTo` when `didUpdateWidget` happens and we null out the `_attachedController`. This would cause the listener added here to fail on a null assertion:
fef41cfce0/packages/flutter/lib/src/widgets/draggable_scrollable_sheet.dart (L135)https://github.com/flutter/flutter/issues/125709
2023-04-29 05:38:08 +00:00
engine-flutter-autoroll
9417b2a468
Roll Flutter Engine from 8f04b29c1b98 to 0079bb4a20d0 (2 revisions) ( #125734 )
...
8f04b29c1b...0079bb4a20737941+loic-sharma@users.noreply.github.com Remove single view assumption from pointer events (flutter/engine#41602 )
2023-04-29 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kNDuhglIFq_xEt5n3... to XeUTCh70VOPbIFXdz... (flutter/engine#41608 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from kNDuhglIFq_x to XeUTCh70VOPb
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-29 05:11:08 +00:00
engine-flutter-autoroll
bd85177d91
Roll Flutter Engine from 788d0ed5ed06 to 8f04b29c1b98 (1 revision) ( #125731 )
...
788d0ed5ed...8f04b29c1bbdero@google.com [Impeller] Remove destructive blend mode check from Contents::ShouldRender (flutter/engine#41600 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-29 02:49:17 +00:00
engine-flutter-autoroll
0ff36a1e63
Roll Flutter Engine from 89a8affdced0 to 788d0ed5ed06 (1 revision) ( #125729 )
...
89a8affdce...788d0ed5edskia-flutter-autoroll@skia.org Roll Skia from 49412cbee072 to c7b3371bcd48 (7 revisions) (flutter/engine#41603 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-29 02:02:56 +00:00
engine-flutter-autoroll
47f4d1a9e2
Roll Flutter Engine from 3835d975c8b0 to 89a8affdced0 (2 revisions) ( #125725 )
...
3835d975c8...89a8affdceskia-flutter-autoroll@skia.org Roll Skia from 9867fa253064 to 49412cbee072 (13 revisions) (flutter/engine#41597 )
2023-04-28 godofredoc@google.com Migrate desktop artifacts to engine v2. (flutter/engine#41599 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-29 01:08:05 +00:00
engine-flutter-autoroll
6f85ff6b36
Roll Flutter Engine from 1ae848ce6b55 to 3835d975c8b0 (1 revision) ( #125722 )
...
1ae848ce6b...3835d975c8jason-simmons@users.noreply.github.com [Impeller] Ensure that embedded blobs are placed at aligned addresses. (flutter/engine#41526 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-29 00:06:50 +00:00
Anas
512e2c3fd5
fix package template create platform folders ( #125292 )
...
`package` template should not create platform folders. This happen cause by default all platforms are supported and tools didn't distinguish between package and other template, which makes all platforms are true for below code,
d186792c00/packages/flutter_tools/lib/src/project.dart (L374-L380)fixes : #119844 which make #116320 makes invalid. As for why tools created deprecated `Android Embedding`, `appManifestFile` does not exist for `package` template, which make below code to trigger,
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/project.dart#L768-L770
This does not happen with `module` and `plugin` as it have specific condition check for them. I try to reproduce it with `app` template but didn't succeed
2023-04-29 00:00:08 +00:00
Tae Hyung Kim
1a0b03cb25
Sliver Cross Axis Group ( #123862 )
...
This widget implements the ability to place slivers side by side in a single ScrollView so that they scroll together. The design document for `SliverCrossAxisGroup` can be found [here](https://docs.google.com/document/d/1e2bdLSYV_Dq2h8aHpF8mda67aOmZocPiMyjCcTTZhTg/edit?resourcekey=0-Xj2X2XA3CAFae22Sv3hAiA ).
Fixes #56756 .
2023-04-28 23:41:58 +00:00
engine-flutter-autoroll
2282eb3682
Roll Flutter Engine from 2a84ea55e4ef to 1ae848ce6b55 (1 revision) ( #125718 )
...
2a84ea55e4...1ae848ce6bskia-flutter-autoroll@skia.org Roll Dart SDK from 8e9bf2bb9878 to e8b86b073413 (1 revision) (flutter/engine#41594 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-28 23:11:06 +00:00
Zachary Anderson
fef41cfce0
Remove bringup from new_gallery_skia_ios__transition_perf ( #125715 )
...
Final step of https://github.com/flutter/flutter/pull/125663
2023-04-28 15:31:19 -07:00
engine-flutter-autoroll
63b7fa5d62
Roll Flutter Engine from 98b6fabc66bb to 2a84ea55e4ef (10 revisions) ( #125714 )
...
98b6fabc66...2a84ea55e4zanderso@users.noreply.github.com Revert "Replace deprecated and internal Skia EncodedImage calls with public versions" (flutter/engine#41595 )
2023-04-28 maruel@gmail.com Roll buildroot to c96c9d4641714301fab450a5f3b0f3c42712e1e3 (flutter/engine#41589 )
2023-04-28 ychris@google.com [platform_view] Only dispose view when it is removed from the composition order (flutter/engine#41521 )
2023-04-28 gspencergoog@users.noreply.github.com Determine lifecycle by looking at window focus also (flutter/engine#41094 )
2023-04-28 zanderso@users.noreply.github.com Increase timeout for clang-tidy on mac (flutter/engine#41588 )
2023-04-28 bdero@google.com [Impeller] Always enable validation for goldens (flutter/engine#41574 )
2023-04-28 maruel@gmail.com fuchsia: do not read version_history.json (flutter/engine#41585 )
2023-04-28 skia-flutter-autoroll@skia.org Roll Dart SDK from c7160d4ea0b7 to 8e9bf2bb9878 (5 revisions) (flutter/engine#41586 )
2023-04-28 kjlubick@users.noreply.github.com Replace deprecated and internal Skia EncodedImage calls with public versions (flutter/engine#41368 )
2023-04-28 skia-flutter-autoroll@skia.org Roll Skia from 05d09f28250a to 9867fa253064 (18 revisions) (flutter/engine#41584 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-28 22:17:35 +00:00
yaakovschectman
7d37f2a616
Opt into CMake policy CMP0135 ( #125502 )
...
~Update the windows app template and migration to use `CMP0135` when
cmake version is >= 3.24.~
Update app templates' and examples' CMakeLists.txt to use
`cmake_policy(VERSION`. https://github.com/flutter/packages/pull/3828
should obviate the need for a migration.
Addresses https://github.com/flutter/flutter/issues/116866
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-28 17:49:54 -04:00
Bruno Leroux
af050d95ae
Add a channel to query the engine keyboard state ( #122885 )
...
## Description
This PR adds a new channel to query the engine keyboard state.
See https://github.com/flutter/flutter/issues/87391#issuecomment-1228975571 for motivation.
## Related Issue
Framework side implementation for https://github.com/flutter/flutter/issues/87391 .
Once approved the framework will try to query the initial keyboard state from the engine. PRs will be needed on the engine side to answer the framework query.
## Tests
Adds 1 test.
2023-04-28 21:05:20 +00:00
Flutter GitHub Bot
73a343f191
Roll pub packages ( #125698 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-04-28 19:30:06 +00:00
Qun Cheng
a433f88d16
Checkbox.fillColor should be applied to checkbox's background color when it is unchecked. (#125643 )
2023-04-28 12:05:31 -07:00
Zachary Anderson
50f83fc277
Add back one Skia test on iOS ( #125663 )
...
Fixes https://github.com/flutter/flutter/issues/125648
2023-04-28 10:41:33 -07:00
Flutter GitHub Bot
888b208d62
Roll pub packages ( #125447 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-04-28 17:31:45 +00:00
Phlippie Bosman
69af934367
Nit: grammar in documentation ( #125462 )
...
Fixes a [grocer's apostrophe](https://www.grammar-monster.com/lessons/apostrophe_error_with_plurals.htm ).
Apostrophes are not used to indicate plurals, and this incorrect usage in the documentation tripped me up, so I figured I could submit a quick correction :)
2023-04-28 17:18:54 +00:00
engine-flutter-autoroll
a698da6078
Roll Flutter Engine from 1d25906b4cf0 to 98b6fabc66bb (4 revisions) ( #125690 )
...
1d25906b4c...98b6fabc66godofredoc@google.com Migrate Linux Arm Host Engine to engine v2. (flutter/engine#41555 )
2023-04-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Rk2iPE0_H1vjuGV4e... to kNDuhglIFq_xEt5n3... (flutter/engine#41582 )
2023-04-28 bdero@google.com [Impeller] Manage the onscreen stencil in EntityPass (flutter/engine#41563 )
2023-04-28 bdero@google.com Revert "Reland: [Impeller] Use a device buffer for SkBitmap allocation, use Linear texture on Metal backend. " (flutter/engine#41567 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Rk2iPE0_H1vj to kNDuhglIFq_x
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-28 16:10:33 +00:00
fzyzcjy
00bbf5434c
Allow users to provide route settings to showMenu ( #124935 )
...
Background: I am adding logging to things like dialogs, bottom sheets and menus. Then I realized that, showMenu does not allow users to provide RouteSettings, while showDialog and showModalBottomSheet both allow. Therefore, IMHO a consistent API design may need to add this to showMenu.
I will add tests if this proposal looks OK :)
2023-04-28 15:21:54 +00:00
Viren Khatri
5a1ef73dd0
enhances OverlayEntry docs ( #124478 )
...
Fixes https://github.com/flutter/flutter/issues/123218
2023-04-28 14:37:55 +00:00
Reid Baker
3a6c4eb14d
Smallest change required to support host apps using agp 8.0 ( #125657 )
...
Testing AGP 8.0 is not possible with the existing infra because of the java version on CI machines. See https://github.com/flutter/flutter/issues/125325 for more details.
https://github.com/flutter/flutter/issues/125181
2023-04-28 14:30:46 +00:00
arvin
f87d208742
fix RangeSlider, with no overlayShape shifts to the left ( #125483 )
2023-04-28 09:24:49 -05:00
engine-flutter-autoroll
55c988fb45
Roll Flutter Engine from 3d61e293cb96 to 1d25906b4cf0 (1 revision) ( #125658 )
...
3d61e293cb...1d25906b4cskia-flutter-autoroll@skia.org Roll Skia from f7c8a58c2127 to 05d09f28250a (4 revisions) (flutter/engine#41557 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-28 00:32:55 +00:00
Jenn Magder
6b73885e2d
Increase Xcode minimum version to 14 ( #125639 )
...
Looks like CocoaPods 1.12.1 is incompatible with < Xcode 14 due to https://github.com/CocoaPods/CocoaPods/pull/11828 (see https://github.com/flutter/flutter/issues/123890 for context).
Bump the minimum Xcode version allowed by tooling to 14, released September 2022.
```
[!] Xcode - develop for iOS and macOS (Xcode 13.4)
â Flutter requires Xcode 14 or higher.
Download the latest version or update via the Mac App Store.
```
Fixes https://github.com/flutter/flutter/issues/125286 .
Previous bump at #97746 .
2023-04-27 23:17:56 +00:00
gmackall
eba2a520b4
Add migrator to upgrade gradle version when conflict with Android Studio bundled Java version is detected ( #124085 )
...
This PR adds an android project migrator that checks the version of android studio and the version of gradle for conflicts, and upgrades to 7.4 if a conflict is detected. For more detail about the particular conflict, see https://github.com/flutter/flutter/issues/122376 .
The PR also upgrades older gradle versions being used in integration testing to 7.4.
Fixes/related to: https://github.com/flutter/flutter/issues/122376 and https://github.com/flutter/flutter/issues/123636
2023-04-27 23:07:50 +00:00
Janice Collins
fb36bba366
Update dartdoc to v6.2.2. ( #125650 )
...
This PR updates the dartdoc version to v6.2.2.
Release notes: https://github.com/dart-lang/dartdoc/releases/tag/v6.2.2
The main impact for Flutter is to update dartdoc to add chips to class and/or mixin pages for class modifiers. See dart-lang/dartdoc#3391 , dart-lang/dartdoc#3402 . This will also be a cherry-pick candidate for 3.1 if it can land in time.
- [ test-exempt ] I added new tests to check the change I am making, or this PR is [test-exempt].
2023-04-27 22:30:06 +00:00
Taha Tesser
746cacc501
Add slider_perf_android task to ci.yaml ( #125540 )
...
This adds `devicelab` task `slider_perf_android` to `.ci.yaml`, which was added in https://github.com/flutter/flutter/pull/125296
2023-04-27 21:32:39 +00:00
engine-flutter-autoroll
215fa3557b
Roll Flutter Engine from 883bb7d5cb28 to 3d61e293cb96 (1 revision) ( #125645 )
...
883bb7d5cb...3d61e293cbskia-flutter-autoroll@skia.org Roll Skia from 8441d7a93942 to f7c8a58c2127 (10 revisions) (flutter/engine#41556 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-27 19:28:10 +00:00
Christopher Fujino
4ff505c861
[flutter_tools] more debugging for timeouts in break_on_framework_exceptions test ( #125584 )
...
Better debugging to investigate: https://github.com/flutter/flutter/issues/125241
When the `test/integration.shard/break_on_framework_exceptions_test.dart` test times out, log out verbose logging to give clues as to why it did not complete.
From one local run it looks like the test runner is failing to load a test file (when I checked the path locally, the file was there, and re-running the `flutter test ...` invocation succeeded--in that the app threw an exception):
```
14:12 +26 -1: breaks when StatefulWidget.build throws [E]
Timed out launching `flutter test`
package:matcher fail
test/integration.shard/break_on_framework_exceptions_test.dart 623:11 _timeoutAfter.<fn>
250s Spawning flutter [test, --disable-service-auth-codes, --machine, --start-paused, test/test.dart] in /tmp/flutter_break_on_framework_exceptions.GUJDAZ
251s <=stdout= {"protocolVersion":"0.1.1","runnerVersion":null,"pid":25763,"type":"start","time":0}
<=stdout= {"suite":{"id":0,"platform":"vm","path":"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart"},"type":"suite","time":0}
<=stdout= {"test":{"id":1,"name":"loading /tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","suiteID":0,"groupIDs":[],"metadata":{"skip":false,"skipReason":null},"line":null,"column":null,"url":null},"type":"testStart","time":0}
258s <=stdout= {"testID":1,"error":"Exception: the Dart compiler exited unexpectedly.","stackTrace":"package:flutter_tools/src/base/common.dart 10:3 throwToolExit\npackage:flutter_tools/src/compile.dart 813:13 DefaultResidentCompiler._compile.<fn>\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7 _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11 _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11 _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11 _StringAdapterSink.close\ndart:convert/line_splitter.dart 141:11 _LineSplitterSink.close\ndart:async/stream_transformers.dart 132:24 _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7 _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11 _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11 _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11 _StringAdapterSink.close\ndart:convert/string_conversion.dart 295:20 _Utf8ConversionSink.close\ndart:convert/chunked_conversion.dart 78:18 _ConverterStreamEventSink.close\ndart:async/stream_transformers.dart 132:24 _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart...
<=stdout= {"testID":1,"error":"Failed to load \"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart\": Compilation failed for testPath=/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","stackTrace":"","isFailure":false,"type":"error","time":7518}
<=stdout= {"testID":1,"result":"error","skipped":false,"hidden":false,"type":"testDone","time":7521}
<=stdout= {"count":1,"time":7526,"type":"allSuites"}
<=stdout= {"success":false,"type":"done","time":7529}
259s Process exited (1)
371s Expecting test.startedProcess event
[+ 95] <=stdout= {"suite":{"id":0,"platform":"vm","path":"/tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart"},"type":"suite","time":0}
[+ 95] <=stdout= {"test":{"id":1,"name":"loading /tmp/flutter_break_on_framework_exceptions.GUJDAZ/test/test.dart","suiteID":0,"groupIDs":[],"metadata":{"skip":false,"skipReason":null},"line":null,"column":null,"url":null},"type":"testStart","time":0}
[+ 7600] <=stdout= {"testID":1,"error":"Exception: the Dart compiler exited unexpectedly.","stackTrace":"package:flutter_tools/src/base/common.dart 10:3 throwToolExit\npackage:flutter_tools/src/compile.dart 813:13 DefaultResidentCompiler._compile.<fn>\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7 _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11 _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11 _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11 _StringAdapterSink.close\ndart:convert/line_splitter.dart 141:11 _LineSplitterSink.close\ndart:async/stream_transformers.dart 132:24 _SinkTransformerStreamSubscription._handleDone\ndart:async/zone.dart 1391:47 _rootRun\ndart:async/zone.dart 1301:19 _CustomZone.run\ndart:async/zone.dart 1209:7 _CustomZone.runGuarded\ndart:async/stream_impl.dart 392:13 _BufferingStreamSubscription._sendDone.sendDone\ndart:async/stream_impl.dart 402:7 _BufferingStreamSubscription._sendDone\ndart:async/stream_impl.dart 291:7 _BufferingStreamSubscription._close\ndart:async/stream_transformers.dart 87:11 _SinkTransformerStreamSubscription._close\ndart:async/stream_transformers.dart 21:11 _EventSinkWrapper.close\ndart:convert/string_conversion.dart 241:11 _StringAdapterSink.close\ndart:convert/string_conversion.dart 295:20 _Utf8ConversionSink.close\ndart:convert/chunked_conversion.dart 78:18 _ConverterStreamEventSink.close\ndart:async/stream_transformers.dart 132:24...
Expecting test.startedProcess event is taking longer than usual...
```
2023-04-27 18:37:59 +00:00
