auto-submit[bot]
886de22182
Reverts "sliverGridDelegate mainAxisExtent add assert ( #148470 )" ( #149224 )
...
Reverts: flutter/flutter#148470
Initiated by: eyebrowsoffire
Reason for reverting: Unit test failures closing the tree.
Original PR Author: hello-coder-xu
Reviewed By: {QuncCccccc, Piinks}
This change reverts the following previous change:
* sliverGridDelegate mainAxisExtent add assert,Avoid incorrect use *
Fixes https://github.com/flutter/flutter/issues/138871
2024-05-29 02:33:16 +00:00
flyboy
af5a1a9e11
sliverGridDelegate mainAxisExtent add assert ( #148470 )
...
* sliverGridDelegate mainAxisExtent add assert,Avoid incorrect use *
Fixes https://github.com/flutter/flutter/issues/138871
2024-05-29 00:26:08 +00:00
Luis
b1540324e5
Fix SearchAnchor suggestions not refreshing after long API call ( #148767 )
...
Fixes https://github.com/flutter/flutter/issues/148765 .
## Fix Demo
https://github.com/flutter/flutter/assets/28322469/ad76ac8b-5e84-4fee-b04c-fbc9fa919450
2024-05-29 00:20:18 +00:00
Loïc Sharma
1f4e378de1
Add link to golden file test docs in the framework gardener guide ( #149207 )
...
This also adds a link from the Framework gardener guide.
2024-05-28 23:55:58 +00:00
Polina Cherkasova
65e3007687
Remove opt out for CurvedAnimation. ( #147594 )
2024-05-28 16:35:29 -07:00
LongCatIsLooong
0214afb40b
Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline ( #149062 )
...
Per Hixie's comment [here](https://github.com/flutter/flutter/issues/145739#issuecomment-2128006146 ), keep the current behavior
2024-05-28 23:21:08 +00:00
Polina Cherkasova
c109b3cb02
Clean leaky test. ( #149199 )
...
Introduced by https://github.com/flutter/flutter/pull/149006
To repro run:
`flutter test /Users/polinach/_/flutter_dev/packages/flutter/test/material/text_button_test.dart --dart-define LEAK_TR`
<img width="268" alt="Screenshot 2024-05-28 at 11 50 33â¯AM" src="https://github.com/flutter/flutter/assets/12115586/c1a1bf5e-4df4-4819-b897-b09021d3a07a ">
2024-05-28 23:06:10 +00:00
Gray Mackall
df64ca0b11
Change android_plugin_new_output_dir_test.dart test description ( #149198 )
...
Changes the test description to what I understand it is testing.
Context at https://discord.com/channels/608014603317936148/846507907876257822/1245077048599515157 .
cc @chunfengyao as the original author, as I see you are still active on Github ð
2024-05-28 23:04:10 +00:00
Bruno Leroux
fdca33c5b1
fix M2 InputDecorator suffix icon doesn't turn red on error ( #149161 )
...
The suffixIcon of a TextField with an error now turns red like it should (on Material 2).
2024-05-28 11:27:55 -07:00
Varun Kamani
e2e68c047c
Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimer… ( #143079 )
...
It's now possible to override the default selection overlay with CupertinoDatePicker.selectionOverlayBuilder and CupertinoTimerPicker.selectionOverlayBuilder.
2024-05-28 11:24:57 -07:00
Justin McCandless
980b5a1976
Mouse onEnter and onExit now support hovering stylus ( #149006 )
...
Hovering with a stylus will now behave similarly to hovering with a mouse. For example, hovering a button will show the button's hovered styling.
2024-05-28 10:39:30 -07:00
LongCatIsLooong
b1221a92dc
Remove TextEditingController private member access ( #149042 )
...
Fixes https://github.com/flutter/flutter/issues/148692
I intend to CP this.
2024-05-28 17:37:25 +00:00
engine-flutter-autoroll
6543a2155e
Roll Packages from b7bcb4bd1267 to a933c3016f6c (1 revision) ( #149184 )
...
b7bcb4bd12...a933c3016fengine-flutter-autoroll@skia.org Roll Flutter from 656447127360 to 0b31ffc125e9 (7 revisions) (flutter/packages#6820 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 15:46:17 +00:00
engine-flutter-autoroll
87564cec51
Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) ( #149169 )
...
b1751088c7...d0323905fcskia-flutter-autoroll@skia.org Roll Skia from 312160c7c920 to 848d9498fd68 (1 revision) (flutter/engine#53059 )
2024-05-28 jonahwilliams@google.com [Impeller] Use scaled font to determine bounds, match Skia position rounding behavior, add subpixel X/Y/All/None positioning. (flutter/engine#53042 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 15:39:26 +00:00
Kevin Moore
891432c30f
[tool] Use kebabCase directly ( #149150 )
...
Drop silly snakeCase(..., '-') bits
2024-05-28 15:33:15 +00:00
Kate Lovett
1fbcbb73a0
[wiki migration] Leftover wiki pages and links ( #148989 )
...
This is waiting on
- https://github.com/flutter/flutter/pull/148777
- https://github.com/flutter/flutter/pull/148790
After this PR lands, there will likely be 1-2 more clean up PRs, after which the migration will be done!
---
This moves the remaining wiki pages as planned in [flutter.dev/go/migrate-flutter-wiki-spreadsheet](https://docs.google.com/spreadsheets/d/1x65189ZBdNiLRygpUYoU08pwvXD4M-Z157c6pm8deGI/edit?usp=sharing )
It also adds the team labels to the label bot for future PRs.
Changes to the content were only updating cross links, or links to refer to the main branch rather than master.
Remaining links to the wiki will be updated once all other pages have finished moving, they still work in the meantime.
Part of https://github.com/flutter/flutter/issues/145009
2024-05-28 15:12:10 +00:00
engine-flutter-autoroll
a1a33e63b9
Roll Flutter Engine from 6e0f812d82fe to b1751088c7e9 (1 revision) ( #149157 )
...
6e0f812d82...b1751088c7skia-flutter-autoroll@skia.org Roll Skia from 064f93590e63 to 312160c7c920 (1 revision) (flutter/engine#53058 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 07:56:25 +00:00
Martin Kustermann
9938ab1c60
[web] Remove --dart-sdk flag to dart2wasm compiler ( #149129 )
...
Dart2wasm only needs a platform file, which contains the compiled
`dart:*` libraries. There's no need to specify a seperate `--dart-sdk`
option (anymore).
(See also https://dart-review.googlesource.com/c/sdk/+/366821 )
2024-05-28 09:48:44 +02:00
engine-flutter-autoroll
ea1976a17c
Roll Flutter Engine from 416c619829a6 to 6e0f812d82fe (1 revision) ( #149155 )
...
416c619829...6e0f812d82chinmaygarde@google.com Add an unoptimized Android debug config to local_engine.json. (flutter/engine#53057 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 07:01:24 +00:00
engine-flutter-autoroll
47f463c382
Roll Flutter Engine from cf201b119585 to 416c619829a6 (1 revision) ( #149148 )
...
cf201b1195...416c619829byoungchan.lee@gmx.com Add Linux platform support for fetching refresh rate on startup. (flutter/engine#52934 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-28 02:26:25 +00:00
engine-flutter-autoroll
f0d6c4413c
Roll Flutter Engine from dcc063c8deae to cf201b119585 (1 revision) ( #149143 )
...
dcc063c8de...cf201b1195skia-flutter-autoroll@skia.org Roll Skia from 96479ef610f5 to 064f93590e63 (1 revision) (flutter/engine#53056 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 20:32:29 +00:00
engine-flutter-autoroll
a821c2113b
Roll Packages from 7b423f582180 to b7bcb4bd1267 (7 revisions) ( #149136 )
...
7b423f5821...b7bcb4bd12engine-flutter-autoroll@skia.org Roll Flutter from cb26a01a40e9 to 656447127360 (3 revisions) (flutter/packages#6796 )
2024-05-26 stuartmorgan@google.com Update Flutter wiki links (flutter/packages#6789 )
2024-05-25 engine-flutter-autoroll@skia.org Roll Flutter from 8dd08314d2e4 to cb26a01a40e9 (12 revisions) (flutter/packages#6794 )
2024-05-24 stuartmorgan@google.com [ci] Switch podspec check over to ARM (flutter/packages#6791 )
2024-05-24 stuartmorgan@google.com [pointer_interceptor] Add Swift Package Manager support (flutter/packages#6790 )
2024-05-24 engine-flutter-autoroll@skia.org Roll Flutter from 8d955cdd644e to 8dd08314d2e4 (22 revisions) (flutter/packages#6788 )
2024-05-24 joonas.kerttula@codemate.com [google_maps_flutter_platform_interface] Add improvements to BitmapDescriptor API (flutter/packages#6687 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 15:54:25 +00:00
engine-flutter-autoroll
0b31ffc125
Roll Flutter Engine from 451480f2bf66 to dcc063c8deae (1 revision) ( #149125 )
...
451480f2bf...dcc063c8deskia-flutter-autoroll@skia.org Roll Skia from a74086522b47 to 96479ef610f5 (1 revision) (flutter/engine#53054 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 09:39:05 +00:00
engine-flutter-autoroll
73fb6c7eff
Roll Flutter Engine from 76f5849eec5d to 451480f2bf66 (1 revision) ( #149123 )
...
76f5849eec...451480f2bfskia-flutter-autoroll@skia.org Roll Skia from 33234e7c2072 to a74086522b47 (3 revisions) (flutter/engine#53052 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 08:48:26 +00:00
engine-flutter-autoroll
fa156f9d8b
Roll Flutter Engine from 2b92f87cb5c1 to 76f5849eec5d (1 revision) ( #149121 )
...
2b92f87cb5...76f5849eecskia-flutter-autoroll@skia.org Roll Skia from 0ac91408b96a to 33234e7c2072 (1 revision) (flutter/engine#53051 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 08:08:06 +00:00
Valentin Vignal
1efca65408
Add test for future_builder.0.dart ( #148453 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/async/future_builder.0.dart`
2024-05-27 07:12:56 +00:00
engine-flutter-autoroll
63b17c8401
Roll Flutter Engine from 469193ef0e9a to 2b92f87cb5c1 (1 revision) ( #149119 )
...
469193ef0e...2b92f87cb5chinmaygarde@google.com [Impeller] Suppress SPIRV validation errors in latest Vulkan SDK. (flutter/engine#53049 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 07:12:55 +00:00
engine-flutter-autoroll
8fd8e66de4
Roll Flutter Engine from e91fbacde56d to 469193ef0e9a (1 revision) ( #149114 )
...
e91fbacde5...469193ef0eskia-flutter-autoroll@skia.org Roll Skia from f357c9f2781c to 0ac91408b96a (1 revision) (flutter/engine#53047 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 01:49:30 +00:00
engine-flutter-autoroll
eb1027f678
Roll Flutter Engine from f3025ae1511b to e91fbacde56d (1 revision) ( #149101 )
...
f3025ae151...e91fbacde5skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from j_hH7zx04OsJaL9p2... to c-Sm5-fy8c2YM7Myk... (flutter/engine#53046 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from j_hH7zx04OsJ to c-Sm5-fy8c2Y
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-27 01:03:32 +00:00
engine-flutter-autoroll
6564471273
Roll Flutter Engine from a207dfe8e96b to f3025ae1511b (1 revision) ( #149098 )
...
a207dfe8e9...f3025ae151skia-flutter-autoroll@skia.org Roll Skia from 93ef9f3c4f39 to f357c9f2781c (1 revision) (flutter/engine#53045 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-26 05:45:25 +00:00
engine-flutter-autoroll
e2c25b24ca
Manual roll Flutter Engine from 1d154ff93a87 to a207dfe8e96b (10 revisions) ( #149096 )
...
Manual roll requested by zra@google.com
1d154ff93a...a207dfe8e9#53032 )" (flutter/engine#53041 )
2024-05-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from b759e9f83ff9 to aed02f471e34 (1 revision) (#53036 )" (flutter/engine#53040 )
2024-05-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from aed02f471e34 to 17c351dd16f4 (1 revision) (#53037 )" (flutter/engine#53039 )
2024-05-25 skia-flutter-autoroll@skia.org Roll Skia from 6e42cb7a099d to 93ef9f3c4f39 (1 revision) (flutter/engine#53038 )
2024-05-25 skia-flutter-autoroll@skia.org Roll Dart SDK from aed02f471e34 to 17c351dd16f4 (1 revision) (flutter/engine#53037 )
2024-05-25 skia-flutter-autoroll@skia.org Roll Dart SDK from b759e9f83ff9 to aed02f471e34 (1 revision) (flutter/engine#53036 )
2024-05-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 9PoD1BZXVglZ-EWu3... to j_hH7zx04OsJaL9p2... (flutter/engine#53035 )
2024-05-25 skia-flutter-autoroll@skia.org Roll Skia from a783c0c8df89 to 6e42cb7a099d (1 revision) (flutter/engine#53034 )
2024-05-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 641d61332238 to b759e9f83ff9 (1 revision) (flutter/engine#53032 )
2024-05-25 skia-flutter-autoroll@skia.org Roll Skia from 7eb8515603c1 to a783c0c8df89 (1 revision) (flutter/engine#53033 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 9PoD1BZXVglZ to j_hH7zx04OsJ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 22:21:25 +00:00
Bruno Leroux
0f3882e050
Fix Linux numpad shortcuts on web ( #148988 )
...
## Description
This PRs fixes a Web issue on Linux related to numpad keys.
In https://github.com/flutter/flutter/pull/145464 , I introduced numpad shortcuts for Linux. These shortcuts work well on a desktop Linux application but they broke the Linux+Web numpad logic.
When I added these shortcuts, I expected them to not be active on Web (because I knew that on Web, those shortcuts are handled by the browser). But there is a trick: text editing shortcuts are still defined on Web but they are disabled at the editable text level so one can use them in components that are not `EditableText` (see https://github.com/flutter/flutter/pull/103377 ).
In this PR, I used the same approach than for other text editing shortcuts: when on web associate those shortcuts to the `DoNothingAndStopPropagationTextIntent` intent.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/148447 .
## Tests
Updates 2 tests.
Adds 2 tests.
2024-05-25 19:59:19 +00:00
engine-flutter-autoroll
cb26a01a40
Roll Flutter Engine from e0207131ea13 to 1d154ff93a87 (1 revision) ( #149070 )
...
e0207131ea...1d154ff93askia-flutter-autoroll@skia.org Roll Skia from 0b7d656b9c03 to 7eb8515603c1 (1 revision) (flutter/engine#53031 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 03:06:27 +00:00
engine-flutter-autoroll
45d7dbad8f
Roll Flutter Engine from f693fdd840e8 to e0207131ea13 (7 revisions) ( #149068 )
...
f693fdd840...e0207131easkia-flutter-autoroll@skia.org Roll Dart SDK from 4ef8ed68a8d4 to 641d61332238 (1 revision) (flutter/engine#53029 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from 10459d97152a to 0b7d656b9c03 (3 revisions) (flutter/engine#53028 )
2024-05-24 flar@google.com Reland "DisplayListBuilder internal reorganization with better rendering op overlap detection" (52646) (flutter/engine#53002 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from 137a4ea4e033 to 10459d97152a (3 revisions) (flutter/engine#53027 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from d252bca326a6 to 137a4ea4e033 (1 revision) (flutter/engine#53026 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from 97783ac3000d to d252bca326a6 (2 revisions) (flutter/engine#53025 )
2024-05-24 chinmaygarde@google.com Rename Skia specific TUs. (flutter/engine#52855 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 01:38:22 +00:00
engine-flutter-autoroll
5bf11bc2cd
Roll Flutter Engine from b5e98f9b8d0f to f693fdd840e8 (4 revisions) ( #149057 )
...
b5e98f9b8d...f693fdd8401961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix overlay reorganization for edge case with only 1 overlay (flutter/engine#53006 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 49b226cecee7 to 4ef8ed68a8d4 (1 revision) (flutter/engine#53024 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from f832549400ab to 97783ac3000d (1 revision) (flutter/engine#53023 )
2024-05-24 30870216+gaaclarke@users.noreply.github.com [Impeller] sped up the linear gradient by moving calculations to the cpu (flutter/engine#53007 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-25 00:44:19 +00:00
Joodo
734d243bc8
fix popup menu offset when using useRootNavigator in PopupMenu ( #144670 )
...
fix issue #144669
2024-05-24 21:38:08 +00:00
hangyu
735c3a857a
[GAR][a11y] Update assessment app to unblock tester from testing dark mode ( #149055 )
...
internal: b/317130300
reopening #149004
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-05-24 13:44:55 -07:00
hangyu
8ff57091bc
[a11y] Slider should respect bold text setting ( #149053 )
...
Fix https://github.com/flutter/flutter/issues/147600
internal GAR issue: b/316933135
reopen from #148435
2024-05-24 19:48:14 +00:00
Kostia Sokolovskyi
7be97ab781
Add tests for editable_text.on_changed.0.dart API example. ( #148874 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds tests for `examples/api/lib/widgets/editable_text/editable_text.on_changed.0.dart`
2024-05-24 19:21:12 +00:00
engine-flutter-autoroll
aa6382093e
Roll Flutter Engine from 979214444aca to b5e98f9b8d0f (1 revision) ( #149051 )
...
979214444a...b5e98f9b8dskia-flutter-autoroll@skia.org Roll Skia from 956e77ac96fd to f832549400ab (1 revision) (flutter/engine#53022 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 18:22:08 +00:00
Kostia Sokolovskyi
6a20a5b19c
Add test for text_editing_controller.0.dart API example. ( #148872 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds test for `examples/api/lib/widgets/editable_text/text_editing_controller.0.dart`
2024-05-24 17:50:00 +00:00
engine-flutter-autoroll
6093a9cd2b
Roll Flutter Engine from 4ab442475223 to 979214444aca (3 revisions) ( #149045 )
...
4ab4424752...979214444askia-flutter-autoroll@skia.org Roll Skia from 92f576fd2c52 to 956e77ac96fd (2 revisions) (flutter/engine#53021 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Dart SDK from fef7786d65f9 to 49b226cecee7 (1 revision) (flutter/engine#53020 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from 8b8cf5b49988 to 92f576fd2c52 (1 revision) (flutter/engine#53019 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 16:26:09 +00:00
Łukasz Gawron
a53b78ddfb
Fix TwoDimensionalViewport's keep alive child not always removed (when no longer should be kept alive) ( #148298 )
...
- Fixes a child not removed from `_keepAliveBucket` when widget is no longer kept alive offscreen. Bug was triggering assert in performLayout.
- Adds test to cover the case from bug report
Fixes #138977
2024-05-24 16:26:07 +00:00
engine-flutter-autoroll
6861b77c2b
Roll Packages from 1008d9e9cd07 to 7b423f582180 (2 revisions) ( #149043 )
...
1008d9e9cd...7b423f5821stuartmorgan@google.com [ci] Start moving podspec check to ARM (flutter/packages#6782 )
2024-05-24 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds onHttpError callback to NavigationDelegate to catch HTTP error status codes (flutter/packages#6378 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 15:44:06 +00:00
engine-flutter-autoroll
8dd08314d2
Roll Flutter Engine from c6041cd9049c to 4ab442475223 (1 revision) ( #149039 )
...
c6041cd904...4ab4424752skia-flutter-autoroll@skia.org Roll Skia from 33f0e2e61db9 to 8b8cf5b49988 (1 revision) (flutter/engine#53017 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 11:26:25 +00:00
engine-flutter-autoroll
ca3aeb0151
Roll Flutter Engine from 8d896f4feb76 to c6041cd9049c (1 revision) ( #149035 )
...
8d896f4feb...c6041cd904skia-flutter-autoroll@skia.org Roll Skia from fc250ec3157f to 33f0e2e61db9 (1 revision) (flutter/engine#53016 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 10:18:25 +00:00
engine-flutter-autoroll
4cb47b864b
Roll Flutter Engine from fe3b26294d8f to 8d896f4feb76 (1 revision) ( #149030 )
...
fe3b26294d...8d896f4febskia-flutter-autoroll@skia.org Roll Skia from 447b7a9db1a7 to fc250ec3157f (1 revision) (flutter/engine#53015 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 08:53:24 +00:00
engine-flutter-autoroll
f524ea89fe
Roll Flutter Engine from b4fb08f21757 to fe3b26294d8f (1 revision) ( #149028 )
...
b4fb08f217...fe3b26294dskia-flutter-autoroll@skia.org Roll Skia from 0a5870c8a4b4 to 447b7a9db1a7 (1 revision) (flutter/engine#53014 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 07:54:14 +00:00
engine-flutter-autoroll
b3d8053f04
Roll Flutter Engine from f873230ce823 to b4fb08f21757 (2 revisions) ( #149025 )
...
f873230ce8...b4fb08f217skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jQHA0UEiQtfQTuWzM... to 9PoD1BZXVglZ-EWu3... (flutter/engine#53012 )
2024-05-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 9d7324ea563a to fef7786d65f9 (1 revision) (flutter/engine#53011 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from jQHA0UEiQtfQ to 9PoD1BZXVglZ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 06:14:19 +00:00
engine-flutter-autoroll
722178b405
Roll Flutter Engine from d78f66753332 to f873230ce823 (1 revision) ( #149021 )
...
d78f667533...f873230ce8skia-flutter-autoroll@skia.org Roll Skia from f2053e772e6f to 0a5870c8a4b4 (1 revision) (flutter/engine#53010 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-24 04:54:24 +00:00
