firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
83,346 Commits 1 Branch 0 Tags
Commit Graph

83346 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
engine-flutter-autoroll
8c5bbf2931
Roll Fuchsia Linux SDK from y-WmESARBN4BZF0gs... to zb7ddt_3LqBcDg5_U... (#165711) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-22 01:32:10 +00:00
auto-submit[bot]
1cf57f1eaa
Reverts "Remove unused Cocoon components from devicelab/bin/test_runner.dart. (#165628)" (#165709) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#165628
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: breaking tree:


https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_mokey%20backdrop_filter_perf__e2e_summary/3833/overview
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: matanlurey
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole, yjbanov}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
🚫 **Do not merge** until
https://flutter-review.googlesource.com/c/recipes/+/64220/1 is merged.

---

Closes https://github.com/flutter/flutter/issues/165618.

The `devicelab/bin/test_runner.dart upload-metrics` command use to have
_two_ responsibilities:

- Well, upload test **metrics** (benchmarks) to Skia Perf (it still does
that)
- Upload test **status** to Cocoon (it did until
https://github.com/flutter/flutter/pull/165614)

As https://github.com/flutter/flutter/pull/165614 proved, this API
predated the current LUCI setup, where Cocoon itself receives task
status updates from LUCI, and it turns out this entire time, DeviceLab
was making (at best) NOP calls, and at worst, causing crashes and
corrupt data (https://github.com/flutter/flutter/issues/165610).

In other words, this is removing entirely dead/unused code (though the
recipes have to be updated first).

/cc @jason-simmons as I need Jason's help reviewing the recipes change
and want to provide context.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-03-21 22:30:47 +00:00
auto-submit[bot]
9164e2332e
Reverts "Moving Linux linux_unopt for tree greeness (#165694)" (#165705) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#165694
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: bot is green (no, really, this specific bot is
green).
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jtmcdole
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {matanlurey}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Unknown how many more changes are needed to make the tree go green and
close out #163012.

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-03-21 21:44:25 +00:00
Matan Lurey
b06c05c6f4
Remove unused Cocoon components from devicelab/bin/test_runner.dart. (#165628) 
🚫 **Do not merge** until
https://flutter-review.googlesource.com/c/recipes/+/64220/1 is merged.

---

Closes https://github.com/flutter/flutter/issues/165618.

The `devicelab/bin/test_runner.dart upload-metrics` command use to have
_two_ responsibilities:

- Well, upload test **metrics** (benchmarks) to Skia Perf (it still does
that)
- Upload test **status** to Cocoon (it did until
https://github.com/flutter/flutter/pull/165614)

As https://github.com/flutter/flutter/pull/165614 proved, this API
predated the current LUCI setup, where Cocoon itself receives task
status updates from LUCI, and it turns out this entire time, DeviceLab
was making (at best) NOP calls, and at worst, causing crashes and
corrupt data (https://github.com/flutter/flutter/issues/165610).

In other words, this is removing entirely dead/unused code (though the
recipes have to be updated first).

/cc @jason-simmons as I need Jason's help reviewing the recipes change
and want to provide context.
 2025-03-21 21:27:48 +00:00
engine-flutter-autoroll
eab1fadb8c
Roll Packages from cf9b0f25a06d to 69816394d25a (1 revision) (#165673) 
cf9b0f25a0...69816394d2

2025-03-21 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.0 in
/packages/webview_flutter/webview_flutter_android/android
(flutter/packages#8841)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-21 21:17:33 +00:00
Daco Harkes
ff97c28f20
[native assets] Roll dependencies (#165574) 
Updating the dart-lang/native dependencies to the ones published today.
 2025-03-21 20:46:08 +00:00
Tong Mu
cc35800e6a
Fix SpringSimulation formula for underdamping (#165017) 
Fix https://github.com/flutter/flutter/issues/163858

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-03-21 20:46:07 +00:00
Victoria Ashworth
673d9979e7
Save a provisioning profile to flutter config for manual code-signing (#164984) 
This adds the ability to save a provisioning profile to the flutter
config. It introduces a flag `flutter config
--select-ios-signing-settings` which prompts the user to select either
Automatic or Manual code-signing and then select a code-signing
identity/cert for Automatic or a provisioning profile for Manual.


Fixes https://github.com/flutter/flutter/issues/164983.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-03-21 20:44:03 +00:00
John "codefu" McDole
97bdde5f74
Moving Linux linux_unopt for tree greeness (#165694) 
Unknown how many more changes are needed to make the tree go green and
close out #163012.
 2025-03-21 20:01:59 +00:00
Jason Simmons
bfe880363e
Fix pylint warning in run_tests.py (#165692) 2025-03-21 19:35:49 +00:00
Jason Simmons
d3571a28a1
Remove the path_ops library test from the run_tests script (#165675) 
This test was not running previously on the Linux builder, but it
started running again when ASAN was disabled due to the Ubuntu 24
upgrade on LUCI. The test is not currently functioning as intended and
needs to be disabled until the Ubuntu upgrade is stable.

See https://github.com/flutter/flutter/pull/165661
 2025-03-21 17:36:44 +00:00
John "codefu" McDole
b6921e1895
Mark Linux linux_web_engine as bringup (#165665) 
After upgrading Ubuntu to 24.04, these tests started flaking.
 2025-03-21 15:38:08 +00:00
Jason Simmons
5a8d4032e9
Disable the address sanitizer in the linux_unopt build (#165661) 
This is causing issues on LUCI workers that were upgraded to a new
version of Ubuntu.

See https://github.com/flutter/flutter/issues/165594
See https://github.com/flutter/flutter/pull/165620
 2025-03-21 15:02:51 +00:00
Jonah Williams
8fde4325ab
remove missing import. (#165624) 
What can you do
 2025-03-21 01:56:29 +00:00
Jonah Williams
8b49f4d4f0
disable linux lsan. (#165620) 
With the ubuntu upgrade, everything is leaking now.
 2025-03-21 01:36:47 +00:00
auto-submit[bot]
0158281d6e
Reverts "[Impeller] add a configuration option that allows defering all PSO construction until needed. (#165261)" (#165619) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#165261
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: bork the tree
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jonahwilliams
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {gaaclarke}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
The cost of bootstapping the initial PSOs can regress cold startup time
for customer money. As an experiment, attempt to defer PSO construction
to skia like.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-03-21 00:17:47 +00:00
Matan Lurey
55f257e39e
Skip /api/update-task-status on Devicelab (#165614) 
Mitigates https://github.com/flutter/flutter/issues/165610.

If this works, we can likely not only fix the tree status, but delete
code from Cocoon (and dev/devicelab). Yay!
 2025-03-21 00:08:03 +00:00
Jonah Williams
cab4fe33c3
[Impeller] add a configuration option that allows defering all PSO construction until needed. (#165261) 
The cost of bootstapping the initial PSOs can regress cold startup time
for customer money. As an experiment, attempt to defer PSO construction
to skia like.

---------

Co-authored-by: Aaron Clarke <aaclarke@google.com>
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
 2025-03-20 21:06:09 +00:00
Victor Sanni
1fa9254076
Cupertino navigation bars transitionBetweenRoutes fidelity update (#164956) 
In the before Flutter video, drag happens after the 17 second mark.

## Flutter before


https://github.com/user-attachments/assets/9fbcd59e-68aa-4975-9a66-f05e72071223


## Flutter after



https://github.com/user-attachments/assets/784d7f46-a8ce-4e5f-a849-3b19df6668c9



## Flutter back swipe drag gesture



https://github.com/user-attachments/assets/09d38c01-aeea-46c1-90b4-590861f8f3a2




## Native iOS


https://github.com/user-attachments/assets/f2ab96c0-766b-4452-b6d5-3f92e6b6785f

## Flutter scaled back chevron and large title after


https://github.com/user-attachments/assets/ba87add7-affa-4dcc-b2f0-abbc3487d677






## Native iOS scaled back chevron and large title


https://github.com/user-attachments/assets/5c7bfe5b-5789-4ab9-8e36-770cf802b1b1



Native iOS is probably using a spring simulation. This is the closest
curve we have to the native transition, but should be updated in the
future with the exact values.

Fixes [Cupertino navigation bars transitionBetweenRoutes fidelity
update](https://github.com/flutter/flutter/issues/164662)
 2025-03-20 19:54:59 +00:00
Chinmay Garde
2db84b20f9
[Impeller] libImpeller: Expose APIs to draw shadows. (#165517) 
Fixes https://github.com/flutter/flutter/issues/165146
 2025-03-20 17:28:00 +00:00
Matthew Kosarek
554c814ada
(#112207) Adding view_id parameter to DispatchSemanticsAction and UpdateSemantics (#164577) 
fixes #112207

## What's new?
- Added a `view_id` on `UpdateSemantics`
- Added a `view_id` on `DispatchSemanticsAction`
- Piped the `view_id` all over creation
- Updated tests for these actions across the different platforms
- Added `FlutterEngineSendSemanticsAction` to the embedder API in order
to not break `FlutterEngineDispatchSemanticsAction`
- Using this view ID properly on the Windows platform (see
`engine/src/flutter/shell/platform/windows/flutter_windows_engine.cc`)

## How to test
1. Checkout
[foundation-plus-framework](https://github.com/canonical/flutter/pull/36)
from canonical/flutter
2. Merge this branch into it
3. Enable the "Narrator" screen reader on windows
4. Run the Multi window reference app (see
[PR](https://github.com/canonical/flutter/pull/36) for details)
5. Open up another window, and note that the right buttons and things
are being highlighted, as the screenreader would expect 🎉

## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-03-20 16:30:07 +00:00
engine-flutter-autoroll
9451e1dcfd
Roll Packages from dd781d4bcb7f to cf9b0f25a06d (1 revision) (#165570) 
dd781d4bcb...cf9b0f25a0

2025-03-20 tarrinneal@gmail.com [pigeon] Dart Class Equality
(flutter/packages#8788)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-20 15:54:32 +00:00
engine-flutter-autoroll
7f2064cda1
Roll Dart SDK from 6cece361df65 to c929e6d3d08f (2 revisions) (#165568) 
https://dart.googlesource.com/sdk.git/+log/6cece361df65..c929e6d3d08f

2025-03-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-210.0.dev
2025-03-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-209.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-20 15:54:32 +00:00
Huy
e0676b47c7
Add SearchAnchor.viewOnOpen and SearchAnchor.bar.onOpen (#164541) 
Fix https://github.com/flutter/flutter/issues/160886

From the context of the issue, user wants to observe open/close events
for search view with SearchController.isOpen. However, I think that is
not a friendly approach/solution due to it relies on a
TextEditingController, it is a ValueNotifier which we implicitly
understand is dedicated to text input.

During the investigation, I found that `viewOnClose` works perfectly
because it is a callback from `_SearchViewRoute` (which is a PopupRoute
so it has didPush and didPop callbacks that we can leverage). `onClose`
was called on `didPop`, so we can solve this by creating a similar
`onOpen` then call it on `didPush`. Users then can implement both
callbacks for their needs.

In this PR:

- Propose adding SearchAnchor.viewOnOpen and `SearchAnchor.bar`.onOpen
- Improve documentation of SearchController, so that users will not be
confused with `SearchController.isOpen`

#### Demo (after the fix)


https://github.com/user-attachments/assets/7f30b831-e2d7-4a72-bc0f-35c858e3427b



## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Signed-off-by: huycozy <huy@nevercode.io>
 2025-03-20 10:22:23 +00:00
Sigurd Meldgaard
95843ca334
Normalize path before searching for package config (#165392) 
If we don't normalize the `.absolute.path` will look like `/child/.`
And `Directory('/child/.').parent` is `Directory('/child)`.
 2025-03-20 10:07:32 +00:00
Jim Graham
e6fbc63d37
[Impeller][DisplayList] Consolidate BlendMode definitions (#165450) 
The 2 enum classes `impeller::BlendMode` and `flutter::DlBlendMode` were
essentially identical so they were merged.

The names were consolidated to the ui.BlendMode/DlBlendMode versions and
the implementation is shared from Impeller to DisplayList via a `using`
directive. No conversion is needed any more to describe blend modes
between DisplayList and Impeller.
 2025-03-20 05:34:06 +00:00
engine-flutter-autoroll
75b9a25fc2
Roll Fuchsia Linux SDK from nvix6F7GN9Q4nLH2Z... to y-WmESARBN4BZF0gs... (#165534) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-20 02:40:35 +00:00
engine-flutter-autoroll
57bde858cd
Roll Dart SDK from fab994cca421 to 6cece361df65 (1 revision) (#165532) 
https://dart.googlesource.com/sdk.git/+log/fab994cca421..6cece361df65

2025-03-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-208.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-20 02:12:34 +00:00
engine-flutter-autoroll
bb46cc88d0
Roll Fuchsia Test Scripts from 8_KSzzxn-koDLjCoa... to Odv8fZ_wqp4I5Nln7... (#165526) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter
Please CC chrome-fuchsia-engprod@google.com,jsimmons@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-20 00:36:23 +00:00
ash2moon
ecbb115ae3
deprecate Android announcement events and add deprecation warning. (#165195) 
Due to this [Android
deprecation](https://developer.android.com/reference/android/view/View#announceForAccessibility(java.lang.CharSequence))
Flutter needs to show deprecation warnings to developers when using
announce on Android.

Unfortunately testing this log statement is impossible since robolectric
currently does not support API >=36.
https://github.com/flutter/flutter/issues/165220 will add the test code
in once robolectric supports 36.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-03-19 23:42:18 +00:00
Jonah Williams
125a2b749e
[Impeller] fix barriers on PowerVR hardware / ensure Render pass cached on non-MSAA. (#165497) 
Work towards https://github.com/flutter/flutter/issues/162033

- barriers for render pass are not correct, but only causes a problem on
powervr/imagination. Added new external subpass dependencies that have
better descriptions for what they do. We now use the subpass to
transition images that are sampled to the final shaderReadOnlylayout,
while keeping swapchain images in eGeneral.

- missing cache for render pass objects when using non-msaa passes. This
mostly impacts powervr hardware because render pass construction is much
slower there.
 2025-03-19 23:31:04 +00:00
engine-flutter-autoroll
a7a3f55ccd
Roll Skia from dbfd72770bdd to e1f426dad46d (1 revision) (#165518) 
https://skia.googlesource.com/skia.git/+log/dbfd72770bdd..e1f426dad46d

2025-03-19 bungeman@google.com Do not create nullptr SkTypeface_proxy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com,jvanverth@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-19 21:09:16 +00:00
engine-flutter-autoroll
ff6ce3fb9b
Roll Dart SDK from cef5d9bd7616 to fab994cca421 (1 revision) (#165516) 
https://dart.googlesource.com/sdk.git/+log/cef5d9bd7616..fab994cca421

2025-03-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-207.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-19 20:49:07 +00:00
Qun Cheng
32b34ff99e
Add aria menu roles to menu-related widgets (#164741) 
Related to https://github.com/flutter/flutter/issues/157177

This PR is to add the following changes:
* Implement `SemanticsRole.menu`, `SemanticsRole.menuItem`,
`SemanticsRole.menuBar`, `SemanticsRole.menuItemCheckbox`, and
`SemanticsRole.menuItemRadio`.
* Add `SemanticsRole.menu` role in ~`MenuAnchor`~, `DropdownButton`, and
`PopupMenuButton`
~* Add `SemanticsRole.menuBar` role to `MenuBar`~
* Add `SemanticsRole.menuItem` to ~`MenuItemButton`~, `DropdownMenuItem`
and `PopupMenuItem`
~* Add `SemanticsRole.menuItemCheckbox` to `CheckboxMenuButton`~
~* Add `SemanticsRole.menuItemRadio` to `RadioMenuButton`~

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-03-19 20:33:15 +00:00
engine-flutter-autoroll
bf3826d2ce
Roll Skia from 38a5185e01f1 to dbfd72770bdd (3 revisions) (#165503) 
https://skia.googlesource.com/skia.git/+log/38a5185e01f1..dbfd72770bdd

2025-03-19 drott@chromium.org [Fontations] Harmonize "slight"
autohinting behavior with FreeType
2025-03-19 kjlubick@google.com Remove slow path for
SkBitmapDevice::drawRRect
2025-03-19 thomsmit@google.com this is my first commit

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com,jvanverth@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-19 18:43:38 +00:00
LongCatIsLooong
342223f2e8
Implement Autocomplete layout with the new OverlayPortal childLayoutBuilder API (#165249) 
Fixes https://github.com/flutter/flutter/issues/160625

This also makes it very easy to implement
https://github.com/flutter/flutter/issues/101620.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-03-19 16:35:24 +00:00
engine-flutter-autoroll
7bd886eae0
Roll Skia from 89c9fb59a4ca to 38a5185e01f1 (1 revision) (#165488) 
https://skia.googlesource.com/skia.git/+log/89c9fb59a4ca..38a5185e01f1

2025-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 95b891d12c2f to 6737c973130b (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com,jvanverth@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-19 15:59:09 +00:00
engine-flutter-autoroll
20e7f8db47
Roll Packages from d450e1bfa713 to dd781d4bcb7f (5 revisions) (#165489) 
d450e1bfa7...dd781d4bcb

2025-03-19 robert.odrowaz@leancode.pl [camera_avfoundation] Tests
backfilling - part 4 (flutter/packages#8854)
2025-03-18 robert.odrowaz@leancode.pl [camera_avfoundation] Tests
backfilling - part 5 (flutter/packages#8873)
2025-03-18 zezohassam@gmail.com [video_player]: reduce video player
position update interval from 500ms to 100ms (flutter/packages#8346)
2025-03-18 joonas.kerttula@codemate.com [google_maps_flutter] Support
for Ground Overlay (flutter/packages#8432)
2025-03-18 joonas.kerttula@codemate.com [google_maps_flutter] Ground
overlay support - platform impls (flutter/packages#8563)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-19 15:51:26 +00:00
engine-flutter-autoroll
3705758a18
Roll Dart SDK from 30a676454f03 to cef5d9bd7616 (1 revision) (#165487) 
https://dart.googlesource.com/sdk.git/+log/30a676454f03..cef5d9bd7616

2025-03-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-206.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-19 15:22:09 +00:00
Flutter GitHub Bot
a780f85f2c
Marks Linux tool_integration_tests_4_7 to be unflaky (#165475) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux tool_integration_tests_4_7"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20tool_integration_tests_4_7%22).
This test can be marked as unflaky.
 2025-03-19 13:03:58 +00:00
Flutter GitHub Bot
59d00e6fed
Marks Linux tool_integration_tests_6_7 to be unflaky (#165477) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux tool_integration_tests_6_7"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20tool_integration_tests_6_7%22).
This test can be marked as unflaky.
 2025-03-19 12:54:47 +00:00
Flutter GitHub Bot
f87f0de96f
Marks Linux tool_integration_tests_5_7 to be unflaky (#165476) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux tool_integration_tests_5_7"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20tool_integration_tests_5_7%22).
This test can be marked as unflaky.
 2025-03-19 12:54:47 +00:00
engine-flutter-autoroll
830fd09310
Roll Skia from 9e3741eedfc6 to 89c9fb59a4ca (2 revisions) (#165467) 
https://skia.googlesource.com/skia.git/+log/9e3741eedfc6..89c9fb59a4ca

2025-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from ae71cc1cd4ca to 2657dba2814d (11 revisions)
2025-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 5d97d5be883b to 27b44046a577 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com,jvanverth@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-19 10:03:39 +00:00
Victor Sanni
010d31d109
Introduce Expansible, a base widget for ExpansionTile (#164049) 
Take 2 

Design doc:
[flutter.dev/go/codeshare-expansion-tile](https://docs.google.com/document/d/1GTyEZjjTpx6fcrzOX-6kQ3phwu5UhUGLOWXJoy0yto0/edit?tab=t.0)

Fixes [Codeshare between ExpansionTile and its Cupertino
variant](https://github.com/flutter/flutter/issues/163552)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-03-19 07:56:09 +00:00
engine-flutter-autoroll
5323f13842
Roll Skia from 42c6eb9a70e4 to 9e3741eedfc6 (1 revision) (#165461) 
https://skia.googlesource.com/skia.git/+log/42c6eb9a70e4..9e3741eedfc6

2025-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 9ddc965c0836 to dfc82bb1097a (16 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com,jvanverth@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-19 06:26:21 +00:00
engine-flutter-autoroll
ca21baed15
Roll Dart SDK from 382211559d5e to 30a676454f03 (1 revision) (#165460) 
https://dart.googlesource.com/sdk.git/+log/382211559d5e..30a676454f03

2025-03-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-205.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-19 06:26:21 +00:00
Ujjwal Pratap Singh
42d4f69566
fix: "show dialog" functions should allow setting an AnimationStyle (#164002) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

fixes issue #154744

## Pre-launch Checklist

- [✅] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [✅] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [✅] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [✅] I signed the [CLA].
- [✅] I listed at least one issue that this PR fixes in the description
above.
- [✅] I updated/added relevant documentation (doc comments with `///`).
- [✅] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [✅] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [✅] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
 2025-03-19 05:40:18 +00:00
Jonah Williams
403404ccd1
[gradle] fix local engine property name (#165444) 
I would recommend changing the propety mock so that the properties are
given as strings and not constants, otherwise you can run into problems
like this where the mock does exactly what you want :)
 2025-03-19 00:30:41 +00:00
engine-flutter-autoroll
3d0efc2706
Roll Skia from 5e37e525459d to 42c6eb9a70e4 (3 revisions) (#165440) 
https://skia.googlesource.com/skia.git/+log/5e37e525459d..42c6eb9a70e4

2025-03-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c1c31f4d17a9 to 95b891d12c2f (172 revisions)
2025-03-18 kjlubick@google.com Disable 3 failing sksl->spirv tests
2025-03-18 lokokung@google.com [dawn] Fixes Dawn backend test races by
enabling implicit sync.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com,jvanverth@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-18 23:43:23 +00:00
engine-flutter-autoroll
466d13db0e
Roll Dart SDK from 2a13e6c0b088 to 382211559d5e (3 revisions) (#165438) 
https://dart.googlesource.com/sdk.git/+log/2a13e6c0b088..382211559d5e

2025-03-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-204.0.dev
2025-03-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-203.0.dev
2025-03-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-202.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-03-18 23:20:08 +00:00