Jim Graham
a513498487
[DisplayList] Migrate DlVertices onto Impeller/DisplayList geometry classes ( #160633 )
...
DlVertices was already half migrated onto the DL geometry classes, this
completes the conversion.
2024-12-20 07:01:52 +00:00
Robert Ancell
dd058ffa5b
Remove all remaining use of mock engine ( #160635 )
...
Test consistency achieved.
2024-12-20 03:48:39 +00:00
Jonah Williams
8ad15cd81e
[monorepo] mark local engine builds as bringup. ( #160627 )
...
These tests are slightly flakey due to the macos cache issue. These
aren't actually tests, instead the prepopulate an RBE cache - so the
failure shouldn't close the tree, because cold caches isn't a failure
state (its just unfortunate).
2024-12-19 23:52:54 +00:00
Jackson Gardner
d363fdc31b
Split build and test builders for web engine ( #160550 )
...
This splits the web engine into a build phase and a test phase. This
requires a few changes:
* Modify the `generate_builder_json.dart` command to produce two
separate json builder files, `linux_web_engine_build.json` and
`linux_web_engine_test.json`. The former is left as the existing builder
with `release_build: true` (which will run in the merge queue) and the
latter is added as a new builder that runs in the second CI phase.
* Change the `copy_artifacts_step.dart` to pull built artifacts from the
GCS bucket when on LUCI, instead of relying on the CAS bucket. This is
necessary to do the tests separately from the build.
* Move the `felt test --copy-artifacts` command from the build steps to
the test steps, since the test steps themselves need to pull from GCS
instead of relying on the artifacts being populated by CAS.
2024-12-19 22:58:29 +00:00
Michael Goderbauer
8e0993eda8
Auto-format Dart code in engine ( #160576 )
...
This auto-formats all *.dart files in the `engine` subdirectory and
enforces that these files stay formatted with a presubmit check.
2024-12-19 17:13:07 +00:00
Matan Lurey
ba01bab4b8
Change CRLF line endings to LF to match the .gitattributes expectations. ( #160557 )
...
Closes https://github.com/flutter/flutter/issues/160529 .
2024-12-19 15:03:06 +00:00
Yegor
b79ee9282c
[tech debt] remove web engine windows build ( #160573 )
...
It takes 30 minutes while all other bots are done in 10-20 minutes. The
old Windows build used to test in IE11 and old Edge. Since we stopped
testing on those we switched to Chromium, but that doesn't provide any
extra signal in addition to what we get from Linux Chromium already.
2024-12-19 06:56:38 +00:00
John McDole
f0bf495594
Trigger Build Part Deux ( #160481 )
...
Hello, Monorepo Part Deux - after adding commit to datastore.
2024-12-18 20:18:06 +00:00
John McDole
721b47e7e6
Merge flutter/engine into framework
...
Adds files from flutter/flaux which contain modifications for the engine
structure. The history for engine/ has been edited. Please see
flutter/engine for the original PRs.
2024-12-17 14:00:52 -08:00
skia-flutter-autoroll
2a17b75443
Roll Dart SDK from a74650e32880 to 37bbc285d8d2 (1 revision) ( flutter/engine#57244 )
...
https://dart.googlesource.com/sdk.git/+log/a74650e32880..37bbc285d8d2
2024-12-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-260.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 18:32:05 +00:00
Hannes Winkler
7f8da94c21
embedder: fix bit-order in software pixel format description ( flutter/engine#57156 )
...
The order of the components for packed software pixel formats is incorrectly documented as being the order in the native type, least-significant-bit first. In reality it's the other way around. For example, for `RGB565`, the `R` is the 5 most significant bits in the 2-byte pixel value, rather than the least significant bits. The test even verify it is that way:
https://github.com/flutter/engine/blob/main/shell/platform/embedder/tests/embedder_unittests.cc#L2782-L2785
I assume noone used the software pixel formats until @sodiboo did, that's why it's gone unnoticed for so long.
Also contains some other minor documentation improvements.
- Issue: https://github.com/flutter/flutter/issues/160149
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-12-17 18:09:06 +00:00
Yegor
fe7d6f3917
[monorepo] remove Linux Web Framework tests ( flutter/engine#57234 )
...
The motivation is described in https://github.com/flutter/flutter/issues/160405 . This is just one step towards cleaning everything up. More PRs to follow.
2024-12-17 17:53:16 +00:00
skia-flutter-autoroll
7db982f38d
Roll Skia from dca47129cf2e to f784f78a5669 (3 revisions) ( flutter/engine#57242 )
...
https://skia.googlesource.com/skia.git/+log/dca47129cf2e..f784f78a5669
2024-12-17 fmalita@google.com [svg writer] Add support for radial and 2pt conical gradients
2024-12-17 fmalita@google.com [svg writer] Clean up addShaderResources
2024-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8d4040d12fd2 to dbec774c7f68 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC egdaniel@google.com ,jacksongardner@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 17:24:01 +00:00
Mouad Debbar
d2a5b9dcb1
[web] Reland: (Add crossOrigin property to <img> tag used for decoding)++ ( flutter/engine#57228 )
...
Relands https://github.com/flutter/engine/pull/54961 with a few more changes and tests.
Fixes https://github.com/flutter/flutter/issues/160127
2024-12-17 15:35:17 +00:00
skia-flutter-autoroll
9acfa539f8
Roll Dart SDK from 58fb2704f28a to a74650e32880 (1 revision) ( flutter/engine#57240 )
...
https://dart.googlesource.com/sdk.git/+log/58fb2704f28a..a74650e32880
2024-12-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-259.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 13:59:35 +00:00
skia-flutter-autoroll
891e5c6f20
Roll Dart SDK from 930f66fab234 to 58fb2704f28a (1 revision) ( flutter/engine#57239 )
...
https://dart.googlesource.com/sdk.git/+log/930f66fab234..58fb2704f28a
2024-12-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-258.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 09:43:24 +00:00
skia-flutter-autoroll
d0293d328c
Roll Skia from 2422a3fc829a to 804042d75299 (1 revision) ( flutter/engine#57238 )
...
https://skia.googlesource.com/skia.git/+log/2422a3fc829a..804042d75299
2024-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 43322002e471 to 47e0bdae10c9 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC egdaniel@google.com ,jonahwilliams@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 07:29:17 +00:00
skia-flutter-autoroll
9bdbf77fc4
Roll Dart SDK from 7ed58b3c462a to 930f66fab234 (1 revision) ( flutter/engine#57235 )
...
https://dart.googlesource.com/sdk.git/+log/7ed58b3c462a..930f66fab234
2024-12-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-257.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 05:24:23 +00:00
skia-flutter-autoroll
ea85c9e222
Roll Dart SDK from 4bfbad776c1a to 7ed58b3c462a (1 revision) ( flutter/engine#57230 )
...
https://dart.googlesource.com/sdk.git/+log/4bfbad776c1a..7ed58b3c462a
2024-12-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-256.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-17 01:15:16 +00:00
Michael Goderbauer
d00bfbb87a
Pre-format licenses script ( flutter/engine#57219 )
...
The license script has load-baring formatting: Changing its format makes signature checks fail. To ensure the formatting change goes in smoothly later this week I am taking it off the critical path by pre-formatting it.
The script itself is fairly stable, so I am not expecting any changes to it between now and when we actually enforce formatting.
Edit: The issue that surfaced with `ci/licenses_golden/licenses_dart` is another reason to take this off the critical path of enforcing formatting.
2024-12-17 00:19:17 +00:00
Michael Goderbauer
93d08f2c1a
Properly report dart format errors ( flutter/engine#57206 )
...
`dart format` can fail (e.g. if a file contains invalid dart code). Previously, those failures were swallowed. This change adds logic to properly print those failures to the terminal.
2024-12-16 23:36:47 +00:00
skia-flutter-autoroll
220114f83f
Roll Skia from 7fc6934b2034 to 2c5159518cf2 (1 revision) ( flutter/engine#57229 )
...
https://skia.googlesource.com/skia.git/+log/7fc6934b2034..2c5159518cf2
2024-12-16 fmalita@google.com [viewer] Add support for animated GIF, WEBP
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC egdaniel@google.com ,jonahwilliams@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 23:17:09 +00:00
skia-flutter-autoroll
fb1948d11e
Roll Skia from 8054b098b5cd to 7fc6934b2034 (14 revisions) ( flutter/engine#57227 )
...
https://skia.googlesource.com/skia.git/+log/8054b098b5cd..7fc6934b2034
2024-12-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from b2e692629c1f to 03700ab28aad (1 revision)
2024-12-16 jvanverth@google.com [graphite] Remove deprecated DisableCachedGlyphUploads ContextOption.
2024-12-16 kjlubick@google.com Remove unnecessary const qualifiers from function definitions
2024-12-16 jlavrova@google.com SkFontMgr_Android_ndk refactoring
2024-12-16 kjlubick@google.com Remove old, empty SkJpegInfo files
2024-12-16 borenet@google.com Add jobs for new Win11 GTX1660 machines
2024-12-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c75bd915ec7d to 00d9ef8f182c (12 revisions)
2024-12-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ae148686458b to 296cdf58b6ec (1 revision)
2024-12-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 9513e7cc4063 to 43322002e471 (12 revisions)
2024-12-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b8306de17c9a to ad54e957a812 (16 revisions)
2024-12-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from c0fe4d40475b to 23b93c7cfe27 (1 revision)
2024-12-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dabbabd8a7bf to ae148686458b (1 revision)
2024-12-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e1632bb25177 to dabbabd8a7bf (2 revisions)
2024-12-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 034518ee55a5 to e1632bb25177 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC egdaniel@google.com ,jonahwilliams@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 21:41:50 +00:00
skia-flutter-autoroll
c837b72d98
Roll Dart SDK from 02aa27c6a075 to 4bfbad776c1a (12 revisions) ( flutter/engine#57224 )
...
https://dart.googlesource.com/sdk.git/+log/02aa27c6a075..4bfbad776c1a
2024-12-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-255.0.dev
2024-12-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-254.0.dev
2024-12-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-253.0.dev
2024-12-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-252.0.dev
2024-12-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-251.0.dev
2024-12-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-250.0.dev
2024-12-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-249.0.dev
2024-12-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-248.0.dev
2024-12-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-247.0.dev
2024-12-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-246.0.dev
2024-12-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-245.0.dev
2024-12-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-244.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 20:54:04 +00:00
skia-flutter-autoroll
1c5ac8c185
Roll Fuchsia Linux SDK from iYz_WkWk1uPr8BLSZ... to zvsXvTuk-Z1Mgtn34... ( flutter/engine#57222 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 20:48:14 +00:00
Robert Ancell
90c1f8ca69
Migrate FlBinaryMessenger using embedder API instead of mock engine. ( flutter/engine#57214 )
...
This allows us to remove most of the remaining mock engine code.
2024-12-16 20:02:45 +00:00
Brett Morgan
00ea54f1fd
Flutter-GPU.md: Fix spelling ( flutter/engine#57216 )
...
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-12-16 19:26:19 +00:00
Mouad Debbar
262b472592
[web] Don't close image source too early ( flutter/engine#57200 )
...
A `CkImage` instance holds a reference to `ImageSource?`. When that `CkImage` gets cloned, the `ImageSource` instance becomes shared between the original `CkImage` and its new clone. Then when one of the `CkImage`s gets disposed of, it closes the shared `ImageSource` leaving other live `CkImage`s holding on to a closed `ImageSource`.
The quick solution to this is to have a ref count on the `ImageSource` to count how many `CkImage`s are referencing it. The `ImageSource` will only be closed if its ref count reaches 0.
Fixes https://github.com/flutter/flutter/issues/160199
Fixes https://github.com/flutter/flutter/issues/158093
2024-12-16 19:10:17 +00:00
skia-flutter-autoroll
26aec9b3ec
Roll Skia from 8c1e2bf9492c to 8054b098b5cd (5 revisions) ( flutter/engine#57197 )
...
https://skia.googlesource.com/skia.git/+log/8c1e2bf9492c..8054b098b5cd
2024-12-13 kjlubick@google.com Update delaunator to read from GoB mirror
2024-12-13 kjlubick@google.com Remove unnecessary const qualifiers from single char params
2024-12-13 egdaniel@google.com [Graphite] Add public APIs for setting cache limits.
2024-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e9b33f04020e to c75bd915ec7d (4 revisions)
2024-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b56cde80dd49 to 034518ee55a5 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jonahwilliams@google.com ,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 19:04:37 +00:00
Michael Goderbauer
24708c00d4
Reland 'Delete stale package_config.json in gclient sync hook' ( flutter/engine#57218 )
...
https://github.com/flutter/engine/pull/57195 was reverted because it tried to delete non-existing files. This adds a check to only attempt to delete the file if it exists.
2024-12-16 18:48:07 +00:00
MyriadSoft
475d981108
docs: Fix RGB565 format documentation and bit masks ( flutter/engine#57210 )
...
The RGB565 format documentation in embedder.h incorrectly stated that the red component uses the least significant bits. Unit tests in embedder/testdefs/embedder_unittests.cc demonstrate this is incorrect, showing:
- Red test (0xF800): Uses bits [15:11]
- Green test (0x07E0): Uses bits [10:5]
- Blue test (0x001F): Uses bits [4:0]
This commit fixes the documentation to correctly reflect the actual bit layout:
- Red uses 5 MSBs [15:11]
- Green uses 6 middle bits [10:5]
- Blue uses 5 LSBs [4:0]
Also fixes the example bit extraction code to use correct masks, matching the test expectations.
Impact: This change helps prevent potential developer confusion about RGB565 bit ordering and ensures the documentation matches the actual implementation as verified by the test suite.
2024-12-16 18:48:04 +00:00
Jonah Williams
481ee0e64f
[Impeller] disable AHB swapchains on all platforms. ( flutter/engine#57213 )
...
Disabling until we figure out if we can even use this.
2024-12-16 17:27:56 +00:00
Jonah Williams
0bc174d87a
[Impeller] fix Adreno precision issue in gaussian downsample. ( flutter/engine#57212 )
...
Fixes observed sampling problems on the adreno series where slightly different mediump/lowp behavior, resulting in the downsample shader showing "chunky" rendeering.
2024-12-16 17:27:53 +00:00
Jason Simmons
bb38935b9a
Disable RBE in the GN flags for wasm_release builds in the linux_web_engine builder ( flutter/engine#57204 )
...
RBE is not supported for this build. Starting the RBE proxy adds unnecessary overhead, and the attempt to use RBE will cause the build recipe to request too many parallel jobs in Ninja.
2024-12-16 15:40:20 +00:00
Robert Ancell
eb4af9071e
Migrate FlEventChannel tests to FlMockBinaryMessenger ( flutter/engine#57150 )
...
Use FlMockBinaryMessenger instead of mocking the whole engine.
2024-12-16 11:45:17 +13:00
Robert Ancell
dcd093fad7
Migrate FlMethodChannel tests to FlMockBinaryMessenger ( flutter/engine#57146 )
...
Use FlMockBinaryMessenger instead of mocking the whole engine.
2024-12-16 10:34:14 +13:00
Michael Goderbauer
b38bf972ae
Adjust some ignores for 'dart format' ( flutter/engine#57208 )
...
When running `dart format` over these lines the `// ignore` ended up on a line where it wasn't properly ignoring the lint. This adjusts the placement of `// ignore`s so they will continue to ignore the right thing even after the code is auto formatted.
I am hoping that if we do this now the large PR that formats the entire repo will go in smoother without manual intervention.
2024-12-14 02:09:06 +00:00
Michael Goderbauer
a0eb1bc42c
Fix include path in fuchsia's analysis_options.yaml files ( flutter/engine#57203 )
...
The old path doesn't exist.
`dart format` stumbles over this non-existent include.
`analysis_options.yaml` files that just imported something non-existent were deleted.
I am surprised that this never caused any other issues. Is this all dead code that isn't actually analyzed?
2024-12-14 00:51:47 +00:00
Michael Goderbauer
ee512e0442
Delete stale package_config.json in gclient sync hook ( flutter/engine#57195 )
...
On the bots there were old and stale `package_config.json` files hanging around that confuse the `dart format` command. This PR adds a step to the `pub_get_offline.py` glcient sync hook to delete all of these files that are not under version control.
2024-12-13 23:58:07 +00:00
Jason Simmons
e0263d4132
[skwasm] Fix implementation of SkwasmPath.relativeLineTo ( flutter/engine#57201 )
...
Fixes https://github.com/flutter/flutter/issues/157161
2024-12-13 23:35:13 +00:00
gaaclarke
cb9307db7e
Made compilation error colors come through et. ( flutter/engine#57174 )
...
fixes https://github.com/flutter/flutter/issues/147931
environment variable documented in github issue:
https://github.com/ninja-build/ninja/issues/2196
## screenshot of results
<img width="712" alt="Screenshot 2024-12-13 at 10 18 15 AM"
src="https://github.com/user-attachments/assets/571da2d8-065d-4b94-8ca2-a5bef5150dc7 "
/>
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/engine/blob/main/docs/testing/Testing-the-engine.md
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
2024-12-13 15:28:36 -08:00
skia-flutter-autoroll
d696f80b74
Roll Fuchsia Linux SDK from iWMEbVYaNdH8RJmXZ... to iYz_WkWk1uPr8BLSZ... ( flutter/engine#57198 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-13 21:52:02 +00:00
Yegor
f344c4699a
[web] allow imports to line-break ( flutter/engine#57170 )
...
We are about to `dart format` all the Dart code in the repo, which line-breaks some of our imports.
This PR updates `sdk_rewriter.dart` to support line-broken imports.
2024-12-13 20:42:30 +00:00
hellohuanlin
e2970df999
[ios]limit web view not tappable workaround to a limited depth ( flutter/engine#57193 )
...
This PR limits the search depth, because we don't want to enable this workaround for AdMob banner, which has a WKWebView in the depth of 7. See the previous PR for more context: https://github.com/flutter/engine/pull/57168
I was able to confirm that this returns YES for the 3P plugin, and NO for AdMob.
*List which issues are fixed by this PR. You must list at least one issue.*
https://github.com/flutter/flutter/issues/158961
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-12-13 19:25:25 +00:00
Tess Strickland
ee9024da88
Add entry-point annotations for test-only code. ( flutter/engine#57158 )
...
This change adds entry-point annotations to methods and classes accessed
by native code during engine tests. Currently, entry point annotations
are not checked by the Dart VM when running in JIT mode, only in AOT
mode. In order to also enforce entry point annotations in JIT mode,
first tests in Flutter must be appropriately annotated to avoid roll
failures.
Related issues:
* https://github.com/flutter/flutter/issues/118608
* https://github.com/dart-lang/sdk/issues/50649
2024-12-13 16:22:17 +01:00
skia-flutter-autoroll
b821ed5a05
Roll Skia from 0aec6f7bfbc8 to 8c1e2bf9492c (26 revisions) ( flutter/engine#57183 )
...
https://skia.googlesource.com/skia.git/+log/0aec6f7bfbc8..8c1e2bf9492c
2024-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7e54d43d6905 to c0fe4d40475b (1 revision)
2024-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 9513bbe24fc9 to 9513e7cc4063 (5 revisions)
2024-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from cf71700f44a8 to b8306de17c9a (15 revisions)
2024-12-13 robertphillips@google.com [graphite] Fix Build-Mac-Clang-arm64-Debug-Graphite_Dawn_Metal_NoGpu build
2024-12-12 jvanverth@google.com [graphite] Add fRequireOrderedRecordings ContextOption.
2024-12-12 robertphillips@google.com [graphite] Add trace for bad Pipeline Purge
2024-12-12 jvanverth@google.com [graphite] Stub in ClipAtlasManager.
2024-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 83e6ead8ab3b to b56cde80dd49 (8 revisions)
2024-12-12 beaufort.francois@gmail.com webgpu: Use featureLevel instead of compatibility
2024-12-12 robertphillips@google.com [graphite] Add Tracing of Pipelines being purged from the Pipeline Cache
2024-12-12 robertphillips@google.com [graphite] Expand logging/tracing of significant precompile events
2024-12-12 kjlubick@google.com Prevent bazelisk from falling back to newer Bazel versions when not pinned
2024-12-12 michaelludwig@google.com [graphite] Add note and single-owner assertion to dumpMemoryStatistics()
2024-12-12 michaelludwig@google.com [graphite] Reset wgpu::BindGroup caches in freeGpuResources()
2024-12-12 jamesgk@google.com [graphite] Reduce switching in colorspace shader
2024-12-12 bungeman@google.com Fix style and axis scanning for variable fonts
2024-12-12 kjlubick@google.com Make AUTHORS non-executable
2024-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 9b8cf765f634 to e9b33f04020e (12 revisions)
2024-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 769bd5140c26 to 83e6ead8ab3b (1 revision)
2024-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 01d91c0571a2 to cf71700f44a8 (23 revisions)
2024-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0849df86a686 to 9513bbe24fc9 (7 revisions)
2024-12-12 kjlubick@google.com Move free functions in SkCodecPriv into class namespace
2024-12-11 kjlubick@google.com Apply rewrite_includes.py diffs
2024-12-11 nicolettep@google.com Rename SkSLProgramSettings variable to be more precise
2024-12-11 kjlubick@google.com Link in jsonreader library
2024-12-11 lukasza@chromium.org [rust png] Silence `unused_unsafe` warning in `cxx`-generated code.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jonahwilliams@google.com ,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-13 07:36:24 +00:00
Jim Graham
c1b3709bdd
Migrate DlRTree and DlRegion to DisplayList/Impeller geometry classes ( flutter/engine#57175 )
...
Continuing the migration of engine code to the new geometry classes. Only DlRTree and DlRegion are converted in this pass, plus a small amount of associated code.
2024-12-13 04:33:17 +00:00
Jim Graham
9976e07414
Normalize round rect bounds when coming from Flutter ( flutter/engine#57171 )
...
A flaw in https://github.com/flutter/engine/pull/57153 - SkRRect would normalize the rect (make it right-side up), a feature that Flutter code takes advantage of. We need to do that manually when we ingest a round rect from Flutter.
2024-12-13 01:14:02 +00:00
hellohuanlin
f9125dfd91
[ios]enable the webview non tappable workaround by checking subviews recursively ( flutter/engine#57168 )
...
The original workaround ([PR](https://github.com/flutter/engine/pull/56804 )) works for the official web view plugin, but it doesn't work for a third party plugin `flutter_inappwebview` ([issue](https://github.com/pichillilorenzo/flutter_inappwebview )). Upon discussion with the author of that plugin, it turns out that their platform view is not a WKWebView, but rather a wrapper of WKWebView.
This PR performs a DFS search of the view hierarchy, and enable the workaround as long as there's a WKWebView inside.
TODO: pending sample project:
I am quite positive that it should work, but **I haven't tried it since I don't have a sample project yet**. I have requested a sample project with them so I can verify the solution.
*List which issues are fixed by this PR. You must list at least one issue.*
https://github.com/pichillilorenzo/flutter_inappwebview/issues/2415
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-12-13 01:06:45 +00:00
gaaclarke
3d8fc3c652
removed c style casts and enabled the lint ( flutter/engine#57162 )
...
test exempt: should have no functional change
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/engine/blob/main/docs/testing/Testing-the-engine.md
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
2024-12-12 15:33:37 -08:00
