10221 Commits

Author SHA1 Message Date
Ian Hickson
b9a7f1b915
Add a hasListeners to ChangeNotifier (#14946)
I found that some ValueListeners want to know when they should start
doing work (e.g. if the value comes from polling a network resource).
2018-02-28 16:37:36 -08:00
Alexander Markov
b011c66653
Roll engine to 66072316382837e66aaea518d219192a80839fc3 (#15000)
This roll contains:
* Make deprecated API unavailable (https://github.com/flutter/engine/pull/4722)
* Remove unavailable API in FlutterDartProject.h (https://github.com/flutter/engine/pull/4723)
* remove unavailabe API from FlutterDartProject.mm (https://github.com/flutter/engine/pull/4724)
* Prepare to enable global type flow analysis in AOT (https://github.com/flutter/engine/pull/4725)
2018-02-28 16:34:18 -08:00
xster
265d0d3c29
Add more haptic feedback varieties (#14829)
* Add more haptic feedback varieties

* tests

* un-meta-ify the test
2018-02-28 16:20:27 -08:00
Todd Volkert
ff04e79380
Actually update the docs site (#15003)
Fixes https://github.com/flutter/flutter/issues/15002
2018-02-28 16:12:04 -08:00
Phil Quitslund
a3f520e488
Add ‘name’s to widget location Json. (#14993) 2018-02-28 15:33:56 -08:00
Alexander Aprelev
9a9aed191d
When doing flutter test use batch compiler and link platform in. (#14983)
This is to fix #14931.
2018-02-28 12:54:30 -08:00
Danny Tuppeny
ae9fdefa4f
Fix example code just showing endless spinner when deployed from Windows (#14878)
* If example code is not found, render a message instead of an endless spinner
* Trim codeTags to avoid lookup issues with windows carriage returns
* Trim \r on Windows off the end of code blocks so they're consistently \n
* Add a test to ensure sample code parses if built on Windows
* Add a comment about why we trimRight()

Fixes #14820.
2018-02-28 20:39:48 +00:00
najeira
e0956cbdb7 remove "the" duplications (#14952) 2018-02-28 12:21:13 -08:00
jcollins-g
614df6949c
Android license detector in doctor, take two (#14783)
* Revert "Revert "Add android license verification to doctor and some refactoring" (#14727)"

This reverts commit d26029475222e8b1c7d8b80072c6b6261e2c3551.

* Add tests, fix sdkManagerEnv and use it consistently, and rearrange Status object model

* AnsiSpinner needs to leave the cursor where it found it.

* fix tests

* Const constructor warning only shows up on windows...?

* Avoid crash if we can't find the home directory

* Make pathVarSeparator return a string in the mock

* Implement review comments

* Fix out-of-order problem on stop
2018-02-28 12:09:52 -08:00
Todd Volkert
97091f513a
Fix create template for "package" (#14976)
Fixes https://github.com/flutter/flutter/issues/14975
2018-02-28 11:53:03 -08:00
Siva
fbf68bbc6d
Roll engine to version b05efc204090f430387398d3c35589571a2fe16b (#14969)
* roll engine version in flutter/flutter to b05efc204090f430387398d3c35589571a2fe16b

* Fix analyzer warnings.
2018-02-28 11:00:37 -08:00
Mikkel Nygaard Ravn
465478dac4
Update google repo url (#14958) 2018-02-28 13:34:45 +01:00
amirh
6993b203c0
Allow changing a clipper's type (ShapeBorderClipper,_BottomAppBarClipper). (#14937)
The downcast was crashing when toggling hasNotch for BottomAppBar.
2018-02-27 17:39:49 -08:00
Chris Bracken
ae6ac2ca74
Add .dart_tool to gitignore (#14932)
Dart is migrating to .dart_tool/ as the location for cached artifacts
and other temporary files generated by tooling in the SDK. As part of
this, pub will be migrating from .pub to .dart_tool/pub.

In future, this path will also be used for other tooling, such as package:build.
2018-02-27 15:29:31 -08:00
Victor Choueiri
9c895fabf2 Add intelliJ path to doctor output (#14795) 2018-02-27 15:19:32 -08:00
Todd Volkert
a5d3a9eb4b
Roll engine to e133da723c603eb43c5bf03aeb27e79c06a50e0c (#14924) 2018-02-27 15:16:21 -08:00
jcollins-g
66e3f9d8aa
Upgrade dartdoc to 0.17.0 (#14929) 2018-02-27 14:39:42 -08:00
Greg Spencer
29d59e3cb7
Switch Mac packaging to use .zip files. (#14894)
We can't use .tar.xz on Mac because although it can unpack them on the command line (with tar), the "Archive Utility" that runs when you double-click on them just does some crazy behavior (it
converts it to a compressed cpio archive, and when you double-click on that, it converts it back to .tar.xz, without ever unpacking it!)

So, this changes the script to use .zip for Mac, and the files are about 220MB larger than they need to be.
2018-02-27 13:15:32 -08:00
Todd Volkert
5dca13dea5
Remove flaky marker from android_sample_catalog_generator (#14923) 2018-02-27 10:30:45 -08:00
Alexander Aprelev
3b84503403
Move quotes around to help Powershell 2.0 to substitute variable with value (#14907) 2018-02-26 20:11:11 -08:00
xster
02546c7046
Revert engine back to 33b881 (#14905)
* Revert "Disable a text field test that fails on some Macs with libtxt (#14895)"

This reverts commit aa04a056f39cc9db23878509dc61e0dae7cd7b05.

* Revert "Roll engine to 33b88173f3820690169348859bbdc29133179e0b (#14832)"

This reverts commit 44592238bbf28fe2038bb51ed86e0038ab09a8c7.

* Revert non-engine reverts
2018-02-26 18:20:46 -08:00
Todd Volkert
91a85ac249
Fetch upstream refs before checking out branch in ChannelCommand (#14896)
https://github.com/flutter/flutter/issues/14893
2018-02-26 15:55:28 -08:00
David Shuckerow
758c221dc3
Doc improvements for animations (#14892)
* Doc improvements for animations
2018-02-26 15:39:42 -08:00
Ryan Macnak
a0ffe87bc3
Use fx get-build-dir and fx netaddr --fuchsia to make fuchsia_reload more convenient. (#14854) 2018-02-26 15:14:09 -08:00
Jason Simmons
aa04a056f3
Disable a text field test that fails on some Macs with libtxt (#14895) 2018-02-26 14:45:00 -08:00
xster
eaa9b47a4a
Add version collition error handling for Android publish (#14835) 2018-02-26 11:40:12 -08:00
Jason Simmons
44592238bb
Roll engine to 33b88173f3820690169348859bbdc29133179e0b (#14832)
libtxt is now the default text renderer
2018-02-26 11:39:48 -08:00
amirh
ed84fb9652
add a bottomAppBarColor to ThemeData (#14859) 2018-02-26 10:41:56 -08:00
Devon Carew
761cb82c6d
update the IntelliJ metadata templates (#14867)
* update the IntelliJ metedata templates

* fix test expectation
2018-02-26 07:38:22 -08:00
Alexander Aprelev
c3bbcb6f91
Add --preview-dart-2 to 'flutter drive' (#14858)
* Add --preview-dart-2 to 'flutter drive'

* Run driver side in --preview-dart-2 mode.

* Fix test
2018-02-24 09:28:58 -08:00
amirh
1f3eb5034f
Add a hasNotch flag to BottomAppBar (#14856) 2018-02-23 18:35:40 -08:00
amirh
c6e7ad1cfb
Let the FAB compute the notch even when it doesn't overlap the BAB. (#14852)
The Floating Action Button adds some margin around it for the notch.
So we need to compute a notch even when the FAB and the Bottom App Bar
doe not overlap.
2018-02-23 15:34:03 -08:00
amirh
5d39f15c69
Smooth Floating Action Button notch (#14851) 2018-02-23 14:58:50 -08:00
Jason Simmons
7f03b9e41b
Upgrade to test package version 0.12.30+4 (#14853)
30+4 has made some changes to the remoting protocol that are incompatbile
with a test harness running 30+3 (e.g. adding a type='initial' field to the
first message)
2018-02-23 12:49:57 -08:00
Vyacheslav Egorov
1f6b9471a8
Fix snapshot fingerprinting in --preview-dart-2 mode. (#14843)
* Fix snapshot fingerprinting in --preview-dart-2 mode.

This is a follow up to PR #14775 - instead of treating dill file
as an input treat as intermediate file and don't fingerprint it.

Make sure to always use original main Dart file as an entry
point for fingerprint calculation.

This fixes an issue that AOT snapshot would not be recompiled in
the preview-dart-2 mode if entry point changes, e.g.

$ flutter build aot -t t/x.dart --preview-dart-2
$ flutter build aot -t t/y.dart --preview-dart-2

The second invocation would not build AOT snapshot.

(This issue is visible on the microbencmarks bot)
2018-02-23 21:40:19 +01:00
David Shuckerow
3ee85e0137
Create and test max and min animations (#14814) 2018-02-22 14:54:27 -08:00
Hans Muller
3ea4d06340
Update TabBar indicator painter when tab controller changes (#14825) 2018-02-22 11:12:39 -08:00
amirh
01b53bd014
Fix overlap check in bottom app bar's custom clipper (#14813) 2018-02-22 09:20:37 -08:00
Greg Spencer
0b6c1938cf
Fix gsutil argument order. (#14808) 2018-02-22 09:03:10 -08:00
Michael Thomsen
382ee4baa4
Detail number of available devices in doctor summary (#14781) 2018-02-22 17:40:56 +01:00
Michael Thomsen
b6d8615aed
No longer gitignore pubspec.lock (#14768) 2018-02-22 10:11:09 +01:00
Todd Volkert
37ffb2d730
Make the isRunningOnBot getter more robust. (#14811)
It was failing in the case of an AppContext being in scope
but not having a `BotDetector` seeded in it.
2018-02-21 15:01:46 -08:00
xster
1bdbfe7b52
Fix SliverPadding dropping the chain on scrollOffsetCorrection propagation (#14789)
* Fix SliverPadding dropping the chain on scrollOffsetCorrection propagation

* review doc
2018-02-21 14:51:14 -08:00
xster
62addedc11
Fix focus switching when changing tabs in CupertinoTabScaffold (#14431)
* Fix focus switching when changing tabs in CupertinoTabScaffold

* review

* Test focuses are saved within tabs

* review
2018-02-21 12:51:19 -08:00
Mikkel Nygaard Ravn
681192a042
Fix test that makes assumptions about the impl of async method (#14804) 2018-02-21 20:47:26 +01:00
Victor Choueiri
3f884661bd Skip upgrade check on upgrade (#14797) 2018-02-21 11:34:36 -08:00
Victor Choueiri
586d7c2f20 Fix broken link to AnimatedListState documentation (#14786) 2018-02-21 11:31:43 -08:00
xster
d3418a5da4
Productionize the publishing Travis shard (#14714) 2018-02-21 10:57:21 -08:00
amirh
7996d7fb82
Initial implementation of BottomAppBar (#14713)
* add a FAB NotchMaker to ScaffoldGeometry

* add a notchMaker to FloatingActionButton

* Initial implementation of BottomAppBar

Mainly includes the notch making logic.
Not yet tested as currently there is no way to make the FAB and the BAB
overlap, once #14368 to lands we could add unit tests to the
BottomAppBar as well.

* use a closeable for clearing the FAB notchmaker
2018-02-21 10:20:58 -08:00
jcollins-g
ca677011f8
Fix flutter tools packages_test when run off bots (#14692)
* Fix packages tests when run off bots

* Tweak dependencies to make bots happy

* Review comment
2018-02-21 09:54:07 -08:00