Jiten Patel
a1651c684b
Fixes typos & spelling error in changelog.md file ( #157438 )
...
This PR fixes the typos and spelling error in `CHANGELOG.md` file.
Fixes #157083
2024-11-03 12:19:37 +00:00
Valentin Vignal
574b7e765d
Add test for raw_scrollbar.0.dart ( #157989 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/scrollbar/raw_scrollbar.0.dart`
2024-11-02 03:57:29 +00:00
engine-flutter-autoroll
ced3e85a2a
Roll Flutter Engine from 38b6165f137d to 05cb5d7f7939 (4 revisions) ( #158038 )
...
38b6165f13...05cb5d7f79matanlurey@users.noreply.github.com Refactor `BuildPlan`, better document and explain `--config`. (flutter/engine#56324 )
2024-11-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from MjcuejuzYvYGobbFM... to 07KmbdEtnhkg_tUhe... (flutter/engine#56322 )
2024-11-01 jonahwilliams@google.com [Impeller] implement external texture gl for embedder. (flutter/engine#56277 )
2024-11-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 789763468d6b to 61bf0877807e (2 revisions) (flutter/engine#56323 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from MjcuejuzYvYG to 07KmbdEtnhkg
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-02 02:24:06 +00:00
engine-flutter-autoroll
2068fe78b2
Roll Flutter Engine from 7dfdcacd8ae4 to 38b6165f137d (5 revisions) ( #158034 )
...
7dfdcacd8a...38b6165f13jonahwilliams@google.com [Impeller] fix downsample with decal tile mode. (flutter/engine#56316 )
2024-11-01 skia-flutter-autoroll@skia.org Roll Skia from dfbb0e6bc974 to 89ac72bb4922 (6 revisions) (flutter/engine#56320 )
2024-11-01 jacksongardner@google.com Remove superfluous dart2wasm test suites/bundles. (flutter/engine#56315 )
2024-11-01 jason-simmons@users.noreply.github.com Write run_tests console logs to stdout instead of stderr (flutter/engine#56312 )
2024-11-01 jonahwilliams@google.com [impeller] use greater equal rather than greater depth compare. (flutter/engine#56310 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-02 00:37:35 +00:00
Matan Lurey
8b5ad69ff8
Delete unused references to dev.flutter.plugins.e2e. ( #158031 )
...
Closes https://github.com/flutter/flutter/issues/157826 .
Like @gmackall I could not find any reference to these, and assume they were boilerplate that was never used (or deleted).
2024-11-02 00:22:04 +00:00
engine-flutter-autoroll
9a5e8ce6b5
Roll Flutter Engine from 7b176f4f25da to 7dfdcacd8ae4 (1 revision) ( #158021 )
...
7b176f4f25...7dfdcacd8ajacksongardner@google.com Reland single threaded Skwasm (flutter/engine#56282 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 21:33:22 +00:00
engine-flutter-autoroll
f45e290437
Roll Flutter Engine from 3a090b46dd35 to 7b176f4f25da (2 revisions) ( #158018 )
...
3a090b46dd...7b176f4f25skia-flutter-autoroll@skia.org Roll Skia from 3b50199d27bb to dfbb0e6bc974 (2 revisions) (flutter/engine#56305 )
2024-11-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 09c8281e66cc to 789763468d6b (2 revisions) (flutter/engine#56303 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 20:29:46 +00:00
Loïc Sharma
3699474585
Make SwiftPM integration tests even MORE idiomatic ( #158014 )
...
Reach peak idiomacy by replacing `expect(file.existsSync(), isTrue)` with `expect(file, exists)`!
Follow up to: https://github.com/flutter/flutter/pull/157971
2024-11-01 20:00:04 +00:00
Loïc Sharma
84ad67f8c1
Improve consistency of code snippets in basic.dart ( #158015 )
...
Updates `basic.dart` to use consistent doc snippets that follows the style from the [documentation on snippets](https://github.com/flutter/flutter/tree/master/dev/snippets#snippet-tool ).
Follow-up to: https://github.com/flutter/flutter/pull/157227#discussion_r1807499353
2024-11-01 19:38:19 +00:00
Matan Lurey
2ce743d0f0
Remove unnecessary kCliAnimationsFeatureName that is available as .configSetting. ( #158013 )
...
... for consistency with the rest of the file/features.
2024-11-01 19:20:59 +00:00
Loïc Sharma
49ccfb7302
Make the SwiftPM integration tests more idiomatic ( #157971 )
...
I recommend reviewing with [whitespace changes disabled](https://github.com/flutter/flutter/pull/157971/files?diff=split&w=1 ).
Changes:
1. Replaces `expect(string.contains('foo'), isTrue)` with `expect(string, contains('foo'))`
2. Replaces `try/finally` with `addTearDown`
Follow-up to: https://github.com/flutter/flutter/pull/157482#discussion_r1813939657
2024-11-01 18:15:15 +00:00
engine-flutter-autoroll
f86b777215
Roll Packages from 7cc1caa0cc36 to 796afa35071d (15 revisions) ( #158003 )
...
7cc1caa0cc...796afa3507stuartmorgan@google.com [google_maps_flutter] Update Android for non-nullable generics (flutter/packages#7990 )
2024-11-01 stuartmorgan@google.com [various] Minor cleanup in recently imported packages (flutter/packages#7995 )
2024-11-01 stuartmorgan@google.com [go_router] Update example app to Kotlin 1.9.0 (flutter/packages#7997 )
2024-10-31 engine-flutter-autoroll@skia.org Manual roll Flutter from fe71cadf1959 to 0fe615343bd9 (18 revisions) (flutter/packages#7989 )
2024-10-31 kevmoo@users.noreply.github.com [vector_garphics] fix execution on the web with WebAssembly (flutter/packages#7991 )
2024-10-31 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.9.0 to 1.9.1 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7986 )
2024-10-31 stuartmorgan@google.com [flutter_svg] Initial import (flutter/packages#7944 )
2024-10-31 stuartmorgan@google.com [vector_graphics] Initial import (flutter/packages#7941 )
2024-10-30 stuartmorgan@google.com [ci] Ensure repo tool is autoformatted (flutter/packages#7963 )
2024-10-30 zanderso@users.noreply.github.com Updates path_parsing README.md with a note about Dan (flutter/packages#7949 )
2024-10-30 stuartmorgan@google.com [tool] Support third_party for --current-package (flutter/packages#7967 )
2024-10-30 stuartmorgan@google.com [tool] Fix third_party dependency overrides (flutter/packages#7966 )
2024-10-30 jessiewong401@gmail.com Applied Gradle Plugins Declaratively for `path_provider` (flutter/packages#7822 )
2024-10-30 stuartmorgan@google.com [palette_generator] Remove unmanaged code snippet (flutter/packages#7962 )
2024-10-30 engine-flutter-autoroll@skia.org Roll Flutter from 42132e879b42 to fe71cadf1959 (12 revisions) (flutter/packages#7961 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 17:07:54 +00:00
Flutter GitHub Bot
f159136549
Marks Linux_pixel_7pro service_extensions_test to be flaky ( #157853 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro service_extensions_test"
}
-->
Issue link: https://github.com/flutter/flutter/issues/157852
2024-11-01 16:40:20 +00:00
engine-flutter-autoroll
2da2332ad1
Roll Flutter Engine from 0a0d5c9be6ff to 3a090b46dd35 (1 revision) ( #157994 )
...
0a0d5c9be6...3a090b46ddchris@bracken.jp fml: Delete weak_nsobject.h,mm (flutter/engine#56289 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 13:41:22 +00:00
engine-flutter-autoroll
3eb000c522
Roll Flutter Engine from bacc5e1e73b7 to 0a0d5c9be6ff (3 revisions) ( #157991 )
...
bacc5e1e73...0a0d5c9be6skia-flutter-autoroll@skia.org Roll Skia from 6035cb5a879c to 3b50199d27bb (1 revision) (flutter/engine#56300 )
2024-11-01 skia-flutter-autoroll@skia.org Roll Skia from 696528fe7d07 to 6035cb5a879c (1 revision) (flutter/engine#56299 )
2024-11-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 32bebf22c765 to 09c8281e66cc (1 revision) (flutter/engine#56298 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 11:33:25 +00:00
Valentin Vignal
fd259714d4
Add test for interactive_viewer.transformation_controller.0.dart ( #157986 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/interactive_viewer/interactive_viewer.transformation_controller.0.dart`
2024-11-01 10:37:59 +00:00
engine-flutter-autoroll
4f8ab5bfe2
Roll Flutter Engine from d7e928911ac2 to bacc5e1e73b7 (1 revision) ( #157982 )
...
d7e928911a...bacc5e1e73skia-flutter-autoroll@skia.org Roll Skia from a5e3b3556739 to 696528fe7d07 (1 revision) (flutter/engine#56296 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 07:45:19 +00:00
Valentin Vignal
43bb6186d2
Add test for notification.0.dart ( #157909 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/notification_listener/notification.0.dart`
2024-11-01 06:41:13 +00:00
Paolo Lammens
d836ca5a68
performance: Override .elementAt in CachingIterable ( #152477 )
...
Add a more efficient override of `Iterable.elementAt` in `CachingIterable`.
Closes #152476
2024-11-01 04:50:17 +00:00
engine-flutter-autoroll
cadac6bca3
Roll Flutter Engine from cd46383cd55e to d7e928911ac2 (4 revisions) ( #157978 )
...
cd46383cd5...d7e928911amatanlurey@users.noreply.github.com Further de-duplicate and refactor `build_plan_test`. (flutter/engine#56284 )
2024-11-01 skia-flutter-autoroll@skia.org Roll Dart SDK from bd93105c4fb6 to 32bebf22c765 (2 revisions) (flutter/engine#56290 )
2024-11-01 jason-simmons@users.noreply.github.com Remove the quiet flag from invocations of run_tests.py on macOS CI builders (flutter/engine#56288 )
2024-11-01 jason-simmons@users.noreply.github.com [Impeller] Fix handling of destination opacity in advanced blends (flutter/engine#56251 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 04:44:32 +00:00
engine-flutter-autoroll
b18d34c574
Roll Flutter Engine from bb77cf867aef to cd46383cd55e (11 revisions) ( #157972 )
...
bb77cf867a...cd46383cd530870216+gaaclarke@users.noreply.github.com reland: Allow BufferViews to have non-owning references to DeviceBuffers (flutter/engine#56286 )
2024-10-31 skia-flutter-autoroll@skia.org Roll Skia from 9168ad248c69 to a5e3b3556739 (1 revision) (flutter/engine#56283 )
2024-10-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Allow BufferViews to have non-owning references to DeviceBuffers (#56224 )" (flutter/engine#56285 )
2024-10-31 chris@bracken.jp macOS: migrate third_party/accessibility to ARC (flutter/engine#56281 )
2024-10-31 30870216+gaaclarke@users.noreply.github.com Allow BufferViews to have non-owning references to DeviceBuffers (flutter/engine#56224 )
2024-10-31 flar@google.com [Impeller] Do not use fast mask blur for stroked shapes (flutter/engine#56247 )
2024-10-31 jonahwilliams@google.com [Impeller] make desktop GL render. (flutter/engine#56274 )
2024-10-31 matanlurey@users.noreply.github.com Vastly rewrite and expand `et/README.md` (flutter/engine#56250 )
2024-10-31 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from dDWvmfG4AxSEs0BQA... to MjcuejuzYvYGobbFM... (flutter/engine#56280 )
2024-10-31 skia-flutter-autoroll@skia.org Roll Dart SDK from f3e3dc44b1dc to bd93105c4fb6 (2 revisions) (flutter/engine#56278 )
2024-10-31 chris@bracken.jp Embedder: migrate Metal surfaces to ARC (flutter/engine#56279 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from dDWvmfG4AxSE to MjcuejuzYvYG
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-01 02:53:17 +00:00
Matan Lurey
d77d7c3f36
Add a warning/additional handlers for parsingsynthetic-package. ( #157934 )
...
Closes https://github.com/flutter/flutter/issues/157928 .
Closes https://github.com/flutter/flutter/issues/157929 .
| Condition | Expectation |
| --------- | ------------ |
| `synthetic-packages: true` && `--implicit-pubpsec-resolution` | Generates `flutter_gen` with warning.
| `<no synthetic-packages key>` && `--implicit-pubspec-resolution` | Generates `flutter_gen` with warning.
| `synthetic-packages: false` && `--implicit-pubpsec-resolution` | Does not generate `flutter_gen`.
| `synthetic-packages: true` && `--no-implicit-pubpsec-resolution` | Error.
| `<no synthetic-packages key>` && `--no-implicit-pubspec-resolution` | Does not generate `flutter_gen`.
| `synthetic-packages: false` && `--no-implicit-pubpsec-resolution` | Generates `flutter_gen` with warning.
2024-11-01 00:45:07 +00:00
engine-flutter-autoroll
088e3577ab
Roll Flutter Engine from f2154ef3e31c to bb77cf867aef (6 revisions) ( #157960 )
...
f2154ef3e3...bb77cf867achris@bracken.jp iOS: migrate Metal testing types to ARC (flutter/engine#56156 )
2024-10-31 chris@bracken.jp iOS,macOS: migrate shell/gpu to ARC (flutter/engine#56157 )
2024-10-31 skia-flutter-autoroll@skia.org Roll Skia from 3c628426f85f to 9168ad248c69 (3 revisions) (flutter/engine#56272 )
2024-10-31 jonahwilliams@google.com [Impeller] Reland: disable AHBs on devices that were upgraded to 29. (flutter/engine#56221 )
2024-10-31 matanlurey@users.noreply.github.com Add `timeout` to `local_engine`. (flutter/engine#56271 )
2024-10-31 matanlurey@users.noreply.github.com Refactor `ArgParser.usage` tests for `BuildPlan` to reduce duplication. (flutter/engine#56254 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-31 22:53:24 +00:00
Matan Lurey
8d7513efb6
Renames injectBuildTimePluginFilesForWebPlatform and removes unused named parameter. ( #157944 )
...
Closes https://github.com/flutter/flutter/issues/157943 .
---------
Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
2024-10-31 15:48:23 -07:00
Jonah Williams
1050959d19
[flutter_driver] use mostly public screenshot API. ( #157888 )
...
Instead of completely private. This has been broken for Impeller for years, which shows how much this method is getting used.
Fixes https://github.com/flutter/flutter/issues/130461
2024-10-31 21:31:07 +00:00
Sarbagya Dhaubanjar
19d8fbc6f4
Made insetPadding configurable for Date Picker Dialog ( #155651 )
...
This PR adds following properties to the **DatePickerDialog**:
- `insetPadding`
2024-10-31 21:07:08 +00:00
Bruno Leroux
5f65bd06c0
Fix showSnackBar can't access useMaterial3 from the theme ( #157707 )
...
## Description
This PR makes it possible for the `MaterialApp` built in `ScaffoldMessenger` state to access the ambient theme.
Before this PR, the built in messenger was above the theme.
After this PR, the build in messenger is below the theme.
## Related Issue
Fixes [Can't access useMaterial3 from the theme in the showSnackBar method](https://github.com/flutter/flutter/issues/115924 )
## Tests
Adds 1 test.
2024-10-31 21:04:57 +00:00
engine-flutter-autoroll
0fe615343b
Roll Flutter Engine from c40b0b602822 to f2154ef3e31c (8 revisions) ( #157926 )
...
c40b0b6028...f2154ef3e3#56206 )" (flutter/engine#56264 )
2024-10-31 skia-flutter-autoroll@skia.org Roll Skia from 4f8f2ecadfb6 to 3c628426f85f (1 revision) (flutter/engine#56261 )
2024-10-31 skia-flutter-autoroll@skia.org Roll Skia from 7e79a516284b to 4f8f2ecadfb6 (1 revision) (flutter/engine#56255 )
2024-10-31 skia-flutter-autoroll@skia.org Roll Dart SDK from 6a8058eef22c to f3e3dc44b1dc (1 revision) (flutter/engine#56253 )
2024-10-31 skia-flutter-autoroll@skia.org Roll Skia from 3c62d4a94d78 to 7e79a516284b (1 revision) (flutter/engine#56252 )
2024-10-31 jonahwilliams@google.com [Impeller] use primitive restart for faster tessellation: write directly into host buffer. (flutter/engine#56173 )
2024-10-31 jacksongardner@google.com Skwasm single threaded (flutter/engine#56206 )
2024-10-31 jonahwilliams@google.com [Impeller] expose reference to tessellator instead of shared_ptr. (flutter/engine#56244 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-31 16:47:57 +00:00
chunhtai
b2f72e08ef
Hides added routes before top-most route finishes pushing ( #156104 )
...
fixes https://github.com/flutter/flutter/issues/156033
2024-10-31 16:47:55 +00:00
Benji Farquhar
b01558c1cd
Fix cursor on hover expand/collapse icon ( #155207 ) ( #155209 )
...
@TahaTesser Fix undesirable side effects of your refactor away from my solution to add `IgnorePointer` during your code review of my PR https://github.com/flutter/flutter/pull/147098 . I don't have time to implement my whole initial fix a second time, and update the tests that were added to verify your disabled color change. The issue is resolved with only adding the IgnorePointer.
See [155207](https://github.com/flutter/flutter/issues/155207 ).
2024-10-31 16:09:18 +00:00
Valentin Vignal
16622e67a0
Add test for media_query_data.system_gesture_insets.0.dart ( #157854 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/media_query/media_query_data.system_gesture_insets.0.dart`
2024-10-31 10:47:14 +00:00
Matan Lurey
fb022290ff
Add and plumb useImplicitPubspecResolution across flutter_tools. ( #157879 )
...
Work towards https://github.com/flutter/flutter/issues/157819 . **No behavior changes as a result of this PR**.
Based on a proof of concept by @jonahwilliams (https://github.com/flutter/flutter/pull/157818 ).
The existence of this flag (which for the time being, defaults to `true`) implies the following:
1. The (legacy, deprecated) `.flutter-plugins` file is not generated:
https://docs.flutter.dev/release/breaking-changes/flutter-plugins-configuration
2. The (legacy, deprecated) `package:flutter_gen` is not synthetically generated:
https://github.com/flutter/website/pull/11343
(awaiting website approvers, but owners approve this change)
This change creates `useImplicitPubspecResolution` and plumbs it through as a required variable, parsing it from a `FlutterCommand.globalResults` where able. In tests, I've defaulted the value to `true` 100% of the time - except for places where the value itself is acted on directly, in which case there are true and false test-cases (e.g. localization and i10n based classes and functions).
I'm not extremely happy this needed to change 50+ files, but is sort of a result of how inter-connected many of the elements of the tools are. I believe keeping this as an explicit (flagged) argument will be our best way to ensure the default behavior changes consistently and that tests are running as expected.
2024-10-31 10:43:25 +00:00
engine-flutter-autoroll
6aaa387f2e
Roll Flutter Engine from 090c33aeae83 to c40b0b602822 (1 revision) ( #157896 )
...
090c33aeae...c40b0b6028chris@bracken.jp iOS: Eliminate strong retain loop in Scenario tests (flutter/engine#56249 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-31 02:29:54 +00:00
engine-flutter-autoroll
b0e84af3dc
Roll Flutter Engine from 9295eeb6d3ce to 090c33aeae83 (4 revisions) ( #157893 )
...
9295eeb6d3...090c33aeaeskia-flutter-autoroll@skia.org Roll Skia from 85b77db25fa3 to 3c62d4a94d78 (1 revision) (flutter/engine#56248 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 4566845d8e30 to 6a8058eef22c (1 revision) (flutter/engine#56246 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from f334411b0a08 to 85b77db25fa3 (5 revisions) (flutter/engine#56245 )
2024-10-30 matanlurey@users.noreply.github.com Add and use `mergeGnArgs` with `--gn-args` from `et`. (flutter/engine#56228 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-31 01:30:25 +00:00
engine-flutter-autoroll
939fd61bb0
Roll Flutter Engine from 2bd854e23b61 to 9295eeb6d3ce (5 revisions) ( #157882 )
...
2bd854e23b...9295eeb6d3skia-flutter-autoroll@skia.org Roll Skia from 77779dfed911 to f334411b0a08 (1 revision) (flutter/engine#56243 )
2024-10-30 jonahwilliams@google.com [engine] add back opt out for merged thread mode. (flutter/engine#56242 )
2024-10-30 jason-simmons@users.noreply.github.com [Impeller] Remove the use of a subpixel minimum stroke size for MSAA (flutter/engine#56223 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zuDYsDZHnJMZVvrc8... to dDWvmfG4AxSEs0BQA... (flutter/engine#56241 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 36aed3607108 to 4566845d8e30 (1 revision) (flutter/engine#56240 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from zuDYsDZHnJMZ to dDWvmfG4AxSE
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 22:49:15 +00:00
LouiseHsu
ec04707feb
Adds a new helpful tool exit message for SocketExceptions thrown during mdns discovery ( #157638 )
...
Addresses https://github.com/flutter/flutter/issues/150131 , but doesn't fix it, as there seem to be cases where the steps included in the messages added in this PR don't work.
2024-10-30 21:20:25 +00:00
miechoo
2d2ebbe263
Fix GlowingOverscrollIndicator examples ( #155203 )
...
Part of https://github.com/flutter/flutter/issues/130459
This pull request adds tests for the example files shown in the [GlowingOverscrollIndicator](https://api.flutter.dev/flutter/widgets/GlowingOverscrollIndicator-class.html ) Flutter API reference documentation.
2024-10-30 20:50:00 +00:00
engine-flutter-autoroll
bb08ec9a03
Roll Flutter Engine from 906a7ad88052 to 2bd854e23b61 (1 revision) ( #157878 )
...
906a7ad880...2bd854e23bskia-flutter-autoroll@skia.org Roll Skia from d022fe64116f to 77779dfed911 (1 revision) (flutter/engine#56239 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 20:18:01 +00:00
Gray Mackall
55c026a230
Upgrade templates to AGP 8.7/Gradle 8.10.2 ( #157872 )
...
These are the versions we use in test, as of https://github.com/flutter/flutter/pull/157617 .
Motivated by noticing a warning with the old template version:
```
This Android Gradle plugin (8.1.0) was tested up to compileSdk = 33 (and compileSdkPreview = "UpsideDownCakePrivacySandbox").
You are strongly encouraged to update your project to use a newer
Android Gradle plugin that has been tested with compileSdk = 35.
```
2024-10-30 18:54:06 +00:00
engine-flutter-autoroll
cb7861cc5f
Roll Flutter Engine from 57ed5d338e7e to 906a7ad88052 (13 revisions) ( #157875 )
...
57ed5d338e...906a7ad880skia-flutter-autoroll@skia.org Roll Skia from 03600bc22ab8 to d022fe64116f (1 revision) (flutter/engine#56237 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 948b01e28f48 to 03600bc22ab8 (1 revision) (flutter/engine#56236 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Dart SDK from b319b2e53bfa to 36aed3607108 (2 revisions) (flutter/engine#56235 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 1a47627e627a to 948b01e28f48 (1 revision) (flutter/engine#56231 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 5410f1c6f86c to 1a47627e627a (1 revision) (flutter/engine#56230 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 70eca740f23f to b319b2e53bfa (1 revision) (flutter/engine#56229 )
2024-10-30 chris@bracken.jp iOS: make unopt debug builds unopt and debug (flutter/engine#56226 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 7385b2d99fe9 to 5410f1c6f86c (1 revision) (flutter/engine#56227 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Dart SDK from fcc2bc69db3e to 70eca740f23f (2 revisions) (flutter/engine#56225 )
2024-10-30 skia-flutter-autoroll@skia.org Roll Skia from 6e0c0a255166 to 7385b2d99fe9 (5 revisions) (flutter/engine#56222 )
2024-10-29 aam@google.com Roll buildroot to 3f1a1f0. (flutter/engine#56214 )
2024-10-29 ditman@gmail.com [web] Prioritize split font fallbacks over monolythic ones. (flutter/engine#56187 )
2024-10-29 skia-flutter-autoroll@skia.org Roll Skia from 5758d9c344e3 to 6e0c0a255166 (3 revisions) (flutter/engine#56215 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 18:42:07 +00:00
Taha Tesser
b8dcb0c3c5
Update Material 3 LinearProgressIndicator for new visual style ( #154817 )
...
Related to [Update both `ProgressIndicator` for Material 3 redesign](https://github.com/flutter/flutter/issues/141340 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatefulWidget {
const MyApp({super.key});
@override
State<MyApp> createState() => _MyAppState();
}
class _MyAppState extends State<MyApp> {
bool isRTL = false;
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: Directionality(
textDirection: isRTL ? TextDirection.rtl : TextDirection.ltr,
child: Center(
child: Column(
spacing: 2.0,
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
const Text('Default LinearProgressIndicator'),
const Padding(
padding: EdgeInsets.all(16.0),
child: LinearProgressIndicator(
value: 0.45,
),
),
const Text('Default indefinite LinearProgressIndicator'),
const Padding(
padding: EdgeInsets.all(16.0),
child: LinearProgressIndicator(),
),
const Text('Updated height and border radius'),
Padding(
padding: const EdgeInsets.all(16.0),
child: LinearProgressIndicator(
value: 0.25,
minHeight: 16.0,
borderRadius: BorderRadius.circular(16.0),
),
),
const Text('Updated stop indicator color and radius'),
Padding(
padding: const EdgeInsets.all(16.0),
child: LinearProgressIndicator(
value: 0.74,
minHeight: 16.0,
borderRadius: BorderRadius.circular(16.0),
stopIndicatorColor: Theme.of(context).colorScheme.error,
stopIndicatorRadius: 32.0,
),
),
const Text('Track gap and stop indicator radius set to 0'),
Padding(
padding: const EdgeInsets.all(16.0),
child: LinearProgressIndicator(
value: 0.50,
minHeight: 16.0,
borderRadius: BorderRadius.circular(16.0),
trackGap: 0,
stopIndicatorRadius: 0,
),
),
],
),
),
),
floatingActionButton: FloatingActionButton.extended(
onPressed: () {
setState(() {
isRTL = !isRTL;
});
},
label: const Text('Toggle Direction'),
),
),
);
}
}
```
</details>
### Preview
<img width="824" alt="Screenshot 2024-09-09 at 13 53 10" src="https://github.com/user-attachments/assets/d12e56a5-f196-4011-8266-c7ab96be96b2 ">
2024-10-30 18:14:11 +00:00
engine-flutter-autoroll
cf4a4b8162
Roll Flutter Engine from 999797a2f690 to 57ed5d338e7e (5 revisions) ( #157833 )
...
999797a2f6...57ed5d338ebdero@google.com [Flutter GPU] Fix MSAA sample size and HostBuffer alignment. (flutter/engine#56218 )
2024-10-29 flar@google.com Change default TileMode for blur ImageFilter objects to null (flutter/engine#55552 )
2024-10-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Reland: disable AHBs on devices that were upgraded to 29. (#56213 )" (flutter/engine#56220 )
2024-10-29 30870216+gaaclarke@users.noreply.github.com Made et compilation errors relative to the CWD (flutter/engine#56177 )
2024-10-29 jonahwilliams@google.com [Impeller] Reland: disable AHBs on devices that were upgraded to 29. (flutter/engine#56213 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 17:24:08 +00:00
Matan Lurey
e6c9fce313
Add hidden --no-implicit-pubspec-resolution flag for one stable release. ( #157635 )
...
Closes https://github.com/flutter/flutter/issues/157532 .
Work towards https://github.com/flutter/flutter/issues/157819 .
Because this flag is checked in `FlutterCommand.verifyAndRun`, it seemed cleaner to just make it a global flag - particularly because this flag's longevity is unlikely to be longer than a single stable release.
2024-10-30 17:00:32 +00:00
engine-flutter-autoroll
e10d1dee5d
Roll Packages from 028027e6b1f1 to 7cc1caa0cc36 (5 revisions) ( #157864 )
...
028027e6b1...7cc1caa0ccstuartmorgan@google.com [tool] Update build-all app creation (flutter/packages#7955 )
2024-10-30 srawlins@google.com Disable two lint rules which are being removed. (flutter/packages#7959 )
2024-10-29 matanlurey@users.noreply.github.com Bump `path_provider_android` to `^2.2.5` due to Android v1 embedder. (flutter/packages#7935 )
2024-10-29 engine-flutter-autoroll@skia.org Roll Flutter from 3fb95c7dd21d to 42132e879b42 (19 revisions) (flutter/packages#7958 )
2024-10-29 stuartmorgan@google.com [webview_flutter] Fix macOS 14+ test hangs (flutter/packages#7953 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 15:55:07 +00:00
stuartmorgan
d3723857de
Mention partial PRs in the contributing docs ( #157863 )
...
Adds a small new subsection to the section on contributing via coding that highlights the list of issues with partial patches that could be picked up by another contributor.
2024-10-30 15:23:21 +00:00
Reid Baker
fe71cadf19
Update CHANGELOG.md to correct ios vs macos issue ( #157822 )
2024-10-30 14:07:28 +00:00
Taha Tesser
40c22749f5
Add ability to customize the default Slider padding ( #156143 )
...
Fixes [Ability to change Sliders padding](https://github.com/flutter/flutter/issues/40098 )
Add ability to override default padding so the Slider can fit better in a layout.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatefulWidget {
const MyApp({super.key});
@override
State<MyApp> createState() => _MyAppState();
}
class _MyAppState extends State<MyApp> {
double _sliderValue = 0.5;
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(
sliderTheme: const SliderThemeData(
padding: EdgeInsets.symmetric(vertical: 4.0),
thumbColor: Colors.red,
inactiveTrackColor: Colors.amber,
),
),
home: Scaffold(
body: Directionality(
textDirection: TextDirection.ltr,
child: Center(
child: Card(
shape: const RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(4.0)),
),
color: Theme.of(context).colorScheme.surfaceContainerHighest,
margin: const EdgeInsets.symmetric(horizontal: 16.0),
child: Padding(
padding: const EdgeInsets.all(16.0),
child: Column(
mainAxisSize: MainAxisSize.min,
children: [
const Placeholder(fallbackHeight: 100.0),
Slider(
value: _sliderValue,
onChanged: (double value) {
setState(() {
_sliderValue = value;
});
},
),
const Placeholder(fallbackHeight: 100.0),
],
),
),
),
),
),
),
);
}
}
```
</details>
### Before
(Cannot adjust default `Slider` padding to fill the horizontal space in a `Column` and reduce the padded height)
<img width="717" alt="Screenshot 2024-10-03 at 15 45 18" src="https://github.com/user-attachments/assets/e9d9a4d1-3087-45b4-8607-b94411e2bd23 ">
### After
Can adjust default `Slider` padding via `SliderTheme`)
<img width="717" alt="Screenshot 2024-10-03 at 15 46 25" src="https://github.com/user-attachments/assets/cd455881-6d52-46cb-8ac6-cc33f50a13ff ">
2024-10-30 10:16:23 +00:00
YeungKC
ec50578982
Fix menu anchor state handling ( #157612 )
...
This commit refactors the `_MenuAnchorState` class in `menu_anchor.dart` to include a check for the mounted state and the scheduler phase before calling `setState()`. This ensures that UI updates are only performed when the widget is still mounted and not during the persistent callbacks phase. Additionally, a new test case is added in `menu_anchor_test.dart` to verify that the `isOpen` state of the `MenuAnchor` widget is updated correctly when the button is pressed.
Fix : #157606
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-10-30 09:42:00 +00:00
Valentin Vignal
f9c130abf0
Add test for interactive_viewer.0.dart ( #157773 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/interactive_viewer/interactive_viewer.0.dart`
2024-10-30 05:46:24 +00:00
Valentin Vignal
1ec1c59d47
Add test for scroll_metrics_notification.0.dart ( #157768 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/scroll_position/scroll_metrics_notification.0.dart`
2024-10-30 05:46:21 +00:00
