firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
38,118 Commits 1 Branch 0 Tags
Commit Graph

29204 Commits

Author SHA1 Message Date
hellohuanlin
9a685756f9 Revert "[ios][platform_view] Fix Platform view gesture recognizer wit… (flutter/engine#55889) 
…h iPad pencil getting stuck (#55724)"

This reverts commit 21eb44914c22761f3c8bdb39b1d36b2fc15bde3b.

Revert since a customer reported the platform view touch is broken after the change. 

*List which issues are fixed by this PR. You must list at least one issue.*
Reopens https://github.com/flutter/engine/pull/55724

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-16 00:04:32 +00:00
Robert Ancell
db1e63b948 Simplify code for dispatching events (flutter/engine#55871) 2024-10-16 10:00:34 +13:00
Chinmay Garde
6be577d05a [Impeller] Ignore opt-outs on iOS devices. (flutter/engine#55808) 
Addresses https://github.com/flutter/flutter/issues/155541

This does **not** remove Skia itself from the build. I'll stage that in a followup. Want to keep the scope of this patch small.

This is the new behavior:

* Impeller is the default on iOS devices **and** simulators.
* On iOS devices **only**, all flags and plist options are ignored.
* On iOS simulators **only**, Flutter will used Impeller's Metal backend by default and fallback to the Null backend if Metal device access is not available.
* On iOS simulators **only**, Flutter can pick Skia using the command line flags or plist flags. This is to allow users one more month to migrate as communicated by @zanderso.

The settings objects `enable_impeller` field is now `static constexpr` to avoid accidentally disabling the flag while it still exists.
 2024-10-15 19:14:23 +00:00
skia-flutter-autoroll
7bcd07c4df Roll Skia from baf314b72924 to 539ab9d39812 (3 revisions) (flutter/engine#55879) 
https://skia.googlesource.com/skia.git/+log/baf314b72924..539ab9d39812

2024-10-15 robertphillips@google.com Add More Mac *SAN Graphite testing jobs
2024-10-15 danieldilan@google.com Add a way to set filter mode in SkAnimatedImage.
2024-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8f346c5caf5a to a993e01ad888 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-15 17:37:25 +00:00
Jonah Williams
0077bfe80a [Impeller] remove extra copy from drawPoints. (flutter/engine#55872) 
Remove the extra host -> host copy performed by the VertexBufferBuilder. Instead, write the drawPoint geometry right into the transients buffer.

https://github.com/flutter/flutter/issues/152702
 2024-10-15 15:45:20 +00:00
skia-flutter-autoroll
c469426d71 Roll Skia from 39bd1d3f242a to baf314b72924 (4 revisions) (flutter/engine#55876) 
https://skia.googlesource.com/skia.git/+log/39bd1d3f242a..baf314b72924

2024-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 78a694a1b82a to 576b5ef40a9b (6 revisions)
2024-10-15 sharaks@google.com Merge 2 release notes into RELEASE_NOTES.md
2024-10-15 sharaks@google.com Update Skia milestone to 132
2024-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2a35388fb5f0 to 5a6102d3459e (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-15 10:26:22 +00:00
skia-flutter-autoroll
4cc9b727a4 Roll Skia from 7d16e5cd642c to 39bd1d3f242a (1 revision) (flutter/engine#55870) 
https://skia.googlesource.com/skia.git/+log/7d16e5cd642c..39bd1d3f242a

2024-10-15 jie.a.chen@intel.com [graphite] Use uint instead of int for divides

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-15 03:18:21 +00:00
Brandon DeRosier
50b5307332 [Impeller] Allow binding multiple vertex buffer views. (flutter/engine#55856) 
Resolves https://github.com/flutter/flutter/issues/116168.
(Continuation of https://github.com/flutter/engine/pull/49670)

Makes it possible for us to use arbitrary vertex layouts, including SoA layouts with attributes stored in different DeviceBuffers. CanRenderPerspectiveCube was converted to an SoA attribute layout with two separate buffers as an example.

Works on all the backends!

OpenGLES:
<img width="1136" alt="image" src="https://github.com/user-attachments/assets/e2398fde-532f-402d-899a-39aaa556f24f">

Vulkan:
<img width="1136" alt="image" src="https://github.com/user-attachments/assets/1c1bf664-bec1-43cb-ab2e-eb2a74718bfd">

Metal:
<img width="1136" alt="image" src="https://github.com/user-attachments/assets/bf59da17-cf52-4913-88e4-ab6f0bd6fc96">
 2024-10-15 01:13:52 +00:00
Brandon DeRosier
778e32ec0d [Flutter GPU] Remove unused fixture. (flutter/engine#55869) 
I used this fixture data early on to bootstrap testing for Flutter GPU before shader bundles were finished. But today we have the build system compile shader bundles for us, so this is no longer used.
 2024-10-15 00:10:21 +00:00
skia-flutter-autoroll
b03c459fab Roll Skia from de6e47f0f17b to 7d16e5cd642c (2 revisions) (flutter/engine#55868) 
https://skia.googlesource.com/skia.git/+log/de6e47f0f17b..7d16e5cd642c

2024-10-14 lukasza@chromium.org [rust png] Initial support for Bazel build.
2024-10-14 kjlubick@google.com Add JSON error when presubmit fails

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-14 22:20:08 +00:00
skia-flutter-autoroll
2cc59a7940 Roll Skia from d6d3c4f624a3 to de6e47f0f17b (9 revisions) (flutter/engine#55867) 
https://skia.googlesource.com/skia.git/+log/d6d3c4f624a3..de6e47f0f17b

2024-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e0070499f409 to 8f346c5caf5a (1 revision)
2024-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e7f0d107f258 to 78a694a1b82a (1 revision)
2024-10-14 robertphillips@google.com [ganesh] Remove last use of SK_IGNORE_ANGLE_VULKAN flag
2024-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 462486a81e05 to 2a35388fb5f0 (5 revisions)
2024-10-14 jvanverth@google.com [graphite] Add Arc support to Shape.
2024-10-14 lukasza@chromium.org [rust png] Populate `fFrameHolder` with all animation frames.
2024-10-14 kjlubick@google.com Remove unavailable jobs from CQ
2024-10-14 kjlubick@google.com Update Bazel's rules_rust to v0.52.2
2024-10-14 kjlubick@google.com Update Swarming dimensions for IntelXe tasks

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-14 20:55:17 +00:00
skia-flutter-autoroll
91abbe23c7 Roll Fuchsia Linux SDK from 2cTD8TkGBMX2IssGl... to T2Cq00sVabK2fCW9r... (flutter/engine#55865) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-14 20:01:37 +00:00
Parker Lougheed
7876f9fc41 Disable non-functional and deprecated package_api_docs lint (flutter/engine#55833) 
Reference: https://github.com/dart-lang/linter/issues/5107
 2024-10-14 18:49:18 +00:00
David Iglesias
0d39b59999 [web] Ensure Flutter adds a generator meta-tag. (flutter/engine#55714) 
Adds a `meta name="generator" content="Flutter"` tag when the engine UI initializes.

## Issues

Fixes https://github.com/flutter/flutter/issues/156262

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-14 18:41:51 +00:00
Jonah Williams
61460afe48 [Impeller] remove STB backend. (flutter/engine#55842) 
Delete the STB typographer backend.

Fixes https://github.com/flutter/flutter/issues/156429
 2024-10-14 18:16:20 +00:00
Brandon DeRosier
dd68ebf2fb [Impeller] Add miplevel to Buffer->Texture blit. (flutter/engine#55848) 
Part of https://github.com/flutter/flutter/issues/156641
 2024-10-14 16:53:19 +00:00
Robert Ancell
0388529ef9 Use GWeakRef API (flutter/engine#55795) 
For consistency with other code.
 2024-10-14 14:36:37 +13:00
Robert Ancell
e0daa80cb2 Remove unnecessary use of std::vector (flutter/engine#55796) 2024-10-14 13:57:12 +13:00
Robert Ancell
7790182059 Remove fl_keyboard_view_delegate_subscribe_to_layout_change and just access the object directly via a method (flutter/engine#55817) 
A step on the way to get FlKeyboardHandler out of FlView and into
FlEngine.
 2024-10-14 13:54:05 +13:00
Robert Ancell
24ceeac432 Split out FlKeyboardLayout into its own class (flutter/engine#55816) 2024-10-14 12:07:26 +13:00
Robert Ancell
b9db87f8ac When rendering into secondary views, copy the pixel contents between contexts (flutter/engine#55639) 
This is because GTK3 can't share contexts between GtkGLAreas.

We may be able to avoid the copy using the GL_OES_EGL_image or
GL_OES_EGL_image_external extensions.

Note that keyboard input doesn't work on the secondary view, this
requires moving the keyboard handling from FlView to FlEngine. Proposing
this now as a step forwards, but not yet useful for real applications.
 2024-10-14 12:05:12 +13:00
Robert Ancell
b857ade17e Make FlRenderable interface (flutter/engine#55763) 
Added to make testing of FlRenderer easier.
 2024-10-14 10:30:41 +13:00
Robert Ancell
e5ecdd9c94 Fix dispose methods that didn't chain the parent. (flutter/engine#55794) 
Remove empty dispose methods and convert finalize methods to dispose for
consistency.
 2024-10-14 09:40:47 +13:00
skia-flutter-autoroll
c750e8e56f Roll Fuchsia Linux SDK from tNuwSyjjbdU9HjOwQ... to 2cTD8TkGBMX2IssGl... (flutter/engine#55862) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-13 18:38:23 +00:00
skia-flutter-autoroll
0af03c79c7 Roll Skia from 88cb2bff3842 to d6d3c4f624a3 (1 revision) (flutter/engine#55861) 
https://skia.googlesource.com/skia.git/+log/88cb2bff3842..d6d3c4f624a3

2024-10-13 michaelludwig@google.com [graphite] Rebind textures on pipeline changes w/ dst-copy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,fmalita@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-13 15:45:38 +00:00
auto-submit[bot]
65114d1bfb Reverts "Manual roll Dart SDK from d916a5f69a48 to 75bf9e183a33 (1 revision) (#55838)" (flutter/engine#55850) 
Reverts: flutter/engine#55838
Initiated by: zanderso
Reason for reverting: Blocking roll to the framework due to https://github.com/flutter/flutter/issues/156654
Original PR Author: skia-flutter-autoroll

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:

Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/d916a5f69a48..75bf9e183a33

2024-10-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-0.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-12 17:17:46 +00:00
Jim Graham
9e747c2eb6 Delete last usages of MockCanvas test mechanism (flutter/engine#55840) 
The MockCanvas API was originally used to test the output of rendering methods to match them against a reference set of "MockData" structures. This API has been superseded by just using a DisplayListBuilder to record reference operations and then to compare the resulting DisplayList objects.

This PR deletes the last remaining uses of MockCanvas as well as the mechanism itself.
 2024-10-12 05:15:17 +00:00
skia-flutter-autoroll
8da20b0a97 Roll Skia from 97cebfb06139 to d2833b68c8c7 (9 revisions) (flutter/engine#55846) 
https://skia.googlesource.com/skia.git/+log/97cebfb06139..d2833b68c8c7

2024-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 73fd75175922 to ab901eb0f984 (7 revisions)
2024-10-11 bungeman@google.com Clean up references to SkDevice::createDevice
2024-10-11 fmalita@google.com [skottie] Fix Viewer crash on invalid json inputs
2024-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f58427c0db47 to 73fd75175922 (3 revisions)
2024-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ae5c3b969e66 to 3ef8d1714d61 (6 revisions)
2024-10-11 cwallez@chromium.org DawnCaps: Prepare for Dawn's output stuct StringView change.
2024-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from bf6353777f11 to 462486a81e05 (6 revisions)
2024-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 68d8508758f2 to f3c7cc5c580e (31 revisions)
2024-10-10 jreck@google.com Fix SkRRect::dumpToString

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-12 03:21:05 +00:00
Jonah Williams
c9f0e8a458 [Impeller] delete a bunch of dead filter code. (flutter/engine#55841) 
All of these filter graph methods are not used or only used to test themselves in a limited unit test. Delete!
 2024-10-12 02:15:23 +00:00
AthulJoseph
3214f65fa3 [Impeller] Added support to set polygon mode in Flutter GPU. (flutter/engine#55804) 
Added support to set polygon mode in Flutter GPU. This fixes the issue [#142732](https://github.com/flutter/flutter/issues/142732).
 2024-10-12 01:07:36 +00:00
skia-flutter-autoroll
96ab9b9e30 Manual roll Dart SDK from d916a5f69a48 to 75bf9e183a33 (1 revision) (flutter/engine#55838) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/d916a5f69a48..75bf9e183a33

2024-10-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-0.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-11 23:42:53 +00:00
skia-flutter-autoroll
3f6fabf728 Roll Fuchsia Linux SDK from 1OZ2rHDklRNSZRUrc... to tNuwSyjjbdU9HjOwQ... (flutter/engine#55837) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-11 23:41:19 +00:00
Chinmay Garde
19709fe088 [Impeller] libImpeller: Upload missing arm artifacts. (flutter/engine#55790) 
Should have been a part of 9910c947f6 but I missed these.
 2024-10-11 20:23:45 +00:00
auto-submit[bot]
205b056c01 Reverts "[Fuchsia] Use more high level fuchsia-gn-sdk templates (#55445)" (flutter/engine#55834) 
Reverts: flutter/engine#55445
Initiated by: zijiehe-google-com
Reason for reverting: This change would break the build_fuchsia_artifacts.py without https://github.com/flutter/engine/pull/55832/files. I'd merge two into one.
Original PR Author: zijiehe-google-com

Reviewed By: {jrwang}

This change reverts the following previous change:
This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk.

The build_fuchsia_artifacts.py is still using pm, and it will be handled in a following change.

Bug: http://b/353729557, http://b/368608542

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-11 17:51:47 +00:00
Chinmay Garde
225aa6dee4 [Impeller] libImpeller: Fix missing exports on some paint methods. (flutter/engine#55814) 
cc @lyceel. I'll followup with a linker script to to verify this later.
 2024-10-11 17:51:26 +00:00
zijiehe@
54e9d74b7a [fuchsia] Use the right versioned libs according to the target-api-level (flutter/engine#55786) 
Except for the vulkan, target-api-level should control the versions of the other libraries rather than the ones in ToT (//fuchsia/sdk/$host_os/arch/$target_cpu/dist).

FYI: @hjfreyer
Bug: http://b/40935282

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-11 17:27:05 +00:00
zijiehe@
297cf4be72 [Fuchsia] Use more high level fuchsia-gn-sdk templates (flutter/engine#55445) 
This change removes the in-house built pm-based build rules in favor of
the high level fuchsia_component / fuchsia_package in the gn-sdk.

The build_fuchsia_artifacts.py is still using pm, and it will be handled
in a following change.

Bug: http://b/353729557, http://b/368608542

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-10-11 08:41:35 -07:00
hellohuanlin
21eb44914c [ios][platform_view] Fix Platform view gesture recognizer with iPad pencil getting stuck (flutter/engine#55724) 
## Summary 

I came across our the "gesture recognizer delegate" implementation and it is quite odd (see below). After fixing it, the problem is resolved. However, it's hard to reason about how it's related to iPad pencil, since it's internal logic that we don't know (see my research below). 

## Gesture recognizer delegate

### Existing odd implementation

- shouldBeRequiredToFailByGestureRecognizer: 

`otherGestureRecognizer != self` is always YES because the delegate set to self, hence `gestureRecognizer` must be self, hence `otherGestureRecognizer` must not be self. 

- shouldRequireFailureOfGestureRecognizer: 

`otherGestureRecognizer == self` is always NO, for the same reason described above. 

### new implementation: 

After digging into various PRs, the idea seems to be that we want to have a precedence of "Forwarding recognizer >  Delaying recognizer > Other recognizers in platform view". 

- shouldBeRequiredToFailByGestureRecognizer:

`return otherGestureRecognizer != _forwardingRecognizer` means Delaying recognizer needs to be higher precedence than all non-Forwarding recognizer. (aka "Delaying recognizer > Other recognizers in platform view")

- shouldRequireFailureOfGestureRecognizer:

`return otherGestureRecognizer == _forwardingRecognizer` means Delaying recognizer needs to have lower precedence than forwarding recognizer. (aka "Forwarding recognizer > Delaying recognizer"). 

## Some research

This is a tricky one since pencil and finger triggers exactly the same callbacks. It turns out that when pencil is involved after finger interaction, the platform view's "forwarding" gesture recognizer is stuck at failed state. This seems to be an iOS bug, because according to [the API doc](https://developer.apple.com/documentation/uikit/uigesturerecognizerstate/uigesturerecognizerstatefailed?language=objc), it should be reset back to "possible" state:

> No action message is sent and the gesture recognizer is reset to [UIGestureRecognizerStatePossible](https://developer.apple.com/documentation/uikit/uigesturerecognizerstate/uigesturerecognizerstatepossible?language=objc).

However, when iPad pencil is involved, the state is not reset. I tried to KVO the state property, and wasn't able to capture the change. This means the state change very likely happened internally within the recognizer via the backing ivar of the state property.

*List which issues are fixed by this PR. You must list at least one issue.*

Fixes https://github.com/flutter/flutter/issues/136244

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-10-11 02:24:43 +00:00
Jim Graham
3f0d57e071 [DisplayList] Create DlFoo type variants to start moving away from Skia types in API (flutter/engine#55812) 
This is the beginning of the bulk of de-skia-fication work in the engine. All of the standard types in the DlCanvas API now have overloads that specify the corresponding Dl type, mainly for Dl*Rect and DlPoint types. This enables further work to switch from SkFoo types to DlFoo types in the various engine modules culminating in the elimination of the old methods that use the Sk types.

All of the former methods that used the basic Sk types are now implemented as inlinable translation overloads and the underlying implementations of DlCanvas now implement only the newer style interfaces so that they don't need to be further modified as we eliminate the old Skia types from the interface.

There are still a couple of Skia types remaining in the DlCanvas API without any DL type variants which will be handled in a future phase:
- SkRRect
- SkRSXform
- SkTextBlob (will be hidden behind a common interface along with TextFrame)
- SkImageInfo (only used in a few calling sites)
 2024-10-11 00:42:23 +00:00
Jonah Williams
a8a7d1db42 [engine] remove merge thread setting and fix default value. (flutter/engine#55810) 
When I removed the configration, I neglected the line that overrode the default from settings. This opted everyone back out. :(
 2024-10-10 23:21:40 +00:00
skia-flutter-autoroll
caedaa5756 Roll Skia from 1e269594df9d to 97cebfb06139 (3 revisions) (flutter/engine#55811) 
https://skia.googlesource.com/skia.git/+log/1e269594df9d..97cebfb06139

2024-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4480c8e9e59c to f58427c0db47 (3 revisions)
2024-10-10 michaelludwig@google.com [graphite] Re-add makeRoundOut() for dst copy bounds
2024-10-10 jvanverth@google.com [graphite] Remove analytic clip staging flag.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-10 23:03:41 +00:00
skia-flutter-autoroll
9519a37b6b Roll Fuchsia Linux SDK from xGr5ZkxX3CajAY1xu... to 1OZ2rHDklRNSZRUrc... (flutter/engine#55807) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-10 19:51:27 +00:00
Matan Lurey
ecb7c78604 Recognizegroup, and warn when we silently discard targets. (flutter/engine#55791) 
Closes https://github.com/flutter/flutter/issues/156260.

Fixes the degenerate case where you specify an unrecognized target, and it falls back to rebuilding the entire engine as if you specified nothing. In addition, added recognition of `group`.
 2024-10-10 18:45:49 +00:00
skia-flutter-autoroll
1dcf56dc4b Roll Skia from 6e4a2f266a17 to 0a9bfc90496e (2 revisions) (flutter/engine#55799) 
https://skia.googlesource.com/skia.git/+log/6e4a2f266a17..0a9bfc90496e

2024-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d0e2141a997c to ae5c3b969e66 (10 revisions)
2024-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 09baf58309a3 to bf6353777f11 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-10 08:26:35 +00:00
skia-flutter-autoroll
0ef69389f0 Roll Skia from 8c95b719bf05 to 3a9e6b6a4721 (1 revision) (flutter/engine#55793) 
https://skia.googlesource.com/skia.git/+log/8c95b719bf05..3a9e6b6a4721

2024-10-10 michaelludwig@google.com [graphite] Clean up legacy dstCopy from KeyContext

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-10-10 02:31:23 +00:00
Matan Lurey
4f6d8c462d Move some et tests around and delete unused files. (flutter/engine#55764) 
Just general cleanup with no behavioral changes.
 2024-10-09 23:03:14 +00:00
Yegor
e478ea9bad [web:a11y] make header a proper <header> (flutter/engine#55747) 
Now that we have [proper headings](https://github.com/flutter/engine/blob/main/lib/web_ui/lib/src/engine/semantics/heading.dart), headers should become proper headers.

Fixes https://github.com/flutter/flutter/issues/152268
 2024-10-09 22:21:51 +00:00
auto-submit[bot]
eae94cf3df Reverts "Reverts "Run gen_snapshot under /usr/bin/time (#55777)" (#55787)" (flutter/engine#55789) 
Reverts: flutter/engine#55787
Initiated by: matanlurey
Reason for reverting: We determined this was an expected failure.
Original PR Author: auto-submit[bot]

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:
Reverts: flutter/engine#55777
Initiated by: matanlurey
Reason for reverting: Breaks CI postsubmit (https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/485517/overview).
Original PR Author: aam

Reviewed By: {matanlurey}

This change reverts the following previous change:
This should help further troubleshoot https://github.com/flutter/flutter/issues/154437
 2024-10-09 21:31:46 +00:00
auto-submit[bot]
93d9a4e1ed Reverts "Run gen_snapshot under /usr/bin/time (#55777)" (flutter/engine#55787) 
Reverts: flutter/engine#55777
Initiated by: matanlurey
Reason for reverting: Breaks CI postsubmit (https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/485517/overview).
Original PR Author: aam

Reviewed By: {matanlurey}

This change reverts the following previous change:
This should help further troubleshoot https://github.com/flutter/flutter/issues/154437
 2024-10-09 21:18:46 +00:00
Alexander Aprelev
de3410f8f4 Run gen_snapshot under /usr/bin/time (flutter/engine#55777) 
This should help further troubleshoot https://github.com/flutter/flutter/issues/154437
 2024-10-09 20:47:36 +00:00