Chinmay Garde
9910c947f6
[Impeller] libImpeller: Publish SDK artifacts. ( flutter/engine#55783 )
...
Fixes https://github.com/flutter/flutter/issues/156358
2024-10-09 20:35:28 +00:00
Chinmay Garde
57e4161fd8
[Impeller] libImpeller: Allow creating image color sources. ( flutter/engine#55754 )
...
Fixes https://github.com/flutter/flutter/issues/156360
This was missed in the earlier bringup.
cc @lyceel I did not expose the solid color source since (as @jonahwilliams [pointed out](https://github.com/flutter/flutter/issues/156360#issuecomment-2398005436 )) all it does it [clear the current color source and set the color on the paint](a01daf5555/display_list/dl_builder.cc (L206)
2024-10-09 20:11:49 +00:00
skia-flutter-autoroll
5c2733f600
Roll Skia from 80191e69c97a to 1349ddc074ad (4 revisions) ( flutter/engine#55779 )
...
https://skia.googlesource.com/skia.git/+log/80191e69c97a..1349ddc074ad
2024-10-09 michaelludwig@google.com [graphite] Reset fDstCopy in resetCommandBuffer()
2024-10-09 egdaniel@google.com [Ganesh] Add support for VK_EXT_frame_boundary.
2024-10-09 nscobie@google.com Punt CTS enforcement of VkProtectedContext_Xyz_Graphite tests to API 36
2024-10-09 egdaniel@google.com [Ganesh] Add GrSubmitInfo struct to GrDirectContext::submit
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-09 18:38:23 +00:00
skia-flutter-autoroll
7d44c0e306
Roll Skia from e0bb55353b27 to 80191e69c97a (4 revisions) ( flutter/engine#55775 )
...
https://skia.googlesource.com/skia.git/+log/e0bb55353b27..80191e69c97a
2024-10-09 bungeman@google.com [pdf] Emit `/Tabs /S` on each page
2024-10-09 cwallez@chromium.org DawnErrorChecker: Prepare for Dawn StringView callback change.
2024-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dbcb4e8a0f0c to 458c840c3ccf (1 revision)
2024-10-09 fmalita@google.com [skjson] Non-recursive Json writer impl
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-09 16:28:08 +00:00
skia-flutter-autoroll
131f9896ae
Manual roll Dart SDK to 3.6.0-334.2.beta ( flutter/engine#55772 )
...
Manual roll requested by zra@google.com
This is a Dart roll for branch alignment to the 3.6.0-334.2.beta version
of Dart. It includes the two dev versions below in addition to two CPs
listed at the top of
https://dart.googlesource.com/sdk/+log/d916a5f69a486de98316900f19ef0ff46834b03d .
https://dart.googlesource.com/sdk.git/+log/85a7e014bea8..115a3c609bf2
2024-10-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.6.0-334.0.dev
2024-10-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.6.0-333.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC
dart-vm-team@google.com ,jacksongardner@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
---------
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2024-10-09 09:17:48 -07:00
Matan Lurey
d62fed45f7
Rename GetTargetRenderPassDescriptor to GetRenderTarget. ( flutter/engine#55765 )
...
Closes https://github.com/flutter/flutter/issues/154799 .
2024-10-09 15:44:41 +00:00
skia-flutter-autoroll
9123b89cc0
Roll Fuchsia Linux SDK from TlU-It6X_ZLrNqMjW... to xGr5ZkxX3CajAY1xu... ( flutter/engine#55770 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-09 10:57:30 +00:00
skia-flutter-autoroll
b6b1210f99
Roll Skia from a077e78e531f to e0bb55353b27 (3 revisions) ( flutter/engine#55768 )
...
https://skia.googlesource.com/skia.git/+log/a077e78e531f..e0bb55353b27
2024-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 878e1c92af0b to d0e2141a997c (1 revision)
2024-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f00ae00fd775 to 09baf58309a3 (10 revisions)
2024-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2574827cf13b to 68d8508758f2 (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-09 08:40:26 +00:00
Chinmay Garde
511ee36f3f
[Impeller] libImpeller: Allow fetching OpenGL texture handle. ( flutter/engine#55753 )
...
Fixes https://github.com/flutter/flutter/issues/156359
cc @lyceel
2024-10-09 07:44:37 +00:00
Matan Lurey
8e3b58f166
ReleaseonTrimMemoryListener after ImageReaderSurfaceProducer released. ( flutter/engine#55760 )
...
Fixes https://github.com/flutter/flutter/issues/156434 .
A better fix for the workaround in https://github.com/flutter/flutter/issues/156158 .
This should likely be cherrypicked, as it's a memory leak, safe, and avoids workaround code in plugins.
2024-10-09 01:35:17 +00:00
Brandon DeRosier
e118869e40
[Flutter GPU] Get the GLES backend/Windows working. ( flutter/engine#55694 )
...
Resolves https://github.com/flutter/flutter/issues/156305 .
* Resolve pipelines and submit command buffers on the raster thread.
* Don't use desktop GL shader variation on Windows.
* Fix interpretation of `array_elements`.
* Fix texture binding metadata.
Gets Flutter GPU working on Windows!
2024-10-09 00:04:39 +00:00
Harry Terkelsen
0ed39374df
[canvaskit] Fix incorrect clipping with Opacity scene layer ( flutter/engine#55751 )
...
Fixes opacity layer incorrectly clipping its children when there are complex transforms applied to them. Since the opacity saveLayer only applies to children which actually draw, it doesn't need to have tight bounds anyways.
Pre-requisite for re-enabling tests here: https://github.com/flutter/flutter/issues/110785
BEFORE:
AFTER:
BEFORE:
AFTER:
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-08 23:49:09 +00:00
Matan Lurey
173af3d95f
Refactor multi-file build parsing into a single BuildPlan class. ( flutter/engine#55720 )
...
Closes https://github.com/flutter/flutter/issues/148444 (code de-duplicated).
Closes https://github.com/flutter/flutter/issues/150877 (`--build-strategy=local`).
Closes https://github.com/flutter/flutter/issues/150884 (`--build-strategy=remote`).
Replaces duplicate code across ~3 commands (query, test, build) with a class called `BuildPlan`, which encapsulates (a) concurrency, (b) build configuration, (c) RBE, (d) LTO, and (e) build strategy. I also moved all of the validation of the build plan into `build_plan_test`, which gives us better coverage at a lower cost (less things to think about in that suite of tests).
I know the diff looks scary, but 1K of the 1.4K is tests.
/cc @gaaclarke @flar
2024-10-08 23:45:20 +00:00
gaaclarke
90cea20d09
fixes mask blurs on stoked gradient geometry ( flutter/engine#55717 )
...
fixes https://github.com/flutter/flutter/issues/155930
This starts taking into account the translation of the entity that is
snapshotted when performing the gaussian blur. I'm uncertain under what
conditions, but sometimes the snapshot logic would need this offset. The
linked issue and added tests demonstrate those cases.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-10-08 15:20:50 -07:00
Jason Simmons
d8d3d6ac4b
[Impeller] Do not scale the miter limit applied to stroked text ( flutter/engine#55745 )
...
Fixes https://github.com/flutter/flutter/issues/156224
2024-10-08 22:07:19 +00:00
AthulJoseph
a01daf5555
Added support to set primitive type ( flutter/engine#55514 )
...
Added a way to specify the PrimitiveType when encoding commands in the RenderPass.
This partially fixes the issue #142732
2024-10-08 21:57:10 +00:00
skia-flutter-autoroll
f15530a2e9
Roll Skia from 8a2fe88d31e3 to 701b6e4b4bc4 (1 revision) ( flutter/engine#55752 )
...
https://skia.googlesource.com/skia.git/+log/8a2fe88d31e3..701b6e4b4bc4
2024-10-08 robertphillips@google.com [ganesh] Disable stencilBuffers and MSAA for Protected GL Contexts
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 21:51:23 +00:00
Chinmay Garde
50366d309d
[Impeller] libImpeller: Fix typo in public API. ( flutter/engine#55750 )
...
cc @lyceel
2024-10-08 20:50:13 +00:00
Chinmay Garde
7af6ae84e6
[Impeller] libImpeller: Allow wrapping external texture handles. ( flutter/engine#55664 )
...
Fixes https://github.com/flutter/flutter/issues/156013
2024-10-08 20:33:26 +00:00
gaaclarke
d2e73aef5b
Added mutex to the pending gpu tasks deque. ( flutter/engine#55748 )
...
b/371513051
The tasks are already capturing their target thread. I had just missed
guarding the deque that is storing the tasks. This has been seen in the
flaking of the newly added `ShellTest.EncodeImageRetryOverflows`.
Example:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8734621687934134433/+/u/test:_Host_Tests_for_host_debug_unopt/stdout
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-10-08 13:19:42 -07:00
skia-flutter-autoroll
d75cffe14f
Roll Skia from 857248fe0a9a to 8a2fe88d31e3 (7 revisions) ( flutter/engine#55749 )
...
https://skia.googlesource.com/skia.git/+log/857248fe0a9a..8a2fe88d31e3
2024-10-08 michaelludwig@google.com [skif] Adjust test tolerances for some GPUs
2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from aacbf041f6cd to 0f7371ae347d (14 revisions)
2024-10-08 nicolettep@google.com [graphite] Migrate Vulkan pipeline to consulting immutable sampler descriptions populated at graphite level
2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from b0d038d01ff9 to 4103ee393de2 (10 revisions)
2024-10-08 michaelludwig@google.com [skif] Fix rescale bounds analysis, consolidate draw codepaths
2024-10-08 michaelludwig@google.com [graphite] Update PaintParams key generation and SkSL generation to use dstCopy intrinsics
2024-10-08 nscobie@google.com [graphite] Fix VulkanCaps::fSupportsMemorylessAttachments init when fProtectedSupport
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 20:04:04 +00:00
Jonah Williams
32aa60630b
[Impeller] remove heap allocation of most geometry objects. ( flutter/engine#55677 )
...
Almost all geometry objects can now be stack allocated while rendering, instead of heap allocated - due to the removal of the EntityPass compositor. Clip geometries must still be heap allocated as the geometry objects are not yet stored in the display list, and the clips must be recorded for backdrop filter clip replay.
The canvas stores unique_ptrs to these geometries in a vector that it clears at the end of the frame. The Geometry factory methods were adjusted to return unique ptrs, and the Geometry class given a virtual dtor since we no longer rely on the special property of std::shared_ptr for memorizing the right dtor.
The ColorSourceContents and ClipContents class now hold onto a const ptr to the geometry object.
At some point in the future, we can rework the geometry object to be stored inline in the display list which will further simplify this code.
Part of https://github.com/flutter/flutter/issues/142054
2024-10-08 19:55:21 +00:00
gaaclarke
96134c85e4
added shell_unittests and ui_unittests to the testing menu ( flutter/engine#55711 )
...
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-10-08 11:17:01 -07:00
John McDole
35d7b1b8f3
Record notes on hashing artifacts in a monorepo ( flutter/engine#55703 )
...
aka "dude, where's my engine?"
2024-10-08 17:01:07 +00:00
skia-flutter-autoroll
e583fecd59
Roll Skia from 38e2598c487b to 857248fe0a9a (3 revisions) ( flutter/engine#55741 )
...
https://skia.googlesource.com/skia.git/+log/38e2598c487b..857248fe0a9a
2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 90b955a8bf93 to b0d038d01ff9 (25 revisions)
2024-10-08 danieldilan@google.com Add SubIFD to exif data when using WriteExif.
2024-10-08 kjlubick@google.com Replace/rename Gr* functions in SkMathPriv with Sk* naming convention
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,jvanverth@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 16:27:21 +00:00
skia-flutter-autoroll
8c4e6c531c
Roll Dart SDK from 7b965fbaa954 to 85a7e014bea8 (2 revisions) ( flutter/engine#55735 )
...
https://dart.googlesource.com/sdk.git/+log/7b965fbaa954..85a7e014bea8
2024-10-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-332.0.dev
2024-10-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-331.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 10:50:41 +00:00
skia-flutter-autoroll
06d7a97aa2
Roll Fuchsia Linux SDK from TTSSw-kHM8_h_tdX0... to TlU-It6X_ZLrNqMjW... ( flutter/engine#55733 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 08:39:12 +00:00
skia-flutter-autoroll
543d1c9f12
Roll Skia from 3866c52c4aa0 to d639ed5e570a (4 revisions) ( flutter/engine#55732 )
...
https://skia.googlesource.com/skia.git/+log/3866c52c4aa0..d639ed5e570a
2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 73d05ecd42e4 to f00ae00fd775 (7 revisions)
2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 38bd0b71717f to 034839b9814b
2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from b1e534c0b156 to 6a07fae851d7
2024-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from c48a419da832 to 931df19ec335
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jvanverth@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 06:51:58 +00:00
dependabot[bot]
088fecfaf1
Bump google/osv-scanner-action from 1.8.4 to 1.9.0 ( flutter/engine#55730 )
...
Bumps [google/osv-scanner-action](https://github.com/google/osv-scanner-action ) from 1.8.4 to 1.9.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/google/osv-scanner-action/releases ">google/osv-scanner-action's releases</a>.</em></p>
<blockquote>
<h2>v1.9.0</h2>
<h2>What's Changed</h2>
<ul>
<li>chore(deps): update workflows by <a href="https://github.com/renovate-bot "><code>@ârenovate-bot</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/40 ">google/osv-scanner-action#40</a></li>
<li>chore(deps): update github/codeql-action action to v3.26.7 by <a href="https://github.com/renovate-bot "><code>@ârenovate-bot</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/43 ">google/osv-scanner-action#43</a></li>
<li>chore(deps): update workflows by <a href="https://github.com/renovate-bot "><code>@ârenovate-bot</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/44 ">google/osv-scanner-action#44</a></li>
<li>chore(deps): update github/codeql-action action to v3.26.10 by <a href="https://github.com/renovate-bot "><code>@ârenovate-bot</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/45 ">google/osv-scanner-action#45</a></li>
<li>Update to v1.9.0 by <a href="https://github.com/michaelkedar "><code>@âmichaelkedar</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/46 ">google/osv-scanner-action#46</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/michaelkedar "><code>@âmichaelkedar</code></a> made their first contribution in <a href="https://redirect.github.com/google/osv-scanner-action/pull/46 ">google/osv-scanner-action#46</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/google/osv-scanner-action/compare/v1.8.5...v1.9.0 ">https://github.com/google/osv-scanner-action/compare/v1.8.5...v1.9.0 </a></p>
<h2>v1.8.5</h2>
<p>This updates OSV-Scanner to v1.8.5.</p>
<h2>What's Changed</h2>
<ul>
<li>chore(deps): update workflows by <a href="https://github.com/renovate-bot "><code>@ârenovate-bot</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/34 ">google/osv-scanner-action#34</a></li>
<li>fix: Use force checkout on second checkout for PR scanning by <a href="https://github.com/another-rex "><code>@âanother-rex</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/41 ">google/osv-scanner-action#41</a></li>
<li>chore: update to v1.8.5 by <a href="https://github.com/cuixq "><code>@âcuixq</code></a> in <a href="https://redirect.github.com/google/osv-scanner-action/pull/42 ">google/osv-scanner-action#42</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/cuixq "><code>@âcuixq</code></a> made their first contribution in <a href="https://redirect.github.com/google/osv-scanner-action/pull/42 ">google/osv-scanner-action#42</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/google/osv-scanner-action/compare/v1.8.4...v1.8.5 ">https://github.com/google/osv-scanner-action/compare/v1.8.4...v1.8.5 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="19ec111656https://redirect.github.com/google/osv-scanner-action/issues/46 ">#46</a> from google/update-to-v1.9.0</li>
<li><a href="305dc322e61748759ebfc80d3cb8d7d2af9baafchttps://redirect.github.com/google/osv-scanner-action/issues/45 ">#45</a> from renovate-bot/renovate/workflows</li>
<li><a href="0f80bc47d7eb1b88d88ahttps://redirect.github.com/google/osv-scanner-action/issues/44 ">#44</a> from renovate-bot/renovate/workflows</li>
<li><a href="fc1c0fda7232affcbc50https://redirect.github.com/google/osv-scanner-action/issues/43 ">#43</a> from renovate-bot/renovate/workflows</li>
<li><a href="5319a0e003https://github.com/google/osv-scanner-action/compare/v1.8.4...v1.9.0 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-10-08 05:53:58 +00:00
dependabot[bot]
3e7a61880d
Bump actions/upload-artifact from 4.3.6 to 4.4.1 ( flutter/engine#55728 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.6 to 4.4.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases ">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.4.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Add a section about hidden files by <a href="https://github.com/joshmgross "><code>@âjoshmgross</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/607 ">actions/upload-artifact#607</a></li>
<li>Add workflow file for publishing releases to immutable action package by <a href="https://github.com/Jcambass "><code>@âJcambass</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/621 ">actions/upload-artifact#621</a></li>
<li>Update <code>@âactions/artifact</code> to latest version, includes symlink and timeout fixes by <a href="https://github.com/robherley "><code>@ârobherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/625 ">actions/upload-artifact#625</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Jcambass "><code>@âJcambass</code></a> made their first contribution in <a href="https://redirect.github.com/actions/upload-artifact/pull/621 ">actions/upload-artifact#621</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4.4.0...v4.4.1 ">https://github.com/actions/upload-artifact/compare/v4.4.0...v4.4.1 </a></p>
<h2>v4.4.0</h2>
<h2>Notice: Breaking Changes ⚠️ </h2>
<p>We will no longer include hidden files and folders by default in the <code>upload-artifact</code> action of this version. This reduces the risk that credentials are accidentally uploaded into artifacts. Customers who need to continue to upload these files can use a new option, <code>include-hidden-files</code>, to continue to do so.</p>
<p>See <a href="https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/ ">"Notice of upcoming deprecations and breaking changes in GitHub Actions runners"</a> changelog and <a href="https://redirect.github.com/actions/upload-artifact/issues/602 ">this issue</a> for more details.</p>
<h2>What's Changed</h2>
<ul>
<li>Exclude hidden files by default by <a href="https://github.com/joshmgross "><code>@âjoshmgross</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/598 ">actions/upload-artifact#598</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4.3.6...v4.4.0 ">https://github.com/actions/upload-artifact/compare/v4.3.6...v4.4.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="604373da63https://redirect.github.com/actions/upload-artifact/issues/625 ">#625</a> from actions/robherley/artifact-2.1.10</li>
<li><a href="0150148bdfa009b25faa9f6f6f402e3eadd8b791https://redirect.github.com/actions/upload-artifact/issues/621 ">#621</a> from actions/Jcambass-patch-1</li>
<li><a href="aeba9f7961b18b1d32f3https://redirect.github.com/actions/upload-artifact/issues/607 ">#607</a> from actions/joshmgross/hidden-files-readme</li>
<li><a href="d7c12077c450769540e7https://redirect.github.com/actions/upload-artifact/issues/598 ">#598</a> from actions/joshmgross/exclude-hidden-files</li>
<li><a href="d52396ac5d834a144ee9...604373da63https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.3.6&new-version=4.4.1 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-10-08 05:53:57 +00:00
dependabot[bot]
29cb62cdca
Bump actions/checkout from 4.2.0 to 4.2.1 ( flutter/engine#55729 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.2.0 to 4.2.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases ">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.2.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Check out other refs/* by commit if provided, fall back to ref by <a href="https://github.com/orhantoy "><code>@âorhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1924 ">actions/checkout#1924</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Jcambass "><code>@âJcambass</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1919 ">actions/checkout#1919</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.2.0...v4.2.1 ">https://github.com/actions/checkout/compare/v4.2.0...v4.2.1 </a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md ">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v4.2.1</h2>
<ul>
<li>Check out other refs/* by commit if provided, fall back to ref by <a href="https://github.com/orhantoy "><code>@âorhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1924 ">actions/checkout#1924</a></li>
</ul>
<h2>v4.2.0</h2>
<ul>
<li>Add Ref and Commit outputs by <a href="https://github.com/lucacome "><code>@âlucacome</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1180 ">actions/checkout#1180</a></li>
<li>Dependency updates by <a href="https://github.com/dependabot "><code>@âdependabot</code></a>- <a href="https://redirect.github.com/actions/checkout/pull/1777 ">actions/checkout#1777</a>, <a href="https://redirect.github.com/actions/checkout/pull/1872 ">actions/checkout#1872</a></li>
</ul>
<h2>v4.1.7</h2>
<ul>
<li>Bump the minor-npm-dependencies group across 1 directory with 4 updates by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1739 ">actions/checkout#1739</a></li>
<li>Bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1697 ">actions/checkout#1697</a></li>
<li>Check out other refs/* by commit by <a href="https://github.com/orhantoy "><code>@âorhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1774 ">actions/checkout#1774</a></li>
<li>Pin actions/checkout's own workflows to a known, good, stable version. by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1776 ">actions/checkout#1776</a></li>
</ul>
<h2>v4.1.6</h2>
<ul>
<li>Check platform to set archive extension appropriately by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1732 ">actions/checkout#1732</a></li>
</ul>
<h2>v4.1.5</h2>
<ul>
<li>Update NPM dependencies by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1703 ">actions/checkout#1703</a></li>
<li>Bump github/codeql-action from 2 to 3 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1694 ">actions/checkout#1694</a></li>
<li>Bump actions/setup-node from 1 to 4 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1696 ">actions/checkout#1696</a></li>
<li>Bump actions/upload-artifact from 2 to 4 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1695 ">actions/checkout#1695</a></li>
<li>README: Suggest <code>user.email</code> to be <code>41898282+github-actions[bot]@users.noreply.github.com</code> by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1707 ">actions/checkout#1707</a></li>
</ul>
<h2>v4.1.4</h2>
<ul>
<li>Disable <code>extensions.worktreeConfig</code> when disabling <code>sparse-checkout</code> by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1692 ">actions/checkout#1692</a></li>
<li>Add dependabot config by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1688 ">actions/checkout#1688</a></li>
<li>Bump the minor-actions-dependencies group with 2 updates by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1693 ">actions/checkout#1693</a></li>
<li>Bump word-wrap from 1.2.3 to 1.2.5 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1643 ">actions/checkout#1643</a></li>
</ul>
<h2>v4.1.3</h2>
<ul>
<li>Check git version before attempting to disable <code>sparse-checkout</code> by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1656 ">actions/checkout#1656</a></li>
<li>Add SSH user parameter by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1685 ">actions/checkout#1685</a></li>
<li>Update <code>actions/checkout</code> version in <code>update-main-version.yml</code> by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1650 ">actions/checkout#1650</a></li>
</ul>
<h2>v4.1.2</h2>
<ul>
<li>Fix: Disable sparse checkout whenever <code>sparse-checkout</code> option is not present <a href="https://github.com/dscho "><code>@âdscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1598 ">actions/checkout#1598</a></li>
</ul>
<h2>v4.1.1</h2>
<ul>
<li>Correct link to GitHub Docs by <a href="https://github.com/peterbe "><code>@âpeterbe</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1511 ">actions/checkout#1511</a></li>
<li>Link to release page from what's new section by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1514 ">actions/checkout#1514</a></li>
</ul>
<h2>v4.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1396 ">Add support for partial checkout filters</a></li>
</ul>
<h2>v4.0.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1067 ">Support fetching without the --progress option</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1436 ">Update to node20</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="eef61447b9https://redirect.github.com/actions/checkout/issues/1925 ">#1925</a>)</li>
<li><a href="6b42224f41https://redirect.github.com/actions/checkout/issues/1919 ">#1919</a>)</li>
<li><a href="de5a000abfhttps://redirect.github.com/actions/checkout/issues/1924 ">#1924</a>)</li>
<li>See full diff in <a href="d632683dd7...eef61447b9https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=4.2.0&new-version=4.2.1 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-10-08 05:48:00 +00:00
skia-flutter-autoroll
541053436b
Roll Dart SDK from 3c4726445ba5 to 7b965fbaa954 (1 revision) ( flutter/engine#55726 )
...
https://dart.googlesource.com/sdk.git/+log/3c4726445ba5..7b965fbaa954
2024-10-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-330.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 05:38:49 +00:00
Liam Appelbe
118cc70a56
Delete DartIsolateTest.PlatformIsolateSendAndReceive ( flutter/engine#55722 )
...
This test is flaky on the mac bots, but I can't repro the failure locally. Sending and receiving messages from the platform isolate is covered more realistically by the [Dart test](f100ecaab7/testing/dart/platform_isolate_test.dart (L65)https://github.com/flutter/flutter/issues/156251
2024-10-08 03:17:23 +00:00
skia-flutter-autoroll
f100ecaab7
Roll Dart SDK from 94ae91747a0b to 3c4726445ba5 (1 revision) ( flutter/engine#55718 )
...
https://dart.googlesource.com/sdk.git/+log/94ae91747a0b..3c4726445ba5
2024-10-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-329.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-08 01:28:03 +00:00
David Iglesias
e2b6520742
[web] Warn users when picking a deprecated renderer. ( flutter/engine#55709 )
...
Warn users when they pick a deprecated renderer for the web, and point them to the appropriate /go/ link.
## Issues
* Part of https://github.com/flutter/flutter/issues/145954
* Fixes https://github.com/flutter/flutter/issues/154879
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-08 00:16:23 +00:00
Jackson Gardner
db449a1603
Revert "Reland [skwasm] Scene builder optimizations for platform view placement ( #55468 )" ( flutter/engine#55715 )
...
This reverts commit b99e758ee1025d5bab2ecff1d62ff75a17b68996 (https://github.com/flutter/engine/pull/55468 )
Reason for revert, devtools has been having rendering issues since this commit. See https://github.com/flutter/devtools/issues/8401
2024-10-08 00:01:15 +00:00
skia-flutter-autoroll
4d14f8631b
Roll Dart SDK from 902494bb4c8b to 94ae91747a0b (1 revision) ( flutter/engine#55712 )
...
https://dart.googlesource.com/sdk.git/+log/902494bb4c8b..94ae91747a0b
2024-10-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-328.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-07 21:16:21 +00:00
skia-flutter-autoroll
9366a74fb8
Roll Skia from 6afbd6253e66 to d0e49fde3765 (4 revisions) ( flutter/engine#55710 )
...
https://skia.googlesource.com/skia.git/+log/6afbd6253e66..d0e49fde3765
2024-10-07 vigneshv@google.com Enable CrabbyAvif for Android framework
2024-10-07 bungeman@google.com [pdf] Spanify SkPDFTagNode::fChildren
2024-10-07 bungeman@google.com Migrate Debian 11 builders
2024-10-07 bungeman@google.com Allow SkSpan<T> declarations with incomplete T
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jvanverth@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-07 20:51:54 +00:00
gaaclarke
96b0bf0ce3
Speculative fix for memory issues related to retrying image decompression ( flutter/engine#55704 )
...
b/371512414
This issue had no reproduction but the stacktrace was provided. The theory of this fix is that the `ImageResult` type is capturing something that doesn't handle being copied and deallocated twice so instead of copying it, we std::move it into a shared_ptr so that it will only be deallocated once.
Also, I just avoid using a `std::move` when overflowing. The idea here is maybe sometimes deleting the std::move'd item isn't kosher. We know from the stacktrace that it has something to do with overflowing because that would be the only case where something is being deleted.
I've added 2 integration tests that exercises the code where the crash appears to be happening. This is good coverage to have but neither of them reproduced the issue, even with MallocScribble enabled. That's the best we can do without a reproduction.
```
Thread 7 (id: 0x0000a103)crashed
0x000000010a48ae8c(Flutter -function.h)std::_fl::allocator<impeller::ContextMTL::PendingTasks>::destroy[abi:v15000](impeller::ContextMTL::PendingTasks*)
0x000000010a48b9fc(Flutter -allocator_traits.h:309)impeller::ContextMTL::StoreTaskForGPU(std::_fl::function<void ()> const&, std::_fl::function<void ()> const&)
0x000000010a48b9fc(Flutter -allocator_traits.h:309)impeller::ContextMTL::StoreTaskForGPU(std::_fl::function<void ()> const&, std::_fl::function<void ()> const&)
0x000000010a4d49e4(Flutter -image_decoder_impeller.cc:422)std::_fl::__function::__func<flutter::ImageDecoderImpeller::UploadTextureToPrivate(std::_fl::function<void (sk_sp<flutter::DlImage>, std::_fl::basic_string<char, std::_fl::char_traits<char>, std::_fl::allocator<char>>)>, std::_fl::shared_ptr<impeller::Context> const&, std::_fl::shared_ptr<impeller::DeviceBuffer> const&, SkImageInfo const&, std::_fl::shared_ptr<SkBitmap> const&, std::_fl::optional<SkImageInfo> const&, std::_fl::shared_ptr<fml::SyncSwitch> const&)::$_1, std::_fl::allocator<flutter::ImageDecoderImpeller::UploadTextureToPrivate(std::_fl::function<void (sk_sp<flutter::DlImage>, std::_fl::basic_string<char, std::_fl::char_traits<char>, std::_fl::allocator<char>>)>, std::_fl::shared_ptr<impeller::Context> const&, std::_fl::shared_ptr<impeller::DeviceBuffer> const&, SkImageInfo const&, std::_fl::shared_ptr<SkBitmap> const&, std::_fl::optional<SkImageInfo> const&, std::_fl::shared_ptr<fml::SyncSwitch> const&)::$_1>, void ()>::operator()()
0x000000010a06c234(Flutter -function.h:512)fml::SyncSwitch::Execute(fml::SyncSwitch::Handlers const&) const
0x000000010a4d42f8(Flutter -image_decoder_impeller.cc:408)flutter::ImageDecoderImpeller::UploadTextureToPrivate(std::_fl::function<void (sk_sp<flutter::DlImage>, std::_fl::basic_string<char, std::_fl::char_traits<char>, std::_fl::allocator<char>>)>, std::_fl::shared_ptr<impeller::Context> const&, std::_fl::shared_ptr<impeller::DeviceBuffer> const&, SkImageInfo const&, std::_fl::shared_ptr<SkBitmap> const&, std::_fl::optional<SkImageInfo> const&, std::_fl::shared_ptr<fml::SyncSwitch> const&)
0x000000010a4d3838(Flutter -image_decoder_impeller.cc:538)std::_fl::__function::__func<flutter::ImageDecoderImpeller::Decode(fml::RefPtr<flutter::ImageDescriptor>, unsigned int, unsigned int, std::_fl::function<void (sk_sp<flutter::DlImage>, std::_fl::basic_string<char, std::_fl::char_traits<char>, std::_fl::allocator<char>>)> const&)::$_1, std::_fl::allocator<flutter::ImageDecoderImpeller::Decode(fml::RefPtr<flutter::ImageDescriptor>, unsigned int, unsigned int, std::_fl::function<void (sk_sp<flutter::DlImage>, std::_fl::basic_string<char, std::_fl::char_traits<char>, std::_fl::allocator<char>>)> const&)::$_1>, void ()>::operator()()
0x000000010a06dd1c(Flutter -function.h:512)fml::ConcurrentMessageLoopDarwin::ExecuteTask(std::_fl::function<void ()> const&)
0x000000010a06737c(Flutter -concurrent_message_loop.cc:101)void* std::_fl::__thread_proxy[abi:v15000]<std::_fl::tuple<std::_fl::unique_ptr<std::_fl::__thread_struct, std::_fl::default_delete<std::_fl::__thread_struct>>, fml::ConcurrentMessageLoop::ConcurrentMessageLoop(unsigned long)::$_0>>(void*)
0x000000021d4ff378(libsystem_pthread.dylib + 0x00006378)_pthread_start
```
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-07 20:46:16 +00:00
Jonah Williams
3f50f56235
[Impeller] disable surface control on API 29. ( flutter/engine#55708 )
...
Fixes https://github.com/flutter/flutter/issues/155877
Technically SurfaceControl is supported on API 29 but I've observed enough reported bugs that I'm bumping the constraint to 30. If we had more time to test all of these older devices maybe we could figure out if the problem is something that can be worked around.
2024-10-07 20:10:16 +00:00
Jonah Williams
086e6a63f5
[Impeller] remove Vulkan command encoder abstraction, use command buffer vk. ( flutter/engine#55680 )
...
The Vulkan command buffer wrapper delegates almost all of its functionality to the "CommandEncoderVK". I did not find that this separation was useful, as they have a 1-1 relationship and an identical lifecycle. Lets combine them to reduce the number of things to worry about.
2024-10-07 19:52:55 +00:00
Jonah Williams
b4d91f9d68
[Impeller] add parsing of known GPU models ( flutter/engine#55196 )
...
We will need to denylist certain Vulkan drivers. This is easier to do if we have some mechanism of determining which GPU model we're currently using. This doesn't add any new denylisting, it just ads a mechanism to parse the driver name into an enum. I mean, there are only so many SoCs, right?
See also https://github.com/flutter/flutter/issues/155185
2024-10-07 19:18:03 +00:00
Justin McCandless
d24bc5a0ef
Path clarification in Setting-up-the-Engine-development-environment.md ( flutter/engine#55529 )
...
I thought that this was referring to the flutter/flutter repo, but it's actually in flutter/engine/src/flutter/bin. Updated to clarify.
2024-10-07 18:16:04 +00:00
skia-flutter-autoroll
9b197d6b75
Roll Skia from 89284b1d7eeb to 6afbd6253e66 (2 revisions) ( flutter/engine#55702 )
...
https://skia.googlesource.com/skia.git/+log/89284b1d7eeb..6afbd6253e66
2024-10-07 kjlubick@google.com Add compile-check for SkImage::RequiredProperties being a map key
2024-10-07 jvanverth@google.com [graphite] Correct sort order when using analytic and shader clips.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jvanverth@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-07 17:40:00 +00:00
skia-flutter-autoroll
33ca2cbbb3
Roll Dart SDK from 5e6945a72200 to 902494bb4c8b (1 revision) ( flutter/engine#55700 )
...
https://dart.googlesource.com/sdk.git/+log/5e6945a72200..902494bb4c8b
2024-10-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-327.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-07 17:05:20 +00:00
Chris Bracken
773c37ab82
Revert "iOS: Migrate FlutterEngine to ARC ( #55590 )" ( flutter/engine#55699 )
...
Causing flakes on the _Mac mac_unopt (Cocoon)_ shard.
This reverts commit a2ac734e10115547d8c8ef34610ea6172e3cc98b.
Issue: https://github.com/flutter/flutter/issues/156177
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-07 16:29:24 +00:00
John McDole
342fc504a2
La Grande Fusion Notes - History Editing ( flutter/engine#55667 )
...
AKA "Dude Where's My Files?"
Document the history editing that will occur during the monorepo merge.
`flutter/engine` will remain the source of truth of revisions older than
the merge.
---------
Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
2024-10-07 09:13:46 -07:00
skia-flutter-autoroll
d580c10611
Roll Skia from 52155a48ff8d to 89284b1d7eeb (3 revisions) ( flutter/engine#55697 )
...
https://skia.googlesource.com/skia.git/+log/52155a48ff8d..89284b1d7eeb
2024-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from cd7f294923c7 to aacbf041f6cd (18 revisions)
2024-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 015479b2afc8 to 73d05ecd42e4 (12 revisions)
2024-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f8d389436d22 to 90b955a8bf93 (13 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jvanverth@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-07 14:33:23 +00:00
skia-flutter-autoroll
ec02ceaeee
Roll Fuchsia Linux SDK from h5VOYlPZ-2eCtUR_z... to TTSSw-kHM8_h_tdX0... ( flutter/engine#55692 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-07 07:23:05 +00:00
skia-flutter-autoroll
233629fb66
Roll Fuchsia Linux SDK from Izy4D5DB98t46Zoh9... to h5VOYlPZ-2eCtUR_z... ( flutter/engine#55678 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-05 22:01:36 +00:00
