29204 Commits

Author SHA1 Message Date
skia-flutter-autoroll
bf099905d2 Roll Dart SDK from 9aa80e32947d to 5e6945a72200 (1 revision) (flutter/engine#55674)
https://dart.googlesource.com/sdk.git/+log/9aa80e32947d..5e6945a72200

2024-10-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-326.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-05 07:18:23 +00:00
Jim Graham
ab7af6ffb2 Honor blur tile mode in BackdropFilter widget on Skia backend (flutter/engine#55640)
The blur ImageFilter has a tile mode that describes how to sample pixels near the edge of the source. When used as a BackdropFilter this behavior is important as the wrong tile mode can cause distracting flashing as app content is scrolled under foreground widgets that blur their background. Unfortunately the Skia backend used to default the tile mode for all backdrop filters to `clamp` mode with no way to update it and that mode was the one that produced the most distracting flashing.

Recently Skia opened up control over the tile mode used for backdrop filters and we now take advantage of that capability so that app developers can now set the tile mode to a nicer value.
2024-10-05 04:58:30 +00:00
Jonah Williams
fd33d17487 [Impeller] remove aiks color_filter and image_filter types. (flutter/engine#55654)
Like the color_source, these classes are just copies of the DL types. Use the DLTypes instead.

Part of https://github.com/flutter/flutter/issues/142054
2024-10-05 04:32:08 +00:00
skia-flutter-autoroll
248c2a7062 Roll Dart SDK from c1c971fd1b94 to 9aa80e32947d (1 revision) (flutter/engine#55673)
https://dart.googlesource.com/sdk.git/+log/c1c971fd1b94..9aa80e32947d

2024-10-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-325.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-05 03:10:09 +00:00
Brandon DeRosier
3b3ffcb8cd [Flutter GPU] Add WindingOrder. (flutter/engine#55413)
Resolves https://github.com/flutter/flutter/issues/155636.

(Extends test in https://github.com/flutter/engine/pull/55409)
2024-10-05 02:04:04 +00:00
Jonah Williams
767efe1ad7 [Impeller] remove usage of MaxBasisLength in favor of XY variant. (flutter/engine#55670)
MaxBasisXYZ prevents usage of scaling factors less than one since Z is almost always 1.

Fixes https://github.com/flutter/flutter/issues/153451
2024-10-05 00:16:37 +00:00
skia-flutter-autoroll
e1473c81a4 Roll Dart SDK from ecba03620fc8 to c1c971fd1b94 (2 revisions) (flutter/engine#55668)
https://dart.googlesource.com/sdk.git/+log/ecba03620fc8..c1c971fd1b94

2024-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-324.0.dev
2024-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-323.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-04 22:33:19 +00:00
John McCutchan
1e3d251560 Add --rbe-force-local flag to force rbe task execution to happen on the local machine (flutter/engine#55635)
`build`, `test`, and `run` commands all support the `--exec-strategy`
flag ('auto', 'local', 'remote').

This flag controls the RBE task execution strategy (when RBE is
enabled).

Closes #150877
2024-10-04 14:59:37 -07:00
skia-flutter-autoroll
8b54d8e12f Roll Skia from 4aff9603622d to 9145d1ef9638 (2 revisions) (flutter/engine#55665)
https://skia.googlesource.com/skia.git/+log/4aff9603622d..9145d1ef9638

2024-10-04 michaelludwig@google.com [graphite] Minor fixes to PaintParamsKey dumping/labels
2024-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from db76988ee4a3 to 31bccb45ea33 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-04 21:21:22 +00:00
Matan Lurey
9f49c8f4e3 Add support for et test //flutter/path/to/dart_test (flutter/engine#55638)
Closes https://github.com/flutter/flutter/issues/147013.
Closes https://github.com/flutter/flutter/issues/147071.

/cc @reidbaker who I know wants to do this for the Java rules soon TM.
/cc @jtmcdole, @zanderso for visibility.
2024-10-04 13:55:27 -07:00
Jim Graham
7f99da5b92 [Impeller] Use a squircle-sdf-based algorithm for fast blurs (flutter/engine#55604)
Use a Squircle Signed Distance Field based algorithm to do a very fast approximation of rrect blurs.

This PR is to provide reference within the team to discuss the future of the algorithm compared to the Gaussian approximation functions that are currently in use. It isn't a complete solution, but can be completed easily with a little more work.

Notably, it doesn't handle elliptical round rects, only circular corners.
Could stand to include an attribution to the source (https://raphlinus.github.io/graphics/2020/04/21/blurred-rounded-rects.html)
2024-10-04 20:24:15 +00:00
skia-flutter-autoroll
8973b6e97a Roll Skia from 59f512b47cc0 to 4aff9603622d (1 revision) (flutter/engine#55663)
https://skia.googlesource.com/skia.git/+log/59f512b47cc0..4aff9603622d

2024-10-04 jamesgk@google.com [graphite] Use Dawn limits for buffer alignment caps

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-04 19:51:05 +00:00
skia-flutter-autoroll
39ee68d618 Roll Fuchsia Linux SDK from TnSpLq0S9XT2rHGl1... to Izy4D5DB98t46Zoh9... (flutter/engine#55662)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-04 19:43:22 +00:00
skia-flutter-autoroll
49a546db67 Roll Skia from e8e0a8c46345 to 59f512b47cc0 (3 revisions) (flutter/engine#55660)
https://skia.googlesource.com/skia.git/+log/e8e0a8c46345..59f512b47cc0

2024-10-04 danieldilan@google.com Reland "Write test for platform image generators."
2024-10-04 cwallez@chromium.org Remove wgpu::FeatureName::SurfaceCapabilities
2024-10-04 kjlubick@google.com Enforce IWYU on graphite's compute and render subdirectories

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-04 18:31:36 +00:00
Jonah Williams
9d8929af60 [Impeller] generate mipmaps for toImage. (flutter/engine#55655)
Fixes https://github.com/flutter/flutter/issues/156161

Mips must be eagerly generated for Picture.toImage and friends so that filter quality (mip sampling) works as expected.
2024-10-04 17:49:55 +00:00
Chris Bracken
a2ac734e10 iOS: Migrate FlutterEngine to ARC (flutter/engine#55590)
Migrates `FlutterEnging` from manual reference counting to ARC. Migrates properties from `retain` to strong and `assign` to `weak` (where referencing an Obj-C object).

No semantic changes, therefore no changes to tests.

Issue: https://github.com/flutter/flutter/issues/137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-04 15:00:30 +00:00
skia-flutter-autoroll
e1a8f27e21 Roll Skia from 0dfa080b5d71 to e8e0a8c46345 (1 revision) (flutter/engine#55652)
https://skia.googlesource.com/skia.git/+log/0dfa080b5d71..e8e0a8c46345

2024-10-04 cwallez@chromium.org WebGPU: Prepare for Dawn output struct WGPUStringView breaking change.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-04 14:44:22 +00:00
skia-flutter-autoroll
a67d772acb Roll Dart SDK from 750b6e44b765 to ecba03620fc8 (1 revision) (flutter/engine#55650)
https://dart.googlesource.com/sdk.git/+log/750b6e44b765..ecba03620fc8

2024-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-322.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-04 14:12:06 +00:00
skia-flutter-autoroll
d4e4693b76 Roll Dart SDK from b96383c6bddd to 750b6e44b765 (3 revisions) (flutter/engine#55649)
https://dart.googlesource.com/sdk.git/+log/b96383c6bddd..750b6e44b765

2024-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-321.0.dev
2024-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-320.0.dev
2024-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-319.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-04 10:06:40 +00:00
skia-flutter-autoroll
e42d01bc98 Roll Skia from cef6e8423365 to 0dfa080b5d71 (4 revisions) (flutter/engine#55648)
https://skia.googlesource.com/skia.git/+log/cef6e8423365..0dfa080b5d71

2024-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6024e9c05548 to cd7f294923c7 (2 revisions)
2024-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 88a2d3572b41 to db76988ee4a3 (4 revisions)
2024-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3bf46a600a54 to 015479b2afc8 (16 revisions)
2024-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 72ca2005cd32 to 7a9a492a38b7 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-04 09:44:24 +00:00
Jonah Williams
959b7c6b60 [Impeller] clamp render target size at max texture size. (flutter/engine#55628)
Part of https://github.com/flutter/flutter/issues/128912

If an intermediate render target would be larger than the max texture size, then clamp the texture.
2024-10-04 03:39:14 +00:00
skia-flutter-autoroll
8571552076 Roll Skia from 379139f0bebe to e732cdf455c8 (11 revisions) (flutter/engine#55642)
https://skia.googlesource.com/skia.git/+log/379139f0bebe..e732cdf455c8

2024-10-03 bungeman@google.com Remove initializer_list use from SkZip.h
2024-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 9edd74e2ff86 to 6024e9c05548 (7 revisions)
2024-10-03 jamesgk@google.com [graphite] Bring minimum uniform buffer size back down to 2kb
2024-10-03 michaelludwig@google.com Revert "Write test for platform image generators."
2024-10-03 danieldilan@google.com Write test for platform image generators.
2024-10-03 drott@chromium.org [Fontations-backend] Roll Fontations, Skrifa to 0.22.3
2024-10-03 lukasza@chromium.org [rust png] Hide stream from `SkCodec` parent class to prevent rewinding.
2024-10-03 nicolettep@google.com [graphite] Migrate dawn pipeline to consulting immutable sampler descriptions populated at graphite level
2024-10-03 robertphillips@google.com Reland "[ganesh] Add GrGLANGLEBackend::kVulkan"
2024-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d2712d5ff726 to 88a2d3572b41 (2 revisions)
2024-10-03 jamesgk@google.com [graphite] Avoid redundant de-duplication of uniform data

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-04 02:26:21 +00:00
Jonah Williams
1cdd8d06be [Impeller] remove aiks color_source. (flutter/engine#55603)
Aiks color source is more or less a one to one copy of the impeller::DisplayListColorSource. We can rip it out, instead of flutter::DisplayList::ColorSource -> impeller::Aiks::ColorSource -> impelller:Entity::ColorSourceContents, just go directly flutter::DisplayList::ColorSource -> impelller:Entity::ColorSourceContents.

Part of https://github.com/flutter/flutter/issues/142054
2024-10-04 02:20:33 +00:00
skia-flutter-autoroll
666a7b8747 Roll Dart SDK from 91d39199994c to b96383c6bddd (1 revision) (flutter/engine#55641)
https://dart.googlesource.com/sdk.git/+log/91d39199994c..b96383c6bddd

2024-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-318.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-04 01:48:23 +00:00
Matan Lurey
92c9c99411 Add missing license headers to engine_tool. (flutter/engine#55636)
Address post-submit feedback on https://github.com/flutter/engine/pull/55537#pullrequestreview-2346684376.
2024-10-04 00:24:20 +00:00
Robert Ancell
971dbd79fb Refactor FlKeyboardHandler (flutter/engine#55601)
Refactor FlKeyboardHandler to be more GObject and less C++.

Done as we will need to move the handler from FlView to FlEngine to
support multi-view.
2024-10-04 12:00:00 +13:00
Matan Lurey
887fcf0563 Add and use a dart_test rule. (flutter/engine#55630)
Work towards https://github.com/flutter/flutter/issues/147013.

I think I still need applicable metadata about the output, and then make
sure `et test` understands everything:

```sh
% et test //flutter/tools/engine_tool/...
[2024-10-03 13:26:42.657137] ERROR: No test targets found
```
2024-10-03 14:41:25 -07:00
skia-flutter-autoroll
b0b41b90c6 Roll Dart SDK from 4c767e0fae21 to 91d39199994c (1 revision) (flutter/engine#55631)
https://dart.googlesource.com/sdk.git/+log/4c767e0fae21..91d39199994c

2024-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-317.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-03 21:30:23 +00:00
Jonah Williams
0854e45692 [Impeller] ensure one AiksContext per app. (flutter/engine#55629)
Reland of https://github.com/flutter/engine/pull/55393
2024-10-03 20:54:04 +00:00
Chinmay Garde
592c393867 [Impeller] A text layout and shaping API for the standalone library. (flutter/engine#55598)
This uses the same shaper as the rest of Flutter. The minimal ICU data configuration comes embedded in the dylib so there are no out-of-band packaging concerns.

<img width="1136" alt="Screenshot 2024-10-02 at 4 11 17 PM" src="https://github.com/user-attachments/assets/ce63dc99-7c3d-4b71-ac5d-926dffa5269b">

Fixes https://github.com/flutter/flutter/issues/156015
2024-10-03 19:36:02 +00:00
Matan Lurey
6c9af1435d Refactor et run (and friends). (flutter/engine#55537)
Does a few things:

- Refactors `run_command_test` significantly to reduce global fixtures
- Replaced stringly-typed things with enum-like objects
- Adds a lot stronger coverage for `run_command` to make future refactors safer
- Takes advantage of `package:test` having a workable matchers system and uses it
- Changes `return 1` into `throw FatalError(...)` where it makes sense in `run_command`

As a result of the refactoring work, I also fixed a bug: Closes https://github.com/flutter/flutter/issues/147646.
2024-10-03 19:32:08 +00:00
Jason Simmons
3ad82894c5 [Impeller] Do not cull in TextFrameDispatcher::drawDisplayList if the transform has perspective (flutter/engine#55602)
Fixes https://github.com/flutter/flutter/issues/155947
2024-10-03 19:26:05 +00:00
Chris Bracken
36078b8126 iOS: Fix IOSSurfaceNoopTest (flutter/engine#55621)
Previously, we were passing `nullptr` to the `IOSSurfaceNoop` constructor:
56d060d501/shell/platform/darwin/ios/ios_surface_noop.mm (L23-L24)

which calls the IOSSurface constructor:
56d060d501/shell/platform/darwin/ios/ios_surface.mm (L55-L58)

Which calls `FML_DCHECK(ios_context_)`, which really doesn't like it when `ios_context_` is null.

I will later follow up with the next question of... "what exactly is going on with our CI here?", but this unbreaks my local dev testing workflow for the moment :)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-03 19:22:09 +00:00
auto-submit[bot]
5215356e5a Reverts "[Impeller] one aiks context per app. (#55393)" (flutter/engine#55625)
Reverts: flutter/engine#55393
Initiated by: matanlurey
Reason for reverting: Postsubmit turned red (clang tidy and build).
Original PR Author: jonahwilliams

Reviewed By: {chinmaygarde}

This change reverts the following previous change:
Hoist the content context up to the ios_surface so that overlay layers don't recreate a bunch of expensive machinery. 

Fixes https://github.com/flutter/flutter/issues/154836
2024-10-03 18:46:46 +00:00
skia-flutter-autoroll
8ea6f1dac2 Roll Fuchsia Linux SDK from YKvfbpZ38daiwJ7H0... to TnSpLq0S9XT2rHGl1... (flutter/engine#55622)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-03 18:26:56 +00:00
Jonah Williams
7bb85d3d81 [Impeller] one aiks context per app. (flutter/engine#55393)
Hoist the content context up to the ios_surface so that overlay layers don't recreate a bunch of expensive machinery. 

Fixes https://github.com/flutter/flutter/issues/154836
2024-10-03 18:13:08 +00:00
Jason Simmons
8478ab1dfb [Impeller] Fix handling of perspective matrices in Matrix::Translate (flutter/engine#55536)
Fixes https://github.com/flutter/flutter/issues/155450
2024-10-03 15:28:47 +00:00
skia-flutter-autoroll
56f6d72cd1 Roll Skia from 68fea8aa589b to fe3cd2adeaaa (1 revision) (flutter/engine#55613)
https://skia.googlesource.com/skia.git/+log/68fea8aa589b..fe3cd2adeaaa

2024-10-03 drott@chromium.org [Fontations-backend] Roll Fontations, Skrifa to 0.22.2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-03 14:02:08 +00:00
skia-flutter-autoroll
cc009ecf66 Roll Dart SDK from 1c2e6ad84af1 to 4c767e0fae21 (1 revision) (flutter/engine#55612)
https://dart.googlesource.com/sdk.git/+log/1c2e6ad84af1..4c767e0fae21

2024-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-316.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-03 13:54:32 +00:00
skia-flutter-autoroll
5aafa9dcb7 Roll Dart SDK from 8b45ba3fdbfa to 1c2e6ad84af1 (1 revision) (flutter/engine#55610)
https://dart.googlesource.com/sdk.git/+log/8b45ba3fdbfa..1c2e6ad84af1

2024-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-315.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-03 09:47:29 +00:00
skia-flutter-autoroll
7b4d815bcd Roll Skia from df2e478e9f8d to f074e2bd0aba (1 revision) (flutter/engine#55608)
https://skia.googlesource.com/skia.git/+log/df2e478e9f8d..f074e2bd0aba

2024-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from a4dc29886e99 to 3bf46a600a54 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-03 07:40:21 +00:00
skia-flutter-autoroll
8294276416 Roll Dart SDK from 14b931c40076 to 8b45ba3fdbfa (1 revision) (flutter/engine#55606)
https://dart.googlesource.com/sdk.git/+log/14b931c40076..8b45ba3fdbfa

2024-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-314.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-03 05:34:20 +00:00
skia-flutter-autoroll
0803f77111 Roll Skia from 03431ca9d337 to ba95ec201dfd (3 revisions) (flutter/engine#55599)
https://skia.googlesource.com/skia.git/+log/03431ca9d337..ba95ec201dfd

2024-10-02 bungeman@google.com [pdf] Reduce size of StructElem
2024-10-02 bungeman@google.com [pdf] Clean up SkPDFDocument initialization
2024-10-02 jamesgk@google.com [graphite] Dynamically size vertex buffers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-03 00:23:22 +00:00
gaaclarke
569ddd287e Vectorize rrect_blur (flutter/engine#55576)
issue: https://github.com/flutter/flutter/issues/148496

28% speed improvement in the rrect_blur shader.

## before
<img width="1728" alt="Screenshot 2024-10-01 at 3 45 46 PM" src="https://github.com/user-attachments/assets/643068a5-ab1e-4fa3-bc03-184b2ee4a6cf">

## after
<img width="1728" alt="Screenshot 2024-10-01 at 3 42 30 PM" src="https://github.com/user-attachments/assets/41445231-ffea-4279-8142-ce126df8187c">

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-03 00:07:22 +00:00
Zachary Anderson
f3746f9001 Shift --no-prebuilt-dart-sdk build to linux_unopt (flutter/engine#55597)
This is my bad for not having this documented better/at-all, but since this build does not produce artifacts, it should not go under a builder that is marked as `release_build: "true"` in the .ci.yaml. This PR moves the build to `linux_unopt.json`.
2024-10-02 23:41:59 +00:00
skia-flutter-autoroll
2734d87bca Roll Skia from 40d51ebc76db to 03431ca9d337 (4 revisions) (flutter/engine#55596)
https://skia.googlesource.com/skia.git/+log/40d51ebc76db..03431ca9d337

2024-10-02 robertphillips@google.com Revert "[ganesh] Add GrGLANGLEBackend::kVulkan"
2024-10-02 bungeman@google.com Revert "Allow passing multiple node IDs per PDF structure node."
2024-10-02 michaelludwig@google.com [skif] SaveLayerRec has configurable backdrop tile mode
2024-10-02 jvanverth@google.com [graphite] Fix issue with YUVA premultiplied alpha.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-02 22:50:13 +00:00
Alexander Aprelev
fd73f20e88 Add host engine build that exercises no-prebuilt-dart-sdk (flutter/engine#55589)
This allows to catch breakages to `--no-prebuilt-dart-sdk` proactively,
prevents issues like https://github.com/flutter/engine/pull/55558
2024-10-02 15:03:29 -07:00
skia-flutter-autoroll
8007e687d4 Roll Dart SDK from 7d0becb773d1 to 14b931c40076 (2 revisions) (flutter/engine#55594)
https://dart.googlesource.com/sdk.git/+log/7d0becb773d1..14b931c40076

2024-10-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-313.0.dev
2024-10-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-312.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-02 21:59:06 +00:00
Matan Lurey
7a1d324299 Remove all use of gn desc global test fixtures. (flutter/engine#55592)
Closes https://github.com/flutter/flutter/issues/148420.
2024-10-02 21:55:05 +00:00
Harry Terkelsen
6d9834ee05 Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55563)
This enhances the overlay optimization by delaying combining pictures to get tighter bounds for the pictures that make up the scene, enabling more sophisticated optimization since we can determine if they intersect with platform views on a per-picture basis.

Fixes https://github.com/flutter/flutter/issues/149863
Fixes https://github.com/flutter/flutter/issues/155833

On a Macbook in Chrome in an example app with an infinite scrolling grid of platform views, this brings the ratio of dropped frames from 93% to 55% (roughly 4 fps to 30 fps).

This is a reland of https://github.com/flutter/engine/pull/54878 with a fix for scenes with pictures and shader masks that are eventually entirely clipped out. It also fixes a performance issue caused by making too many Canvases just to record the size of the picture elements in the scene.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-02 21:26:46 +00:00