36295 Commits

Author SHA1 Message Date
Jonah Williams
f7bd03202f
[devicelab] boot up benchmarks. (#132148)
Enable Impeller benchmarks for drawAtlas/drawVertices on iOS/Metal, Android/GLES, and Android/Vulkan.

Enable impeller tessellation benchmarks on iOS/Metal and Android/Vulkan - not GLES as this is measuring backend agnostic performance.
2023-08-14 18:47:08 +00:00
engine-flutter-autoroll
6d87a23b37
Roll Packages from 9b15c2e6ab30 to 08080abd9cbb (5 revisions) (#132505)
9b15c2e6ab...08080abd9c

2023-08-12 66741910+mishapark@users.noreply.github.com [google_maps_flutter] removed old overrides (flutter/packages#4679)
2023-08-11 katelovett@google.com [dynamic_layouts] Refactor flaky test (flutter/packages#4681)
2023-08-11 stuartmorgan@google.com [shared_preferences] Update iOS/macOS Pigeon (flutter/packages#4668)
2023-08-11 tarrinneal@gmail.com [pigeon] skipGen (flutter/packages#4682)
2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter from 685141bf3b5f to 9b6945b465a1 (25 revisions) (flutter/packages#4680)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-14 18:36:04 +00:00
engine-flutter-autoroll
7f12bbc689
Roll Flutter Engine from c125e1e23d4b to 46c11916f8d2 (1 revision) (#132502)
c125e1e23d...46c11916f8

2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from 8b051126be8a to a690bd1fb8b8 (1 revision) (flutter/engine#44684)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-14 18:00:00 +00:00
Victoria Ashworth
ec0b7443c4
Fix log filtering and CI tests for iOS 17 physical devices (#132491)
Fixes a couple of issues introduced in new iOS 17 physical device tooling: https://github.com/flutter/flutter/pull/131865.

1) Duplicate messages were being filtered out too aggressively. 

For example, if on the counter app, you printed "Increment!" on button click, it would only print once no matter how many times you clicked.

Sometimes more than one log source is used at a time and the original intention was to filter duplicates between two log sources, so it wouldn't print the same message from both logs. However, it would also filter when the same message was added more than once via the same log.

The new solution distinguishes a "primary" and a "fallback" log source and prefers to use the primary source unless it's not working, in which it'll use the fallback. If the fallback is faster than the primary, the primary will exclude the logs received by the fallback in a 1-to-1 fashion to prevent too-aggressive filtering. Once a flutter-message has been received by the primary source, fallback messages will be ignored.

Note: iOS < 17 did not regress.

2) There was a race condition between the shutdown hooks and exiting XcodeDebug that was causing a crash when deleting a file that doesn't exist. This only affects CI  - for the new integration tests and when testing with iOS 17 physical devices.
2023-08-14 17:30:55 +00:00
engine-flutter-autoroll
8b8f262d4d
Roll Flutter Engine from 4e8b2b61f648 to c125e1e23d4b (1 revision) (#132496)
4e8b2b61f6...c125e1e23d

2023-08-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from yr5wa34bzOBfEgzDH... to AvjxPvh-niiyQpYoD... (flutter/engine#44683)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from yr5wa34bzOBf to AvjxPvh-niiy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-14 17:14:18 +00:00
Polina Cherkasova
a7b69b069f
Unpin leak_tracker and handle breaking changes in API. (#132352) 2023-08-14 10:05:20 -07:00
engine-flutter-autoroll
87de2c5e60
Roll Flutter Engine from 62a392f29aa5 to 4e8b2b61f648 (2 revisions) (#132490)
62a392f29a...4e8b2b61f6

2023-08-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 452c6617ee36 to 3295a353980a (1 revision) (flutter/engine#44681)
2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from a4aa96331dd5 to 8b051126be8a (2 revisions) (flutter/engine#44680)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-14 16:17:09 +00:00
engine-flutter-autoroll
8b132c0f3d
Roll Flutter Engine from f50ad637de75 to 62a392f29aa5 (1 revision) (#132487)
f50ad637de...62a392f29a

2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from f3b22eaf86bd to a4aa96331dd5 (1 revision) (flutter/engine#44678)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-14 14:30:15 +00:00
engine-flutter-autoroll
9c21403471
Roll Flutter Engine from 9cebd2015688 to f50ad637de75 (3 revisions) (#132480)
9cebd20156...f50ad637de

2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from efb8daa0503b to f3b22eaf86bd (1 revision) (flutter/engine#44677)
2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from afec82ee6a10 to efb8daa0503b (1 revision) (flutter/engine#44676)
2023-08-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 55d7c1b35902 to 452c6617ee36 (1 revision) (flutter/engine#44675)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-14 08:47:23 +00:00
engine-flutter-autoroll
de84eec63a
Roll Flutter Engine from bcaaa0e125fe to 9cebd2015688 (2 revisions) (#132477)
bcaaa0e125...9cebd20156

2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from a8715028bba1 to afec82ee6a10 (1 revision) (flutter/engine#44674)
2023-08-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from yfMzjtavZwtK0QM4C... to JKTVoxVrHjZjBaxG4... (flutter/engine#44673)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from yfMzjtavZwtK to JKTVoxVrHjZj

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-14 07:16:34 +00:00
engine-flutter-autoroll
427bfc6609
Roll Flutter Engine from 7915c049a1fd to bcaaa0e125fe (1 revision) (#132473)
7915c049a1...bcaaa0e125

2023-08-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UN2vSCJekPhDnlCRd... to yr5wa34bzOBfEgzDH... (flutter/engine#44672)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from UN2vSCJekPhD to yr5wa34bzOBf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-14 04:57:40 +00:00
engine-flutter-autoroll
d4c5e90e26
Roll Flutter Engine from f47e864f2dcb to 7915c049a1fd (1 revision) (#132466)
f47e864f2d...7915c049a1

2023-08-14 skia-flutter-autoroll@skia.org Roll Skia from 9bb236d03e63 to a8715028bba1 (1 revision) (flutter/engine#44671)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-14 03:33:11 +00:00
Casey Hillers
7ce2d83b84
Revert "Fix PopupMenuItem & CheckedPopupMenuItem has redundant ListTile padding and update default horizontal padding for Material 3" (#132457)
Reverts flutter/flutter#131609

b/295497265 - This broke Google Testing. We'll need the internal patch
before landing as there's a large number of customer codebases impacted.
2023-08-13 14:27:01 -07:00
engine-flutter-autoroll
6b3eefc286
Roll Flutter Engine from 7c9d71a464c4 to f47e864f2dcb (1 revision) (#132459)
7c9d71a464...f47e864f2d

2023-08-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from vHvU_OjTM5PQkRx1Y... to yfMzjtavZwtK0QM4C... (flutter/engine#44669)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from vHvU_OjTM5PQ to yfMzjtavZwtK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-13 17:03:16 +00:00
engine-flutter-autoroll
e6797126a8
Roll Flutter Engine from 6e0804f8aff3 to 7c9d71a464c4 (2 revisions) (#132458)
6e0804f8af...7c9d71a464

2023-08-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from tfgOFdhH6PlJyMv3V... to UN2vSCJekPhDnlCRd... (flutter/engine#44668)
2023-08-13 skia-flutter-autoroll@skia.org Roll Skia from 52eef2a16dfe to 9bb236d03e63 (1 revision) (flutter/engine#44667)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from tfgOFdhH6PlJ to UN2vSCJekPhD

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-13 15:49:17 +00:00
engine-flutter-autoroll
28400daf2d
Roll Flutter Engine from 86a1e6582c71 to 6e0804f8aff3 (1 revision) (#132447)
86a1e6582c...6e0804f8af

2023-08-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1-uqfjivXAYe2ue-4... to tfgOFdhH6PlJyMv3V... (flutter/engine#44665)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 1-uqfjivXAYe to tfgOFdhH6PlJ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-13 03:20:24 +00:00
engine-flutter-autoroll
156c12c452
Roll Flutter Engine from 2107c6f6971f to 86a1e6582c71 (1 revision) (#132446)
2107c6f697...86a1e6582c

2023-08-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from NepG1SFiAP-GMJS7R... to vHvU_OjTM5PQkRx1Y... (flutter/engine#44664)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from NepG1SFiAP-G to vHvU_OjTM5PQ

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-13 01:46:27 +00:00
engine-flutter-autoroll
b8c1f8e2fc
Roll Flutter Engine from f4db669cf4e6 to 2107c6f6971f (1 revision) (#132441)
f4db669cf4...2107c6f697

2023-08-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from UdQpH1Y2NyVf3vt3R... to NepG1SFiAP-GMJS7R... (flutter/engine#44662)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from UdQpH1Y2NyVf to NepG1SFiAP-G

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-12 15:48:37 +00:00
engine-flutter-autoroll
dc8ec01f9d
Roll Flutter Engine from a0d550756800 to f4db669cf4e6 (1 revision) (#132435)
a0d5507568...f4db669cf4

2023-08-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from wSdqhvS1srhptT4ij... to 1-uqfjivXAYe2ue-4... (flutter/engine#44661)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from wSdqhvS1srhp to 1-uqfjivXAYe

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-12 11:13:35 +00:00
engine-flutter-autoroll
7d83e9eebb
Roll Flutter Engine from 8435d7d344a4 to a0d550756800 (1 revision) (#132434)
8435d7d344...a0d5507568

2023-08-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 6118ce565dc2 to 55d7c1b35902 (1 revision) (flutter/engine#44660)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-12 10:15:22 +00:00
engine-flutter-autoroll
0fefd9d6ff
Roll Flutter Engine from f6ad8d574dee to 8435d7d344a4 (2 revisions) (#132431)
f6ad8d574d...8435d7d344

2023-08-12 skia-flutter-autoroll@skia.org Roll Skia from e0f07834d736 to 52eef2a16dfe (1 revision) (flutter/engine#44659)
2023-08-12 skia-flutter-autoroll@skia.org Roll Dart SDK from e23931233ff2 to 6118ce565dc2 (1 revision) (flutter/engine#44658)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-12 09:07:24 +00:00
engine-flutter-autoroll
7cca588194
Roll Flutter Engine from e59ea1641b75 to f6ad8d574dee (4 revisions) (#132427)
e59ea1641b...f6ad8d574d

2023-08-12 skia-flutter-autoroll@skia.org Roll Dart SDK from ade04f1beb2c to e23931233ff2 (1 revision) (flutter/engine#44657)
2023-08-12 ypomortsev@google.com Remove dependencies on fuchsia.sys.* FIDL protocols (flutter/engine#44614)
2023-08-12 skia-flutter-autoroll@skia.org Roll Skia from dc71a424d870 to e0f07834d736 (1 revision) (flutter/engine#44655)
2023-08-11 31859944+LongCatIsLooong@users.noreply.github.com allow `ParagraphBuilder.shouldDisableRoundingHack` to actually be set to false in tests (flutter/engine#44647)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-12 05:36:15 +00:00
engine-flutter-autoroll
5d03cf9c2d
Roll Flutter Engine from 5669544866f3 to e59ea1641b75 (2 revisions) (#132420)
5669544866...e59ea1641b

2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from 0f0ff37af487 to
dc71a424d870 (3 revisions) (flutter/engine#44654)
2023-08-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
7DmdwgtGmIxyejFDl... to UdQpH1Y2NyVf3vt3R... (flutter/engine#44653)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from 7DmdwgtGmIxy to UdQpH1Y2NyVf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 21:42:23 -07:00
LongCatIsLooong
881945ddb8
Read --dart-define in RendererBinding.initInstances() (#132408)
Move `SKPARAGRAPH_REMOVE_ROUNDING_HACK` reading to the framework from `dart:ui` so `flutter run --dart-define="SKPARAGRAPH_REMOVE_ROUNDING_HACK=false"` works
2023-08-12 01:56:22 +00:00
Elliott Brooks
118544972a
Update DWDS to 20.0.1 in flutter_tools (#132350)
- Updates DWDS from `19.0.2` to `20.0.1`
- Makes the required changes for the breaking changes to the `AssetReader` class
2023-08-11 23:09:07 +00:00
engine-flutter-autoroll
36c40e4972
Roll Flutter Engine from 832e7803b758 to 5669544866f3 (3 revisions) (#132413)
832e7803b7...5669544866

2023-08-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from v33NyNdr6Y1sKZDze... to wSdqhvS1srhptT4ij... (flutter/engine#44648)
2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from 7dd695d828cf to 0f0ff37af487 (6 revisions) (flutter/engine#44649)
2023-08-11 john@johnmccutchan.com Rename impeller::TextureIntent to impeller::TextureCoordinateSystem (flutter/engine#44628)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from v33NyNdr6Y1s to wSdqhvS1srhp

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 22:48:13 +00:00
engine-flutter-autoroll
83f56ee77f
Roll Flutter Engine from 622ded929968 to 832e7803b758 (7 revisions) (#132407)
622ded9299...832e7803b7

2023-08-11 stuartmorgan@google.com Allow macOS plugins to register as app delegates (flutter/engine#44587)
2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from 68ea92de8f29 to 7dd695d828cf (1 revision) (flutter/engine#44643)
2023-08-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 83f96a990792 to ade04f1beb2c (1 revision) (flutter/engine#44642)
2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from fa30af9c2b80 to 68ea92de8f29 (2 revisions) (flutter/engine#44641)
2023-08-11 30870216+gaaclarke@users.noreply.github.com [Impeller] Added benchmark for advanced blend. (flutter/engine#44450)
2023-08-11 737941+loic-sharma@users.noreply.github.com [Embedder] Refactor how semantic updates are mapped (flutter/engine#44553)
2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from cfb9844091fa to fa30af9c2b80 (1 revision) (flutter/engine#44639)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 21:53:54 +00:00
Renzo Olivares
457d00449d
Add double click and double click + drag gestures to SelectionArea (#124817)
Adds double click to select a word.
Adds double click + drag to select word by word.

https://user-images.githubusercontent.com/948037/234363577-941c36bc-ac42-4b7f-84aa-26b106c9ff05.mov

Partially fixes #104552
2023-08-11 21:08:39 +00:00
engine-flutter-autoroll
b3096225e0
Roll Flutter Engine from 77dfeea40e10 to 622ded929968 (2 revisions) (#132397)
77dfeea40e...622ded9299

2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from 416789a5e761 to
cfb9844091fa (1 revision) (flutter/engine#44638)
2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from 723df2275d7b to
416789a5e761 (1 revision) (flutter/engine#44637)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 13:57:39 -07:00
Nate Bosch
d23fb23df8
Send test message channel from the test frame (#131881)
Towards https://github.com/dart-lang/test/issues/2065

The flutter test runner uses the copy of `host.dart.js` from the copy of
`package:test` that surfaces in the pub solve for `flutter_tool`. This
copy has been updated to allow either the old pattern of communication,
or this new pattern. The new pattern removes an extra hop and use of the
frame `window.onMessage` messages.
2023-08-11 19:46:53 +00:00
Victoria Ashworth
fff08248b3
Disable Xcode Debug tests (#132398)
Temporarily removes Xcode debug tests. 

Xcode tests are currently failing in CI for some infra-related issues. I have a fix for it (https://github.com/flutter/flutter/pull/132318) that I confirmed worked in presubmit, but I think the logic is better suited to live in recipes. However, it's going to be a bit of a learning curve to update recipes and might take me a couple days so disabling them in the meantime.

Tracking issue to readd when ready: https://github.com/flutter/flutter/issues/132309
2023-08-11 18:24:23 +00:00
engine-flutter-autoroll
2605e03b55
Roll Packages from 881c1f552d0f to 9b15c2e6ab30 (4 revisions) (#132391)
881c1f552d...9b15c2e6ab

2023-08-10 tarrinneal@gmail.com [dynamic_layouts] relax layout test to fix tree (flutter/packages#4677)
2023-08-10 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.2 to 2.21.3 (flutter/packages#4664)
2023-08-09 jhy03261997@gmail.com go_router should allow setting requestFocus (flutter/packages#4636)
2023-08-09 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Fixes widget rebuild bug caused by key type (flutter/packages#4667)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 16:38:48 +00:00
engine-flutter-autoroll
9b6945b465
Roll Flutter Engine from 93e8901490e7 to 77dfeea40e10 (1 revision) (#132389)
93e8901490...77dfeea40e

2023-08-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 13317278a6fa to 83f96a990792 (1 revision) (flutter/engine#44633)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 14:24:25 +00:00
engine-flutter-autoroll
b062b81b5b
Roll Flutter Engine from 4e532b957225 to 93e8901490e7 (1 revision) (#132381)
4e532b9572...93e8901490

2023-08-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from hdjihTvRxbNprHI9x... to 7DmdwgtGmIxyejFDl... (flutter/engine#44630)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from hdjihTvRxbNp to 7DmdwgtGmIxy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 10:31:40 +00:00
engine-flutter-autoroll
496144de94
Roll Flutter Engine from 25afdb9b696d to 4e532b957225 (4 revisions) (#132376)
25afdb9b69...4e532b9572

2023-08-11 john@johnmccutchan.com Add support for HardwareBuffer backed Android Platform Views under Impeller/GLES (flutter/engine#44617)
2023-08-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from konJQZKk2qXc276iA... to v33NyNdr6Y1sKZDze... (flutter/engine#44627)
2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from 41d099099095 to 723df2275d7b (1 revision) (flutter/engine#44626)
2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from f4080803ee69 to 41d099099095 (2 revisions) (flutter/engine#44624)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from konJQZKk2qXc to v33NyNdr6Y1s

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 09:33:20 +00:00
engine-flutter-autoroll
a491089acc
Roll Flutter Engine from da23fb0d9a1d to 25afdb9b696d (1 revision) (#132370)
da23fb0d9a...25afdb9b69

2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from 88d5e1daa3ba to f4080803ee69 (1 revision) (flutter/engine#44622)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 06:37:32 +00:00
engine-flutter-autoroll
9d3268b891
Roll Flutter Engine from acd1bc5536ef to da23fb0d9a1d (2 revisions) (#132367)
acd1bc5536...da23fb0d9a

2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from b669a6cd29f7 to 88d5e1daa3ba (1 revision) (flutter/engine#44620)
2023-08-11 skia-flutter-autoroll@skia.org Roll Dart SDK from a2eac00da6b8 to 13317278a6fa (2 revisions) (flutter/engine#44618)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 04:55:49 +00:00
engine-flutter-autoroll
dd4c8d9f09
Roll Flutter Engine from 578a8e8aabf6 to acd1bc5536ef (1 revision) (#132365)
578a8e8aab...acd1bc5536

2023-08-11 skia-flutter-autoroll@skia.org Roll Skia from b001e0a5e46f to b669a6cd29f7 (1 revision) (flutter/engine#44615)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 03:33:30 +00:00
engine-flutter-autoroll
653187668a
Roll Flutter Engine from 18a71c031f5f to 578a8e8aabf6 (1 revision) (#132364)
18a71c031f...578a8e8aab

2023-08-11 matanlurey@users.noreply.github.com Update `examples/**` to provide `--local-engine-host`. (flutter/engine#44610)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-11 02:12:34 +00:00
Matan Lurey
a7997f606e
Update dev/devicelab/** to provide --local-engine-host. (#132342)
Partial work towards https://github.com/flutter/flutter/issues/132245.

I have to admit I don't totally understand what I've updated, or whether
there are more integration points needed.
2023-08-10 17:25:30 -07:00
engine-flutter-autoroll
978461c54e
Roll Flutter Engine from b019ac62f21f to 18a71c031f5f (2 revisions) (#132347)
b019ac62f2...18a71c031f

2023-08-10 chris@bracken.jp [shell] Add references to VsyncWaiter docs (flutter/engine#44607)
2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from b6492f5ce8c3 to b001e0a5e46f (1 revision) (flutter/engine#44606)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 23:50:09 +00:00
engine-flutter-autoroll
67ded4b080
Roll Flutter Engine from 16b01b98af20 to b019ac62f21f (1 revision) (#132341)
16b01b98af...b019ac62f2

2023-08-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SoKcmsZ5H8uHJXV1S... to hdjihTvRxbNprHI9x... (flutter/engine#44600)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from SoKcmsZ5H8uH to hdjihTvRxbNp

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 22:51:23 +00:00
Matan Lurey
b4d5c8f425
Update flutter_tools/bin/*.(dart|sh) to provide, if set, --local-engine-host. (#132336)
Partial work towards https://github.com/flutter/flutter/issues/132245.

Other than updating error messages, and passing `$LOCAL_ENGINE_HOST`
downwards, this PR should not change the behavior of any existing
workflows or code (i.e. it's purely additive).
2023-08-10 15:25:57 -07:00
chunhtai
7dff527be5
Update application id and bundle id of a11y assessment app (#132334)
The skeleton id needed to be updated to be sent to app store or play store
2023-08-10 22:15:26 +00:00
engine-flutter-autoroll
2bb91a2692
Roll Flutter Engine from a9be77e6f475 to 16b01b98af20 (6 revisions) (#132332)
a9be77e6f4...16b01b98af

2023-08-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 46da53e7abe2 to a2eac00da6b8 (1 revision) (flutter/engine#44601)
2023-08-10 huxiaohu2007@gmail.com Fix unexpected pointer change issue and Add test case (flutter/engine#43949)
2023-08-10 47866232+chunhtai@users.noreply.github.com Reland "Android a11y bridge sets importantness" (flutter/engine#44589)
2023-08-10 john@johnmccutchan.com Support for Android Platform Views under Impeller/Vulkan (flutter/engine#44571)
2023-08-10 109111084+yaakovschectman@users.noreply.github.com Reintroduce Windows lifecycle with guard for posthumous `OnWindowStateEvent` (flutter/engine#44344)
2023-08-10 skia-flutter-autoroll@skia.org Roll Skia from 92e6f52b0fa8 to b6492f5ce8c3 (1 revision) (flutter/engine#44597)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-10 21:58:07 +00:00
Ian Hickson
a2e2574941
Remove the fast reassemble / single widget reload feature (#132255)
Fixes https://github.com/flutter/flutter/issues/132157
2023-08-10 21:48:06 +00:00
Michael Goderbauer
6cf5dbe371
Analyze code snippets in integration_test docs (#132314) 2023-08-10 21:34:49 +00:00
pdblasi-google
5df1c996ad
Adds SemanticsNode Finders for searching the semantics tree (#127137)
* Pulled `FinderBase` out of `Finder`
  * `FinderBase` can be used for any object, not just elements
  * Terminology was updated to be more "find" related
* Re-implemented `Finder` using `FinderBase<Element>`
  * Backwards compatibility maintained with `_LegacyFinderMixin`
* Introduced base classes for SemanticsNode finders
* Introduced basic SemanticsNode finders through `find.semantics`
* Updated some relevant matchers to make use of the more generic `FinderBase`

Closes #123634
Closes #115874
2023-08-10 21:31:06 +00:00
Renzo Olivares
73e0dbf5f4
TextField should correctly resolve provided style for material states (#132330)
This change makes sure the style provided through the `TextField`s `style` parameter is resolved for material states before merging it with defaults.

Fixes #132212
2023-08-10 21:25:05 +00:00
Ian Hickson
1e35d3a6b7
setState documentation (#132090)
Fixes https://github.com/flutter/flutter/issues/12296
2023-08-10 21:14:06 +00:00