Nate Biggs
1d766ed8d9
Add experimental hot reload flag support to flutter tools ( #162889 )
...
Rather than ask users to pass the complicated and long string
`--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc`
we want a simpler flag to enable the new DDC module system/hot reload.
Technically this flag enables the new module system, not necessarily hot
reload directly. But we only expect people to use the flag to enable hot
reload so I've chosen the name based on that.
---------
Co-authored-by: Nate Biggs <natebiggs@google.com>
2025-02-10 17:23:47 +00:00
Jonah Williams
33a4c95de0
[flutter_tools] remove SkSL bundling and dump skp on compilation. ( #162849 )
...
SkSL precompilation was only ever beneficial for iOS. For other
platforms, we recommended against it as Skia generated shaders per
target architecture which could be invalid on other devices. It is no
longer possible to use Skia on iOS.
Delete all Skia shader bundling logic.
Fixes https://github.com/flutter/flutter/issues/80091
2025-02-10 16:54:02 +00:00
Harri Kirik
c89d563944
Add additional information to DeviceLab readme for running DeviceLab tests locally ( #160243 )
...
Fixes https://github.com/flutter/flutter/issues/160242
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
2025-02-10 16:39:49 +00:00
engine-flutter-autoroll
e7cb7a30bb
Roll Skia from 22f96cc60dec to 180ed4fc263d (2 revisions) ( #162974 )
...
https://skia.googlesource.com/skia.git/+log/22f96cc60dec..180ed4fc263d
2025-02-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from fe735af98e27 to 21597fbbfeb0 (12 revisions)
2025-02-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 19cc3648535f to a1770b70c6be (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,jamesgk@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-10 09:49:12 +00:00
Robert Ancell
99690cb8c7
Drop link to engine.version which is no longer checked in. ( #162497 )
...
The engine SHA is the same as the Flutter SHA since they were merged in
the monorepo.
2025-02-10 04:43:36 +00:00
engine-flutter-autoroll
5156de731b
Roll Skia from a8f4bcc62532 to 22f96cc60dec (1 revision) ( #162946 )
...
https://skia.googlesource.com/skia.git/+log/a8f4bcc62532..22f96cc60dec
2025-02-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from dbe0a14ab512 to b4c8dd090b72 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,kjlubick@google.com,nicolettep@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-09 05:46:39 +00:00
engine-flutter-autoroll
5e646e2614
Roll Skia from 8e83e49cba3a to a8f4bcc62532 (3 revisions) ( #162943 )
...
https://skia.googlesource.com/skia.git/+log/8e83e49cba3a..a8f4bcc62532
2025-02-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 2acbf990918f to 19cc3648535f (7 revisions)
2025-02-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
ANGLE from e9cda7f685da to ffb7575c7d58 (14 revisions)
2025-02-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from d7a3a302691b to dbe0a14ab512 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,kjlubick@google.com,nicolettep@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-08 21:03:12 +00:00
engine-flutter-autoroll
829fe68e9d
Roll Skia from d25aea76dbc7 to 8e83e49cba3a (27 revisions) ( #162911 )
...
https://skia.googlesource.com/skia.git/+log/d25aea76dbc7..8e83e49cba3a
2025-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c32804ca5a39 to d7a3a302691b (3 revisions)
2025-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 483be92cf076 to e9cda7f685da (10 revisions)
2025-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from ecff3b887f5d to fe735af98e27 (6 revisions)
2025-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 863d392cd025 to 2acbf990918f (32 revisions)
2025-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from f1d4fcb60688 to c32804ca5a39 (14 revisions)
2025-02-06 kjlubick@google.com Minor cleanups in SkEdgeBuilder
2025-02-06 kjlubick@google.com SkBlitter cleanups
2025-02-06 kjlubick@google.com Small MaskFilter cleanups
2025-02-06 nicolettep@google.com Revert "fix image serialization for
MSKPs on Android using derived generators"
2025-02-06 bungeman@google.com Fix FontMgrFontConfig_Fontations_AllBold
test
2025-02-06 kjlubick@google.com Remove redundant pis from src/
2025-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 46d51c9afa5d to f1d4fcb60688 (2 revisions)
2025-02-06 lokokung@google.com [dawn][headers] Use renamed
wgpu::ImageCopyTexture structure.
2025-02-06 danieldilan@google.com [png] Allow fInterlaceBuffer to fail
on malloc instead of abort
2025-02-06 bungeman@google.com Correct "proxy" terminology, remove
setProxy
2025-02-06 robertphillips@google.com [graphite] Add Vulkan serialization
for Android-style Precompile keys
2025-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from aa94da0253a2 to 483be92cf076 (12 revisions)
2025-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from aac2fe5e6d52 to ecff3b887f5d (10 revisions)
2025-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 28a2e8a45f16 to 5017ce3c800e (1 revision)
2025-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 83cddb9b590f to 863d392cd025 (24 revisions)
2025-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 4d67b5012a2f to 46d51c9afa5d (9 revisions)
2025-02-05 jvanverth@google.com [graphite] Address some clip atlas bugs.
2025-02-05 robertphillips@google.com [graphite] Precompile cleanup
2025-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from c83c11cec8f5 to 8b3338080c3c
2025-02-05 jmbetancourt@google.com fix image serialization for MSKPs on
Android using derived generators
2025-02-05 nscobie@google.com Correct CtsEnforcement::kApiLevel_V to
kApiLevel_202404
2025-02-05 lokokung@google.com [dawn][headers] Use
InstanceDescriptor.capabilities.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,kjlubick@google.com,nicolettep@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-08 01:05:01 +00:00
Jonah Williams
53bcdf2cda
[Android] Make PVC1 and PVC2 share a platform view registry. ( #162857 )
...
This avoids the insanity of having to register everything twice. Since
the object is shared a registration on pvc1 will automatically apply to
pvc2.
2025-02-08 01:05:00 +00:00
Matan Lurey
6cca066620
Revert the preview-device feature, tests, and code that only existed for it. ( #162835 )
...
Closes https://github.com/flutter/flutter/issues/162693 .
Fortunately due to the power of `git`, it will live forever 🫡
2025-02-08 01:03:25 +00:00
Jonah Williams
494c47cb4f
Lower minimum java file count to 1. ( #162915 )
...
We removed enough java files that we're failing a "minimum number of
java check".
2025-02-08 00:12:48 +00:00
Jonah Williams
045fb9989c
Make sure to opt hcpp tests into using hcpp ( #162906 )
...
🤦
2025-02-07 23:17:06 +00:00
Jenn Magder
7c894c091f
Add team-ios label to relevant PRs ( #162491 )
...
Using `git ls-files pattern`:
<details>
<summary>engine/src/flutter/shell/platform/darwin/common/**/*</summary>
```
engine/src/flutter/shell/platform/darwin/common/BUILD.gn
engine/src/flutter/shell/platform/darwin/common/availability_version_check.cc
engine/src/flutter/shell/platform/darwin/common/availability_version_check.h
engine/src/flutter/shell/platform/darwin/common/availability_version_check_unittests.cc
engine/src/flutter/shell/platform/darwin/common/buffer_conversions.h
engine/src/flutter/shell/platform/darwin/common/buffer_conversions.mm
engine/src/flutter/shell/platform/darwin/common/command_line.h
engine/src/flutter/shell/platform/darwin/common/command_line.mm
engine/src/flutter/shell/platform/darwin/common/framework/Headers/FlutterBinaryMessenger.h
engine/src/flutter/shell/platform/darwin/common/framework/Headers/FlutterChannels.h
engine/src/flutter/shell/platform/darwin/common/framework/Headers/FlutterCodecs.h
engine/src/flutter/shell/platform/darwin/common/framework/Headers/FlutterDartProject.h
engine/src/flutter/shell/platform/darwin/common/framework/Headers/FlutterHourFormat.h
engine/src/flutter/shell/platform/darwin/common/framework/Headers/FlutterMacros.h
engine/src/flutter/shell/platform/darwin/common/framework/Headers/FlutterTexture.h
engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterBinaryMessengerRelay.h
engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterBinaryMessengerRelay.mm
engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterBinaryMessengerRelayTest.mm
engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterChannels.mm
engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterChannelsTest.m
engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterCodecs.mm
engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterHourFormat.mm
engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterNSBundleUtils.h
engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterNSBundleUtils.mm
engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterStandardCodec.mm
engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterStandardCodecHelper.cc
engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterStandardCodecHelper.h
engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterStandardCodec_Internal.h
engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterTestUtils.h
engine/src/flutter/shell/platform/darwin/common/framework/Source/FlutterTestUtils.mm
engine/src/flutter/shell/platform/darwin/common/framework/Source/flutter_codecs_unittest.mm
engine/src/flutter/shell/platform/darwin/common/framework/Source/flutter_standard_codec_unittest.mm
engine/src/flutter/shell/platform/darwin/common/framework_common.gni
```
</details>
<details>
<summary>engine/src/flutter/shell/platform/darwin/ios/framework/**/*</summary>
```
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/Flutter.h
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterAppDelegate.h
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterCallbackCache.h
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterEngine.h
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterEngineGroup.h
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterHeadlessDartRunner.h
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterPlatformViews.h
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterPlugin.h
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterPluginAppLifeCycleDelegate.h
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterViewController.h
engine/src/flutter/shell/platform/darwin/ios/framework/Info.plist
engine/src/flutter/shell/platform/darwin/ios/framework/PrivacyInfo.xcprivacy
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterAppDelegate.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterAppDelegateTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterAppDelegate_Test.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterCallbackCache.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterCallbackCache_Internal.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterChannelKeyResponder.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterChannelKeyResponder.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterChannelKeyResponderTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterDartProject.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterDartProjectTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterDartProject_Internal.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterDartVMServicePublisher.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterDartVMServicePublisher.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEmbedderKeyResponder.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEmbedderKeyResponder.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEmbedderKeyResponderTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngineGroup.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngineGroupTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEnginePlatformViewTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngineTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine_Internal.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine_Test.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterFakeKeyEvents.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterFakeKeyEvents.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterHeadlessDartRunner.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterIndirectScribbleDelegate.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterKeyPrimaryResponder.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterKeySecondaryResponder.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterKeyboardManager.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterKeyboardManager.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterKeyboardManagerTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterMetalLayer.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterMetalLayer.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterMetalLayerTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterOverlayView.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterOverlayView.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformPlugin.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformPlugin.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformPluginTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsController.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsController.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegate.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegateTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegate_internal.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterRestorationPlugin.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterRestorationPlugin.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterRestorationPluginTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterSemanticsScrollView.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterSemanticsScrollView.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPluginTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterTextInputDelegate.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterTextInputPluginTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterTextureRegistryRelay.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterTextureRegistryRelay.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterTextureRegistryRelayTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterTouchInterceptingView_Test.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterUIPressProxy.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterUIPressProxy.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterUmbrellaImport.m
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterUndoManagerDelegate.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterUndoManagerPlugin.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterUndoManagerPlugin.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterUndoManagerPluginTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterView.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterView.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterViewControllerTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterViewController_Internal.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterViewResponder.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterViewTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/IOKit.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/KeyCodeMap.g.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/KeyCodeMap_Internal.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/SemanticsObject+UIFocusSystem.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/SemanticsObject.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/SemanticsObject.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/SemanticsObjectTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/SemanticsObjectTestMocks.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/TextInputSemanticsObject.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/TextInputSemanticsObject.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/UIViewController+FlutterScreenAndSceneIfLoaded.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/UIViewController+FlutterScreenAndSceneIfLoaded.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/UIViewController_FlutterScreenAndSceneIfLoadedTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/VsyncWaiterIosTest.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/accessibility_bridge.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/accessibility_bridge_ios.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/accessibility_bridge_test.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/availability_version_check_test.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/connection_collection.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/connection_collection.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/connection_collection_test.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/overlay_layer_pool.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/overlay_layer_pool.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/platform_message_response_darwin.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/platform_message_response_darwin.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/profiler_metrics_ios.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/profiler_metrics_ios.mm
engine/src/flutter/shell/platform/darwin/ios/framework/Source/vsync_waiter_ios.h
engine/src/flutter/shell/platform/darwin/ios/framework/Source/vsync_waiter_ios.mm
engine/src/flutter/shell/platform/darwin/ios/framework/module.modulemap
```
</details>
<details>
<summary>packages/flutter_tools/**/ios/*</summary>
```
packages/flutter_tools/lib/src/ios/application_package.dart
packages/flutter_tools/lib/src/ios/code_signing.dart
packages/flutter_tools/lib/src/ios/core_devices.dart
packages/flutter_tools/lib/src/ios/devices.dart
packages/flutter_tools/lib/src/ios/ios_deploy.dart
packages/flutter_tools/lib/src/ios/ios_emulators.dart
packages/flutter_tools/lib/src/ios/ios_workflow.dart
packages/flutter_tools/lib/src/ios/iproxy.dart
packages/flutter_tools/lib/src/ios/mac.dart
packages/flutter_tools/lib/src/ios/migrations/host_app_info_plist_migration.dart
packages/flutter_tools/lib/src/ios/migrations/ios_deployment_target_migration.dart
packages/flutter_tools/lib/src/ios/migrations/metal_api_validation_migration.dart
packages/flutter_tools/lib/src/ios/migrations/project_base_configuration_migration.dart
packages/flutter_tools/lib/src/ios/migrations/project_build_location_migration.dart
packages/flutter_tools/lib/src/ios/migrations/remove_bitcode_migration.dart
packages/flutter_tools/lib/src/ios/migrations/remove_framework_link_and_embedding_migration.dart
packages/flutter_tools/lib/src/ios/migrations/uiapplicationmain_deprecation_migration.dart
packages/flutter_tools/lib/src/ios/migrations/xcode_build_system_migration.dart
packages/flutter_tools/lib/src/ios/plist_parser.dart
packages/flutter_tools/lib/src/ios/simulators.dart
packages/flutter_tools/lib/src/ios/xcode_build_settings.dart
packages/flutter_tools/lib/src/ios/xcode_debug.dart
packages/flutter_tools/lib/src/ios/xcodeproj.dart
packages/flutter_tools/lib/src/ios/xcresult.dart
packages/flutter_tools/lib/src/isolated/native_assets/ios/native_assets.dart
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Config.tmpl/Debug.xcconfig
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Config.tmpl/Flutter.xcconfig
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Config.tmpl/Release.xcconfig
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/AppDelegate.h
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/AppDelegate.m
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/AppIcon.appiconset/Contents.json
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/AppIcon.appiconset/Icon-App-1024x1024@1x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/AppIcon.appiconset/Icon-App-20x20@1x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/AppIcon.appiconset/Icon-App-20x20@2x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/AppIcon.appiconset/Icon-App-20x20@3x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/AppIcon.appiconset/Icon-App-29x29@1x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/AppIcon.appiconset/Icon-App-29x29@2x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/AppIcon.appiconset/Icon-App-29x29@3x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/AppIcon.appiconset/Icon-App-40x40@1x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/AppIcon.appiconset/Icon-App-40x40@2x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/AppIcon.appiconset/Icon-App-40x40@3x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/AppIcon.appiconset/Icon-App-60x60@2x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/AppIcon.appiconset/Icon-App-60x60@3x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/AppIcon.appiconset/Icon-App-76x76@1x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/AppIcon.appiconset/Icon-App-76x76@2x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/AppIcon.appiconset/Icon-App-83.5x83.5@2x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/LaunchImage.imageset/Contents.json
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/LaunchImage.imageset/LaunchImage.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/LaunchImage.imageset/LaunchImage@2x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/LaunchImage.imageset/LaunchImage@3x.png
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Assets.xcassets/LaunchImage.imageset/README.md
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Base.lproj/LaunchScreen.storyboard
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Base.lproj/Main.storyboard
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/Info.plist.tmpl
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.tmpl/main.m
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.xcodeproj.tmpl/project.pbxproj.tmpl
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.xcodeproj.tmpl/project.xcworkspace/contents.xcworkspacedata
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.xcodeproj.tmpl/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.xcodeproj.tmpl/project.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.xcodeproj.tmpl/xcshareddata/xcschemes/Runner.xcscheme
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.xcworkspace.tmpl/contents.xcworkspacedata
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.xcworkspace.tmpl/xcshareddata/IDEWorkspaceChecks.plist
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.xcworkspace.tmpl/xcshareddata/WorkspaceSettings.xcsettings
packages/flutter_tools/templates/module/ios/host_app_ephemeral_cocoapods/Config.tmpl/Debug.xcconfig
packages/flutter_tools/templates/module/ios/host_app_ephemeral_cocoapods/Config.tmpl/Release.xcconfig
packages/flutter_tools/templates/module/ios/host_app_ephemeral_cocoapods/Podfile.copy.tmpl
packages/flutter_tools/templates/module/ios/host_app_ephemeral_cocoapods/Runner.tmpl/AppDelegate.m
packages/flutter_tools/templates/module/ios/library/Flutter.tmpl/AppFrameworkInfo.plist
packages/flutter_tools/templates/module/ios/library/Flutter.tmpl/README.md
packages/flutter_tools/templates/module/ios/library/Flutter.tmpl/podhelper.rb.tmpl
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/README.md
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/Runner.xcodeproj.tmpl/project.pbxproj
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/Runner.xcodeproj.tmpl/project.xcworkspace/contents.xcworkspacedata
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/Runner.xcodeproj.tmpl/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/Runner.xcodeproj.tmpl/project.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/Runner.xcodeproj.tmpl/xcshareddata/xcschemes/Runner.xcscheme.tmpl
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/Runner.xcworkspace.tmpl/contents.xcworkspacedata
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/Runner.xcworkspace.tmpl/xcshareddata/IDEWorkspaceChecks.plist
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/Runner.xcworkspace.tmpl/xcshareddata/WorkspaceSettings.xcsettings
packages/flutter_tools/test/general.shard/ios/code_signing_test.dart
packages/flutter_tools/test/general.shard/ios/core_devices_test.dart
packages/flutter_tools/test/general.shard/ios/devices_test.dart
packages/flutter_tools/test/general.shard/ios/ios_deploy_test.dart
packages/flutter_tools/test/general.shard/ios/ios_device_install_test.dart
packages/flutter_tools/test/general.shard/ios/ios_device_logger_test.dart
packages/flutter_tools/test/general.shard/ios/ios_device_port_forwarder_test.dart
packages/flutter_tools/test/general.shard/ios/ios_device_project_test.dart
packages/flutter_tools/test/general.shard/ios/ios_device_start_nonprebuilt_test.dart
packages/flutter_tools/test/general.shard/ios/ios_device_start_prebuilt_test.dart
packages/flutter_tools/test/general.shard/ios/ios_project_migration_test.dart
packages/flutter_tools/test/general.shard/ios/ios_workflow_test.dart
packages/flutter_tools/test/general.shard/ios/mac_test.dart
packages/flutter_tools/test/general.shard/ios/metal_api_validator_test.dart
packages/flutter_tools/test/general.shard/ios/simulators_test.dart
packages/flutter_tools/test/general.shard/ios/xcode_debug_test.dart
packages/flutter_tools/test/general.shard/ios/xcodeproj_test.dart
packages/flutter_tools/test/general.shard/ios/xcresult_test.dart
packages/flutter_tools/test/general.shard/ios/xcresult_test_data.dart
packages/flutter_tools/test/general.shard/isolated/ios/native_assets_test.dart
```
</details>
<details>
<summary>packages/flutter_tools/**/*xcode*</summary>
```
packages/flutter_tools/bin/xcode_backend.dart
packages/flutter_tools/bin/xcode_backend.sh
packages/flutter_tools/bin/xcode_debug.js
packages/flutter_tools/lib/src/ios/migrations/xcode_build_system_migration.dart
packages/flutter_tools/lib/src/ios/xcode_build_settings.dart
packages/flutter_tools/lib/src/ios/xcode_debug.dart
packages/flutter_tools/lib/src/ios/xcodeproj.dart
packages/flutter_tools/lib/src/macos/xcode.dart
packages/flutter_tools/lib/src/macos/xcode_validator.dart
packages/flutter_tools/lib/src/migrations/xcode_project_object_version_migration.dart
packages/flutter_tools/lib/src/migrations/xcode_script_build_phase_migration.dart
packages/flutter_tools/lib/src/migrations/xcode_thin_binary_build_phase_input_paths_migration.dart
packages/flutter_tools/lib/src/xcode_project.dart
packages/flutter_tools/templates/app/ios-objc.tmpl/Runner.xcodeproj/project.pbxproj.tmpl
packages/flutter_tools/templates/app/ios-objc.tmpl/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme.tmpl
packages/flutter_tools/templates/app/ios-swift.tmpl/Runner.xcodeproj/project.pbxproj.tmpl
packages/flutter_tools/templates/app/ios-swift.tmpl/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme.tmpl
packages/flutter_tools/templates/app/ios.tmpl/Runner.xcodeproj/project.xcworkspace/contents.xcworkspacedata
packages/flutter_tools/templates/app/ios.tmpl/Runner.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
packages/flutter_tools/templates/app/ios.tmpl/Runner.xcodeproj/project.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings
packages/flutter_tools/templates/app/macos.tmpl/Runner.xcodeproj/project.pbxproj.tmpl
packages/flutter_tools/templates/app/macos.tmpl/Runner.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
packages/flutter_tools/templates/app/macos.tmpl/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme.tmpl
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.xcodeproj.tmpl/project.pbxproj.tmpl
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.xcodeproj.tmpl/project.xcworkspace/contents.xcworkspacedata
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.xcodeproj.tmpl/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.xcodeproj.tmpl/project.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings
packages/flutter_tools/templates/module/ios/host_app_ephemeral/Runner.xcodeproj.tmpl/xcshareddata/xcschemes/Runner.xcscheme
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/README.md
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/Runner.xcodeproj.tmpl/project.pbxproj
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/Runner.xcodeproj.tmpl/project.xcworkspace/contents.xcworkspacedata
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/Runner.xcodeproj.tmpl/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/Runner.xcodeproj.tmpl/project.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/Runner.xcodeproj.tmpl/xcshareddata/xcschemes/Runner.xcscheme.tmpl
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/Runner.xcworkspace.tmpl/contents.xcworkspacedata
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/Runner.xcworkspace.tmpl/xcshareddata/IDEWorkspaceChecks.plist
packages/flutter_tools/templates/xcode/ios/custom_application_bundle/Runner.xcworkspace.tmpl/xcshareddata/WorkspaceSettings.xcsettings
packages/flutter_tools/test/general.shard/ios/xcode_debug_test.dart
packages/flutter_tools/test/general.shard/ios/xcodeproj_test.dart
packages/flutter_tools/test/general.shard/macos/xcode_test.dart
packages/flutter_tools/test/general.shard/macos/xcode_validator_test.dart
packages/flutter_tools/test/general.shard/xcode_backend_test.dart
packages/flutter_tools/test/general.shard/xcode_project_test.dart
packages/flutter_tools/test/integration.shard/xcode_backend_test.dart
```
</details>
---------
Co-authored-by: Victoria Ashworth <15619084+vashworth@users.noreply.github.com>
2025-02-07 23:13:01 +00:00
Jonah Williams
ec7cdbd126
[Android] Add missing API level check for hcpp ( #162901 )
...
Requires API 34
2025-02-07 21:52:35 +00:00
Matan Lurey
6e631c5a46
Delete un-tested hybrid_android_views, add layering to android_engine_test. ( #162903 )
...
Another large test suite that has never been running.
The underlying thing I _think_ it wanted tested, which was hybrid
composition, is now tested by `android_engine_test`. I also added a red
square on top of each platform view so that, like
`hybrid_android_views`, we can make sure layering is working as
expected.
Any other ideas? Can also be follow-up PRs?
2025-02-07 21:51:54 +00:00
Matan Lurey
2c5c1143c2
Remove android_verified_input, it was never added to CI and does not run locally. ( #162895 )
...
Someone could always resurrect it via `git`-magic (or GitHub), but let's
not maintain (including Gradle lock files, Dart analysis, etc) unused
code that hasn't run in 12+ months.
/cc @johnmccutchan
2025-02-07 20:59:02 +00:00
Jonah Williams
745ac10e83
[Android] fix hcpp gestures. ( #162859 )
...
We only need to conditionally send motion events to the platform_view_2
channel. This can be done with an override in the controller, the
existing surface classes don't need to be touched.
2025-02-07 20:53:34 +00:00
davidhicks980
d48820528c
[raw_menu_anchor.0.dart] Remove misdrawn emojis. ( #162807 )
...
This PR removes the leading emojis displayed on the RawMenuAnchor
example. I knew emojis usually showed up monochrome on web, but code
samples also appear to incorrectly display the emoji source.
Because this change doesn't affect the menu's functionality, I didn't
include additional tests, but I'd be happy to add tests if needed. One
test was modified to account for menu items no longer having a leading
icon.
<img width="1247" alt="image"
src="https://github.com/user-attachments/assets/58a338c8-c882-4ad1-af44-596d91e9f382 "
/>
Fixes https://github.com/flutter/flutter/issues/162806
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Tirth <pateltirth454@gmail.com>
2025-02-07 20:45:35 +00:00
Matan Lurey
2d30cae396
Start removing unsound null safety from the web SDK tools. ( #162850 )
...
On an internal chat, I asked:
> Is there a reason I don't understand why `flutter` should still
support "unsound" null-safety modes?
@jonahwilliams:
> I don't believe its possible to have non-null safe flutter code.
---
There is quite a bit of code and branches, so to keep the PRs
understandable/approachable, this first PR removes the ability to have
the `DevFS` implementations for the web SDK choose between sound and
unsound null safety, and removes the mapping accordingly.
The enums still exist, but can be cleaned up in a follow-up PR (you'd
want to rename to remove "sound" as well, ideally).
2025-02-07 20:40:41 +00:00
Matan Lurey
8ca08577a5
Enable *_module_test_ios tests that are skipped on presubmit. ( #162892 )
...
@vashworth fixed the underlying issue in
https://github.com/flutter/flutter/issues/150642 .
There doesn't seem to be anything specific to iOS/macOS that is
regularly failing:
-
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20module_test_ios
-
https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Mac_arm64%20build_ios_framework_module_test
-
https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20build_aar_module_test
-
https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Mac%20build_ios_framework_module_test
2025-02-07 20:37:58 +00:00
jesswrd
75df59e62f
Fix Status Bar Icon Brightness ( #162297 )
...
On Android devices, the statusBar is now by default transparent starting
android API 35
[here](https://developer.android.com/develop/ui/views/layout/edge-to-edge#:~:text=system%20bars%20transparent )
(due to automatic opt-in to edge to edge mode
[here](https://developer.android.com/develop/ui/views/layout/edge-to-edge#:~:text=Important%3A%20Edge%2Dto%2Dedge%20is%20enforced%20on%20Android%2015%20(API%20level%2035)%20and%20higher%20once%20your%20app%20targets%20SDK%2035.%20If%20your%20app%20is%20not%20already%20edge%2Dto%2Dedge%2C%20portions%20of%20your%20app%20may%20be%20obscured%20and%20you%20must%20handle%20insets.%20Depending%20on%20the%20app%2C%20this%20work%20may%20or%20may%20not%20be%20significant .)),
which is making the statusBar icons difficult to see. We decided to make
the change in Cupertino/Material layer as opposed to the embedder layer
becasue we cannot make assumptions on the defaults when we don't know
what kind of Widgets the Flutter dev will be using.
In MaterialApp, the `statusBarIconBrightness` is made to be dark because
the system's brightness (dark mode or light mode) **does not affect**
the brightness of the default app. This means when I turn on dark mode
on my phone, the app does not use a dark theme—it uses the same light
theme.
In CupertinoApp, the `statusBarIconBrightness` is made to be opposite of
the system's brightness (dark mode or light mode) because the system
**does affect** the brightness of the default app. The system and the
default app have the same brightness. This means when I turn on dark
mode on my phone, the app also uses a dark theme.
Fixes #160305
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-07 20:37:56 +00:00
Victor Sanni
41c3008afb
Support CupertinoSliverNavigationBar.search with condensed large title ( #159120 )
...
https://github.com/user-attachments/assets/70f48a0e-c87e-4399-ad7b-4dfac4376938
Fixes [Suggestion: CupertinoSliverNavigationBar allow forcing condensed
title](https://github.com/flutter/flutter/issues/59525 )
Fixes [Expose search field in
CupertinoSliverNavigationBar.search](https://github.com/flutter/flutter/issues/161556 )
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-07 19:02:24 +00:00
Mouad Debbar
a33904a57a
[web] Move frame_reference.dart to the html/ folder ( #162608 )
...
The `frame_reference.dart` file is only used by the HTML renderer. I'm
moving the file to the `html/` folder so that we don't forget to delete
with the rest of the HTML renderer code.
2025-02-07 18:35:43 +00:00
engine-flutter-autoroll
892f9c13a2
Roll Skia from 4bdf90faf708 to d25aea76dbc7 (38 revisions) ( #162746 )
...
Roll Skia from 4bdf90faf708 to d25aea76dbc7 (38 revisions)
https://skia.googlesource.com/skia.git/+log/4bdf90faf708..d25aea76dbc7
2025-02-05 kjlubick@google.com Cleanups related to Masks and RRects
2025-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 9fa954563726 to 4d67b5012a2f (4 revisions)
2025-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 957bafb51066 to aa94da0253a2 (7 revisions)
2025-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 16948351755e to aac2fe5e6d52 (9 revisions)
2025-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 86cf34f50cbe to 28a2e8a45f16 (1 revision)
2025-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 7132f397c4b2 to 83cddb9b590f (20 revisions)
2025-02-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 6fe9d7e0521b to 9fa954563726 (6 revisions)
2025-02-04 bungeman@google.com [pdf] Do not scale miterLimit
2025-02-04 briansalomon@gmail.com [graphite] list MtlGraphiteTypesPriv.h
in bazel/gn sources
2025-02-04 robertphillips@google.com [graphite] Add
PrecompileContext::precompile option
2025-02-04 hcm@google.com Merge 3 release notes into RELEASE_NOTES.md
2025-02-04 kjlubick@google.com Apply clang-tidy suggestion to
GrProcessorUnitTest.cpp
2025-02-04 lokokung@google.com [dawn][header] Use wgpu::StringView
instead of const char*.
2025-02-04 hcm@google.com Update Skia milestone to 135
2025-02-04 lokokung@google.com [dawn][headers] Use PassTimestampWrites.
2025-02-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 2e4b45a53a0e to 6fe9d7e0521b (10 revisions)
2025-02-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 44b5f0a59f2a to 957bafb51066 (6 revisions)
2025-02-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from f69f215a2ce4 to 16948351755e (9 revisions)
2025-02-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from acd89d9f169a to 7132f397c4b2 (15 revisions)
2025-02-03 egdaniel@google.com [Graphite] Update Vulkan buffer barriers.
2025-02-03 kjlubick@google.com Update skottie-base to include
skottie-dev files
2025-02-03 renatopereyra@google.com [Ganesh] Update Intel GPU mappings
in Vulkan backend
2025-02-03 jvanverth@google.com [graphite] Set up atlas-based clipping.
2025-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from de6d9c09f769 to 2e4b45a53a0e (30 revisions)
2025-02-03 robertphillips@google.com [graphite] Fix ContextOptions.h
#includes
2025-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 938de304bdcb to de6d9c09f769 (14 revisions)
2025-02-03 fmalita@google.com [skottie] Drop motion blur support
2025-02-03 robertphillips@google.com Make the Ganesh/Graphite DM
precompilation options more distinct
2025-02-03 robertphillips@google.com [graphite] Add API to return
Android-specific keys back to the user
2025-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from c469d593acab to acd89d9f169a (1 revision)
2025-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 53594a79cc60 to f69f215a2ce4 (13 revisions)
2025-02-01 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
ANGLE from 439dfe5e2c51 to 44b5f0a59f2a (14 revisions)
2025-02-01 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 6bc6697d10a4 to c469d593acab (10 revisions)
2025-01-31 egdaniel@google.com [Graphite] Use Dawn
disable_lazy_clear_for_mapped_at_creation_buffer toggle
2025-01-31 fmalita@google.com [skottie] Visible track matte adjustments
2025-01-31 robertphillips@google.com Actually draw the new gradient
interpolation types
2025-01-31 bwils@google.com Skottie no longer checks version is set
2025-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from e330d9595d80 to 439dfe5e2c51 (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com ,kjlubick@google.com,nicolettep@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
...
2025-02-07 17:15:20 +00:00
engine-flutter-autoroll
0385ddc7eb
Roll Packages from e6ce02c2a859 to 625023aa0376 (4 revisions) ( #162878 )
...
e6ce02c2a8...625023aa03mchudy@users.noreply.github.com [camera] Remove OCMock from
AvailableCamerasTests, CameraOrientationTests and
ThreadSafeEventChannelTests (flutter/packages#8363 )
2025-02-06 tarrinneal@gmail.com [pigeon] Adds annotation options to omit
shared classes used in Event Channels (flutter/packages#8566 )
2025-02-06 stuartmorgan@google.com [quick_actions] Update Android Pigeon
version (flutter/packages#8580 )
2025-02-05 ditman@gmail.com [ci] Move Wasm test shards out of bringup.
(flutter/packages#8572 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-07 15:54:23 +00:00
gaaclarke
68e785e868
Fixed translated text's subpixel alignment. ( #162824 )
...
fixes https://github.com/flutter/flutter/issues/162776
fixes https://github.com/flutter/flutter/issues/149652
Previously we weren't calculating the subpixel offset correctly. We
weren't using the transform of the object being drawn to get global
coordinates, now we are.
## Video of https://github.com/flutter/flutter/issues/149652 after PR
https://github.com/user-attachments/assets/3e9063d5-f70c-46d0-a7a4-892819b247b8
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-07 15:50:50 +00:00
Huy
44203b67f5
Fix DropdownMenu example RenderFlex overflowed error ( #162558 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Fix https://github.com/flutter/flutter/issues/162506
| before | after |
| --------------- | --------------- |
<video
src="https://github.com/user-attachments/assets/91c82b7c-3449-4b65-9b7a-547030dd6536 "/>
| <img
src="https://github.com/user-attachments/assets/a32ecb23-3c87-4b95-8687-d7b3d8190863 "/>
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Signed-off-by: huycozy <huy@nevercode.io>
2025-02-07 10:04:14 +00:00
yim
e6a65afca4
Directional focus edge traversal behavior. ( #161285 )
...
Fixes : #160843
This PR adds edge behavior feature for traversing focus using arrow
keys. This allows cycling through the focus within the `FocusScope` in a
closed loop using the arrow keys. Which may be needed by TV application
developers.
Additionally, as in case #160843 , `TraversalEdgeBehavior.parentScope`
can be used to allow nested Navigators to traverse focus beyond the
Navigator using arrow keys.
```dart
MaterialApp(
home: Column(
children: <Widget>[
makeFocus(0),
Navigator(
onGenerateRoute: (RouteSettings settings) {
return MaterialPageRoute<void>(
traversalDirectionedEdgeBehavior: TraversalEdgeBehavior.parentScope,
builder: (BuildContext context) {
return Column(
children: <Widget>[
makeFocus(1),
makeFocus(2),
],
);
},
);
},
),
makeFocus(3),
],
),
);
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-07 05:26:19 +00:00
Jonah Williams
f0396970e9
[Android] HC++ wire up dart platform channel code and integration test. ( #162751 )
...
Use the PlatformViewController2 to register a platform view, allow the
dart side platform view logic to opt into this new platform view. Wires
up an integration test with android_engine_test.
2025-02-07 03:09:24 +00:00
auto-submit[bot]
7569fbfce5
Reverts "Remove --verbose from devicelab task executions. ( #162644 )" ( #162853 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#162644
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: At least one post-submit test depends on the
output of `--verbose`.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: matanlurey
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {cbracken, reidbaker, jonahwilliams}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
These can be useful, but were probably left in past the point where they
are always useful:
- https://github.com/flutter/flutter/pull/58018
- https://github.com/flutter/flutter/pull/56342
- https://github.com/flutter/flutter/pull/74080
... compared to the cost of reading these logs with 1000s of lines of
`stdout: ` output.
Will ask the CI gods if any of this was load-bearing before sending out
for review.
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-02-07 01:27:47 +00:00
Matan Lurey
fdeb7b93aa
Remove --verbose from devicelab task executions. ( #162644 )
...
These can be useful, but were probably left in past the point where they
are always useful:
- https://github.com/flutter/flutter/pull/58018
- https://github.com/flutter/flutter/pull/56342
- https://github.com/flutter/flutter/pull/74080
... compared to the cost of reading these logs with 1000s of lines of
`stdout: ` output.
Will ask the CI gods if any of this was load-bearing before sending out
for review.
2025-02-07 00:25:20 +00:00
Harry Terkelsen
db7e82bdfb
chore(canvaskit): remove SurfaceFrame from Surface ( #162825 )
...
SurfaceFrame is no longer used. This is a cleanup in preparation for a
larger refactor of `Surface` to improve performance.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-06 23:59:30 +00:00
Paulik8
a6344bf2b3
Changed docs for hintOverrides field of SemanticsProperties ( #162632 )
...
Fix https://github.com/flutter/flutter/issues/129356
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-06 23:24:57 +00:00
Michael Goderbauer
1e035cc693
Adjustments to FocusHighlightMode handling ( #162417 )
...
Fixes https://github.com/flutter/flutter/issues/158527
Adjustments:
* Using the mouse/trackpad does no longer change `FocusHighlightMode`s
(this matches observed behavior on Android)
* Changing focus via a11y on the web forces `FocusHighlightModes.touch`,
which hides the visual input focus indication from non-Textfields. The
reason here is in order to give something input focus on the web it also
has to have a11y focus, which is indicated separately.
2025-02-06 21:26:08 +00:00
Taha Tesser
58b7ee137e
Fix Slider renders track when track colors are transparent ( #161814 )
...
### Description
Fixes [`Slider` with transparent track colors and custom `trackHeight`
cannot reach the extreme ends
](https://github.com/flutter/flutter/issues/161210 )
### Code Sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatefulWidget {
const MyApp({super.key});
@override
State<MyApp> createState() => _MyAppState();
}
class _MyAppState extends State<MyApp> {
double _value = 0;
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: Center(
child: Column(
spacing: 20,
mainAxisSize: MainAxisSize.min,
children: [
SizedBox(
height: 4,
width: 400,
child: DecoratedBox(
decoration: const BoxDecoration(
gradient:
LinearGradient(colors: [Colors.yellow, Colors.green]),
),
child: SliderTheme(
data: const SliderThemeData(
trackHeight: 200,
activeTrackColor: Colors.transparent,
inactiveTrackColor: Colors.transparent,
padding: EdgeInsets.zero,
),
child: Slider(
value: _value,
max: 100,
onChanged: (double value) {
setState(() {
_value = value;
});
},
),
),
),
),
Text('Slider value: ${_value.roundToDouble()}')
],
),
),
),
);
}
}
```
</details>
### Before
<img width="728" alt="Screenshot 2025-01-17 at 16 32 00"
src="https://github.com/user-attachments/assets/378a31b2-b897-4bf8-9067-66539239af09 "
/>
### After
<img width="728" alt="Screenshot 2025-01-17 at 16 31 33"
src="https://github.com/user-attachments/assets/aef12d5e-a0cc-4947-8f72-2024edf29f14 "
/>
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-06 20:42:02 +00:00
Harry Terkelsen
1b095a030d
[canvaskit] Resize to exactly the requested dimensions ( #162708 )
...
Adds a `SurfaceResizeStrategy` to `Surface`. The default option,
`onlyGrow`, implements the current behavior of only re-allocating the
Surface when the requested size is larger than the currently allocated
Surface. This PR adds the option of `SurfaceResizeStrategy.exact` which
always reallocates the Surface and resizes the underlying
OffscreenCanvas. This options performs better in practice since having
the OffScreenCanvas larger than the actual rendered size causes calls to
`createImageBitmap` to be slower than if the OffscreenCanvas is exactly
the size of the bitmap being created.
Fixes https://github.com/flutter/flutter/issues/162700
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-06 20:11:37 +00:00
AthulJoseph
f6b0598945
Added support to set viewport ( #162602 )
...
Resolves #157201 .
2025-02-06 19:07:01 +00:00
Michael Goderbauer
c783ce2344
Remove outdated ignores ( #162773 )
...
Powered by the new and amazing `unnecessary_ignore` lint.
We're not enabling this lint by default because being able to
temporarily use ignores that don't ignore anything is a powerful tool to
enable migrations. We should turn this lint on locally periodically,
though, and clean up all outdated ignores.
2025-02-06 18:40:25 +00:00
dev-lup
5944d992ac
Fix: Ensure CupertinoAlertDialog divider spans full width and resolve ( #161490 )
...
Fix: Ensure CupertinoAlertDialog divider spans full width and resolves
divider color (#158522 )
The `_Divider` in CupertinoAlertDialog did not span the full width and
the `dividerColor` was not resolved correctly. This fix uses a
`SizedBox` with `double.infinity` as the width for the divider and
ensures that the `dividerColor` is properly applied.
Fixes #158522
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Harshit Sharma <krishnatrea@gmail.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
2025-02-06 18:14:19 +00:00
Matan Lurey
0e59f0f64c
flutter build aar regenerates tooling between each build-mode step (#162705 )
...
Closes https://github.com/flutter/flutter/issues/162703 .
I still need to do a similar change for `ios|macos`-`framework` in
https://github.com/flutter/flutter/issues/162704 .
I added two unit tests, as well as opted in an integration test to the
flag (it will become the default in
https://github.com/flutter/flutter/pull/160289 ).
/cc @reidbaker @gmackall.
2025-02-06 17:03:02 +00:00
Gaspard Ruan
f219bbac55
Update code comments for navigation_bar.dart ( #162596 )
...
Fixes https://github.com/flutter/flutter/issues/162592
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
### Comments error:
```
class NavigationDestination extends StatelessWidget {
...
/// The text label that appears below the icon of this
/// [NavigationDestination].
///
/// The accompanying [Text] widget will use
/// [NavigationBarThemeData.labelTextStyle]. If this are null, the default
/// text style would use [TextTheme.labelSmall] with [ColorScheme.onSurface].
final String label;
...
}
```
`If this are null, the default text style would use
[TextTheme.labelSmall]` is wrong. Actually, This is right in material2,
but wrong in material3. I have dived into `_NavigationBarDefaultsM3`, I
found this:
```
class _NavigationBarDefaultsM3 extends NavigationBarThemeData {
...
@override
MaterialStateProperty<TextStyle?>? get labelTextStyle {
return MaterialStateProperty.resolveWith((Set<MaterialState> states) {
final TextStyle style = _textTheme.labelMedium!;
return style.apply(
color: states.contains(MaterialState.disabled)
? _colors.onSurfaceVariant.withOpacity(0.38)
: states.contains(MaterialState.selected)
? _colors.onSurface
: _colors.onSurfaceVariant
);
});
}
...
}
```
**The default text style would use [TextTheme.labelMedium] in
Material3.**
### Changes
Just clarify the doc comments above.[test-exempt]
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
2025-02-06 11:40:19 +00:00
Yegor
d4772e591c
[web] warm-up frame does not block schedule frame ( #162779 )
...
Fix the issue with the first frame not rendering, introduced in
https://github.com/flutter/flutter/pull/162554 .
Nobody filed an issue yet. I found it while testing something else.
2025-02-06 05:01:10 +00:00
Yegor
1f5cb0d665
support running et fetch from anywhere ( #162712 )
...
Support running `et fetch` from any directory.
2025-02-06 04:59:24 +00:00
chunhtai
1d85de0fc8
Introduce caching mechanism during compile semantics tree monorepo and formatted version ( #161195 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
old pr: https://github.com/flutter/flutter/pull/150394
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-06 03:08:23 +00:00
Kostia Sokolovskyi
243413f11b
Add role check in SemanticsNode._isDifferentFromCurrentSemanticAnnotation function. ( #162578 )
...
Fixes https://github.com/flutter/flutter/issues/162577
### Description
- Adds `role` check in
`SemanticsNode._isDifferentFromCurrentSemanticAnnotation` function.
- Adds `SemanticsNode.debugIsDirty` property to check in tests whether
the node is marked as dirty.
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
2025-02-05 21:55:44 +00:00
Paulik8
ce6817b0a1
Added equals and hashCode for TextInputConfiguration and AutofillConfiguration ( #162238 )
...
- Added equals and hashCode for `TextInputConfiguration` and
`AutofillConfiguration` (fixed
https://github.com/flutter/flutter/issues/139033 )
- Fixed copyWith method in `TextInputConfiguration` (fixed
https://github.com/flutter/flutter/issues/162236 )
- Added some tests
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
2025-02-05 21:46:56 +00:00
Kishan Rathore
211d83d772
fix: RangeError when selecting text in SelectionArea ( #162228 )
...
fix: RangeError when selecting text in SelectionArea
fixes #161931
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-02-05 21:11:26 +00:00
Jonah Williams
17cb12d9bd
[Android] wire up Java Transaction to AHB swapchain. ( #162750 )
...
* When the opt in surface control setting is enabled (and the backend is
impeller vulkan) - then use the external view embedder 2.
* ALways create the SurfaceControl.Transaction in
PlatformViewController2 and manage it in Java. This was done for ease of
implementation. Rather than switching between SurfaceControl.Transaction
objects created in the native heap or created in java, we always go
through java. This also means that adding platform views shouldn't
change this flow.
* We may need to separate this after peformance profiling.
One more PR to go to wire up the new message channels and add the
integration_test.
2025-02-05 21:07:34 +00:00
Gianluca Bettega
1fecd2bd79
SearchAnchor viewOnClose ( #160892 )
...
Fixes https://github.com/flutter/flutter/issues/160891
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
2025-02-05 21:02:37 +00:00
Paulik8
e78f135e36
Fix issue #156954 : Wrong dateHelpText in MaterialLocalizationIt ( #161889 )
...
Fix #156954
- Changed current value `dataHelpText` used in `MaterialLocalizationIt`
from "mm/gg/aaaa" to "gg/mm/aaaa"
- Wrote test
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-05 20:59:16 +00:00
Nate Biggs
