Byoungchan Lee
b8fd23c76f
Improve the test for clangd --check to choose files deterministically ( #161072 )
...
It seems that not all files in the Flutter repository are compatible
with clangd. This change improves the clangd invocation in CI to choose
files that are known to work with clangd.
Reason for the change:
In https://github.com/flutter/flutter/pull/161012 , I'm trying to update
GN to the latest version. However, this change made the order of files
in the compile_commands.json. This caused [the clangd check to
fail](https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20clangd/10395/overview )
because `engine/src/flutter/tools/clangd_check/bin/main.dart` currently
chooses the first file in the compile_commands.json, and the newly
chosen file
(`engine/src/flutter/third_party/skia/modules/skparagraph/src/Decorations.cpp`)
is not compatible with clangd. To fix this, I'm making the test choose
the file that is known to work with clangd.
(`gen/flutter/assets/_fl__fl_assets_fixtures.cc`)
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2025-02-03 23:59:42 +00:00
gaaclarke
cebc34c92c
Increased the glyph atlas resolution 2x ( #162555 )
...
issue: https://github.com/flutter/flutter/issues/149652
This makes https://github.com/flutter/flutter/issues/149652 better. It
doesn't completely it better though, there is still a shrinking of
whitespace at larger scales. Without this patch though the test will
fail with many 3 pixel jumps between glyphs.
I think scaling in the thousands is reasonable so this is an adequate
test.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-03 21:29:37 +00:00
Chinmay Garde
d0685bf086
[FML] Make logging available in constexpr contexts. ( #162343 )
...
Asking if the logs should be emitted and killing the process (say on
unreachable statements) wasn't constexpr. However we managed to use
these in constexpr contexts. As I understand, this was because of
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2448r2.html
which is available in C++23. This technique makes the methods constexpr
safe in C++17.
2025-02-03 20:29:06 +00:00
Mouad Debbar
041d5246f7
[web] Remove HTML from the engine's test suites ( #162404 )
...
- Remove html bundles/suites from configs and CI.
- Delete html test files.
- Replace the `isHtml` helper with `false` and refactor accordingly.
2025-02-03 20:01:15 +00:00
Gray Mackall
df114fbe9b
Remove default for stripped option in engine/src/flutter/tools/gn, don't strip by default on android ( #161546 )
...
Remake of https://github.com/flutter/engine/pull/52852 .
Makes it so that `stripped` defaults to false for android in `gn`
arguments, i.e. we don't strip the Android engine builds. AGP does this
by default when the NDK is installed (and we download it automatically
now after https://github.com/flutter/flutter/pull/159756 ).
In testing, the step that AGP does to strip symbols adds ~1-2 seconds to
the build.
Adds a tool verification for release app bundle builds that checks to
make sure we have stripped the debug symbols and placed them in the
[`BUNDLE-METADATA`
directory](https://developer.android.com/guide/app-bundle/app-bundle-format ).
The check is done by invoking `apkanalyzer`, which takes ~`0.5` seconds,
which is why the check is only enabled for release builds.
BEFORE LANDING: I need to follow up on
https://github.com/flutter/engine/pull/50443#issuecomment-1945644730 , to
ensure we start stripping symbols internally as well.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-02-03 17:07:25 +00:00
Jonah Williams
4d08217f8d
[Android] add lint ignores to Flutter JNI. ( #162527 )
...
These API calls are triggering lints in g3, which has stricter lints for
transitively calling higher API level methods.
2025-02-01 22:43:34 +00:00
Brandon DeRosier
039d0db698
[Flutter GPU] Breaking: Use exceptions for resource creation errors. ( #162104 )
...
Resolves https://github.com/flutter/flutter/issues/143891 .
This patch includes breaking changes, but this API is still in preview.
* Breaking: Rename `Texture.GetBaseMipLevelSizeInBytes` to
`Texture.getBaseMipLevelSizeInBytes`.
* Breaking: Make `Texture.overwrite` throw exception instead of
returning false.
* Non-breaking: Make `DeviceBuffer`/`Texture` creation throw exceptions
instead of returning nullables.
We can incrementally add more specific exceptions for resource creation
failure.
2025-02-01 01:46:34 +00:00
Jonah Williams
806772b528
[Impeller] Increase conical gradient precision. ( #162543 )
...
Fixes https://github.com/flutter/flutter/issues/162379
The IPConicalGradient function requires full float 32 precision, though
this depends on the exact gpu behavior. To be safe, increase the general
precision in all of these shaders.
2025-02-01 00:01:23 +00:00
Harry Terkelsen
385878e7c1
[web] Gracefully handle empty ui.Vertices ( #162461 )
...
It is valid to create a `ui.Vertices` object with empty positions. This
fixes Flutter Web so we don't crash when we see an empty `ui.Vertices`
object.
Fixes https://github.com/flutter/flutter/issues/160355
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-31 19:58:35 +00:00
Mouad Debbar
fca7da1eb0
[web] Remove HTML build artifacts ( #162528 )
...
Stop building artifacts for the HTML/AUTO renderers.
2025-01-31 19:40:27 +00:00
Jason Simmons
53f2b136db
Add a special case for the Fuchsia SDK ftl.fidl file in the license script ( #162423 )
...
Recent versions of the Fuchsia SDK added a source file named "ftl.fidl".
The _licenseNamePattern in the script thinks this file may be a license
because some licenses also use filenames containing "FTL".
2025-01-31 18:58:08 +00:00
Jason Simmons
4226d48c52
[Impeller] Remove some unused methods from EntityPassClipStack ( #162478 )
2025-01-31 18:58:08 +00:00
Victoria Ashworth
e7a89c7ef4
Reenable linux_web_engine mac tests on Mac-14 ( #162409 )
...
Mac-14 bots are on macOS 14.7 (previously 14.5), which [presumably has
Safari
18](https://github.com/flutter/flutter/issues/150023#issuecomment-2479664389 )
and may fix the errors we were seeing in
https://github.com/flutter/flutter/issues/150023 .
Let's run them on Mac-14 again and see how they do.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-31 17:38:24 +00:00
engine-flutter-autoroll
06bbbfebb0
Roll Skia from e0941791b86e to c1dc5033e7c9 (1 revision) ( #162504 )
...
https://skia.googlesource.com/skia.git/+log/e0941791b86e..c1dc5033e7c9
2025-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 85d97f3cbf76 to 53594a79cc60 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,fmalita@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-01-31 09:43:07 +00:00
engine-flutter-autoroll
e578cb231f
Roll Skia from a9af2a74c5ab to ec8c632b8c7f (2 revisions) ( #162496 )
...
https://skia.googlesource.com/skia.git/+log/a9af2a74c5ab..ec8c632b8c7f
2025-01-30 michaelludwig@google.com [graphite] Use lock-free linked list
return queue
2025-01-30 egdaniel@google.com [Graphite] Add simple cache for reusing
single Texture DescSets in Vk.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,fmalita@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-01-31 03:53:11 +00:00
gaaclarke
3c5ae1eb87
Fixed the text aspect ratio ( #162415 )
...
fixes https://github.com/flutter/flutter/issues/162348
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-31 02:50:20 +00:00
Matan Lurey
4d8585d936
Fix the build borked in https://github.com/flutter/flutter/pull/162475 . ( #162484 )
...
Fixes https://github.com/flutter/flutter/pull/162475 .
2025-01-30 23:30:45 +00:00
engine-flutter-autoroll
105600d4ff
Roll Skia from e6daf687b558 to a9af2a74c5ab (5 revisions) ( #162474 )
...
https://skia.googlesource.com/skia.git/+log/e6daf687b558..a9af2a74c5ab
2025-01-30 fmalita@google.com [skottie] Handle missing SkSLEffect image
inputs gracefully
2025-01-30 fmalita@google.com [skottie] Clamp path offset values
2025-01-30 robertphillips@google.com [graphite] Add serialization
helpers for the Android-specific Precompile API
2025-01-30 michaelludwig@google.com [graphite] Use transfer color type
in Mtl/DawnCaps
2025-01-30 kjlubick@google.com Apply ClangTidy suggestions to
ClipAtlasManager
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,fmalita@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-01-30 22:12:24 +00:00
John McDole
3acc3bc03f
Bump `Linux mac_clang_tidy" to 120m timeout ( #162475 )
...
Matches `Linux linux_clang_tidy`
2025-01-30 21:44:23 +00:00
gaaclarke
d0d4e9613e
Fixed some floating point inaccuracies in TextContents ( #162351 )
...
issue: https://github.com/flutter/flutter/issues/149652
## before
Animating from 0.444x to 0.445x
## after
Animating from 0.444x to 0.445x
## diff
Diff at 0.444x
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-30 20:42:39 +00:00
Jonah Williams
a4927668cb
[Android] add HC++ platform view class. ( #161829 )
...
Part of the HC++ project for Android. This adds a current unused and
unusable separate manager class for the new platform view strategy.
Subsequent PRs will fill in the engine implementation as well as adding
a mechanism to detect if support is available and provide a framework
opt in.
2025-01-30 20:02:15 +00:00
Jonah Williams
a3fced5da1
[Impeller] Disable Vulkan on Emulators. ( #162454 )
...
Forces known android emulators to use OpenGLES. This is a very
conservative check that could be expanded over time if need be. For
testing emulators can still use the debug flags.
Fixes https://github.com/flutter/flutter/issues/160442
Fixes https://github.com/flutter/flutter/issues/160439
Fixes https://github.com/flutter/flutter/issues/155973
2025-01-30 19:41:04 +00:00
engine-flutter-autoroll
0444dda508
Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions) ( #162447 )
...
Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions)
https://skia.googlesource.com/skia.git/+log/f22419dbed05..e6daf687b558
2025-01-30 michaelludwig@google.com [sksl] Move test from shared/ to
errors/
2025-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from f231d94b280f to e330d9595d80 (11 revisions)
2025-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from fc6bd168cd2d to 85d97f3cbf76 (6 revisions)
2025-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 04c2ec3144a0 to 4dfae713222c (23 revisions)
2025-01-30 robertphillips@google.com Try to de-flake the
TSAN_Graphite_Dawn_Metal job
2025-01-29 egdaniel@google.com [Graphite] Fix Dawn NMOF compressed
texture GM.
2025-01-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from 18c5fe2272c0 to 2f895d13711a
2025-01-29 egdaniel@google.com Disable use of Dawn Validation on Release
tool builds.
2025-01-29 jvanverth@google.com [graphite] Hook in atlas clip via
PaintParams.
2025-01-29 michaelludwig@google.com [graphite] Call
processReturnedResources() on occassion
2025-01-29 aaronhk@chromium.org Add remaining 4 color spaces as
interpolation spaces
2025-01-29 jvanverth@google.com [graphite] Add ClipAtlasManager to
AtlasProvider.
2025-01-29 het@google.com Delete typeface after it has been registered
to prevent memory leak
2025-01-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 2c2860f3ab02 to 938de304bdcb (11 revisions)
2025-01-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 0878d8543f62 to f231d94b280f (9 revisions)
2025-01-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 9e2b0184e3cc to fc6bd168cd2d (5 revisions)
2025-01-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from ba0f4a824014 to 04c2ec3144a0 (15 revisions)
2025-01-29 olv@google.com [ganesh] Force gpu submit when there are too
many render passes
2025-01-28 lokokung@google.com [dawn][headers] Removes default case for
MapAsyncStatus.
2025-01-28 kjlubick@google.com Remove references to decomissioned test
devices
2025-01-28 vigneshv@google.com SkCrabbyAvifCodec: Support repetition
count
2025-01-28 vigneshv@google.com SkCrabbyAvifCodec: Clean up some TODOs
2025-01-28 jamesgk@google.com [graphite] Remove PremulAlphaColorFilter
snippet
2025-01-28 kjlubick@google.com Split SkMaskFilter.cpp into two files
2025-01-28 kjlubick@google.com Try using less stack space for auto
blitters
2025-01-28 michaelludwig@google.com Use Apple's linear transformation
equation for XR color types in SkRasterPipeline
2025-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from ef9be82521e9 to 2c2860f3ab02 (2 revisions)
2025-01-28 jamesgk@google.com [graphite] Avoid int ops in universal
color xform shader
2025-01-28 jvanverth@google.com [graphite] Set up NonMSAAClip struct.
2025-01-28 danieldilan@google.com [SkSL] Add check for unsized array in
checkForOutOfRangeLiteral
2025-01-28 robertphillips@google.com [graphite] Fix race condition in
ThreadedPipelineCompilePurgingTest
2025-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 8c3179402f7f to 0878d8543f62 (10 revisions)
2025-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 417d9315f5b9 to 9e2b0184e3cc (7 revisions)
2025-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 539ed5c222e1 to ba0f4a824014 (20 revisions)
2025-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from a87fa39f6446 to 86cf34f50cbe (1 revision)
2025-01-28 michaelludwig@google.com [graphite] getImmutableSamplerInfo
only takes in TextureInfo, not the whole proxy
2025-01-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 7425f0646395 to ef9be82521e9 (20 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,fmalita@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
...
2025-01-30 18:11:41 +00:00
Jonah Williams
1eecbf1256
[Android] HC++ plumbing. ( #162407 )
...
We'll need the JNI fascade to create the surface transaction for HC++
mode. Split into a separate PR so that the "real" HC++ PR isn't 5000
lines long.
2025-01-30 18:04:40 +00:00
Jonah Williams
524325a2fd
[Android] SurfaceTransaction updates for HC++. ( #162405 )
...
Adds but does not use the ability to use imported Java
SurfaceTransactions in the AHB swapchain. When an imported
SurfaceTransaction is used, the Swapchain will not apply the transaction
and instead will rely on the PlatformViewController to do so.
2025-01-30 04:14:38 +00:00
Jim Graham
e6185c3471
[Impeller] Avoid NaN values when setting up for the fast squircle blur shader ( #162421 )
...
Fixes https://github.com/flutter/flutter/issues/162128
Zero dimensioned rectangle blurs were causing the setup code to generate
NaN values. This condition could also happen for some very thin or short
rectangles so rather than just rule out zero-dimensioned rectangles, the
uniforms are checked for NaN values and the operation is skipped in
those cases.
2025-01-30 03:26:14 +00:00
Harry Terkelsen
4526f65d4a
[web] Correctly read the repetitionCount for images ( #162414 )
...
There was a bug in `ResizingCodec` where it returned `frameCount`
instead of `repetitionCount` in the `repetitionCount` getter, causing
animated images to stop animating even if they were set to loop
infinitely.
Fixes https://github.com/flutter/flutter/issues/161800
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-29 23:55:13 +00:00
auto-submit[bot]
d048c771e3
Reverts "Started adjusting uvs to match pixel snapping. ( #162049 )" ( #162392 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#162049
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gaaclarke
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Negatively affected Android rendering (
https://github.com/flutter/flutter/issues/162361 )
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: gaaclarke
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {jonahwilliams}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
issue: https://github.com/flutter/flutter/issues/149652
doc: (currently google only)
https://docs.google.com/document/d/1Rulw_noQi0G8Glb47vk17uBbb6sySDxlQe-l-0kHn14/edit?tab=t.0
This increases the RMSE value in the test in
https://github.com/flutter/flutter/pull/161445 by a slight amount. I do
believe this reduces the time where we get non uniform scalars and
protects the integrity of relative spacing, thus being more what we
expect. There is still a bug that has to do with pixel alignment that
does give the illusion of stretching and shrinking though because of
hard/soft lines.
## Before
https://github.com/user-attachments/assets/e9b80b70-0961-4e02-9053-84d4457348e5
## After
https://github.com/user-attachments/assets/2494a2b1-497d-4a2b-afd7-23064acba293
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-01-29 23:35:55 +00:00
Jason Simmons
4fc2f0b251
Manual roll of Skia to f22419dbed05 ( #162293 )
2025-01-29 22:53:07 +00:00
Jason Simmons
14cf4acc97
[Impeller] Fix various typos ( #162295 )
2025-01-29 21:38:59 +00:00
Chinmay Garde
3905156860
[DisplayList] Don't call Skia Ganesh methods when its not available. ( #162345 )
...
This follows the same pattern followed in [Skia
itself](c59d1f0a27/bench/GpuTools.h (L34)
2025-01-29 02:09:42 +00:00
Kevin Moore
1ba0561963
[engine, web] return switch expressions in many places ( #162336 )
2025-01-29 02:07:45 +00:00
gaaclarke
dc580aff78
Started adjusting uvs to match pixel snapping. ( #162049 )
...
issue: https://github.com/flutter/flutter/issues/149652
doc: (currently google only)
https://docs.google.com/document/d/1Rulw_noQi0G8Glb47vk17uBbb6sySDxlQe-l-0kHn14/edit?tab=t.0
This increases the RMSE value in the test in
https://github.com/flutter/flutter/pull/161445 by a slight amount. I do
believe this reduces the time where we get non uniform scalars and
protects the integrity of relative spacing, thus being more what we
expect. There is still a bug that has to do with pixel alignment that
does give the illusion of stretching and shrinking though because of
hard/soft lines.
## Before
https://github.com/user-attachments/assets/e9b80b70-0961-4e02-9053-84d4457348e5
## After
https://github.com/user-attachments/assets/2494a2b1-497d-4a2b-afd7-23064acba293
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-28 18:54:23 +00:00
Matan Lurey
9e273d5e6e
Remove scenario_app/android and rename to ios_scenario_app. ( #160992 )
...
🚫 **BLOCKED** : Do not merge until
https://github.com/flutter/flutter/issues/161261 (additional test
coverage).
---
This PR eliminates (1) `scenario_app/android`, and all references to an
Android `scenario_app`, including documentation, CI configuration, build
rules, test runner, Android-side test application, and (2), to verify
and disambiguate the remains, renames the folder `ios_scenario_app`,
which is now accurate.
It also eliminates elements that were _only_ used in the Android-side
scenario_app, such as Firebase Test Lab uploading.
I would be open to doing this in phases if we thought it was better to
do so, but given its mostly a mechanical change (and by renaming the
directory, references can be checked merely by looking for
`/\bscenario_app/`, I believe this is safe to iterate on and eventually
merge after the holidays.
## Background
As of the merged mono-repo, there is no longer a requirement for the
engine to be testable as a standalone unit.
As an example,
[`%ENGINE%/testing/scenario_app`](3762f2e973/engine/src/flutter/testing/scenario_apphttps://github.com/flutter/flutter/tree/master/dev/integration_tests/native_driver_test ),
which is a full-fledged Flutter app, which uses standard tooling (i.e.
`flutter`), to test most of the same elements that previously were only
tested in the Android version of `scenario_app`.
2025-01-28 03:43:46 +00:00
Matan Lurey
9ebd172442
Add missing properties: ... and move to presubmit. ( #162170 )
...
Closes https://github.com/flutter/flutter/issues/160701 .
Resolves
https://github.com/flutter/flutter/issues/160701#issuecomment-2613078030
and moves to presubmit (which means this PR shouldn't be able to land
until it works).
2025-01-28 00:29:28 +00:00
Jonah Williams
95811bd82a
[Impeller] make swapchain related external fence/semaphore extensions optional. ( #162205 )
...
Fixes https://github.com/flutter/flutter/issues/162088
Since we will always support a fallback to the KHR swapchain on Android,
we can make the external fence/semaphore extensions optional.
2025-01-27 23:55:45 +00:00
Chinmay Garde
ac9d6aa152
Don't depend on Dart from FML. ( #162271 )
...
This was likely a holdover from a time when trace events were routed to
the timeline directly.
This was causing standalone QNX builds to also pull in Dart.
No change in functionality and hopefully faster builds for smaller
targets.
2025-01-27 22:22:35 +00:00
Chinmay Garde
cd586eea50
[DisplayList] Move nested canvas enums into their own TU. ( #162037 )
...
These cause ambiguous compiler reference errors on some GCC versions.
And, the errors seem right. But, newer versions of clang seem to resolve
that ambiguity by also checking if the references to the types are also
references to identical types.
Per the chat with Jim, also added the Dl prefix to those types.
No change in functionality. Just a rename of the types and removal of
the now unnecessary typedefs.
2025-01-27 22:00:01 +00:00
Ryan Ferrell
489b186904
Avoid iOS text selection crash by returning nil range ( #161996 )
...
[Previously approved](https://github.com/flutter/engine/pull/55909 ) in
/engine before monorepo shift.
Reverts an unnecessary assertion introduced by
[#16496 ](https://github.com/flutter/engine/pull/16496 ) that crashes upon
valid user text field interactions. Follow-on work can resolve the
underlying discrepancy between iOS and Flutter range finding (see
#160100 ). For crash reports, see issue
[#138464 ](https://github.com/flutter/flutter/issues/138464 ).
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Co-authored-by: Chris Bracken <chris@bracken.jp>
2025-01-27 19:10:19 +00:00
Mohellebi abdessalem
ca14403b06
fix felt link to point to flutter repo instead of the engine repo ( #161423 )
...
fix `felt` link to point to flutter repo instead of the engine repo
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] All existing and new tests are passing.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Nate Wilson <nathan.wilson1232@gmail.com>
2025-01-27 19:03:08 +00:00
Harry Terkelsen
6b8ead49f3
[canvaskit] Fix debug build for CanvasKit ( #162198 )
...
Fixes the debug build for CanvasKit.
NOTE: We need to build the debug WASM build with `-O1` because building
with `-O0` causes Emscripten to produce a binary that is rejected by
Chrome for having functions with too many local variables. Building with
`-O1` optimizes those locals out.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-27 17:56:33 +00:00
Jackson Gardner
fdd7ebc59f
Don't install xcode when doing local_engine web builds on mac. ( #162164 )
...
We don't actually need Xcode installed to do web builds on a Mac, since
it uses emscripten. We can specify to skip the install via the property
added here: https://flutter-review.googlesource.com/c/recipes/+/62500
2025-01-25 02:03:09 +00:00
Jonah Williams
e057941ee7
[Impeller] when a command pool has many unused buffers, reset with release resources flag. ( #162171 )
...
Fixes https://github.com/flutter/flutter/issues/161861
Resetting a command pool is not sufficient to reclaim memory. The pool
must be trimmed. Contrary to what you would expect, it appears that just
resetting the pool, even if the cmd buffers are reclaimed, never frees
any memory.
2025-01-24 23:24:47 +00:00
Jonah Williams
b82e9022a3
[Impeller] Skip clip entity replay that cannot impact current clip. ( #162113 )
...
Fixes https://github.com/flutter/flutter/issues/161262
Sometimes we end up with clip replay entities that have clip depth
values substantially below the current depth. I suspect this is due to
either mismatched save/restore or a bug in our code. Update: this isn't
a bug/bug but its definitely a bug. We can have multiple clips per save,
but the restore will remove at most one from the record/replay.
If a clip has a depth value that is less than the current clip depth, it
cannot by definition impact anything that draws after it.
2025-01-24 19:49:40 +00:00
Jim Graham
bf7daf22a5
Reland "[Impeller] Migrate unit tests off of Skia geometry classes ( #161855 )" ( #162146 )
...
Reverts flutter/flutter#162046
The root cause of the test failures seen in the original PR have been
fixed.
2025-01-24 12:02:29 +00:00
Jim Graham
83bac343ba
[Impeller] Fix source offset in PathBuilder::AddPath ( #162052 )
...
An error in bookkeeping in `PathBuilder::AddPath` caused crashes in
recent unit tests (see https://github.com/flutter/flutter/pull/162046 )
2025-01-24 05:18:25 +00:00
jesswrd
96e74bbb41
Add to Setup Path Example to Engine README ( #162115 )
...
Added link to direct to engine setup and a path example.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-24 05:14:38 +00:00
auto-submit[bot]
176a7652e1
Reverts "Unskip test. ( #162106 )" ( #162122 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#162106
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: harryterkelsen
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: causing test breakage on web. See:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/270/infra
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: polina-c
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {yjbanov}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
No description provided.
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-01-23 23:39:46 +00:00
Jackson Gardner
bfe31d607c
Fix skwasm target in wasm_debug_unopt build. ( #162100 )
...
Fixes a couple issues in the skwasm build rules:
* `DEMANGLE_SUPPORT` is deprecated in emscripten, so just remove it.
* `sSHARED_MEMORY=1` needs to be added to the cflags so that emscripten
appends the proper feature flags (`-matomics` and `-mbulk-memory`) when
doing the compile so that the flags match the linking step.
2025-01-23 22:05:52 +00:00
Polina Cherkasova
8d00bd9c9a
Unskip test. ( #162106 )
2025-01-23 21:10:38 +00:00
