Reid Baker
e110019f04
Update README.md to include googler post verification steps ( #162272 )
...
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-01-29 02:08:54 +00:00
Kevin Moore
1ba0561963
[engine, web] return switch expressions in many places ( #162336 )
2025-01-29 02:07:45 +00:00
Reid Baker
60182c5e21
Update README.md to not have engine link for android ( #162330 )
...
Came up in triage, no bug.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-01-29 02:07:41 +00:00
Ben Konyi
2e4b40bdfa
Reland "[ Widget Previews ] Add support for detecting previews and generating code ( #161911 )"" ( #162337 )
...
Reverts flutter/flutter#162327
2025-01-29 02:05:53 +00:00
Gray Mackall
2d11b6a362
Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore ( #162332 )
...
Fixes https://github.com/flutter/flutter/issues/161480 .
Ended up going with just providing instructions instead of checking in
the binary, as the instructions is just one line.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Co-authored-by: Gray Mackall <mackall@google.com>
2025-01-29 02:04:50 +00:00
Matan Lurey
8b9b6a39af
Fix tests to prepare for --explicit-package-dependencies and a bug. ( #162289 )
...
@camsim99 discovered these would fail here:
https://github.com/flutter/flutter/pull/161826#issuecomment-2617059566 .
This fixes in preparation for the flag flipping, and also fixes a bug in
resolving `synthetic-package` I missed (it _can't_ be true if
`--explicit-package-dependencies` is set).
2025-01-29 02:04:50 +00:00
Matan Lurey
f5bf8f7707
Add a currently unused runs_in_merge_queue property to Linux analyze. ( #162335 )
...
Towards https://github.com/flutter/flutter/issues/162329 .
This currently does nothing.
2025-01-29 01:07:53 +00:00
auto-submit[bot]
1807704009
Reverts "[ Widget Previews ] Add support for detecting previews and generating code ( #161911 )" ( #162327 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#161911
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Mid-air collision with another Flutter tool
update.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: bkonyi
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {andrewkolos}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
`flutter widget-preview start` will now look for functions annotated
with `@Preview()` within the developer's project. These functions will
be used to generate
`.dart_tool/widget_preview_scaffold/lib/generated_preview.dart`, which
inserts the returned value from each preview function into a
`List<WidgetPreview>` returned from a `previews()` method that is
invoked by the widget preview scaffold root.
**Example generated_preview.dart:**
```dart
// ignore_for_file: no_leading_underscores_for_library_prefixes
import 'package:foo/foo.dart' as _i1;
import 'package:foo/src/bar.dart' as _i2;
import 'package:widget_preview/widget_preview.dart';
List<WidgetPreview> previews() => [_i1.preview(), _i2.barPreview1(), _i2.barPreview2()];
```
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-01-28 19:14:26 +00:00
Srujan Gaddam
6d2792de5c
Support hot restart for DDC library bundle format ( #162123 )
...
https://github.com/dart-lang/webdev/issues/2516
https://github.com/dart-lang/webdev/issues/2561
- Adds logic to emit newly compiled sources to a file that can be read
by the bootstrapper.
- Adds bootstrapping logic to reload scripts as needed. This involves
implementing the necessary hot restart callback, fetching and processing
the emitted file of newly compiled sources, cache busting, and loading
the scripts onto the page. A lot of this logic is similar or identical
to what we have for internal hot restart support.
- Runs existing hot restart tests with the new bundle format.
- Adds meta tag to run with utf-8 like in
https://github.com/flutter/flutter/pull/161493 .
- Uses DWDS 24.3.3.
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
2025-01-28 19:10:20 +00:00
gaaclarke
dc580aff78
Started adjusting uvs to match pixel snapping. ( #162049 )
...
issue: https://github.com/flutter/flutter/issues/149652
doc: (currently google only)
https://docs.google.com/document/d/1Rulw_noQi0G8Glb47vk17uBbb6sySDxlQe-l-0kHn14/edit?tab=t.0
This increases the RMSE value in the test in
https://github.com/flutter/flutter/pull/161445 by a slight amount. I do
believe this reduces the time where we get non uniform scalars and
protects the integrity of relative spacing, thus being more what we
expect. There is still a bug that has to do with pixel alignment that
does give the illusion of stretching and shrinking though because of
hard/soft lines.
## Before
https://github.com/user-attachments/assets/e9b80b70-0961-4e02-9053-84d4457348e5
## After
https://github.com/user-attachments/assets/2494a2b1-497d-4a2b-afd7-23064acba293
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-28 18:54:23 +00:00
Mohellebi abdessalem
29bb5e7a00
Refactor code inside flutter.groovy ( #160250 )
...
remove unnecessary spacing
remove the usage of System.env because it is dynamic .
the getProperty have the ability to take a second argument wich will be
the default value
android studio linter is prompting `Consider using 'configureEach' to
avoid unnecessary configuration`
android studio linter is prompting `Call to 'get' can be keyed access `
android studio linter is prompting `Cannot determine type of 'o'`
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-28 18:23:44 +00:00
chunhtai
b5c3a9fa61
Table implements redepth ( #162282 )
...
As title
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-28 18:22:06 +00:00
Ben Konyi
f25b4b77ff
[ Widget Previews ] Add support for detecting previews and generating code ( #161911 )
...
`flutter widget-preview start` will now look for functions annotated
with `@Preview()` within the developer's project. These functions will
be used to generate
`.dart_tool/widget_preview_scaffold/lib/generated_preview.dart`, which
inserts the returned value from each preview function into a
`List<WidgetPreview>` returned from a `previews()` method that is
invoked by the widget preview scaffold root.
**Example generated_preview.dart:**
```dart
// ignore_for_file: no_leading_underscores_for_library_prefixes
import 'package:foo/foo.dart' as _i1;
import 'package:foo/src/bar.dart' as _i2;
import 'package:widget_preview/widget_preview.dart';
List<WidgetPreview> previews() => [_i1.preview(), _i2.barPreview1(), _i2.barPreview2()];
```
2025-01-28 17:59:57 +00:00
Andrew Kolos
a9c50335c7
remove dependency on Usage from Pub class ( #162279 )
...
Towards https://github.com/flutter/flutter/issues/150575
Removes more usage of `Usage`. This PR is scoped to removing all
references to it in `pub`-related code.
<details>
<summary> Pre-launch checklist </summary>
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
</details>
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-28 17:32:27 +00:00
engine-flutter-autoroll
21f7283f5d
Roll Packages from 258f6dce6a49 to 02c6fef4ef63 (6 revisions) ( #162313 )
...
258f6dce6a...02c6fef4efstuartmorgan@google.com Revert "[shared_preferences] Add
shared preferences devtool" (flutter/packages#8515 )
2025-01-28 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Updates the internal wrapper to use
`@ProxyApi` from pigeon (flutter/packages#8311 )
2025-01-28 jhy03261997@gmail.com update the `const` in
StatefulShellRouteData generation (flutter/packages#8502 )
2025-01-27 pawel.jakubowski@leancode.pl
[video_player_platform_interface] Platform view support
(flutter/packages#8453 )
2025-01-27 andrewrkolos@gmail.com [multicast_dns] Rewrite `_readFQDN` to
avoid recursion (flutter/packages#8390 )
2025-01-27 stuartmorgan@google.com [shared_preferences] Fix Android type
mismatch regression (flutter/packages#8512 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-01-28 16:09:53 +00:00
Matan Lurey
9e273d5e6e
Remove scenario_app/android and rename to ios_scenario_app. ( #160992 )
...
🚫 **BLOCKED** : Do not merge until
https://github.com/flutter/flutter/issues/161261 (additional test
coverage).
---
This PR eliminates (1) `scenario_app/android`, and all references to an
Android `scenario_app`, including documentation, CI configuration, build
rules, test runner, Android-side test application, and (2), to verify
and disambiguate the remains, renames the folder `ios_scenario_app`,
which is now accurate.
It also eliminates elements that were _only_ used in the Android-side
scenario_app, such as Firebase Test Lab uploading.
I would be open to doing this in phases if we thought it was better to
do so, but given its mostly a mechanical change (and by renaming the
directory, references can be checked merely by looking for
`/\bscenario_app/`, I believe this is safe to iterate on and eventually
merge after the holidays.
## Background
As of the merged mono-repo, there is no longer a requirement for the
engine to be testable as a standalone unit.
As an example,
[`%ENGINE%/testing/scenario_app`](3762f2e973/engine/src/flutter/testing/scenario_apphttps://github.com/flutter/flutter/tree/master/dev/integration_tests/native_driver_test ),
which is a full-fledged Flutter app, which uses standard tooling (i.e.
`flutter`), to test most of the same elements that previously were only
tested in the Android version of `scenario_app`.
2025-01-28 03:43:46 +00:00
Matan Lurey
281efca413
Apparently it is illegal to use stderr in this project. ( #162294 )
...
Unblocks https://github.com/flutter/flutter/issues/162201 .
2025-01-28 02:51:37 +00:00
Alexander Aprelev
0b33d7b48d
Fix update_engine_version_test in presence of FLUTTER_PREBUILT_ENGINE_VERSION env vars. ( #162270 )
...
Fixes https://github.com/flutter/flutter/issues/162260
2025-01-28 01:19:47 +00:00
Matan Lurey
9ebd172442
Add missing properties: ... and move to presubmit. ( #162170 )
...
Closes https://github.com/flutter/flutter/issues/160701 .
Resolves
https://github.com/flutter/flutter/issues/160701#issuecomment-2613078030
and moves to presubmit (which means this PR shouldn't be able to land
until it works).
2025-01-28 00:29:28 +00:00
Jonah Williams
95811bd82a
[Impeller] make swapchain related external fence/semaphore extensions optional. ( #162205 )
...
Fixes https://github.com/flutter/flutter/issues/162088
Since we will always support a fallback to the KHR swapchain on Android,
we can make the external fence/semaphore extensions optional.
2025-01-27 23:55:45 +00:00
dependabot[bot]
abd0d16232
Bump the all-github-actions group with 2 updates ( #162277 )
...
Bumps the all-github-actions group with 2 updates:
[actions/checkout](https://github.com/actions/checkout ) and
[codecov/codecov-action](https://github.com/codecov/codecov-action ).
Updates `actions/checkout` from 3 to 4
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/actions/checkout/releases ">actions/checkout's
releases</a>.</em></p>
<blockquote>
<h2>v4.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update default runtime to node20 by <a
href="https://github.com/takost "><code>@takost</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1436 ">actions/checkout#1436</a></li>
<li>Support fetching without the --progress option by <a
href="https://github.com/simonbaird "><code>@simonbaird</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1067 ">actions/checkout#1067</a></li>
<li>Release 4.0.0 by <a
href="https://github.com/takost "><code>@takost</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1447 ">actions/checkout#1447</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/takost "><code>@takost</code></a> made
their first contribution in <a
href="https://redirect.github.com/actions/checkout/pull/1436 ">actions/checkout#1436</a></li>
<li><a
href="https://github.com/simonbaird "><code>@simonbaird</code></a> made
their first contribution in <a
href="https://redirect.github.com/actions/checkout/pull/1067 ">actions/checkout#1067</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/checkout/compare/v3...v4.0.0 ">https://github.com/actions/checkout/compare/v3...v4.0.0 </a></p>
<h2>v3.6.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Mark test scripts with Bash'isms to be run via Bash by <a
href="https://github.com/dscho "><code>@dscho</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1377 ">actions/checkout#1377</a></li>
<li>Add option to fetch tags even if fetch-depth > 0 by <a
href="https://github.com/RobertWieczoreck "><code>@RobertWieczoreck</code></a>
in <a
href="https://redirect.github.com/actions/checkout/pull/579 ">actions/checkout#579</a></li>
<li>Release 3.6.0 by <a
href="https://github.com/luketomlinson "><code>@luketomlinson</code></a>
in <a
href="https://redirect.github.com/actions/checkout/pull/1437 ">actions/checkout#1437</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/RobertWieczoreck "><code>@RobertWieczoreck</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/checkout/pull/579 ">actions/checkout#579</a></li>
<li><a
href="https://github.com/luketomlinson "><code>@luketomlinson</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/checkout/pull/1437 ">actions/checkout#1437</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/checkout/compare/v3.5.3...v3.6.0 ">https://github.com/actions/checkout/compare/v3.5.3...v3.6.0 </a></p>
<h2>v3.5.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Fix: Checkout Issue in self hosted runner due to faulty submodule
check-ins by <a
href="https://github.com/megamanics "><code>@megamanics</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1196 ">actions/checkout#1196</a></li>
<li>Fix typos found by codespell by <a
href="https://github.com/DimitriPapadopoulos "><code>@DimitriPapadopoulos</code></a>
in <a
href="https://redirect.github.com/actions/checkout/pull/1287 ">actions/checkout#1287</a></li>
<li>Add support for sparse checkouts by <a
href="https://github.com/dscho "><code>@dscho</code></a> and <a
href="https://github.com/dfdez "><code>@dfdez</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1369 ">actions/checkout#1369</a></li>
<li>Release v3.5.3 by <a
href="https://github.com/TingluoHuang "><code>@TingluoHuang</code></a>
in <a
href="https://redirect.github.com/actions/checkout/pull/1376 ">actions/checkout#1376</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/megamanics "><code>@megamanics</code></a> made
their first contribution in <a
href="https://redirect.github.com/actions/checkout/pull/1196 ">actions/checkout#1196</a></li>
<li><a
href="https://github.com/DimitriPapadopoulos "><code>@DimitriPapadopoulos</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/checkout/pull/1287 ">actions/checkout#1287</a></li>
<li><a href="https://github.com/dfdez "><code>@dfdez</code></a> made
their first contribution in <a
href="https://redirect.github.com/actions/checkout/pull/1369 ">actions/checkout#1369</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/checkout/compare/v3...v3.5.3 ">https://github.com/actions/checkout/compare/v3...v3.5.3 </a></p>
<h2>v3.5.2</h2>
<h2>What's Changed</h2>
<ul>
<li>Fix: Use correct API url / endpoint in GHES by <a
href="https://github.com/fhammerl "><code>@fhammerl</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1289 ">actions/checkout#1289</a>
based on <a
href="https://redirect.github.com/actions/checkout/issues/1286 ">#1286</a>
by <a href="https://github.com/1newsr "><code>@1newsr</code></a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/checkout/compare/v3.5.1...v3.5.2 ">https://github.com/actions/checkout/compare/v3.5.1...v3.5.2 </a></p>
<h2>v3.5.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Improve checkout performance on Windows runners by upgrading
<code>@actions/github</code> dependency by <a
href="https://github.com/BrettDong "><code>@BrettDong</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1246 ">actions/checkout#1246</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/BrettDong "><code>@BrettDong</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/checkout/pull/1246 ">actions/checkout#1246</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="11bd71901bhttps://redirect.github.com/actions/checkout/issues/1953 ">#1953</a>)</li>
<li><a
href="e3d2460bbbhttps://redirect.github.com/actions/checkout/issues/1946 ">#1946</a>)</li>
<li><a
href="163217dfcdhttps://redirect.github.com/actions/checkout/issues/1941 ">#1941</a>)</li>
<li><a
href="eef61447b9https://redirect.github.com/actions/checkout/issues/1925 ">#1925</a>)</li>
<li><a
href="6b42224f41https://redirect.github.com/actions/checkout/issues/1919 ">#1919</a>)</li>
<li><a
href="de5a000abfhttps://redirect.github.com/actions/checkout/issues/1924 ">#1924</a>)</li>
<li><a
href="d632683dd7https://redirect.github.com/actions/checkout/issues/1878 ">#1878</a>)</li>
<li><a
href="6d193bf280https://redirect.github.com/actions/checkout/issues/1777 ">#1777</a>)</li>
<li><a
href="db0cee9a51https://redirect.github.com/actions/checkout/issues/1872 ">#1872</a>)</li>
<li><a
href="b684943689https://redirect.github.com/actions/checkout/issues/1180 ">#1180</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/actions/checkout/compare/v3...v4 ">compare
view</a></li>
</ul>
</details>
<br />
Updates `codecov/codecov-action` from 5.1.1 to 5.3.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/codecov/codecov-action/releases ">codecov/codecov-action's
releases</a>.</em></p>
<blockquote>
<h2>v5.3.1</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: add docs and copy over dist by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1752 ">codecov/codecov-action#1752</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.3.0...v5.3.1 ">https://github.com/codecov/codecov-action/compare/v5.3.0...v5.3.1 </a></p>
<h2>v5.3.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update README with reqs by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1749 ">codecov/codecov-action#1749</a></li>
<li>chore(release): wrapper -0.1.0 by <a
href="https://github.com/codecov-releaser-app "><code>@codecov-releaser-app</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1750 ">codecov/codecov-action#1750</a></li>
<li>chore(release): 5.3.0 by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1751 ">codecov/codecov-action#1751</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.2.0...v5.3.0 ">https://github.com/codecov/codecov-action/compare/v5.2.0...v5.3.0 </a></p>
<h2>v5.2.0</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: remove erroneous linebreak in readme by <a
href="https://github.com/Vampire "><code>@Vampire</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1734 ">codecov/codecov-action#1734</a></li>
<li>feat: add disable-telem feature by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1739 ">codecov/codecov-action#1739</a></li>
<li>chore(deps): bump wrapper to 0.0.32 by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1740 ">codecov/codecov-action#1740</a></li>
<li>build(deps): bump actions/upload-artifact from 4.4.3 to 4.6.0 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1743 ">codecov/codecov-action#1743</a></li>
<li>build(deps): bump github/codeql-action from 3.27.9 to 3.28.1 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1742 ">codecov/codecov-action#1742</a></li>
<li>use correct audience when requesting oidc token by <a
href="https://github.com/juho9000 "><code>@juho9000</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1744 ">codecov/codecov-action#1744</a></li>
<li>Th/add commands by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1745 ">codecov/codecov-action#1745</a></li>
<li>Fix typo in README by <a
href="https://github.com/tserg "><code>@tserg</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1747 ">codecov/codecov-action#1747</a></li>
<li>chore(release): bump to 5.2.0 by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1748 ">codecov/codecov-action#1748</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Vampire "><code>@Vampire</code></a> made
their first contribution in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1734 ">codecov/codecov-action#1734</a></li>
<li><a href="https://github.com/juho9000 "><code>@juho9000</code></a>
made their first contribution in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1744 ">codecov/codecov-action#1744</a></li>
<li><a href="https://github.com/tserg "><code>@tserg</code></a> made
their first contribution in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1747 ">codecov/codecov-action#1747</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.1.2...v5.2.0 ">https://github.com/codecov/codecov-action/compare/v5.1.2...v5.2.0 </a></p>
<h2>v5.1.2</h2>
<h2>What's Changed</h2>
<ul>
<li>build(deps): bump github/codeql-action from 3.27.5 to 3.27.6 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1717 ">codecov/codecov-action#1717</a></li>
<li>Remove mistake from options table by <a
href="https://github.com/Acconut "><code>@Acconut</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1718 ">codecov/codecov-action#1718</a></li>
<li>build(deps): bump github/codeql-action from 3.27.6 to 3.27.9 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1722 ">codecov/codecov-action#1722</a></li>
<li>Put quotes around <code>${{ inputs.token }}</code> in
<code>action.yml</code> by <a
href="https://github.com/jwodder "><code>@jwodder</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1721 ">codecov/codecov-action#1721</a></li>
<li>chore(release): wrapper-0.0.31 by <a
href="https://github.com/codecov-releaser-app "><code>@codecov-releaser-app</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1723 ">codecov/codecov-action#1723</a></li>
<li>fix: prevent oidc on tokenless due to permissioning by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1724 ">codecov/codecov-action#1724</a></li>
<li>fix: update action script by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1725 ">codecov/codecov-action#1725</a></li>
<li>fix: update statment by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1726 ">codecov/codecov-action#1726</a></li>
<li>chore(release): 5.1.2 by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1727 ">codecov/codecov-action#1727</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Acconut "><code>@Acconut</code></a> made
their first contribution in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1718 ">codecov/codecov-action#1718</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md ">codecov/codecov-action's
changelog</a>.</em></p>
<blockquote>
<h2>v5.3.1</h2>
<h3>What's Changed</h3>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.3.0..v5.3.1 ">https://github.com/codecov/codecov-action/compare/v5.3.0..v5.3.1 </a></p>
<h2>v5.3.0</h2>
<h3>What's Changed</h3>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.2.0..v5.3.0 ">https://github.com/codecov/codecov-action/compare/v5.2.0..v5.3.0 </a></p>
<h2>v5.2.0</h2>
<h3>What's Changed</h3>
<ul>
<li>Fix typo in README by <a
href="https://github.com/tserg "><code>@tserg</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1747 ">codecov/codecov-action#1747</a></li>
<li>Th/add commands by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1745 ">codecov/codecov-action#1745</a></li>
<li>use correct audience when requesting oidc token by <a
href="https://github.com/juho9000 "><code>@juho9000</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1744 ">codecov/codecov-action#1744</a></li>
<li>build(deps): bump github/codeql-action from 3.27.9 to 3.28.1 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1742 ">codecov/codecov-action#1742</a></li>
<li>build(deps): bump actions/upload-artifact from 4.4.3 to 4.6.0 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1743 ">codecov/codecov-action#1743</a></li>
<li>chore(deps): bump wrapper to 0.0.32 by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1740 ">codecov/codecov-action#1740</a></li>
<li>feat: add disable-telem feature by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1739 ">codecov/codecov-action#1739</a></li>
<li>fix: remove erroneous linebreak in readme by <a
href="https://github.com/Vampire "><code>@Vampire</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1734 ">codecov/codecov-action#1734</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.1.2..v5.2.0 ">https://github.com/codecov/codecov-action/compare/v5.1.2..v5.2.0 </a></p>
<h2>v5.1.2</h2>
<h3>What's Changed</h3>
<ul>
<li>fix: update statment by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1726 ">codecov/codecov-action#1726</a></li>
<li>fix: update action script by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1725 ">codecov/codecov-action#1725</a></li>
<li>fix: prevent oidc on tokenless due to permissioning by <a
href="https://github.com/thomasrockhu-codecov "><code>@thomasrockhu-codecov</code></a>
in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1724 ">codecov/codecov-action#1724</a></li>
<li>chore(release): wrapper-0.0.31 by
<code>@app/codecov-releaser-app</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1723 ">codecov/codecov-action#1723</a></li>
<li>Put quotes around <code>${{ inputs.token }}</code> in
<code>action.yml</code> by <a
href="https://github.com/jwodder "><code>@jwodder</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1721 ">codecov/codecov-action#1721</a></li>
<li>build(deps): bump github/codeql-action from 3.27.6 to 3.27.9 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1722 ">codecov/codecov-action#1722</a></li>
<li>Remove mistake from options table by <a
href="https://github.com/Acconut "><code>@Acconut</code></a> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1718 ">codecov/codecov-action#1718</a></li>
<li>build(deps): bump github/codeql-action from 3.27.5 to 3.27.6 by
<code>@app/dependabot</code> in <a
href="https://redirect.github.com/codecov/codecov-action/pull/1717 ">codecov/codecov-action#1717</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/codecov/codecov-action/compare/v5.1.1..v5.1.2 ">https://github.com/codecov/codecov-action/compare/v5.1.1..v5.1.2 </a></p>
<h2>v5.1.1</h2>
<h3>What's Changed</h3>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="13ce06bfc63e26040980https://redirect.github.com/codecov/codecov-action/issues/1752 ">#1752</a>)</li>
<li><a
href="0da7aa657dhttps://redirect.github.com/codecov/codecov-action/issues/1751 ">#1751</a>)</li>
<li><a
href="1ca7ce65dfhttps://redirect.github.com/codecov/codecov-action/issues/1750 ">#1750</a>)</li>
<li><a
href="65baa5fcb6https://redirect.github.com/codecov/codecov-action/issues/1749 ">#1749</a>)</li>
<li><a
href="5a605bd927https://redirect.github.com/codecov/codecov-action/issues/1748 ">#1748</a>)</li>
<li><a
href="5825942583https://redirect.github.com/codecov/codecov-action/issues/1747 ">#1747</a>)</li>
<li><a
href="b1a63834cehttps://redirect.github.com/codecov/codecov-action/issues/1745 ">#1745</a>)</li>
<li><a
href="6c5b693a58https://redirect.github.com/codecov/codecov-action/issues/1744 ">#1744</a>)</li>
<li><a
href="ad45165bd4https://redirect.github.com/codecov/codecov-action/issues/1742 ">#1742</a>)</li>
<li>Additional commits viewable in <a
href="7f8b4b4bde...13ce06bfc6
2025-01-27 22:51:59 +00:00
Chinmay Garde
ac9d6aa152
Don't depend on Dart from FML. ( #162271 )
...
This was likely a holdover from a time when trace events were routed to
the timeline directly.
This was causing standalone QNX builds to also pull in Dart.
No change in functionality and hopefully faster builds for smaller
targets.
2025-01-27 22:22:35 +00:00
Chinmay Garde
cd586eea50
[DisplayList] Move nested canvas enums into their own TU. ( #162037 )
...
These cause ambiguous compiler reference errors on some GCC versions.
And, the errors seem right. But, newer versions of clang seem to resolve
that ambiguity by also checking if the references to the types are also
references to identical types.
Per the chat with Jim, also added the Dl prefix to those types.
No change in functionality. Just a rename of the types and removal of
the now unnecessary typedefs.
2025-01-27 22:00:01 +00:00
Ryan Ferrell
489b186904
Avoid iOS text selection crash by returning nil range ( #161996 )
...
[Previously approved](https://github.com/flutter/engine/pull/55909 ) in
/engine before monorepo shift.
Reverts an unnecessary assertion introduced by
[#16496 ](https://github.com/flutter/engine/pull/16496 ) that crashes upon
valid user text field interactions. Follow-on work can resolve the
underlying discrepancy between iOS and Flutter range finding (see
#160100 ). For crash reports, see issue
[#138464 ](https://github.com/flutter/flutter/issues/138464 ).
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Co-authored-by: Chris Bracken <chris@bracken.jp>
2025-01-27 19:10:19 +00:00
Mohellebi abdessalem
ca14403b06
fix felt link to point to flutter repo instead of the engine repo ( #161423 )
...
fix `felt` link to point to flutter repo instead of the engine repo
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] All existing and new tests are passing.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Nate Wilson <nathan.wilson1232@gmail.com>
2025-01-27 19:03:08 +00:00
Matan Lurey
a37898413a
Enable the Android Engine OpenGLES/Vulkan suites. ( #162258 )
...
For some reason they never ran on `bringup: true` (???) but I guess
they'll run on presubmit (or not, we'll see).
Closes https://github.com/flutter/flutter/issues/161333 .
2025-01-27 18:04:23 +00:00
Harry Terkelsen
6b8ead49f3
[canvaskit] Fix debug build for CanvasKit ( #162198 )
...
Fixes the debug build for CanvasKit.
NOTE: We need to build the debug WASM build with `-O1` because building
with `-O0` causes Emscripten to produce a binary that is rejected by
Chrome for having functions with too many local variables. Building with
`-O1` optimizes those locals out.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-27 17:56:33 +00:00
engine-flutter-autoroll
a2c56f3d75
Roll Packages from 3d3ab7bcb07e to 258f6dce6a49 (19 revisions) ( #162254 )
...
3d3ab7bcb0...258f6dce6aadsonpleal@gmail.com [shared_preferences] Add shared
preferences devtool (flutter/packages#8494 )
2025-01-24 tarrinneal@gmail.com [shared_preferences] update List<String>
encode/decode (flutter/packages#8335 )
2025-01-24 engine-flutter-autoroll@skia.org Manual roll Flutter from
c1561a41c530 to c1ffaa9d9deb (21 revisions) (flutter/packages#8498 )
2025-01-24 stuartmorgan@google.com [ios_platform_images] Switch to
`loadImage` (flutter/packages#8216 )
2025-01-24 mchudy@users.noreply.github.com [camera] Remove OCMock from
CameraExposureTests and CameraFocusTests (flutter/packages#8351 )
2025-01-24 tarrinneal@gmail.com [shared_preferences] Tool for migrating
from legacy shared_preferences to shared_preferences_async
(flutter/packages#8229 )
2025-01-23 stuartmorgan@google.com Revert "[shared_preferences] Add
shared preferences devtool" (flutter/packages#8493 )
2025-01-23 20254485+kaboc@users.noreply.github.com [go_router] Fix
return type of current state getter to be non-nullable
(flutter/packages#8173 )
2025-01-23 engine-flutter-autoroll@skia.org Manual roll Flutter from
b2f515f45ef5 to c1561a41c530 (18 revisions) (flutter/packages#8491 )
2025-01-23 tarrinneal@gmail.com [pigeon] fixes event channel dart
instance name usage and adds test (flutter/packages#8483 )
2025-01-23 51104750+AffanShaikhsurab@users.noreply.github.com [go
_route] fragment parameter added (flutter/packages#8232 )
2025-01-23 mchudy@users.noreply.github.com [in_app_purchase] Update
in_app_purchase_android version in in_app_purchase
(flutter/packages#8463 )
2025-01-23 stuartmorgan@google.com [image_picker] Reference alternate
macOS implementations (flutter/packages#8487 )
2025-01-23 32538273+ValentinVignal@users.noreply.github.com [rfw]
Activate leak testing (flutter/packages#8370 )
2025-01-23 32538273+ValentinVignal@users.noreply.github.com
[video_player] Activate leak testing (flutter/packages#8379 )
2025-01-23 engine-flutter-autoroll@skia.org Manual roll Flutter from
b9e86a565f92 to b2f515f45ef5 (42 revisions) (flutter/packages#8482 )
2025-01-23 olli.helenius@codemate.com [camera] Add API support query for
image streaming (app-facing) (flutter/packages#8422 )
2025-01-23 engine-flutter-autoroll@skia.org Manual roll Flutter from
b9e86a565f92 to eb6af3d029b7 (13 revisions) (flutter/packages#8473 )
2025-01-23 adsonpleal@gmail.com [shared_preferences] Add shared
preferences devtool (flutter/packages#8322 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-01-27 16:25:30 +00:00
Matan Lurey
a16de734bd
Pin customer_testing to the SHA specified in tests.version ( #162048 )
...
Closes https://github.com/flutter/flutter/issues/162041 .
I also converted the `.sh` and `.bat` files (largely) to Dart, mostly
because I don't know enough Windows XP command prompt in order to make
the change safely. They should still run the same from the CI
bootstrapping, but most of the logic is now Dart code.
Will send a separate PR to update the `flutter/tests` PR template.
/cc @johnmccutchan @Piinks
2025-01-25 22:15:28 +00:00
Matan Lurey
a3f0704f25
Formalize update_engine_version.{sh|ps1}. ( #162118 )
...
Towards https://github.com/flutter/flutter/issues/162201 .
**NOTE**: This renames the environment variable to
`FLUTTER_PREBUILT_ENGINE_VERSION`.
---
We occasionally break ourselves, our users, and the Dart up (or is it
down? side-ways) stream repos (i.e. HHH) when we change how the
undocumented
[`update_engine_version.sh`](https://github.com/flutter/flutter/blob/master/bin/internal/update_engine_version.sh )
script, and it's Windows counterpart
[`update_engine_version.ps1`](https://github.com/flutter/flutter/blob/master/bin/internal/update_engine_version.ps1 )
work, but have no way of knowing until N days/weeks later when someone
tells us.
For example,
<https://flutter-review.googlesource.com/c/recipes/+/62400 >.
This is my attempt to encode "this is what you can guarantee by calling
this script".
It _still_ will be an internal only API that we might rev at any time,
but at least we:
1. Can tell the Dart team "this is tested and how it works"
2. If we want to change it, the tests will keep us from changing it
without informing folks it changed
These tests should (in theory) cover both Linux/MacOS and Windows.
/cc @a-siva
2025-01-25 19:53:17 +00:00
Tirth
586a59211d
Rename 'SelectionChangedCause.scribble' to 'SelectionChangedCause.stylusHandwriting' ( #161518 )
...
Rename 'SelectionChangedCause.scribble' to
'SelectionChangedCause.stylusHandwriting'
Fixes #159223
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-25 05:50:26 +00:00
Jackson Gardner
fdd7ebc59f
Don't install xcode when doing local_engine web builds on mac. ( #162164 )
...
We don't actually need Xcode installed to do web builds on a Mac, since
it uses emscripten. We can specify to skip the install via the property
added here: https://flutter-review.googlesource.com/c/recipes/+/62500
2025-01-25 02:03:09 +00:00
Matan Lurey
9cc132d4c2
Force Impeller backend for android_engine_test, and test both OpenGLES and Vulkan ( #162089 )
...
A few changes in this PR (could have been split up, but that would take
an extra 4 hours - 2 days in CI time):
- Removed the old `flutter_driver_android_test` shards and references
- Override `AndroidManifest.xml` per backend, forcing that backend to be
used (no fallbacks) or it fails
- Bumps the Android emulator to 35 due to the use of magic strings, I
think
The check for the Impeller backend actually being used is the honor
system right now, as a bug in `flutter drive`
(https://github.com/flutter/flutter/issues/162087 ) prevents me from
seeing error output, meaning that it's impossible to be sure a
particular Impeller backend is used (or understand why a crash happens),
so I guess I'll work on that next.
Due to https://github.com/flutter/flutter/issues/162088 , we were
accidentally running our Vulkan tests as OpenGLES 🤦🏼 .
2025-01-25 01:55:28 +00:00
Jonah Williams
e057941ee7
[Impeller] when a command pool has many unused buffers, reset with release resources flag. ( #162171 )
...
Fixes https://github.com/flutter/flutter/issues/161861
Resetting a command pool is not sufficient to reclaim memory. The pool
must be trimmed. Contrary to what you would expect, it appears that just
resetting the pool, even if the cmd buffers are reclaimed, never frees
any memory.
2025-01-24 23:24:47 +00:00
Mouad Debbar
3755fd1f6e
[web] Remove HTML renderer from framework tests ( #162038 )
...
- Cleanup many HTML special cases and skips in framework tests.
- Update some dartdocs that referred to the HTML renderer.
For reviewers: it may help if you set `Hide whitespace` to true in
Github. It will help you skip through all the formatting/indentation
changes.
2025-01-24 21:33:27 +00:00
Jonah Williams
b82e9022a3
[Impeller] Skip clip entity replay that cannot impact current clip. ( #162113 )
...
Fixes https://github.com/flutter/flutter/issues/161262
Sometimes we end up with clip replay entities that have clip depth
values substantially below the current depth. I suspect this is due to
either mismatched save/restore or a bug in our code. Update: this isn't
a bug/bug but its definitely a bug. We can have multiple clips per save,
but the restore will remove at most one from the record/replay.
If a clip has a depth value that is less than the current clip depth, it
cannot by definition impact anything that draws after it.
2025-01-24 19:49:40 +00:00
Fichtelcoder
74ade43341
Update Android integration test package for newer AGP ( #161856 )
...
Now that Flutter requires AGP 7+, we can use Java 11 as the
compatibility version in the plugin template rather than 1.8, avoiding
warnings with newer toolchains. This was already done for templates, but
the integration test package still produces a warning because it still
uses Java 1.8 which is now bumped to version 11.
Another part of #156111 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
2025-01-24 18:36:25 +00:00
Loïc Sharma
c1ffaa9d9d
Fix link to hotfix documentation best practices ( #162116 )
...
Currently the [cherrypick
process](https://github.com/flutter/flutter/blob/master/docs/releases/Flutter-Cherrypick-Process.md#automatically-create-a-cherry-pick-request )
links to:
https://github.com/flutter/flutter/blob/master/docs/releases/docs/releases/Hotfix-Documentation-Best-Practices.md
This should be:
https://github.com/flutter/flutter/blob/master/docs/releases/Hotfix-Documentation-Best-Practices.md
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-24 15:17:48 +00:00
Reid Baker
02e11f95a1
Add integration test for cutout rotation evaluation ( #160354 )
...
Test that the position of a cutout as reported by the Android engine
repositions based on screen orientation.
Related to https://github.com/flutter/engine/pull/55992
Part of https://github.com/flutter/flutter/issues/155658
to test run flutter drive integration_test/display_cutout_test.dart
from dev/integration_tests/display_cutout_rotation
Pr also force upgrades pub dependencies because I was getting presubmit
failure in version solve.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-01-24 14:50:38 +00:00
Jim Graham
bf7daf22a5
Reland "[Impeller] Migrate unit tests off of Skia geometry classes ( #161855 )" ( #162146 )
...
Reverts flutter/flutter#162046
The root cause of the test failures seen in the original PR have been
fixed.
2025-01-24 12:02:29 +00:00
Bruno Leroux
a2ec056b82
Fix TextField intrinsic width when hint is not visible ( #161235 )
...
## Description
This PR changes the TextField intrinsic width computation for non-empty
TextField.
Before:
When a TextField is non-empty, the intrinsic width can't be smaller than
the hint width:
After:
The width does not depend on the hint when the TextField is non empty.
<details><summary>Code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(
title: 'Material App',
home: Scaffold(
body: Center(
child: IntrinsicWidth(
child: TextField(
decoration: InputDecoration(
filled: true,
hintText: 'Moderately long hint text',
),
),
),
),
),
);
}
}
```
</details>
## Related Issue
Fixes [[TextField] The computation of the intrinsic width of a TextField
should include the hint width only when
visible](https://github.com/flutter/flutter/issues/93337 )
## Tests
Adds 2 tests.
2025-01-24 09:34:25 +00:00
Jenn Magder
f8b9bdceef
When parsing flavors, handle Xcode build configurations that are not lowercase ( #161455 )
...
The flavors/Xcode build config/Xcode scheme matching logic tries to be
permissive with casing. Instead of passing the lower-cased config into
`xcodebuild`, instead pass the real configuration name to get the right
casing.
Fixes https://github.com/flutter/flutter/issues/85643
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-24 05:18:33 +00:00
Jim Graham
83bac343ba
[Impeller] Fix source offset in PathBuilder::AddPath ( #162052 )
...
An error in bookkeeping in `PathBuilder::AddPath` caused crashes in
recent unit tests (see https://github.com/flutter/flutter/pull/162046 )
2025-01-24 05:18:25 +00:00
jesswrd
96e74bbb41
Add to Setup Path Example to Engine README ( #162115 )
...
Added link to direct to engine setup and a path example.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-24 05:14:38 +00:00
auto-submit[bot]
176a7652e1
Reverts "Unskip test. ( #162106 )" ( #162122 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#162106
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: harryterkelsen
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: causing test breakage on web. See:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/270/infra
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: polina-c
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {yjbanov}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
No description provided.
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-01-23 23:39:46 +00:00
Mahesh Jamdade
787afad5b4
feat: Add hint (Widget) property to InputDecoration ( #161424 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Adds a new property to InputDecoration `hintTextWidget`
*Fixes*: #161130
With the introduction of ~hintTextWidget~ hint We should be able to
animate hintText
https://github.com/user-attachments/assets/7955a835-5f60-4451-8ede-b5e5f0457046
https://github.com/user-attachments/assets/55d7f021-cc8f-471e-a1d8-e601262ff640
<details>
<summary>sample code</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({Key? key}) : super(key: key);
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
primarySwatch: Colors.blue,
),
home: const MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
const MyHomePage({Key? key, required this.title}) : super(key: key);
final String title;
@override
State<MyHomePage> createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> with TickerProviderStateMixin {
String _searchText = 'Popular Picks';
List<String> wordsToShow = [
'Popular Picks',
'Trending',
'New Arrivals',
'Best Sellers',
'Top Rated',
];
int index = 0;
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text(widget.title),
),
body: Center(
child: Padding(
padding: const EdgeInsets.all(8.0),
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
TextField(
cursorHeight: 16,
decoration: InputDecoration(
maintainHintHeight: true,
hintTextWidget: Row(
children: [
const Text(
"Search for ",
style: TextStyle(fontSize: 16),
),
SlidingText(
onCompleted: () {
index = (index + 1) % wordsToShow.length;
setState(() {
_searchText = wordsToShow[index];
});
},
word: _searchText,
interval: 1500,
isDelay: true),
],
),
border: OutlineInputBorder(),
),
),
],
),
),
),
);
}
}
class SlidingText extends StatefulWidget {
final String word;
final int interval;
final bool isDelay;
final Function onCompleted;
const SlidingText({
required this.word,
required this.interval,
required this.isDelay,
required this.onCompleted,
Key? key,
}) : super(key: key);
@override
_SlidingTextState createState() => _SlidingTextState();
}
class _SlidingTextState extends State<SlidingText>
with SingleTickerProviderStateMixin {
late AnimationController _animController;
late Animation<Offset> _slideAnimation;
late Animation<double> _fadeAnimation;
@override
void initState() {
super.initState();
_animController = AnimationController(
duration: Duration(milliseconds: widget.interval),
vsync: this,
);
_slideAnimation = Tween<Offset>(
begin: Offset(0, 0.5),
end: Offset(0, -0.6),
).animate(
CurvedAnimation(
parent: _animController,
curve: Curves.easeInOut,
),
);
_fadeAnimation = TweenSequence([
TweenSequenceItem(
tween: Tween<double>(begin: 0.0, end: 1.0).chain(
CurveTween(curve: Curves.easeIn),
),
weight: 50, // First half of the animation
),
TweenSequenceItem(
tween: Tween<double>(begin: 1.0, end: 0.0).chain(
CurveTween(curve: Curves.easeOut),
),
weight: 50, // Second half of the animation
),
]).animate(_animController);
// add interval
_animController.addStatusListener((status) async {
if (status == AnimationStatus.completed) {
await Future.delayed(Duration(milliseconds: 500));
widget.onCompleted();
}
});
_animController.forward();
}
@override
void didUpdateWidget(covariant SlidingText oldWidget) {
super.didUpdateWidget(oldWidget);
if (oldWidget.word != widget.word) {
_animController.reset();
_animController.forward();
}
}
@override
void dispose() {
_animController.dispose();
super.dispose();
}
@override
Widget build(BuildContext context) {
return AnimatedBuilder(
animation: _animController,
builder: (context, child) {
return SlideTransition(
position: _slideAnimation,
child: FadeTransition(
opacity: _fadeAnimation,
child: Text(
widget.word,
style: const TextStyle(fontSize: 16),
),
),
);
},
);
}
}
```
</details>
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-23 23:11:53 +00:00
Jackson Gardner
bfe31d607c
Fix skwasm target in wasm_debug_unopt build. ( #162100 )
...
Fixes a couple issues in the skwasm build rules:
* `DEMANGLE_SUPPORT` is deprecated in emscripten, so just remove it.
* `sSHARED_MEMORY=1` needs to be added to the cflags so that emscripten
appends the proper feature flags (`-matomics` and `-mbulk-memory`) when
doing the compile so that the flags match the linking step.
2025-01-23 22:05:52 +00:00
Flutter GitHub Bot
8c4ad50389
Marks Linux_android_emu android views to be unflaky ( #160493 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_android_emu android views"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android_emu%20android%20views%22 ).
This test can be marked as unflaky.
Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
2025-01-23 21:55:50 +00:00
Polina Cherkasova
8d00bd9c9a
Unskip test. ( #162106 )
2025-01-23 21:10:38 +00:00
Taha Tesser
1c0b3369cb
Add ability to maintain bottom view padding in NavigationBar safe area ( #162076 )
...
Fixes [When the on-screen keyboard is open, NavigationBar does not
maintainBottomViewPadding in Edge-to-Edge
mode](https://github.com/flutter/flutter/issues/159526 )
### Description
According to the
[SafeArea.maintainBottomViewPadding](https://api.flutter.dev/flutter/widgets/SafeArea/maintainBottomViewPadding.html )
docs, it is expected that `NavigationBar` will shift when the view
padding changes. This PR provides ability to override the
`maintainBottomViewPadding` property in the under `SafeArea` in the
`NavigationBar`.
### Code Sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
void main() async {
WidgetsFlutterBinding.ensureInitialized();
await SystemChrome.setEnabledSystemUIMode(SystemUiMode.edgeToEdge);
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
appBar: AppBar(
title: const Text('Sample'),
),
body: const Center(
child: Padding(
padding: EdgeInsets.all(16.0),
child: TextField(
decoration: InputDecoration(border: OutlineInputBorder()),
),
),
),
bottomNavigationBar: NavigationBar(
maintainBottomViewPadding: true,
destinations: const <Widget>[
NavigationDestination(icon: Icon(Icons.favorite_rounded), label: 'Favorite'),
NavigationDestination(icon: Icon(Icons.favorite_rounded), label: 'Favorite'),
NavigationDestination(icon: Icon(Icons.favorite_rounded), label: 'Favorite')
]),
floatingActionButton: FloatingActionButton(
onPressed: () {},
child: const Icon(Icons.add),
),
),
);
}
}
```
</details>
### With `maintainBottomViewPadding: false` (Default)
https://github.com/user-attachments/assets/1cea27d4-2d6d-4bca-bb9a-53c0a21fdb4d
### With `maintainBottomViewPadding: true`
https://github.com/user-attachments/assets/b6c7487f-e23c-43db-a365-90bf69fa03dd
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-01-23 21:00:08 +00:00
