firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
83,011 Commits 1 Branch 0 Tags
Commit Graph

29915 Commits

Author SHA1 Message Date
Matan Lurey
fe6c05b778
Update links to the flutter/engine repository for the monorepo. (#164328) 
Just general cleanup while working on other things.
 2025-02-27 21:57:59 +00:00
Gray Mackall
c9c3e74747
Add empty io.flutter.app.FlutterApplication to give deprecation notice, and un-break projects that have not migrated (#164233) 
The removal of the v1 embedding missed that this class was not marked as
deprecated, and did not provide a notice in the breaking changes
section. V1 apps that needed the functionality of the old
`FlutterApplication` were all broken in the previous release, but some
V2 apps have been referencing the v1 `FlutterApplication`.

For these apps, this is the same as extending the base
`android.app.Application`. So we can provide an "empty extension" of
that base class, to provide these v2 apps a deprecation notice, and
avoid breaking them without warning (in 3.29.1).

Arbitrarily chose the `spell_checker` integration test to reference this
empty application, let me know if you think I should bring up an
entirely new devicelab test instead.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <mackall@google.com>
 2025-02-27 21:47:12 +00:00
Alexander Aprelev
6ec7ae3a1c
Revert dart sdks that were causing dartaotruntime issues in g3 (#164307) 
Revert four collateral rolls, one with offending change
https://dart-review.googlesource.com/c/sdk/+/410921

Revert "Roll Dart SDK from b8292dfeaa67 to 80865748abe0 (9 revisions)
(#164168)"
Revert "Roll Dart SDK from 80865748abe0 to 7fa5901bd8a3 (3 revisions)
(#164226)"
Revert "Roll Dart SDK from 7fa5901bd8a3 to 4a218fbffc80 (2 revisions)
(#164260)"
Revert "Roll Dart SDK from 4a218fbffc80 to fcda71ce147b (1 revision)
(#164276)"
Revert "Roll Dart SDK from fcda71ce147b to d70b123c77d4 (1 revision)
(#164295)"
 2025-02-27 21:06:23 +00:00
Kevin Moore
2bc40b39dc
[web_ui] dependency cleanup (#164256) 
Update dependencies across 3 web engine packages
Remove unneeded dependencies
One set of associated code fixes
 2025-02-27 19:21:18 +00:00
engine-flutter-autoroll
0c200c7a09
Roll Skia from e5a33102401c to c16b145749d4 (1 revision) (#164314) 
https://skia.googlesource.com/skia.git/+log/e5a33102401c..c16b145749d4

2025-02-27 jamesgk@google.com Reland "[graphite] Require colorspaces for
precomp color xform objects"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-27 19:16:48 +00:00
Kevin Moore
671bcbe6d6
[web_ui] move several uses of (deprecated) pkg:js to js_interop_unsafe (#164264) 2025-02-27 18:46:01 +00:00
engine-flutter-autoroll
7c0c98eb7b
Roll Dart SDK from fcda71ce147b to d70b123c77d4 (1 revision) (#164295) 
https://dart.googlesource.com/sdk.git/+log/fcda71ce147b..d70b123c77d4

2025-02-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-149.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,matanl@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-27 15:22:06 +00:00
engine-flutter-autoroll
458a1f2e00
Roll Dart SDK from 4a218fbffc80 to fcda71ce147b (1 revision) (#164276) 
https://dart.googlesource.com/sdk.git/+log/4a218fbffc80..fcda71ce147b

2025-02-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-148.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,matanl@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-27 10:11:34 +00:00
Robert Ancell
d8a57c61dd
Add windowing channel support to Linux embedder (#163180) 
Implement flutter/windowing for the Linux embedder.
 2025-02-27 04:14:20 +00:00
engine-flutter-autoroll
11d33f203e
Roll Dart SDK from 7fa5901bd8a3 to 4a218fbffc80 (2 revisions) (#164260) 
https://dart.googlesource.com/sdk.git/+log/7fa5901bd8a3..4a218fbffc80

2025-02-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-147.0.dev
2025-02-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-146.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,matanl@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-27 03:58:33 +00:00
engine-flutter-autoroll
e6f4fa4204
Roll Skia from fdd97386193e to 0f2e106c9abc (4 revisions) (#164259) 
https://skia.googlesource.com/skia.git/+log/fdd97386193e..0f2e106c9abc

2025-02-26 jamesgk@google.com [graphite] Remove guards for
RenderPassProperties field
2025-02-26 egdaniel@google.com Fix equality check in VulkanBuffer for
host access.
2025-02-26 robertphillips@google.com [graphite] Reduce
SkRuntimeEffect::Options overhead for KnownRuntimeEffects
2025-02-26 jvanverth@google.com [graphite] Remove most validation from
ClipAtlas.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-27 03:36:31 +00:00
John McDole
4b65ead926
Run more builds faster (#164125) 
The following builds all download drone assets and run generators, and
thus could benefit from the flags.

- Linux linux_android_aot_engine
- Linux linux_android_debug_engine
- Linux linux_fuchsia
- Linux linux_host_engine

See #164069 for other builds
 2025-02-27 03:10:42 +00:00
Jason Simmons
1d25f6953d
Reland "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools" (#164240) 
Relands https://github.com/flutter/flutter/pull/163890 and updates the
Ninja path used by the engine tool
 2025-02-27 00:13:58 +00:00
Liam Appelbe
0f3b092a10
Use the Dart isolate ownership API on the root isolate (#163703) 
The isolate ownership API was [introduced
recently](https://dart-review.googlesource.com/c/sdk/+/407700) to solve
[some deadlock bugs](https://github.com/dart-lang/native/issues/1908) in
native callbacks.

A native callback is a call from native code into a Dart function.
Currently all such callbacks must run that Dart function in the isolate
that created the callback (called the target isolate). The only native
callback primitives at the moment are `NativeCallable.isolateLocal`
(blocking, but must be invoked from the same thread as the target
isolate, and the target isolate must be currently entered on that
thread) and `NativeCallable.listener` (non-blocking, can be invoked from
any thread).

To build blocking callbacks that can be called from any thread, we can
use a `NativeCallable.listener`, and use a synchronization object like a
mutex or a condition variable to block until the callback is complete.
However, if we try to do this on the thread that is currently entered in
the target isolate, we will deadlock: we invoke the listener, a message
is sent to the target isolate, and we block waiting for the message to
be handled, so we never pass control flow back to the isolate to handle
the message, and never stop waiting.

To fix this deadlock, Ffigen and Jnigen both have a mechanism that
checks if we're on the target isolate's thread first:
- If the native caller is already on the same thread as the target
isolate, and the target isolate is entered:
- Call the Dart function directly using `NativeCallable.isolateLocal` or
similar
- Otherwise, if the native caller is coming from a different thread:
- Call the Dart function asynchronously using `NativeCallable.listener`
or similar
  - Block until the callback finishes

However, this neglects the case where we're on the target isolate's
thread, but not entered into the isolate. This case happens in Flutter
when the callback is invoked from the UI thread (or the platform thread
when thread merging is enabled), and the target isolate is the root
isolate. When the native callback is invoked, the root isolate is not
entered, so we hit the second case: we send a message to the root
isolate, and block to wait for a response. Since the root isolate is
exclusively run on the UI thread, and we're blocking the UI thread, the
message will never be handled, and we deadlock.

The isolate ownership API fixes this by allowing the embedder to inform
the VM that it will run a particular isolate exclusively on a particular
thread, using `Dart_SetCurrentThreadOwnsIsolate`. Other native code can
then query that ownership using `Dart_GetCurrentThreadOwnsIsolate`. This
lets us add a third case to our conditional:

- If the native caller is on the thread that is currently entered in the
target isolate:
- Call the Dart function directly using `NativeCallable.isolateLocal` or
similar
- Otherwise, if the native caller is on the thread that owns the target
isolate
  - Enter the target isolate
- Call the Dart function directly using `NativeCallable.isolateLocal `or
similar
  - Exit the target isolate
- Otherwise, the native caller is coming from an unrelated thread:
- Call the Dart function asynchronously using `NativeCallable.listener`
or similar
  - Block until the callback finishes

**Note:** We don't need to set the ownership of VM managed threads,
because they run in a thread pool exclusively used by the VM, so there's
no way for native code to be executed on the thread (except by FFI, in
which case we're entered into the isolate anyway). We only need this for
Flutter's root isolate because work can be sent to the UI
thread/platform thread using OS specific APIs like Android's
`Looper.getMainLooper()`.
 2025-02-27 00:05:53 +00:00
Gray Mackall
b287365b21
Implement opacity FlutterMutator for hcpp (#164147) 
This is essentially a reland of
https://github.com/flutter/engine/pull/30264/, except that it only
applies the opacity if the new alpha (alpha = 255*opacity, where
opacity∈[0,1]) is different from the current alpha.

Also adds a new opacity screenshot test. Need to figure out how to bring
up a new screenshot test... does the screenshot get uploaded
automatically? Do I need to manually upload somewhere?

Fixes https://github.com/flutter/flutter/issues/164212

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <mackall@google.com>
 2025-02-26 23:12:19 +00:00
engine-flutter-autoroll
f0b08055e6
Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... (#164232) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC matanl@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Co-authored-by: zijiehe@ <68449066+zijiehe-google-com@users.noreply.github.com>
 2025-02-26 23:02:48 +00:00
engine-flutter-autoroll
f6e66cb27f
Roll Skia from 47b84f354604 to fdd97386193e (8 revisions) (#164221) 
https://skia.googlesource.com/skia.git/+log/47b84f354604..fdd97386193e

2025-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 28db7e56a2ed to 8ed929b84efc (3 revisions)
2025-02-26 robertphillips@google.com [graphite] Minor cleanups
2025-02-26 robertphillips@google.com [graphite] Cleanup TestPrecompile
jobs
2025-02-26 michaelludwig@google.com Reland "Reland "[graphite] Remove
TextureInfoData and TextureSpec in TextureInfo""
2025-02-26 robertphillips@google.com [graphite] Add getPipelineLabel API
for serialized Pipeline keys
2025-02-26 aswolfers@google.com Add BGRA format support
2025-02-26 jamesgk@google.com [graphite] Add dst color space field to
RenderPassProperties
2025-02-26 jamesgk@google.com Attempt specialized blurred rrect draw for
arcs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-26 20:55:18 +00:00
Jonah Williams
04cc4b1f11
[Impeller] Reland: move AHB check into Flutter main, don't disable ImageReader on 29. (#164201) 
Rather than conditionally disabling AHBs, just disable Vulkan on devices
where AHB imports don't work. FIx from last time is in the last commit,
I reversed the string check accidentally and disabled vulkan everywhere
🥺

https://github.com/flutter/flutter/issues/163473
https://github.com/flutter/flutter/issues/160854
 2025-02-26 20:53:57 +00:00
engine-flutter-autoroll
05eb42f32d
Roll Dart SDK from 80865748abe0 to 7fa5901bd8a3 (3 revisions) (#164226) 
https://dart.googlesource.com/sdk.git/+log/80865748abe0..7fa5901bd8a3

2025-02-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-145.0.dev
2025-02-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-144.0.dev
2025-02-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-143.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,matanl@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-26 20:53:56 +00:00
Jonah Williams
0b96fa88fd
[Impeller] work around for crashy Nexus 5 Driver. (#164040) 
Rewrites exp to work around crashes on Nexus 5.
 2025-02-26 17:54:53 +00:00
auto-submit[bot]
52876a0b25
Reverts "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (#163890)" (#164209) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#163890
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jason-simmons
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: et and related packages in
https://github.com/flutter/flutter/tree/master/engine/src/flutter/tools
need to be updated for the new Ninja path
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jason-simmons
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {matanlurey, jtmcdole}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
The depot_tools Ninja wrapper looks for Ninja at specific paths within
the tree. The use of "name": "." in the engine's .gclient file is not
expected by the depot_tools logic for locating the engine's source
directory.

This PR creates an alternative layout that is supported by depot_tools.
If the project root directory contains a "buildtools" subdirectory, then
depot_tools will look for Ninja at "third_party/ninja" within the root.

Fixes https://github.com/flutter/flutter/issues/163487
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-02-26 17:53:36 +00:00
gaaclarke
8b3f5f4a2f
Added compilation failure if a max ubo size is exceeded (#164038) 
issue: https://github.com/flutter/flutter/issues/163580

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-02-26 17:36:00 +00:00
engine-flutter-autoroll
e039a911c5
Roll Skia from 5336e20498d9 to 47b84f354604 (2 revisions) (#164188) 
https://skia.googlesource.com/skia.git/+log/5336e20498d9..47b84f354604

2025-02-26 robertphillips@google.com [graphite] Disable
UserDefinedStableKeyTest on Android Protected jobs
2025-02-26 robertphillips@google.com [graphite] Shorten shader names w/o
relying on auto-trimming

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-26 16:07:50 +00:00
Jason Simmons
3d018b5924
Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (#163890) 
The depot_tools Ninja wrapper looks for Ninja at specific paths within
the tree. The use of "name": "." in the engine's .gclient file is not
expected by the depot_tools logic for locating the engine's source
directory.

This PR creates an alternative layout that is supported by depot_tools.
If the project root directory contains a "buildtools" subdirectory, then
depot_tools will look for Ninja at "third_party/ninja" within the root.

Fixes https://github.com/flutter/flutter/issues/163487
 2025-02-26 15:11:31 +00:00
engine-flutter-autoroll
80233283c3
Roll Skia from 3ce6f25dc13e to 5336e20498d9 (9 revisions) (#164174) 
https://skia.googlesource.com/skia.git/+log/3ce6f25dc13e..5336e20498d9

2025-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 25a22decd766 to 8dbd2fe62ac3 (11 revisions)
2025-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from ce93f1f3a1f4 to 63deebde9085 (26 revisions)
2025-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 7ee45b04303c to 28db7e56a2ed (13 revisions)
2025-02-25 kjlubick@google.com Minor cleanups in blitters
2025-02-25 jvanverth@google.com [graphite] Potential fix for clip atlas
crash
2025-02-25 robertphillips@google.com [graphite] Add unit tests for
user-defined known runtime effects
2025-02-25 ccameron@chromium.org SkJpegGainmapEncoder::MakeMPF: Move MP
parameters before StartOfScan
2025-02-25 jmbetancourt@google.com [MSKP] fix image serialization for
MSKPs using derived generators
2025-02-25 michaelludwig@google.com Revert "Reland "[graphite] Remove
TextureInfoData and TextureSpec in TextureInfo""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,kjlubick@google.com,matanl@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-26 10:03:03 +00:00
engine-flutter-autoroll
d4bdeb7c46
Roll Dart SDK from b8292dfeaa67 to 80865748abe0 (9 revisions) (#164168) 
https://dart.googlesource.com/sdk.git/+log/b8292dfeaa67..80865748abe0

2025-02-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-142.0.dev
2025-02-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-141.0.dev
2025-02-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-140.0.dev
2025-02-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-139.0.dev
2025-02-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-138.0.dev
2025-02-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-137.0.dev
2025-02-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-136.0.dev
2025-02-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-135.0.dev
2025-02-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-134.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,matanl@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-26 10:01:10 +00:00
Tong Mu
a3e9df35aa
[Engine] Remove dead code for RoundedSuperellipse (#164163) 
Remove dead code that occurred during development and I forgot to
remove.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-02-26 09:59:05 +00:00
Jonah Williams
ac9f68b12d
[Impeller] detect mediatek soc and fall back to GLES. (#164126) 
If the device is _probably_ mediatek, then use OpenGL. We may relax this
check if the future if we find a mediatek soc that works well w/ Vulkan.
 2025-02-26 05:07:59 +00:00
Jonah Williams
8bb34f2c20
[Impeller] make DLOG into LOG for startup errors. (#164110) 
Make logs visible to help debug
https://github.com/flutter/flutter/issues/163532 . Right now we can't
see why context creation is failing.

It may be an EGL config issue.
 2025-02-26 05:07:59 +00:00
auto-submit[bot]
cca82ed93b
Reverts "[Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (#164109)" (#164166) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#164109
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: brain not work too good.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jonahwilliams
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {matanlurey}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Rather than conditionally disabling AHBs, just disable Vulkan on devices
where AHB imports don't work.

https://github.com/flutter/flutter/issues/163473
https://github.com/flutter/flutter/issues/160854
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-02-26 04:32:26 +00:00
Jonah Williams
8b3f1a4c0f
[Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (#164109) 
Rather than conditionally disabling AHBs, just disable Vulkan on devices
where AHB imports don't work.

https://github.com/flutter/flutter/issues/163473
https://github.com/flutter/flutter/issues/160854
 2025-02-26 02:50:12 +00:00
LouiseHsu
99e1a0652c
Fix extra numbers showing up when enabling VoiceControl (#163593) 
Fixes https://github.com/flutter/flutter/issues/158477 and
https://github.com/flutter/flutter/issues/156368.

The excess numbers in both PRs are caused by all `SemanticObjects`
returning `YES` for `accessibilityRespondsToUserInteraction`, even if it
has no semantic actions. For example, a SemanticObject with just a label
has semantic information (the label) but no action. This PR adds a
check, ensuring that an `SemanticObjects` has at least one accessible
action before returning `YES`

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-02-26 00:59:54 +00:00
engine-flutter-autoroll
17e73f219f
Roll Dart SDK from aea6fff33f06 to b8292dfeaa67 (1 revision) (#163973) 
https://dart.googlesource.com/sdk.git/+log/aea6fff33f06..b8292dfeaa67

2025-02-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-133.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jacksongardner@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-26 00:56:34 +00:00
Jim Graham
f825cccda2
[DisplayList] Delete all legacy Skia-oriented method overloads in DlCanvas (#164054) 
Delete remaining DlCanvas method overloads that were allowing the use of
Skia geometry objects in rendering code.

The only remaining uses of Skia classes in the DlCanvas interface are
SkImageInfo and SkTextBlob.
 2025-02-26 00:44:27 +00:00
zijiehe@
70b7664ba2
[fuchsia] enable assets_unittests (#164019) 
It is an easy fix.

http://b/394632376

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-02-25 17:51:36 +00:00
Matej Knopp
940fb3c8b1
[Embedder] Wire view focus event and focus request (#163930) 
This wires `PlatformDispatcher.onViewFocusChange` and
`PlatformDispatches.requestViewFocusChange` through embedder API.

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I readand followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Matthew Kosarek <matt.kosarek@canonical.com>
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
 2025-02-25 17:37:06 +00:00
John McDole
be1938aa1c
Enable luci_flags for faster builds (#164069) 
Experiment enable turning on faster builds.

1. Moves collecting of builds till after we setup the orchestrator bot
2. Downloads drone artifacts in parallel.

See: https://flutter-review.googlesource.com/c/recipes/+/63800
 2025-02-25 16:18:56 +00:00
Jonah Williams
73b518d0c3
[iOS] increase backdrop cached task limit. (#164036) 
Partial workaround for https://github.com/flutter/flutter/issues/161142
. Since this was an arbitrary number anyway we can increase it a bit.
 2025-02-25 15:41:47 +00:00
Matej Knopp
641765e283
[Windows] Use enum to configure UI thread policy (#163727) 
https://github.com/flutter/flutter/pull/162935 added a boolean setting
to allow merged platform and UI thread. Using boolean doesn't allow for
opting out of the behavior once we enable it by default, which is
something we will likely want to allow, at least for a period of time.

This PR replaces the boolean with following enum:
```cpp
// Configures the thread policy for running the UI isolate.
typedef enum {
  // Default value. Currently will run the UI isolate on separate thread,
  // later will be changed to running the UI isolate on platform thread.
  Default,
  // Run the UI isolate on platform thread.
  RunOnPlatformThread,
  // Run the UI isolate on a separate thread.
  RunOnSeparateThread,
} FlutterDesktopUIThreadPolicy;
```

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
 2025-02-25 12:33:27 +00:00
engine-flutter-autoroll
ebd80b701b
Roll Skia from a141a3ceef87 to 521c27acf504 (8 revisions) (#164083) 
https://skia.googlesource.com/skia.git/+log/a141a3ceef87..521c27acf504

2025-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from f09a19cebdaf to 25a22decd766 (9 revisions)
2025-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 2407a54c9b29 to c12c13839d68 (2 revisions)
2025-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from d20125b786b1 to ce93f1f3a1f4 (11 revisions)
2025-02-25 michaelludwig@google.com Reland "[graphite] Remove
TextureInfoData and TextureSpec in TextureInfo"
2025-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 90cce021a3ec to 34a782c7af2d (10 revisions)
2025-02-24 kjlubick@google.com Fix ninepatch size calculations when
dealing with fractional radii
2025-02-24 robertphillips@google.com [graphite] Add user-defined known
runtime effect API
2025-02-24 robertphillips@google.com [graphite] Add user-defined known
runtime effects to ShaderCodeDictionary

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brettos@google.com,jacksongardner@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-25 09:31:06 +00:00
Matan Lurey
7535cb10bc
Move AndroidRenderingApi from common to shell/platform/android (#163796) 
Towards https://github.com/flutter/flutter/issues/163792.

Major changes:

- `enum class AndroidRenderingAPI` physically moves to
`shell/platform/android`
- Store in `FlutterMain` (as a result of `::init`), instead of in
`Settings`

---------

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
 2025-02-25 02:40:29 +00:00
engine-flutter-autoroll
ebc7d244d3
Roll Skia from 994168b1ba10 to a141a3ceef87 (1 revision) (#164023) 
https://skia.googlesource.com/skia.git/+log/994168b1ba10..a141a3ceef87

2025-02-24 jvanverth@google.com [graphite] Add back some validation for
clip atlas.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brettos@google.com,jacksongardner@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-24 22:30:25 +00:00
Devon Carew
2bf32d855e
[deps] update dep references from older repos to newer (current SOT) repos (#163891) 
Update dep references from older repos to newer (current SOT) repos:

- package:markdown is now part of the dart-lang/tools monorepo
- package:glob is now part of the dart-lang/tools monorepo
- package:web_socket_channel is now in dart-lang/http
- package:intl moved (quite a while ago) to the dart-lang/i18n monorepo
- package:gcloud moved (a while ago) to dart-lang/labs

I didn't have to update any references to package:intl as part of this;
I suspect that means that its not actually used here.

I was not able to update package:gcloud to the most recent commit; I had
to stop short of that because the package is now referencing
package:retry - in google/dart-neats - and there's no mirror for that.

Generally, it would be useful to have a process to update older
references here and / or garbage collect the dep'd in repos.

Done as the last bit of https://github.com/dart-lang/sdk/issues/56591.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-02-24 20:13:03 +00:00
Mouad Debbar
6b5b468a60
[web] Actual removal of HTML code (#164003) 
All usages of this code have been cleaned up. There's nothing using this
code at this point.

Closes https://github.com/flutter/flutter/issues/145954
 2025-02-24 19:32:13 +00:00
Jonah Williams
a488d104f2
[iOS] switch iOS to slimpeller variant. (#163808) 
Now that skia can no longer be used on both iOS devices and Simulators,
we can switch the iOS engine to the "slimpeller" variant which removes
some (not all!) of the Skia dependencies. This should reduce binary size
and build time.

I also did some cleanups as some tests we're still opting into Skia
behaviors (though not actually running skia) and we now flag these as
errors.
 2025-02-24 19:05:21 +00:00
Jonah Williams
1e2583eff2
[ui] Fix ImageFilter.shader equality to consider uniform values. (#163348) 
Fixes https://github.com/flutter/flutter/issues/163302

Framework widgets check for ImageFIlter.== to determine whether to mark
themselves dirty. The filter obejct needs to delegate its equality to
the underlying native filter so that uniform values are considered.
 2025-02-24 19:01:55 +00:00
engine-flutter-autoroll
35eaaaa3d0
Roll Skia from 322bb2226654 to 994168b1ba10 (3 revisions) (#164007) 
https://skia.googlesource.com/skia.git/+log/322bb2226654..994168b1ba10

2025-02-24 kjlubick@google.com Remove extra multiplication from rrect GM
2025-02-24 kjlubick@google.com Revert "Remove transform_scanline
functions from SkJpegEncoderImpl"
2025-02-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 02cb40cbb578 to 90cce021a3ec (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brettos@google.com,jacksongardner@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-24 18:27:54 +00:00
Yegor
de72d1c642
[web] retry safaridriver session creation (#163791) 
Speculatively retry when WebDriver session fails with a timed out
Safari. It is hard enough to get `safaridriver` to open a local port, so
one we have that going, it might be good to give a chance to connect to
the browser 🤷

Fixes https://github.com/flutter/flutter/issues/163790
 2025-02-24 16:50:26 +00:00
Jonah Williams
0102da95cd
[Impeller] Disable text cache. (#163906) 
I forgot to make a master branch version of the cherry pick here:
https://github.com/flutter/flutter/pull/163754
 2025-02-24 16:26:01 +00:00
engine-flutter-autoroll
7f447ea98c
Roll Dart SDK from bad289580d9b to aea6fff33f06 (3 revisions) (#163912) 
https://dart.googlesource.com/sdk.git/+log/bad289580d9b..aea6fff33f06

2025-02-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-132.0.dev
2025-02-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-131.0.dev
2025-02-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-130.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jacksongardner@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-22 06:42:38 +00:00