firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
83,011 Commits 1 Branch 0 Tags
Commit Graph

29915 Commits

Author SHA1 Message Date
engine-flutter-autoroll
f7be00358a
Roll Skia from 1d884bab8593 to cca9328df6ca (12 revisions) (#163910) 
https://skia.googlesource.com/skia.git/+log/1d884bab8593..cca9328df6ca

2025-02-21 kjlubick@google.com Revert "[graphite] Require colorspaces
for precomp color xform objects"
2025-02-21 robertphillips@google.com [graphite] Allow unit tests to get
access to TestOptions
2025-02-21 michaelludwig@google.com Revert "[graphite] Remove
TextureInfoData and TextureSpec in TextureInfo"
2025-02-21 kjlubick@google.com Add missing dependencies to jpeg_helpers
target
2025-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 126c9b378eb7 to a256e0e7f2a6 (17 revisions)
2025-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 80093a7d8f85 to be98f841ec88 (9 revisions)
2025-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from d7ed113c66ec to 2407a54c9b29 (3 revisions)
2025-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from be5b722c82af to 5070f7af1ee9 (17 revisions)
2025-02-20 jamesgk@google.com [graphite] Require colorspaces for precomp
color xform objects
2025-02-20 danieldilan@google.com Remove transform_scanline functions
from SkJpegEncoderImpl
2025-02-20 lokokung@google.com [dawn][headers] Use ifdefs for flattening
of wgpu::*Limits.
2025-02-20 kjlubick@google.com Add gm to highlight differences in
codepaths to draw blurry rrects

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jacksongardner@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-22 05:32:17 +00:00
zijiehe@
645e9f17a7
[fuchsia] include more tests in the fuchsia builders (#163800) 
This change includes 5 more test suites, and another 5 disabled test
suites. Fixing tests would be performed separately later.

http://b/394632376

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-02-22 04:25:27 +00:00
Tong Mu
5b7a3c8b20
[Engine] Add RoundSuperellipse to drawing OP (#160883) 
This PR adds support for clipping round superellipse to the engine.

For what a rounded superellipse is, see [this design
doc](https://docs.google.com/document/d/1CJXULKJGQt22FOFsrlm2TKVjKBtif1yU4U50cMfL6Kc/edit?tab=t.0).
Video demos can be found at https://github.com/flutter/engine/pull/56726
and https://github.com/flutter/flutter/pull/161409.

Only impeller can actually render it. On Skia and Web, this shape falls
back to `RRect`.

Part of https://github.com/flutter/flutter/issues/139321 and
https://github.com/flutter/flutter/issues/13914, also related to
https://github.com/flutter/flutter/issues/91523.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-02-21 23:58:26 +00:00
Gray Mackall
7d23780c7f
[remake] Restore old back handling for FlutterFragmentActivity (#161545) 
Remake of https://github.com/flutter/engine/pull/56565. Quoting from an
old comment, slightly edited:

------------ 

https://github.com/flutter/engine/pull/52302 seems to have
unintentionally had the effect of not allowing people to "opt out" of
predictive back. This is actually aligned with what the android docs say
should happen:

https://developer.android.com/guide/navigation/custom-back/predictive-back-gesture
> Note: OnBackPressedCallback is always called regardless of the value
of android:enableOnBackInvokedCallback. In other words, disabling the
system animation doesn't affect your app's back handling logic if it
uses OnBackPressedCallback.

But this wasn't actually true for flutter apps before
https://github.com/flutter/engine/pull/52302, because we were not
calling `super`, and `FlutterFragmentActivity` extends a
`FragmentActivity` which in turn extends a `ComponentActivity`, which
uses the old `onBackPressed` to [invoke the new back
handling](https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:activity/activity/src/main/java/androidx/activity/ComponentActivity.kt;l=587?q=ComponentActivity):
```kotlin
   override fun onBackPressed() {
        onBackPressedDispatcher.onBackPressed()
    }
```

So while the docs imply that removing the `onBackPressed` in
`FlutterFragmentActivity` shouldn't have had an effect, that wasn't true
because in our case we were consuming the back event and ignoring the
warning
```java
  @Override
  @SuppressWarnings("MissingSuperCall")
  public void onBackPressed() {
    flutterFragment.onBackPressed();
  }
```

What all this means is that apps that _aren't_ opting in to predictive
back had their back handling migrated to the new code path
automatically. FlutterFragmentActivity was uniquely is forced into the
new back handling codepath by
https://github.com/flutter/engine/pull/52302, which this PR fixes.

------------ 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <mackall@google.com>
 2025-02-21 22:22:24 +00:00
engine-flutter-autoroll
401ab831ee
Roll Dart SDK from c5e582f15b6c to bad289580d9b (1 revision) (#163885) 
https://dart.googlesource.com/sdk.git/+log/c5e582f15b6c..bad289580d9b

2025-02-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-129.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jacksongardner@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-21 21:41:55 +00:00
engine-flutter-autoroll
c6573749d0
Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) (#163789) 
Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions)

https://skia.googlesource.com/skia.git/+log/6da10829d017..1d884bab8593

2025-02-20 jlavrova@google.com Drawing hanging whitespaces in Paragraph
2025-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 26efdfb4f31d to 126c9b378eb7 (5 revisions)
2025-02-20 nscobie@google.com Update SkQPTestCases enforcement for
202504 vendor API bump (Android 16)
2025-02-20 jamesgk@google.com Split format calculation out of
SkWorkingFormatColorFilter
2025-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from 7c51661ea28c to 7b44b80c0fac
2025-02-20 michaelludwig@google.com [graphite] Remove TextureInfoData
and TextureSpec in TextureInfo
2025-02-20 nicolettep@google.com [graphite] Prepend input attachment
descriptor set to all Vulkan pipelines layouts
2025-02-20 nicolettep@google.com [graphite] Allow backends to define
resource set/group indices for SkSL generation
2025-02-20 bungeman@google.com [pdf] Developer build dump of input
structure tree
2025-02-20 jvanverth@google.com [graphite] Use linked list for
ClipAtlasManager.
2025-02-20 patrto@microsoft.com Bump golang.org/x/crypto and
golang.org/x/net
2025-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from c77cb9bbcd29 to be5b722c82af (26 revisions)
2025-02-20 borenet@google.com [infra] Update to go 1.22.0 in go.mod
2025-02-20 rop@google.com Updating license IDs to be spdx compliant
2025-02-20 jamesgk@google.com [graphite] Fix precomp tests involving
picture shaders
2025-02-20 nscobie@google.com [graphite] Re-enable BackendTextureTest on
Vulkan (& fix protectedness)
2025-02-20 egdaniel@google.com Revert "[Graphite] Add dawn
disable_lazy_clear_for_mapped_at_creation_buffer toggle"
2025-02-20 robertphillips@google.com [graphite] Update known runtime
effect constants for user-defined known runtime effects
2025-02-20 vmiura@google.com [graphite] Prevent default zero
initializaiton for DrawList members.
2025-02-20 michaelludwig@google.com [skif] Add build flag to avoid slow
small sigma CPU blurs
2025-02-20 robertphillips@google.com [graphite] Shore up snippet ID
error handling in preparation for user-defined known runtime effects
2025-02-20 robertphillips@google.com [graphite] Tinker w/ serialized
pipeline keys a bit
2025-02-20 kjlubick@google.com Reland "Decouple PDF backend and JPEG
encoding/decoding"
2025-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from bace6371e325 to 80093a7d8f85 (14 revisions)
2025-02-20 kjlubick@google.com Reland "Add some checks to avoid
asserting deep in ImageFilter code"
2025-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 65cf97632f2a to c77cb9bbcd29 (16 revisions)
2025-02-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 720189cae847 to d7ed113c66ec (2 revisions)
2025-02-19 lukasza@chromium.org [rust png] Add a new
`SkCodec::isAnimated` API.
2025-02-19 borenet@google.com [infra] Update Go to 1.24.0
2025-02-19 borenet@google.com [infra] Use SkiaIOS pool for iOS devices
2025-02-19 michaelludwig@google.com [skif] Relax assert in
srcRelativeOutput
2025-02-19 kjlubick@google.com Revert "Decouple PDF backend and JPEG
encoding/decoding"
2025-02-19 kjlubick@google.com Revert "[graphite] Enable
BackendTextureTest on Vulkan"
2025-02-19 kjlubick@google.com Revert "Add some checks to avoid
asserting deep in ImageFilter code"
2025-02-18 robertphillips@google.com [graphite] Move
PipelineCallbackHandler to skiatools for reuse
2025-02-18 kjlubick@google.com Add some checks to avoid asserting deep
in ImageFilter code
2025-02-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 5d08bc0b0e23 to 26efdfb4f31d (8 revisions)
2025-02-18 nscobie@google.com [SkQP] Create new AllSkQPTestCases module
for Android framework builds
2025-02-18 nscobie@google.com [graphite] Enable BackendTextureTest on
Vulkan
2025-02-18 kjlubick@google.com Decouple PDF backend and JPEG
encoding/decoding
2025-02-18 drott@chromium.org [Fontations] Match FreeType antialiasing
on unknown pixel geometry
2025-02-18 kjlubick@google.com Use SkSpans in BlurMask and related
classes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
...

Co-authored-by: Jackson Gardner <jacksongardner@google.com>
 2025-02-21 21:20:06 +00:00
Matan Lurey
ad76af2327
Enable linux_android_emulator_tests on presubmit. (#163879) 
Finalizes https://github.com/flutter/flutter/issues/163742.

It passed the last ~10 builds on postsubmit.
 2025-02-21 21:09:48 +00:00
zijiehe@
6018856ece
[fuchsia] reorder tests in test_suites.yaml and update the comment (#163799) 
This is a no-op change to avoid bloating
https://github.com/flutter/flutter/tree/zijiehe-google-com/more-tests.
The change reorders the test_suites.yaml alphabetically and removes the
unused run_with_dart_aot field.

The change should test itself, no extra tests are needed.

http://b/394632376

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-02-21 17:02:24 +00:00
engine-flutter-autoroll
99b2c1adaa
Roll Dart SDK from 7ceb3be8ed0a to c5e582f15b6c (2 revisions) (#163844) 
https://dart.googlesource.com/sdk.git/+log/7ceb3be8ed0a..c5e582f15b6c

2025-02-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-128.0.dev
2025-02-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-127.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jacksongardner@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-21 16:08:21 +00:00
engine-flutter-autoroll
b205b6b48a
Roll Dart SDK from ad642ee6f94b to 7ceb3be8ed0a (2 revisions) (#163832) 
https://dart.googlesource.com/sdk.git/+log/ad642ee6f94b..7ceb3be8ed0a

2025-02-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-126.0.dev
2025-02-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-125.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jacksongardner@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-21 10:24:24 +00:00
Matan Lurey
190d3be607
Update how to use VSCode with clangd after the monorepo merge (#163671) 2025-02-21 03:38:42 +00:00
Robert Ancell
dec3b1e20e
Fix incorrect function name in FlutterEngineRun documentation (#163696) 2025-02-21 03:27:33 +00:00
engine-flutter-autoroll
9583e0ac12
Roll Dart SDK from 557cbf2c7da6 to ad642ee6f94b (5 revisions) (#163794) 
https://dart.googlesource.com/sdk.git/+log/557cbf2c7da6..ad642ee6f94b

2025-02-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-124.0.dev
2025-02-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-123.0.dev
2025-02-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-122.0.dev
2025-02-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-121.0.dev
2025-02-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-120.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jacksongardner@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-21 01:07:39 +00:00
Harry Terkelsen
442c24147b
[canvaskit] Use visualViewport.scale to determine device pixel ratio. (#163688) 
When using Chrome for Android with "Request Desktop Site" checked will
cause the browser to set the `visualViewport` to have a very large size
and a scale of less than 1. If we do not account for the scale, then we
will create a huge bitmap (on a Pixel 4 emulator with "Request Desktop
Site" checked the viewport size was ~2500 x ~5000). Attempting to create
a too-large bitmap can silently fail and create a bitmap that is
slightly too small. This fixes Flutter Web to take the visual viewport
scale into account so we don't create enormous (and potentially flaky)
bitmaps on every frame.

BEFORE:

![Screenshot 2025-02-18 at 10 30
59 AM](https://github.com/user-attachments/assets/0bc5194a-59d7-4dcd-9240-b60c85f5d119)


AFTER:

![Screenshot 2025-02-19 at 4 44
53 PM](https://github.com/user-attachments/assets/ac62e141-da87-4463-a5f9-d15477951bb7)


Fixes https://github.com/flutter/flutter/issues/136319
Fixes https://github.com/flutter/flutter/issues/154162

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-02-21 00:51:28 +00:00
Jim Graham
d0e2fc72bc
[DisplayList] Migrate rendering tests and benchmarks to DL geometry (#163766) 
Migrating the benchmark and rendering tests to using DL geometry with DL
rendering calls.
 2025-02-21 00:15:39 +00:00
NabilaWorks
d4c86003d9
WebKit should respect TextCapitalization.words (#161027) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

Fixes https://github.com/flutter/flutter/issues/151118



https://github.com/user-attachments/assets/88a9baf9-8f2c-48fb-ad9c-1618fbce0795


Flutter web apps on iOS were forced to use `sentences` instead of
`words` when `TextCapitalization.words` was specified, in order to work
around this particular bug :
https://bugs.webkit.org/show_bug.cgi?id=148504

That bug was fixed more than 4 years ago so it should be safe to use
`words` now.

With this change, legacy devices that are still on specific versions on
iOS 13 or lower might experience the old WebKit bug when
`TextCapitalization.words` is used, however the Flutter developer who
expects such users can work around that bug by detecting the user agent
and using `TextCapitalization.sentences` conditionally, in order to get
the existing behavior prior to this change.



## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
 2025-02-21 00:04:00 +00:00
Matan Lurey
177b7e6091
Restore linux_android_emulator_tests to CI. (#163747) 
Closes https://github.com/flutter/flutter/issues/163742.

Removed JSON files for testing emulator API variations (that was only
applicable for Scenario App).
 2025-02-20 22:34:34 +00:00
Yegor
9b356c17c3
introduce system color palette (#163335) 
Introduce system colors:

* Add new `SystemColor` class.
* Add `PlatformDispatcher.systemColors` getter.

The web engine part for https://github.com/flutter/flutter/issues/118853
 2025-02-20 22:32:06 +00:00
engine-flutter-autoroll
5ce2ad9158
Roll Dart SDK from 2cecb16348e4 to 557cbf2c7da6 (3 revisions) (#163705) 
https://dart.googlesource.com/sdk.git/+log/2cecb16348e4..557cbf2c7da6

2025-02-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-119.0.dev
2025-02-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-118.0.dev
2025-02-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-117.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jacksongardner@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-20 17:30:51 +00:00
Jonah Williams
90d7ced2e7
[iOS] remove Skia interfaces from iOS platform code. (#163505) 
Skia can no longer be enabled on iOS. Remove software and skia surfaces,
references to GrContext.
 2025-02-20 15:37:19 +00:00
Matej Knopp
e6c333b555
[windows] Implement merged UI and platform thread (#162935) 
Original issue: https://github.com/flutter/flutter/issues/150525

Thread merging is currently disabled by default. 
It is controlled from the application through `DartProject`:
```cpp
flutter::DartProject project(L"data");
// Enables running UI isolate on platform thread
project.set_merged_platform_ui_thread(true);
```
Required changes to windows embedder: 
- Resize synchronization no longer blocks on condition variable, instead
it polls the Flutter run loop (ignoring other windows messages) until
the frame is available. This way resize synchronization works with both
thread merging enabled and disabled.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
 2025-02-20 10:33:13 +00:00
Jonah Williams
72cc1d198c
[iOS] always post new task during gesture dispatch. (#163646) 
Fixes https://github.com/flutter/flutter/issues/163429

If we synchronously call into dart ui when dispatching pointer events,
then we only end up scheduling about ~half as many frames as we should.
Nothing is blocked, no task starvation, et cetera. It should always be
safe to post pointer events as a new task instead.
 2025-02-19 22:52:07 +00:00
Jim Graham
99ac47897e
Reland "[Impeller] add support for rational bezier conics to Path (#63282)" (#163645) 
Reverts flutter/flutter#163624
Relands https://github.com/flutter/flutter/pull/163282

Add basic support for storing rational bezier conics in impeller::Path.
The support is very thin and just degrades the conics into a pair of
quadratic curves just as Impeller has always done for the conic segments
that it receives via SkPath objects, but it puts in place the framework
for eventually handling the conics more directly and allows the unit
tests to be rewritten on top of Impeller paths rather than SkPaths,
paving the way for reduced internal API dependencies.
 2025-02-19 21:54:08 +00:00
Yegor
7e297c29f8
[web:a11y] wheel events switch to pointer mode (#163582) 
Fixes https://github.com/flutter/flutter/issues/159358
 2025-02-19 21:33:04 +00:00
Dimitar Kyurtov
3d2ab872b8
replace deprecated [UIScreen mainScreen] in iOS (#162785) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

1. Replaced `mainScreen` in `FlutterPlatformViewsController` with the
`screeScale` of the `screen` that the `flutterViewController` is
attached to. Updated API usage of `FlutterClippingMaskViewPool` and
`OverlayLayerPool` by providing the correct `screenScale` from the
screen that the `flutterViewController` is attached to.
2. Replaced `mainScreen` in `OverlayLayerPool` by adding an API for the
`screenScale` to be provided by the class user.
3. Replaced `mainScreen` in `FlutterClippingMaskViewPool` by adding an
API for the `screenScale` to be provided by the class user.
4. Replaced `mainScreen` in `FlutterPlatformViewsTest` by adding a
mocked `FlutterViewController` which has a mocked `screen` with a mocked
`screenScale`. The `flutterViewController` is then provided the to the
`flutterPlatformViewsController`.

All of the above changes allow platform views and their overlays
displayed on an external screen to be properly scaled when rendered.

Fixes #130832. I believe this fixed #130825 since
FlutterPlatformViews_Internal.mm does not exist but the definition of
the interfaces declared in FlutterPlatformViews_Internal.h are part of
the files modified by this pr. This pr also replaces `mainScreen` in
`overlay_layer_pool.mm`.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I updated/added new tests to check the change I am making, or this
PR is [test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-02-19 20:41:44 +00:00
Jason Simmons
b4d05f4867
Manual roll of Dart SDK from 023ac80cef14 to 2cecb16348e4 (#163621) 2025-02-19 20:37:35 +00:00
Jonah Williams
408cbaf233
[Impeller] ensure that OpenGL "flipped" textures do not leak via texture readback. (#163501) 
Fixes https://github.com/flutter/flutter/issues/163315
Fixes https://github.com/flutter/flutter/issues/163521
Fixes https://github.com/flutter/flutter/issues/142641

OpenGL has an inverted coordinate system (bottom left is zero) compared
to Metal/Vulkan (top left is zero). We handle this by rendering things
upside down on OpenGL. Unfortunately this can leak out of the renderer
via readback (toImage), so we need to make sure to undo the inversion.

This is not performed for the "TextureCoordinateSystem::kUploadFromHost"
state as that indicates the texture is already "right side up".
 2025-02-19 20:07:07 +00:00
Paul Sturm
6ac63dc0fc
Hot Restart should dispose all previous Platform Views (macOS) (#163439) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

When using Platform Views on macOS, performing a Hot Restart throws an
exception with message "trying to create an already created view". This
is because the old Platform Views are not cleaned up. So, here we
dispose of the old Platform Views as part of the Hot Restart process.

Fixes issue: https://github.com/flutter/flutter/issues/110381

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-02-19 20:02:57 +00:00
Matan Lurey
78d0f5f0f6
Remove duplicate sources in the web_sdk. (#163636) 
Post-submit feedback on https://github.com/flutter/flutter/pull/163015.
 2025-02-19 19:59:12 +00:00
Matan Lurey
485c9105fc
Revert "[Impeller] add support for rational bezier conics to Path (#63282)" (#163624) 
This reverts commit db0bdfd117077a69f79ce0d4c03ab387a78ef7dd to fix a
tree breakage.
 2025-02-19 18:51:42 +00:00
Jonah Williams
e7d167cca2
[android] use macro definition to shrink repetitive JNI code size. (#163395) 
But less code!
 2025-02-18 21:31:36 +00:00
Mouad Debbar
4be1b57d50
[web] Cleanup everything HTML from the engine (outside html/ folder) (#162840) 
Things being cleaned up:

- Remove `flutter.js` support for HTML/AUTO renderers.
- Delete the renderer auto-detection logic and flag.
- Remove references to the `HtmlRenderer` from renderer-agnostic code.
- Remove the `auto-selected`/`requested explicitly` info from the DOM.

As a follow up to this, I'll create another PR that deletes the entire
`html/` folder.
 2025-02-18 21:28:24 +00:00
Jim Graham
db0bdfd117
[Impeller] add support for rational bezier conics to Path (#163282) 
Add basic support for storing rational bezier conics in impeller::Path.
The support is very thin and just degrades the conics into a pair of
quadratic curves just as Impeller has always done for the conic segments
that it receives via SkPath objects, but it puts in place the framework
for eventually handling the conics more directly and allows the unit
tests to be rewritten on top of Impeller paths rather than SkPaths,
paving the way for reduced internal API dependencies.
 2025-02-18 21:20:50 +00:00
Chinmay Garde
a16c447abc
[Impeller] Don't create a redundant typography context. (#163513) 
This was a typo that caused a typography context to be created, its
validity checked, but the context not actually used. Instead returning a
new one.

No change in functionality.
 2025-02-18 19:05:10 +00:00
engine-flutter-autoroll
9fc779960c
Roll Dart SDK from fcef25f18e4d to 023ac80cef14 (1 revision) (#163110) 
https://dart.googlesource.com/sdk.git/+log/fcef25f18e4d..023ac80cef14

2025-02-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-92.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-18 18:58:17 +00:00
Jonah Williams
063d0da3c0
[Impeller] when binding to READ_FRAMEBUFFER, treat multisampled textures as single sampled. (#163345) 
I noticed this causes crashes when doing readback, but only on some
deivces. I suspect that this is the more correct binding choice, and
other drivers are just more lenient.
 2025-02-18 18:20:09 +00:00
Robert Ancell
5365993ff5
Replace hard coded numbers with mouse button defines (#163503) 
No behaviour change, just for clarity.
 2025-02-18 14:36:46 +00:00
Harry Terkelsen
92281aae46
[canvaskit] Handle MakeGrContext returning null (#163332) 
Mark up the CanvasKit binding API to acknowledge that `MakeGrContext`
can return null.

Towards https://github.com/flutter/flutter/issues/162868

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-02-14 23:36:26 +00:00
chunhtai
644e46a3b3
Adds all semantics roles (#163075) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
This pr adds all the roles enum in one go without actually wiring up to
framework and engine.
It serves the following purposes
1. reduce pr conflict when multiple people working on adding new enum in
the list
2. help with IDE and google test as these enum will be added in the
latest engine binary after it merge.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-02-14 21:11:20 +00:00
engine-flutter-autoroll
14c585b5c2
Roll Skia from 20924303cc25 to 13a3b6f34ee8 (1 revision) (#163336) 
https://skia.googlesource.com/skia.git/+log/20924303cc25..13a3b6f34ee8

2025-02-14 kjlubick@google.com Remove unnecessary parameter in blur mask
code

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jamesgk@google.com,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-14 21:05:25 +00:00
Jonah Williams
3e219d1cd8
[Impeller] don't use glFramebufferBlit for onscreen restore. (#163327) 
With the OpenGLES backend, we use the MSAA render to texture extension.
This means that the offscreen textures are multisample and implicitly
resolved when sampled from. This implicit resolve does not occur in the
blit command used to restore to the onscreen, which can trigger a crash
in the GLES driver.

In other backends, the onscreen is also multisample and the blit is OK.

Fixes https://github.com/flutter/flutter/issues/163304
 2025-02-14 19:59:39 +00:00
gaaclarke
f949d8eaed
Tweaked TextContents math to avoid floating point errors (#162480) 
This gets rid of artifacts in characters.

## before

![before_445](https://github.com/user-attachments/assets/c66d3d22-baaf-4d66-bff3-3ad5b4d5747c)

## after

![after_445](https://github.com/user-attachments/assets/0e23a593-b68a-4334-a82e-4f7dc1ecdc17)


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-02-14 17:21:30 +00:00
Hannah Jin
7cf38fd93c
Add table related semantics role (#162339) 
issue: https://github.com/flutter/flutter/issues/45205

This PR added roles: table,cell,row,columnheader in engine side. 

Also added table, cell , columnheader in framework widgets `Table` and
`DataTable`.

This PR didn't add `row` in framework side because right now TableCell
is ParentDataWidget expecting its parent to be a Table, tableRow is not
a widget or a renderObject, but just some data. If we want to add a role
to `row`, we need to do some refactor to `TableCell`, `TableRow` and
`Table`. If we need to add row, I will do that in another PR.




## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-02-14 02:01:28 +00:00
Jason Simmons
0fc52bc91f
[Impeller] Call glDebugMessageControlKHR only if the KHR_debug extension is available (#163273) 
Fixes https://github.com/flutter/flutter/issues/163269
 2025-02-14 01:58:51 +00:00
engine-flutter-autoroll
5e5f6080a1
Roll Skia from 748415976ad1 to 5a38d23ee247 (3 revisions) (#163271) 
https://skia.googlesource.com/skia.git/+log/748415976ad1..5a38d23ee247

2025-02-13 robertphillips@google.com [graphite] Split out factories for
reused runtime effects
2025-02-13 egdaniel@google.com [Graphite] Add param to ask for
Discardable DepthStencil from caps.
2025-02-13 nscobie@google.com Add trace event to
StrikeCache::internalPurge

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jamesgk@google.com,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-14 00:49:57 +00:00
Harry Terkelsen
934af97328
[canvaskit] Use transferToImageBitmap instead of createImageBitmap (#163175) 
Use `transferToImageBitmap` instead of `createImageBitmap` if we have an
`OffscreenCanvas`.

Now that we are sizing the `OffscreenCanvas` exactly to the frame size,
we can use `transferToImageBitmap`, which should be zero-copy and
therefore faster than `createImageBitmap`. In testing, this speeds
things up a little bit but we still drop frames compared to
multi-Surface rasterization.

Helps with https://github.com/flutter/flutter/issues/162618

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-02-14 00:32:07 +00:00
Jackson Gardner
7d22606cda
[skwasm] Use transferToImageBitmap instead of createImageBitmap (#163251) 
Harry had investigated that on the CanvasKit side, that this was a bit a
faster than the `createImageBitmap` approach when dealing with multiple
DOM canvases. Also, it appears that Safari is significantly faster at
`transferToImageBitmap` compared to `createImageBitmap`, so this might
make porting skwasm to Safari a bit more feasible. Either way, we should
validate the performance and make sure this doesn't actually make
anything slower.
 2025-02-14 00:32:07 +00:00
Matan Lurey
9ffdd3a0ec
Show 'started' messages, explain how to debug hangs in the Android JUnit tests (#163242) 
There is more work to do, i.e.
https://github.com/flutter/flutter/issues/163239, to make this a better
experience, but better than nothing.
 2025-02-13 22:50:09 +00:00
engine-flutter-autoroll
f3bdcbda58
Roll Skia from 0f2500a715c3 to 748415976ad1 (10 revisions) (#163256) 
https://skia.googlesource.com/skia.git/+log/0f2500a715c3..748415976ad1

2025-02-13 danieldilan@google.com Roll dng_sdk to latest in Android and
remove obsolete workaround
2025-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 3c7761e2d611 to 5cc3a63e8fdb (4 revisions)
2025-02-13 jmbetancourt@google.com Dump Android stack trace before
rebooting test devices
2025-02-13 egdaniel@google.com [Graphite] Add caching of framebuffers in
Vulkan backend.
2025-02-13 egdaniel@google.com [Graphite] Add dawn
disable_lazy_clear_for_mapped_at_creation_buffer toggle
2025-02-13 nicolettep@google.com [graphite] Define a DrawPassCommand to
add barriers
2025-02-13 drott@chromium.org [Fontations-backend] Roll Fontations,
Skrifa to 0.28
2025-02-13 robertphillips@google.com [graphite] Fix RenderPassDesc
serialization
2025-02-13 jvanverth@google.com Revert "[graphite] Re-enable clip atlas
with some validation checks."
2025-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 706e3be9d658 to c8049a47d3fe (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jamesgk@google.com,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-02-13 21:51:15 +00:00
Jonah Williams
128caa701f
[Impeller] disable Vulkan on known bad exynos SoCs. (#163236) 
The common theme in:
  * https://github.com/flutter/flutter/issues/160854
  * https://github.com/flutter/flutter/issues/160804
  * https://github.com/flutter/flutter/issues/158091
  
Is that the Samsung exynos chipset has problems with AHB imports.
Unfortunately some of the reported bugs are hard crashes/. While I
couldn't reproduce the crash itself, it does indicate to me that
attempting to feature detect if AHB imports work is probably too risky
(and potentially slow, as we'd have to do a read back).
 
While the Vulkan drivers otherwise work, the deivces in question are not
able to reliably import AHBs which prevents platform views from working.
 
This may not fix all issues as there could be different SoC models that
also have problems. I considered removing 29 support as well, but there
are a large number of APi 29 devices that work fine.
 2025-02-13 21:01:37 +00:00