29915 Commits

Author SHA1 Message Date
Jason Simmons
ce659cda5e
[Impeller] Ensure that texture coordinate coverage and gradient color source sizes used by DrawVertices are nonempty (#163177)
Fixes https://github.com/flutter/flutter/issues/162969
2025-02-13 20:04:08 +00:00
gaaclarke
bffedc7f2c
Backfill subpixel unit tests (#162710)
issue: https://github.com/flutter/flutter/issues/149652

I made these unit tests while investigating a fix for
https://github.com/flutter/flutter/issues/149652. The fixes have already
landed with different tests. I figured I'd land these too since they
were helpful to me.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-13 18:40:46 +00:00
Jonah Williams
1cd3ab16ca
[android] correct API availibility checks for hcpp. (#163226)
This fixes the HCPP crashes in devicelab by correctly disabling HCPP for
devices that are < API level 34. Unfortunately this means we can't
benchmark on CI until we update the devices.
2025-02-13 17:39:48 +00:00
Robert Ancell
4cc9db4125
Move FlTextInputHandler from FlView (#162131)
This moves the final part of the keyboard handling from FlView to the
FlEngine and means keyboard should work correctly with multiple views.
2025-02-13 02:30:33 +00:00
Jonah Williams
a0dca0c30a
[Android] add missing null check to java object for hcpp mode. (#163165)
This can be hit if the FlutterJNI has been disconnected. In this case,
it is correct to return a nullptr as the engine can create its own
trasnaction.
2025-02-13 00:58:48 +00:00
engine-flutter-autoroll
c4d53f1d79
Roll Skia from f31c733c86c4 to a6de5c85d540 (14 revisions) (#163164)
https://skia.googlesource.com/skia.git/+log/f31c733c86c4..a6de5c85d540

2025-02-12 michaelludwig@google.com [graphite] Consolidate Utils/Types
headers
2025-02-12 kjlubick@google.com Remove references to .riv files
2025-02-12 egdaniel@google.com [Graphite] Allow MSAA on imagination
GPUs.
2025-02-12 nicolettep@google.com [graphite] Pass in dst texture
information to Caps when determining DstReadStrategy
2025-02-12 kjlubick@google.com Add util for dumping a buffer (e.g. mask)
2025-02-12 nscobie@google.com Upstream: Enabled CtsSkQPTestCases for
visible background users
2025-02-12 jvanverth@google.com [graphite] Re-enable clip atlas with
some validation checks.
2025-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from e5091a671b6f to 7379a582d0b4
2025-02-12 alecmouri@google.com Support ISO gainmap colorspace in PNG
2025-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 7164021c9e32 to e2163451af70 (3 revisions)
2025-02-12 danieldilan@google.com [png] Check interlacedBuffer full size
+ add early exit path
2025-02-12 robertphillips@google.com [graphite] Gracefully fail Pipeline
key serialization
2025-02-12 drott@chromium.org Prepare Fontations roll by allowing use of
deprecated functions
2025-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from ef2ef1072427 to 706e3be9d658 (19 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jamesgk@google.com,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-12 23:27:24 +00:00
Jonah Williams
a7a4da95c9
[Android] increment shared_ptr for jni impl. (#163152)
More speculative fixes for crashing. Since we were closing over a ref,
maybe it is nullptr? Lets check with an FML_CHECK too.
2025-02-12 20:49:48 +00:00
Jason Simmons
0f801f8dbd
[Impeller] In Paint::CreateContents, do not set a color source size if the size is empty (#163099)
The Canvas::DrawVertices lazy texture function will be unable to create
a snapshot based on an empty color source size.

See https://github.com/flutter/flutter/issues/162969
2025-02-12 19:41:01 +00:00
Harry Terkelsen
512d1d58ff
[canvaskit] Add configuration option to force multi-Surface rendering (#163087)
Adds a configuration option `canvasKitForceMultiSurfaceRasterizer` and
associated environment variable
`FLUTTER_WEB_CANVASKIT_FORCE_MULTI_SURFACE_RASTERIZER` to force the
CanvasKit renderer to use `MultiSurfaceRasterizer`.

This allows us to easily create reproduction apps for
https://github.com/flutter/flutter/issues/162618 to show to the Chrome
team.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-12 19:39:23 +00:00
Matej Knopp
1023664651
[Embedder] Detect and ignore stale task runner tasks (#163129)
Fixes https://github.com/flutter/flutter/issues/163104

The core issue is that `EmbedderTaskRunner` can schedule things in
advance, but there is no checking if the task is stale when executing
it. It is possible that `FlutterEngineRunTask` will attempt to run the
task on engine that is non null but already being deallocated.

This in not a problem for raster and platform task runners, because
raster task runner shouldn't have any scheduled tasks after shutdown and
platform task runner executes the shutdown process, so the pointer is
always either valid or null, but it is an issue for custom
`ui_task_runner`, because it may be calling `FlutterEngineRunTask` with
engine pointer that is not yet null but already shutting down.

The proposed solution is to assign a unique identifier for each
`EmbedderTaskRunner`, use this identifier as the `runner` field inside
`FlutterTask` instead of casting the address of the runner, and verify
that this identifier is valid inside `FlutterEngineRunTask` before
calling anything on the engine.

Special care needs to be done to not invalidate the unique identifier
while `ui_task_runner` is running a task as it may lead to raciness. See
`EmbedderEngine::CollectThreadHost()`.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-12 19:16:45 +00:00
Tong Mu
ef927e85d5
[Impeller] Add RoundSuperellipse class, containment check and stroking (#162826)
This PR:
* Adds a `RoundSuperellipse` class, which mirrors the current
`RoundRect` class.
* Implements `RoundSuperellipse::Contains`, which checks if a point is
contained by the RSE.
* Adds `Path::AddSuperellipse`, which draws an RSE with Bezier
approximation.
* Adds a `RoundSuperellipseParam` class, which is the common computation
shared by geometry drawing, stroking, and containment check.


https://github.com/user-attachments/assets/883c7762-7b35-432e-9b31-d204db3bd6e1


This PR also updates the RSE algorithm according to my recent research,
which uses one fewer precomputed variable (no more `d`), shares the same
gap factor with RRect, and allows much better precision. The result
shape is almost unchanged (~0.2% slimmer).

> For reviewers: The `RoundSuperellipseParam` and
`RoundSuperellipse::Contains` parts are repurposed from the abandoned
https://github.com/flutter/flutter/pull/162349. This PR is a preparation
for https://github.com/flutter/flutter/pull/160883.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-12 17:45:56 +00:00
Jonah Williams
ad74f9f0cd
[android] speculative fix for hcpp crashes. (#163108)
The crash indicates that FlutterJNI is returning a nullptr
SurfaceControl.Transaction. That likely indicates that we're trying to
rasterize a frame before the platform view controller is setup.
Potentially a startup race?

At any rate, if the PVC is null that means there is no platform views -
so it should be safe to create a tx on the fly. Interestingly I cannot
repro this locally even on the same device.

```
[2025-02-11 21:50:37.462356] [STDOUT] stdout: [ +173 ms] *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
[2025-02-11 21:50:37.462539] [STDOUT] stdout: [        ] Build fingerprint: 'google/cheetah/cheetah:13/TQ3A.230901.001/10750268:user/release-keys'
[2025-02-11 21:50:37.462564] [STDOUT] stdout: [        ] Revision: 'MP1.0'
[2025-02-11 21:50:37.463914] [STDOUT] stdout: [   +1 ms] ABI: 'arm64'
[2025-02-11 21:50:37.463946] [STDOUT] stdout: [        ] Timestamp: 2025-02-11 21:57:42.183302140-0800
[2025-02-11 21:50:37.463959] [STDOUT] stdout: [        ] Process uptime: 3s
[2025-02-11 21:50:37.464054] [STDOUT] stdout: [        ] Cmdline: dev.benchmarks.platform_views_layout
[2025-02-11 21:50:37.464174] [STDOUT] stdout: [        ] pid: 15185, tid: 15246, name: 1.raster  >>> dev.benchmarks.platform_views_layout <<<
[2025-02-11 21:50:37.464354] [STDOUT] stdout: [        ] uid: 10250
[2025-02-11 21:50:37.464398] [STDOUT] stdout: [        ] tagged_addr_ctrl: 0000000000000001 (PR_TAGGED_ADDR_ENABLE)
[2025-02-11 21:50:37.464440] [STDOUT] stdout: [        ] signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0000000000000000
[2025-02-11 21:50:37.464602] [STDOUT] stdout: [        ] Cause: null pointer dereference
[2025-02-11 21:50:37.464651] [STDOUT] stdout: [        ]     x0  b400007b82ff2e70  x1  000000000000002d  x2  b400007c3309f370  x3  0000007abbcc6a23
[2025-02-11 21:50:37.464745] [STDOUT] stdout: [        ]     x4  0000007a30d286b0  x5  0000007a4f6dd47b  x6  0000000000000000  x7  61686b4b11ff3a78
[2025-02-11 21:50:37.464831] [STDOUT] stdout: [        ]     x8  0000000000000000  x9  1417c2bd490e1f78  x10 0000000000000010  x11 000000000000009c
[2025-02-11 21:50:37.464933] [STDOUT] stdout: [        ]     x12 0000000000000adb  x13 b400007ba2fe9510  x14 0000000000000e6b  x15 b400007ba2fe9510
[2025-02-11 21:50:37.465012] [STDOUT] stdout: [        ]     x16 0000000000000001  x17 0000000000000067  x18 0000007a2f996000  x19 b400007b82ff2e70
[2025-02-11 21:50:37.465082] [STDOUT] stdout: [        ]     x20 000000000000002d  x21 b400007ae3064b60  x22 b400007af30d0fa8  x23 0000000000000001
[2025-02-11 21:50:37.465155] [STDOUT] stdout: [        ]     x24 0000007a30d2a000  x25 b400007b73028fb0  x26 0000007a3a22da20  x27 000000003b9bf6c8
[2025-02-11 21:50:37.465235] [STDOUT] stdout: [        ]     x28 b400007af30d0fa8  x29 b400007ad3022cd0
[2025-02-11 21:50:37.465318] [STDOUT] stdout: [        ]     lr  0000007a3a8c7918  sp  0000007a30d28940  pc  0000000000000000  pst 0000000040001000
[2025-02-11 21:50:37.465401] [STDOUT] stdout: [        ] backtrace:
[2025-02-11 21:50:37.465491] [STDOUT] stdout: [        ]       #00 pc 0000000000000000  <unknown>
[2025-02-11 21:50:37.465596] [STDOUT] stdout: [        ]       #01 pc 000000000088b914  /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (flutter::PlatformViewAndroidJNIImpl::createTransaction()+104) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1)
[2025-02-11 21:50:37.465688] [STDOUT] stdout: [        ]       #02 pc 000000000087f738  /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (std::_fl::__function::__func<flutter::AndroidSurfaceVKImpeller::SetNativeWindow(fml::RefPtr<flutter::AndroidNativeWindow>, std::_fl::shared_ptr<flutter::PlatformViewAndroidJNI> const&)::$_0, std::_fl::allocator<flutter::AndroidSurfaceVKImpeller::SetNativeWindow(fml::RefPtr<flutter::AndroidNativeWindow>, std::_fl::shared_ptr<flutter::PlatformViewAndroidJNI> const&)::$_0>, impeller::android::SurfaceTransaction ()>::operator()()+16) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1)
[2025-02-11 21:50:37.465785] [STDOUT] stdout: [        ]       #03 pc 0000000000bdbf1c  /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (std::_fl::__function::__func<impeller::AHBSwapchainImplVK::AcquireNextDrawable()::$_0, std::_fl::allocator<impeller::AHBSwapchainImplVK::AcquireNextDrawable()::$_0>, bool ()>::operator()()+1716) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1)
[2025-02-11 21:50:37.465874] [STDOUT] stdout: [        ]       #04 pc 0000000000b1d180  /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (flutter::SurfaceFrame::Submit()+148) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1)
[2025-02-11 21:50:37.465989] [STDOUT] stdout: [        ]       #05 pc 0000000000beb2b4  /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (flutter::Rasterizer::DrawToSurfacesUnsafe(flutter::FrameTimingsRecorder&, std::_fl::vector<std::_fl::unique_ptr<flutter::LayerTreeTask, std::_fl::default_delete<flutter::LayerTreeTask> >, std::_fl::allocator<std::_fl::unique_ptr<flutter::LayerTreeTask, std::_fl::default_delete<flutter::LayerTreeTask> > > >)+1284) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1)
[2025-02-11 21:50:37.466400] [STDOUT] stdout: [        ]       #06 pc 0000000000beac58  /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (flutter::Rasterizer::DrawToSurfaces(flutter::FrameTimingsRecorder&, std::_fl::vector<std::_fl::unique_ptr<flutter::LayerTreeTask, std::_fl::default_delete<flutter::LayerTreeTask> >, std::_fl::allocator<std::_fl::unique_ptr<flutter::LayerTreeTask, std::_fl::default_delete<flutter::LayerTreeTask> > > >)+112) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1)
[2025-02-11 21:50:37.466444] [STDOUT] stdout: [        ]       #07 pc 0000000000bec144  /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (std::_fl::__function::__func<flutter::Rasterizer::Draw(std::_fl::shared_ptr<flutter::Pipeline<flutter::FrameItem> > const&)::$_0, std::_fl::allocator<flutter::Rasterizer::Draw(std::_fl::shared_ptr<flutter::Pipeline<flutter::FrameItem> > const&)::$_0>, void (std::_fl::unique_ptr<flutter::FrameItem, std::_fl::default_delete<flutter::FrameItem> >)>::operator()(std::_fl::unique_ptr<flutter::FrameItem, std::_fl::default_delete<flutter::FrameItem> >&&)+192) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1)
[2025-02-11 21:50:37.466468] [STDOUT] stdout: [        ]       #08 pc 0000000000bebc48  /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (flutter::Rasterizer::Draw(std::_fl::shared_ptr<flutter::Pipeline<flutter::FrameItem> > const&)+360) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1)
[2025-02-11 21:50:37.466521] [STDOUT] stdout: [        ]       #09 pc 0000000000bf9f7c  /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (std::_fl::__function::__func<fml::internal::CopyableLambda<flutter::Shell::OnAnimatorDraw(std::_fl::shared_ptr<flutter::Pipeline<flutter::FrameItem> >)::$_0>, std::_fl::allocator<fml::internal::CopyableLambda<flutter::Shell::OnAnimatorDraw(std::_fl::shared_ptr<flutter::Pipeline<flutter::FrameItem> >)::$_0> >, void ()>::operator()()+84) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1)
[2025-02-11 21:50:37.466543] [STDOUT] stdout: [        ]       #10 pc 00000000008a09ec  /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (fml::MessageLoopImpl::RunExpiredTasksNow()+728) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1)
[2025-02-11 21:50:37.466667] [STDOUT] stdout: [        ]       #11 pc 00000000008a4600  /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (fml::MessageLoopAndroid::MessageLoopAndroid()::$_0::__invoke(int, int, void*)+84) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1)
[2025-02-11 21:50:37.466746] [STDOUT] stdout: [        ]       #12 pc 0000000000011178  /system/lib64/libutils.so (android::Looper::pollOnce(int, int*, int*, void**)+808) (BuildId: 0b4a793fa8045c04066d988c68bac8bb)
[2025-02-11 21:50:37.466784] [STDOUT] stdout: [        ]       #13 pc 00000000000185e4  /system/lib64/libandroid.so (ALooper_pollOnce+100) (BuildId: 682dab490c18361d5d6527bcdd86cdfa)
[2025-02-11 21:50:37.466865] [STDOUT] stdout: [        ]       #14 pc 00000000008a470c  /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (fml::MessageLoopAndroid::Run()+28) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1)
[2025-02-11 21:50:37.466903] [STDOUT] stdout: [        ]       #15 pc 00000000008a283c  /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (std::_fl::__function::__func<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0, std::_fl::allocator<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0>, void ()>::operator()()+116) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1)
[2025-02-11 21:50:37.466943] [STDOUT] stdout: [        ]       #16 pc 00000000008a2670  /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)::$_0::__invoke(void*)+8) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1)
[2025-02-11 21:50:37.467002] [STDOUT] stdout: [        ]       #17 pc 00000000000c226c  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+204) (BuildId: dc4001c2ef2dfc23467040797a96840c)
[2025-02-11 21:50:37.467058] [STDOUT] stdout: [        ]       #18 pc 0000000000054a30  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64) (BuildId: dc4001c2ef2dfc23467040797a96840c)
[2025-02-11 21:50:37.525275] [STDOUT] stdout: [  +57 ms] 00:00 +0 -1: scrolling performance test (setUpAll) [E]
```
2025-02-12 17:37:08 +00:00
auto-submit[bot]
e8f34a9eea
Reverts "Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (#163127)" (#163133)
<!-- start_original_pr_link -->
Reverts: flutter/flutter#163127
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: zanderso
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: The whole tree is red
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: engine-flutter-autoroll
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {fluttergithubbot}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:

https://skia.googlesource.com/skia.git/+log/f31c733c86c4..25937c31f153

2025-02-12 drott@chromium.org Prepare Fontations roll by allowing use of
deprecated functions
2025-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from ef2ef1072427 to 706e3be9d658 (19 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jamesgk@google.com,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-02-12 14:51:20 +00:00
engine-flutter-autoroll
cdce765847
Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (#163127)
https://skia.googlesource.com/skia.git/+log/f31c733c86c4..25937c31f153

2025-02-12 drott@chromium.org Prepare Fontations roll by allowing use of
deprecated functions
2025-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from ef2ef1072427 to 706e3be9d658 (19 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jamesgk@google.com,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-12 12:48:21 +00:00
Jonny Wang
f43542d8d5
Update .ci.yaml to support Fuchsia cherrypick branches (#163000)
Fuchsia cherry-pick branches were previously created in flutter/engine,
and now need to be supported in flutter/flutter:
https://github.com/flutter/engine/blob/main/.ci.yaml#L11

Branch naming was changed from `fuchsia_rNN` to `fuchsia_fNN` (see
https://chat.google.com/room/AAAAT9RJL9Q/AnUIORFRVOM)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-02-12 10:44:08 +00:00
engine-flutter-autoroll
bfa9a4ed3f
Roll Skia from a9dbb2479c26 to 6f17f2ebb2e5 (2 revisions) (#163109)
https://skia.googlesource.com/skia.git/+log/a9dbb2479c26..6f17f2ebb2e5

2025-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from a1770b70c6be to 4111d9e10b6a (40 revisions)
2025-02-12 bungeman@google.com [pdf] Apply paint alpha to color shader
alpha

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jamesgk@google.com,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-12 07:38:23 +00:00
Jonah Williams
17ea9569da
[Impeller] mirror tile mode requires highp for Adreno. (#163066)
Fixes https://github.com/flutter/flutter/issues/162891

On Adreno GPU the mediump precision causes mirror to drop this number to
zero.
2025-02-12 04:15:07 +00:00
engine-flutter-autoroll
e924e8cb45
Roll Skia from 5b56d9a91633 to a9dbb2479c26 (6 revisions) (#163100)
https://skia.googlesource.com/skia.git/+log/5b56d9a91633..a9dbb2479c26

2025-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
jsfiddle-base from fb2d48f7af98 to 18808c894e65
2025-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from cd5e835851d1 to 7164021c9e32 (11 revisions)
2025-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
debugger-app-base from e9a6ea69ff3d to cc91ae26ecef
2025-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
shaders-base from 9481c3eb25d2 to 81fa6c51b85b
2025-02-11 michaelludwig@google.com Update rewrite_includes.py to
support duplicate header names
2025-02-11 bwils@google.com Manually trigger update of Skottie web.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jamesgk@google.com,jimgraham@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-12 04:00:17 +00:00
engine-flutter-autoroll
4120730a29
Roll Dart SDK from d9d7f103b6b7 to fcef25f18e4d (3 revisions) (#163098)
https://dart.googlesource.com/sdk.git/+log/d9d7f103b6b7..fcef25f18e4d

2025-02-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-91.0.dev
2025-02-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-90.0.dev
2025-02-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-89.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-12 03:30:07 +00:00
Matan Lurey
b728c4c06a
Remove unsound artifacts, remove *Sound qualifier. (#163015)
Towards https://github.com/flutter/flutter/issues/162846.

Removes all of the unsound host artifacts, and then uses their name for
the sound artifacts.

That is, for something like `webPlatformDDCKernelDill`, this PR:

- Changes the web GN builders to only emit the sound SDK, without the
`-sound` suffixes
- Deletes `webPlatformDDCKernelDill` and all usages of it (implicitly
unsound, and unused).
- Renames `webPlatformDDCKernelSoundDill` to `webPlatformDDCKernelDill`.

No user impact expected, as there was no way to use the unsound
artifacts from the Flutter tool.
2025-02-12 02:40:18 +00:00
Chinmay Garde
8c843aa9d3
[Impeller] libImpeller: Add support for Metal and Vulkan rendering. (#161547)
* Adds context creation and WSI routines for Metal and Vulkan.
* Enables all tests for the Metal, Vulkan, and OpenGLES backends.
* Separate standalone examples for Metal, Vulkan, and OpenGLES have been
created. These will be packaged with the SDK.
  * Disallows the use of OpenGL ES on macOS.
* All new public methods are documented.
* The SDK version number has been bumped.
* Some incorrect nullability annotations were patched.
* Tests harness is overhauled to reuse the same underlying context as
the playgrounds.
* The C++ public header has been updated.

Fixes https://github.com/flutter/flutter/issues/159512
Ports https://github.com/flutter/engine/pull/56906
2025-02-12 00:47:19 +00:00
Koji Wakamiya
80235272c9
fix: Dispose codec after completing frame creation (#159945)
ref https://github.com/flutter/flutter/issues/93404,
[comment](https://github.com/flutter/flutter/issues/93404#issuecomment-2525453113)
and
[comment](https://github.com/flutter/flutter/issues/93404#issuecomment-2547622795).

Added a process to call `ui.Codec`'s `dispose`.
With this change,
[HtmlBlobCodec](8e0993eda8/engine/src/flutter/lib/web_ui/lib/src/engine/html_image_element_codec.dart (L100))'s
dispose will be called in Safari when using CanvasKit, and
`revokeObjectURL` will be executed as expected.

* https://api.flutter.dev/flutter/dart-ui/Codec/dispose.html
* https://bugs.webkit.org/show_bug.cgi?id=31253
*
https://developer.mozilla.org/en-US/docs/Web/API/URL/createObjectURL_static
*
https://developer.mozilla.org/en-US/docs/Web/API/URL/revokeObjectURL_static

If this fix looks good, I will open the
https://github.com/flutter/flutter/pull/161481 to remove the
`AlearmClock` from the `BrowserImageDecoder`.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-11 23:20:06 +00:00
hellohuanlin
b37e7aaaab
[ios][secure_paste]show menu item based on info sent from framework (#161103)
This is moved from https://github.com/flutter/engine/pull/56362

*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-11 21:54:38 +00:00
sigmundch
2376fa02f1
Add new builder for experiment with dynamic modules. (#162855)
This adds a new flavor of android_release_arm64, which enables a build
flag. This is not part of the merge-queue since it's intended for
experimental and internal use at the moment.

Tested locally via `et build --config ci/android_release_arm64_ddm`

This is a first step to get a better gauge of the cost on the build. The
.json is identical to the android_release_arm64 configuration except for
2 new flags added (easier to diff locally). The .ci.yaml has additional
changes to make set this up as no backfill and no release.

cc @jtmcdole @jiahaog @andrewkolos

---------

Co-authored-by: Sigmund Cherem < 2049220+sigmundch@users.noreply.github.com>
2025-02-11 20:16:43 +00:00
Jason Simmons
6c9a555e56
Roll vulkan-deps to 9edf248c597b (#162549) 2025-02-11 19:52:47 +00:00
chunhtai
21471aa236
Adds dialog and alertdialog role (#162692)
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

fixes https://github.com/flutter/flutter/issues/162124
fixes https://github.com/flutter/flutter/issues/157207
fixes https://github.com/flutter/flutter/issues/157204

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-11 19:51:05 +00:00
engine-flutter-autoroll
04cbda2b1a
Roll Dart SDK from 99789828cc95 to d9d7f103b6b7 (12 revisions) (#163060)
https://dart.googlesource.com/sdk.git/+log/99789828cc95..d9d7f103b6b7

2025-02-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-88.0.dev
2025-02-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-87.0.dev
2025-02-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-86.0.dev
2025-02-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-85.0.dev
2025-02-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-84.0.dev
2025-02-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-83.0.dev
2025-02-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-82.0.dev
2025-02-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-81.0.dev
2025-02-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-80.0.dev
2025-02-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-79.0.dev
2025-02-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-78.0.dev
2025-02-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-77.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-11 19:51:04 +00:00
Jonah Williams
761c1623ca
[Android] fix hcpp overlay layer intersection. (#163024)
Since we only have a single overlay layer, we need to diff out the
platform views that _would_ intersect if we did the correct layering.
2025-02-11 17:13:19 +00:00
Matej Knopp
94cd4b14c9
[Embedder] Implement merged platform and UI thread (#162944)
Fixes https://github.com/flutter/flutter/issues/152337

Introduces `ui_task_runner` field on `FlutterCustomTaskRunners`. This
lets the embedder to specify task runner for UI isolate tasks, allowing
for merging platform and UI threads.

With custom UI task runner there is no `MessageLoop` anymore for the UI
thread, so the message loop task observer can no longer be used to flush
microtask queue. Instead the microtask queue is flushed at the end of
each `FlutterEngineRunTask` invocation if needed. This is handled
internally by the embedder.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2025-02-11 12:24:13 +00:00
Jonah Williams
7cd9e0f640
[Android] Remove overlay when platform views are removed from screen. (#162908)
When there are no more platform views, make sure the overlay layer is
hidden. When a platform view is added again, show the overlay. The
show/hide allows us to avoid continually recreating and destroying the
overlay surface + swapchain when a platform view slides in and out of
frame.

To further reduce memory usage, we could do a delayed de-allocation of
the overlay layer (say after 50 frames of no platform view, destroy it).
But I'm leaving this to a follow up.
2025-02-11 02:29:07 +00:00
Jason Simmons
2d39a739ea
Roll Dart to 3.8.0-76.0.dev (#162913)
https://dart.googlesource.com/sdk.git/+log/548dcc7a544dd23b8835be61e5d790d8001a2d0c..99789828cc95b713f33dfb7b19a6430f617ee9f2


[9978982](https://dart.googlesource.com/sdk.git/+/99789828cc95b713f33dfb7b19a6430f617ee9f2)
[Version
3.8.0-76.0.dev](https://dart.googlesource.com/sdk.git/+/99789828cc95b713f33dfb7b19a6430f617ee9f2)
by Dart CI · 4 hours ago
[lkgr-dev](https://dart.googlesource.com/sdk.git/+/refs/heads/lkgr-dev)
[3.8.0-76.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-76.0.dev)

[89af242](https://dart.googlesource.com/sdk.git/+/89af2425f23bfb127ab39c2f73e9149042715443)
[[ddc] Append hot restart instruction to hot reload rejection
reasons.](https://dart.googlesource.com/sdk.git/+/89af2425f23bfb127ab39c2f73e9149042715443)
by Nate Biggs · 6 hours ago

[3b42c4f](https://dart.googlesource.com/sdk.git/+/3b42c4fec851d0dc82fbc1c8c0ff93f6db52ffe9)
[Version
3.8.0-75.0.dev](https://dart.googlesource.com/sdk.git/+/3b42c4fec851d0dc82fbc1c8c0ff93f6db52ffe9)
by Dart CI · 8 hours ago
[3.8.0-75.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-75.0.dev)

[89e545c](https://dart.googlesource.com/sdk.git/+/89e545c5cc939f5861faace1d78252fd2aca834f)
[[dot-shorthands][co19] Rename enum-shorthands flag to dot-shorthands
(and roll co19 to
b14b080)](https://dart.googlesource.com/sdk.git/+/89e545c5cc939f5861faace1d78252fd2aca834f)
by Kallen Tu · 8 hours ago
[base](https://dart.googlesource.com/sdk.git/+/refs/heads/base)

[e0b0c33](https://dart.googlesource.com/sdk.git/+/e0b0c33937e783f8420884fdd4a7f3305640df47)
[[cfe] Remove nullaiblity requirement from shape sufficiency
checks](https://dart.googlesource.com/sdk.git/+/e0b0c33937e783f8420884fdd4a7f3305640df47)
by Chloe Stefantsova · 11 hours ago

[2c81261](https://dart.googlesource.com/sdk.git/+/2c81261f941db1717c2b975ef8395a96ca3b97b4)
[[cfe] Use last token for missing constructor
error](https://dart.googlesource.com/sdk.git/+/2c81261f941db1717c2b975ef8395a96ca3b97b4)
by Johnni Winther · 11 hours ago

[4c0121f](https://dart.googlesource.com/sdk.git/+/4c0121f2d3dd7ee33776d83f85f6ff1403aefc92)
[[cfe] Run ErrorCommentCheck
last](https://dart.googlesource.com/sdk.git/+/4c0121f2d3dd7ee33776d83f85f6ff1403aefc92)
by Johnni Winther · 13 hours ago

[26c5df2](https://dart.googlesource.com/sdk.git/+/26c5df200f796eb9cb6a5446dd3865430308fb39)
[Version
3.8.0-74.0.dev](https://dart.googlesource.com/sdk.git/+/26c5df200f796eb9cb6a5446dd3865430308fb39)
by Dart CI · 16 hours ago
[3.8.0-74.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-74.0.dev)

[19622c5](https://dart.googlesource.com/sdk.git/+/19622c5238bfeab0b7ebe45ae2ebea237e7a57f1)
[Update
issue-triage.yml](https://dart.googlesource.com/sdk.git/+/19622c5238bfeab0b7ebe45ae2ebea237e7a57f1)
by Devon Carew · 17 hours ago

[31ab99c](https://dart.googlesource.com/sdk.git/+/31ab99c258d15312c92920b938d7fbe524888909)
[Version
3.8.0-73.0.dev](https://dart.googlesource.com/sdk.git/+/31ab99c258d15312c92920b938d7fbe524888909)
by Dart CI · 20 hours ago
[3.8.0-73.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-73.0.dev)

[26b3e61](https://dart.googlesource.com/sdk.git/+/26b3e61ffe454fcf41dd628e868f0234143549a5)
[Prepare to publish analyzer 7.3.0 and _fe_analyzer_shared
80.0.0](https://dart.googlesource.com/sdk.git/+/26b3e61ffe454fcf41dd628e868f0234143549a5)
by Konstantin Shcheglov · 21 hours ago

[dd22a35](https://dart.googlesource.com/sdk.git/+/dd22a358a64010fa574e1e851a0ed0c00585965c)
[[dart2js] Adding some documentation on split
constraints.](https://dart.googlesource.com/sdk.git/+/dd22a358a64010fa574e1e851a0ed0c00585965c)
by Sigmund Cherem · 22 hours ago

[e962350](https://dart.googlesource.com/sdk.git/+/e962350dd658469eea8c3f4031d1f2d046bd6139)
[[dart2js] Simply is-test when type parameters not
needed](https://dart.googlesource.com/sdk.git/+/e962350dd658469eea8c3f4031d1f2d046bd6139)
by Stephen Adams · 23 hours ago

[27a58d9](https://dart.googlesource.com/sdk.git/+/27a58d9e2da681f2f1f7ed9cfcf168d36b9dfe59)
[Version
3.8.0-72.0.dev](https://dart.googlesource.com/sdk.git/+/27a58d9e2da681f2f1f7ed9cfcf168d36b9dfe59)
by Dart CI · 24 hours ago
[3.8.0-72.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-72.0.dev)

[7349ef5](https://dart.googlesource.com/sdk.git/+/7349ef5e1187c99a835f5f35466f1e5e37b0ca65)
[[analyzer] Fix message for
ENUM_WITHOUT_CONSTANTS](https://dart.googlesource.com/sdk.git/+/7349ef5e1187c99a835f5f35466f1e5e37b0ca65)
by Jaime Wren · 25 hours ago

[f4cfbf9](https://dart.googlesource.com/sdk.git/+/f4cfbf9cdce38b6cd59a740ca56dd3bf70ec48f9)
[Update create function fix to create an async function for await
expressions](https://dart.googlesource.com/sdk.git/+/f4cfbf9cdce38b6cd59a740ca56dd3bf70ec48f9)
by Jake Macdonald · 26 hours ago

[50f96d6](https://dart.googlesource.com/sdk.git/+/50f96d6e5b015bfc32fa7fbc9cdde6dbe48e4cce)
[Revert "[diagnostics] fix `removed_lint`
reporting"](https://dart.googlesource.com/sdk.git/+/50f96d6e5b015bfc32fa7fbc9cdde6dbe48e4cce)
by Phil Quitslund · 26 hours ago

[7559108](https://dart.googlesource.com/sdk.git/+/755910894551477f350da8bba3cb59a15d6a1ff4)
[[DAS] Tests for parameter
highlights](https://dart.googlesource.com/sdk.git/+/755910894551477f350da8bba3cb59a15d6a1ff4)
by FMorschel · 27 hours ago

[8dab178](https://dart.googlesource.com/sdk.git/+/8dab17891290f42242d4a2478f0bd7d5a1f09441)
[[dds/dap] Remove macro
tests](https://dart.googlesource.com/sdk.git/+/8dab17891290f42242d4a2478f0bd7d5a1f09441)
by Danny Tuppeny · 28 hours ago

[93847ce](https://dart.googlesource.com/sdk.git/+/93847ce649b21e8646eca74ace03597bf7a4c507)
[[productivity] server test launch config and generate
task](https://dart.googlesource.com/sdk.git/+/93847ce649b21e8646eca74ace03597bf7a4c507)
by pq · 28 hours ago

[dd4f341](https://dart.googlesource.com/sdk.git/+/dd4f341e157bb4c2114f3ed02ad6c022363e720a)
[[dart2bytecode] Add API to invoke dart2bytecode
programmatically](https://dart.googlesource.com/sdk.git/+/dd4f341e157bb4c2114f3ed02ad6c022363e720a)
by Alexander Markov · 31 hours ago

[c19f913](https://dart.googlesource.com/sdk.git/+/c19f913d50220a97e8bded07de33ba49ce9f88db)
[[co19] Roll co19 to
dd7fa9c980a47c5196c192046f5d4a43dbce70ef](https://dart.googlesource.com/sdk.git/+/c19f913d50220a97e8bded07de33ba49ce9f88db)
by Sergey G. Grekhov · 35 hours ago

[440593f](https://dart.googlesource.com/sdk.git/+/440593fe9d80b59017d8ba876b198f12c9cca0c9)
[[gardening] Mark test
slow](https://dart.googlesource.com/sdk.git/+/440593fe9d80b59017d8ba876b198f12c9cca0c9)
by Daco Harkes · 35 hours ago

[9200023](https://dart.googlesource.com/sdk.git/+/9200023b49f0f549494cc47564a2a075d2e14691)
[Use `AsyncError` more in future error
handling.](https://dart.googlesource.com/sdk.git/+/9200023b49f0f549494cc47564a2a075d2e14691)
by Lasse R.H. Nielsen · 35 hours ago

[7566327](https://dart.googlesource.com/sdk.git/+/756632700b856ec3b7b0d3573f60f95bc2b0072f)
[[deps] Update
benchmarks_internal](https://dart.googlesource.com/sdk.git/+/756632700b856ec3b7b0d3573f60f95bc2b0072f)
by Ömer Sinan Ağacan · 35 hours ago

[9f529ae](https://dart.googlesource.com/sdk.git/+/9f529aefc4df2662c9119336b6149ed0e7cb900e)
[[cfe] Add
TypeParameterFragment](https://dart.googlesource.com/sdk.git/+/9f529aefc4df2662c9119336b6149ed0e7cb900e)
by Johnni Winther · 2 days ago

[72963bf](https://dart.googlesource.com/sdk.git/+/72963bf6f0b4098bda46ee3a9a16f0d989936902)
[[dart2wasm] Fix inlining issue after introducing unchecked
entrypoints](https://dart.googlesource.com/sdk.git/+/72963bf6f0b4098bda46ee3a9a16f0d989936902)
by Martin Kustermann · 2 days ago

[e05a423](https://dart.googlesource.com/sdk.git/+/e05a423e049c8ea0193db1edd681d2f9f39771c9)
[[dart2wasm] Avoid extra global definitions for int constants that are
wasmI32.](https://dart.googlesource.com/sdk.git/+/e05a423e049c8ea0193db1edd681d2f9f39771c9)
by Nate Biggs · 2 days ago

[07b7cfe](https://dart.googlesource.com/sdk.git/+/07b7cfed076131afbb10b695bdcad75023305ace)
[New assist to add/edit `hide` at import for ambiguous
import](https://dart.googlesource.com/sdk.git/+/07b7cfed076131afbb10b695bdcad75023305ace)
by FMorschel · 2 days ago

[8aa6b41](https://dart.googlesource.com/sdk.git/+/8aa6b413ebe0986e8be47137409dd8ab3a8220a8)
[[ddc] Update hot reload test suite to use
recompile-restart](https://dart.googlesource.com/sdk.git/+/8aa6b413ebe0986e8be47137409dd8ab3a8220a8)
by Srujan Gaddam · 2 days ago

[4617198](https://dart.googlesource.com/sdk.git/+/4617198d58001a1192e829a65d53c5ad2c14e28d)
[[vm] Add option for GC at
[re]throw.](https://dart.googlesource.com/sdk.git/+/4617198d58001a1192e829a65d53c5ad2c14e28d)
by Ryan Macnak · 2 days ago

[3700d33](https://dart.googlesource.com/sdk.git/+/3700d3320375443d333fa559240e3fec247fbd95)
[Elements. Migrate
type_algebra_test.dart](https://dart.googlesource.com/sdk.git/+/3700d3320375443d333fa559240e3fec247fbd95)
by Konstantin Shcheglov · 2 days ago

[97772dd](https://dart.googlesource.com/sdk.git/+/97772dd77255b2959bb7539485db2293b3d74e64)
[[doc] Update GSoC
projects](https://dart.googlesource.com/sdk.git/+/97772dd77255b2959bb7539485db2293b3d74e64)
by Daco Harkes · 2 days ago

[f2d70ce](https://dart.googlesource.com/sdk.git/+/f2d70cec0415f24c839baaef117731a61b4434e5)
[[vm,arm64] Fix AddImmediate in case of
CSP](https://dart.googlesource.com/sdk.git/+/f2d70cec0415f24c839baaef117731a61b4434e5)
by Alexander Markov · 2 days ago

[5f9e3af](https://dart.googlesource.com/sdk.git/+/5f9e3af19c0dffebadc17f7e7bbcd50b67998092)
[Elements. Migrate
BinaryExpressionResolver.](https://dart.googlesource.com/sdk.git/+/5f9e3af19c0dffebadc17f7e7bbcd50b67998092)
by Konstantin Shcheglov · 2 days ago

[30d6cc9](https://dart.googlesource.com/sdk.git/+/30d6cc9394fad4c178bc93e6b4d13151cf07b984)
[[vm,tests] Fix vm/dart/devirtualization_during_inlining_il_test on
vm-aot-optimization-level-linux-release-x64](https://dart.googlesource.com/sdk.git/+/30d6cc9394fad4c178bc93e6b4d13151cf07b984)
by Alexander Markov · 2 days ago

[7134a45](https://dart.googlesource.com/sdk.git/+/7134a451f3d86ccfc93a7f8f109ee93f056e7d95)
[Format
tests/language/i*.](https://dart.googlesource.com/sdk.git/+/7134a451f3d86ccfc93a7f8f109ee93f056e7d95)
by Robert Nystrom · 2 days ago

[43e190b](https://dart.googlesource.com/sdk.git/+/43e190beda22b15310b6f37b4f672ff1adf347b9)
[[deps] rev core, ecosystem, http, markdown, test, vector_math, web,
web_socket_channel, webdev,
webdriver](https://dart.googlesource.com/sdk.git/+/43e190beda22b15310b6f37b4f672ff1adf347b9)
by Devon Carew · 2 days ago

[ba301f4](https://dart.googlesource.com/sdk.git/+/ba301f49c0c3dedda81c6accf09db9ee89beb700)
[Roll BoringSSL from 2b19cd39ba3a to ea42fe287758 (7
revisions)](https://dart.googlesource.com/sdk.git/+/ba301f49c0c3dedda81c6accf09db9ee89beb700)
by DEPS Autoroller · 2 days ago

[075bbe9](https://dart.googlesource.com/sdk.git/+/075bbe92456a5d3829809647a6fd3d7e208c71fa)
[[cfe] Create SourceClassBuilder throught
ClassDeclaration+Fragment](https://dart.googlesource.com/sdk.git/+/075bbe92456a5d3829809647a6fd3d7e208c71fa)
by Johnni Winther · 2 days ago

[c833c12](https://dart.googlesource.com/sdk.git/+/c833c1227ccdbf587fb1fc120efda2f8745148b4)
[[dart2wasm] Add support for dispatch table calls to unchecked
entries](https://dart.googlesource.com/sdk.git/+/c833c1227ccdbf587fb1fc120efda2f8745148b4)
by Martin Kustermann · 2 days ago

[7c22f94](https://dart.googlesource.com/sdk.git/+/7c22f942aa88b78667781cbc83d89a035348f598)
[[_fe_analyzer_shared] Remove macro tests and
helpers](https://dart.googlesource.com/sdk.git/+/7c22f942aa88b78667781cbc83d89a035348f598)
by Johnni Winther · 3 days ago

[ca16a42](https://dart.googlesource.com/sdk.git/+/ca16a4271cbb9bec2da06aa2bf95b70c9f7b3953)
[[scanner] Replace
KeywordState](https://dart.googlesource.com/sdk.git/+/ca16a4271cbb9bec2da06aa2bf95b70c9f7b3953)
by Jens Johansen · 3 days ago

[49a9d42](https://dart.googlesource.com/sdk.git/+/49a9d42cfc08138b3d230296d704ae99c4ae1323)
[[scanner] Ask VM to inline
Token._setCommentParent](https://dart.googlesource.com/sdk.git/+/49a9d42cfc08138b3d230296d704ae99c4ae1323)
by Jens Johansen · 3 days ago

[95265c3](https://dart.googlesource.com/sdk.git/+/95265c319c101636e15e36d36f26e7836e8bfe18)
[[scanner] Optimize scanning of identifiers, comments, spaces
etc.](https://dart.googlesource.com/sdk.git/+/95265c319c101636e15e36d36f26e7836e8bfe18)
by Jens Johansen · 3 days ago

[f534c13](https://dart.googlesource.com/sdk.git/+/f534c1337f7c2e91f215ceffa51109bf5d5dbc71)
[[dart2js, ddc] Slightly quicker 'as' checks for primitve
types](https://dart.googlesource.com/sdk.git/+/f534c1337f7c2e91f215ceffa51109bf5d5dbc71)
by Stephen Adams · 3 days ago

[81f7324](https://dart.googlesource.com/sdk.git/+/81f73241653d1edbb38a9d226f1dc3799fe947ef)
[Format
tests/language/l*.](https://dart.googlesource.com/sdk.git/+/81f73241653d1edbb38a9d226f1dc3799fe947ef)
by Robert Nystrom · 3 days ago

[9e3daae](https://dart.googlesource.com/sdk.git/+/9e3daae3cadaf59fed3defd43d528f45e7f1ad33)
[Roll Fuchsia SDK from 26.20250120.5.1 to
27.20250203.4.1](https://dart.googlesource.com/sdk.git/+/9e3daae3cadaf59fed3defd43d528f45e7f1ad33)
by DEPS Autoroller · 3 days ago

[83cb99c](https://dart.googlesource.com/sdk.git/+/83cb99cec8fd42256b8497ef0eca58cf4fe96346)
[Roll BoringSSL from afa405fd7c90 to 2b19cd39ba3a (6
revisions)](https://dart.googlesource.com/sdk.git/+/83cb99cec8fd42256b8497ef0eca58cf4fe96346)
by DEPS Autoroller · 3 days ago

[919160c](https://dart.googlesource.com/sdk.git/+/919160ca6502e49e3d2b2457396394c92d8244a6)
[Roll Fuchsia Test Scripts from 47fHFQ75rAiCuvG7G... to
2fowg5AX8Ry8Vf_Ku...](https://dart.googlesource.com/sdk.git/+/919160ca6502e49e3d2b2457396394c92d8244a6)
by DEPS Autoroller · 3 days ago

[1e8b9ea](https://dart.googlesource.com/sdk.git/+/1e8b9eae70aa1183c2c3f6b5cbba25b23f3336b4)
[Version
3.8.0-71.0.dev](https://dart.googlesource.com/sdk.git/+/1e8b9eae70aa1183c2c3f6b5cbba25b23f3336b4)
by Dart CI · 3 days ago
[3.8.0-71.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.8.0-71.0.dev)

[5e52d5b](https://dart.googlesource.com/sdk.git/+/5e52d5bac322f17d045f4423e3575ee4f0e27433)
[Bump github/codeql-action from 3.28.5 to
3.28.8](https://dart.googlesource.com/sdk.git/+/5e52d5bac322f17d045f4423e3575ee4f0e27433)
by dependabot[bot] · 3 days ago

[2cf3a72](https://dart.googlesource.com/sdk.git/+/2cf3a726b2ec34f722a0e96c71e5334063085022)
[Bump actions/setup-python from 5.3.0 to
5.4.0](https://dart.googlesource.com/sdk.git/+/2cf3a726b2ec34f722a0e96c71e5334063085022)
by dependabot[bot] · 3 days ago

[466cc35](https://dart.googlesource.com/sdk.git/+/466cc35c7eff7244bf00885e8fb88c59020ce9e0)
[[CQ] correct options fix test
docs](https://dart.googlesource.com/sdk.git/+/466cc35c7eff7244bf00885e8fb88c59020ce9e0)
by pq · 3 days ago

[2ac5992](https://dart.googlesource.com/sdk.git/+/2ac59922d2e6ab5f62ceb8725ffad96cfd147c68)
[DAS plugins: Support fixes to ignore
diagnostics](https://dart.googlesource.com/sdk.git/+/2ac59922d2e6ab5f62ceb8725ffad96cfd147c68)
by Sam Rawlins · 3 days ago

[4305541](https://dart.googlesource.com/sdk.git/+/430554158e74e862ead25d21b013eb769056431c)
[[vm] Support implicit dynamic
calls](https://dart.googlesource.com/sdk.git/+/430554158e74e862ead25d21b013eb769056431c)
by Alexander Markov · 3 days ago

[052e03c](https://dart.googlesource.com/sdk.git/+/052e03c82905ea6342bb2176085df7707ef85c02)
[DAS plugins: Support plugin-namespaced inline ignore
comments](https://dart.googlesource.com/sdk.git/+/052e03c82905ea6342bb2176085df7707ef85c02)
by Sam Rawlins · 3 days ago

[00e5314](https://dart.googlesource.com/sdk.git/+/00e5314d7b70f997d562bf1dd7aeb4d171f9bbbb)
[[vm,compiler] Do not treat unrelated DynamicInvocation flag as
InstanceInvocation.FlagInvariant](https://dart.googlesource.com/sdk.git/+/00e5314d7b70f997d562bf1dd7aeb4d171f9bbbb)
by Alexander Markov · 3 days ago

[938d9c0](https://dart.googlesource.com/sdk.git/+/938d9c0dc8ed139fc7b15481ed5026258af1d866)
[[cfe] Create synthesized super classes
late](https://dart.googlesource.com/sdk.git/+/938d9c0dc8ed139fc7b15481ed5026258af1d866)
by Johnni Winther · 3 days ago

[98e29db](https://dart.googlesource.com/sdk.git/+/98e29db45cd969a0a1cd913ef69e231307b17b02)
[[native_assets] Disable experiment on stable and beta
channel](https://dart.googlesource.com/sdk.git/+/98e29db45cd969a0a1cd913ef69e231307b17b02)
by Daco Harkes · 4 days ago

[74f2d4b](https://dart.googlesource.com/sdk.git/+/74f2d4b1afef800e5728558889b77429d4bd8d01)
[[vm/ffi] Error on invoking callback from leaf
call](https://dart.googlesource.com/sdk.git/+/74f2d4b1afef800e5728558889b77429d4bd8d01)
by Daco Harkes · 4 days ago

[5984cc8](https://dart.googlesource.com/sdk.git/+/5984cc8c24ac4989a6ddf65a5c4b76c32bd7fad0)
[[vm] Verify transitions in generated
code](https://dart.googlesource.com/sdk.git/+/5984cc8c24ac4989a6ddf65a5c4b76c32bd7fad0)
by Daco Harkes · 4 days ago

[6157f45](https://dart.googlesource.com/sdk.git/+/6157f4598cf64ae5d189be5035dac1b286796b5e)
[[benchmark][ffi] Add simple callback
benchmark](https://dart.googlesource.com/sdk.git/+/6157f4598cf64ae5d189be5035dac1b286796b5e)
by Daco Harkes · 4 days ago

[68d334d](https://dart.googlesource.com/sdk.git/+/68d334d6204c219248202b9a54dc4b751192ddf6)
[Replace link to non-existent language versioning document with current
dev docs on
subject](https://dart.googlesource.com/sdk.git/+/68d334d6204c219248202b9a54dc4b751192ddf6)
by Tim Maffett · 4 days ago

[3a4277b](https://dart.googlesource.com/sdk.git/+/3a4277bdef70dd11ea2719be9715a1089dc739d6)
[[docs] Add GSoC 2025 project
ideas](https://dart.googlesource.com/sdk.git/+/3a4277bdef70dd11ea2719be9715a1089dc739d6)
by Daco Harkes · 4 days ago

[0dfbab89](https://dart.googlesource.com/sdk.git/+/0dfbab89cba46e6bd750e674af0f9ee26f0c2240)
[Make tests/lib/js/static_interop not use
minitest.](https://dart.googlesource.com/sdk.git/+/0dfbab89cba46e6bd750e674af0f9ee26f0c2240)
by Lasse R.H. Nielsen · 4 days ago

[e534983](https://dart.googlesource.com/sdk.git/+/e534983216e6db5fdc8bd7c773c3a6a5a519301a)
[Linkable AOT snapshots on
macOS](https://dart.googlesource.com/sdk.git/+/e534983216e6db5fdc8bd7c773c3a6a5a519301a)
by Ivan Inozemtsev · 4 days ago

[d678a7e](https://dart.googlesource.com/sdk.git/+/d678a7e191c0b99e5367e2819c46597b7b356d35)
[[analyzer] Stop generating the diagnostics.md
file](https://dart.googlesource.com/sdk.git/+/d678a7e191c0b99e5367e2819c46597b7b356d35)
by Parker Lougheed · 4 days ago

[7bb0c4c](https://dart.googlesource.com/sdk.git/+/7bb0c4cdf42db9252a969c9984f86da71c487c25)
[Update d8 and jsc in
DEPS](https://dart.googlesource.com/sdk.git/+/7bb0c4cdf42db9252a969c9984f86da71c487c25)
by Srujan Gaddam · 4 days ago

[dacb2a7](https://dart.googlesource.com/sdk.git/+/dacb2a71a7566c687c3a04e33200250b1137899e)
[[ CLI ] Remove implicit entry into DartDev if VM service is
enabled](https://dart.googlesource.com/sdk.git/+/dacb2a71a7566c687c3a04e33200250b1137899e)
by Ben Konyi · 4 days ago

[5454e70](https://dart.googlesource.com/sdk.git/+/5454e70ce25a0e10f43d0982ca3949a7ffe18b30)
[[migration] Rename utilities in
protocol_dart.dart](https://dart.googlesource.com/sdk.git/+/5454e70ce25a0e10f43d0982ca3949a7ffe18b30)
by Brian Wilkerson · 4 days ago

[a9f288a](https://dart.googlesource.com/sdk.git/+/a9f288a810f96497b3df5fa5817a9316795f7abd)
[[diagnostics] fix `removed_lint`
reporting](https://dart.googlesource.com/sdk.git/+/a9f288a810f96497b3df5fa5817a9316795f7abd)
by pq · 4 days ago

[fb0cac7](https://dart.googlesource.com/sdk.git/+/fb0cac7375664e8204ad831af92bedbb79d4ca52)
[[vm] Fix uninitialized Code::instructions_ during deferred
loading.](https://dart.googlesource.com/sdk.git/+/fb0cac7375664e8204ad831af92bedbb79d4ca52)
by Ryan Macnak · 4 days ago

[2e13d4d](https://dart.googlesource.com/sdk.git/+/2e13d4d95498a586df8a5b7ce984640902d76c4a)
[[linter] Doc and changelog
updates](https://dart.googlesource.com/sdk.git/+/2e13d4d95498a586df8a5b7ce984640902d76c4a)
by Parker Lougheed · 4 days ago

[0d03fb8](https://dart.googlesource.com/sdk.git/+/0d03fb88d6f1e14b4c2f758cd0abd0782626faa2)
[Make more methods
synchronous.](https://dart.googlesource.com/sdk.git/+/0d03fb88d6f1e14b4c2f758cd0abd0782626faa2)
by Konstantin Shcheglov · 4 days ago

[448f0d4](https://dart.googlesource.com/sdk.git/+/448f0d408028113d196d45d0322f862737f87a2d)
[[migrate]
server/protocol_dart.dart](https://dart.googlesource.com/sdk.git/+/448f0d408028113d196d45d0322f862737f87a2d)
by Brian Wilkerson · 4 days ago
2025-02-11 02:12:49 +00:00
engine-flutter-autoroll
e8a0fbbe69
Roll Skia from 8c377e8bedd2 to 5b56d9a91633 (9 revisions) (#163021)
https://skia.googlesource.com/skia.git/+log/8c377e8bedd2..5b56d9a91633

2025-02-10 bungeman@google.com SkScalerContext to not own SkTypeface
2025-02-10 jamesgk@google.com Revert "Roll Fontations, Skrifa to 0.27"
2025-02-10 robertphillips@google.com [graphite] Add jobs to exercise the
gr*testprecompile configs
2025-02-10 robertphillips@google.com Serialize stableKeys, rather than
SkSL code, for runtimeEffects in skp files
2025-02-10 drott@chromium.org Roll Fontations, Skrifa to 0.27
2025-02-10 egdaniel@google.com [Graphite] Fix ResourceCache Token if
size changes.
2025-02-10 kjlubick@google.com Cleanups in SkEdge and SkAnalyticEdge
2025-02-10 jvanverth@google.com [graphite] Disable clip atlas manager
for now.
2025-02-10 jvanverth@google.com [graphite] Use more integer types in
path atlas code.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,jamesgk@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-11 02:07:08 +00:00
Robert Ancell
af3c91045b
Fix Linux keyboard support for AltGr (#162495)
This was previously connected to right alt, which was confusing the
keyboard handling code into generating up events for this key when it
didn't match the expected values. This key is also configurable, and
only defaults to right alt in Ubuntu/GNOME.

Fixes https://github.com/flutter/flutter/issues/154053
2025-02-11 01:03:48 +00:00
Jonah Williams
9438fd4471
[Android] add runtime flag to determine if HCPP is supported. (#163004)
Developers will need to _conditionally_ use HCPP (or the framework will
need to handle it automatically). This requires the ability to query at
runtime whether HCPP mode is enabled + supported.

Add a message channel to do so, and add the usage of this to the
android_engine_test. Does not yet add any automatic selection.

---------

Co-authored-by: Matan Lurey <matanlurey@users.noreply.github.com>
2025-02-10 22:43:25 +00:00
Koji Wakamiya
5e37c966c0
[iOS][Engine] Fix view removal process for AutofillContextAction.cancel (#160653)
Original PR https://github.com/flutter/engine/pull/57209

---

The `removeFromSuperview` in the `hideTextInput` method was triggering
the save password, so I changed it to `cleanUpViewHierarchy`.

fix https://github.com/flutter/flutter/issues/145681

sample app code

https://github.com/koji-1009/autofill_cancel_issue

before


https://github.com/user-attachments/assets/c380538b-6783-4706-9a09-4db1c3b761df

after


https://github.com/user-attachments/assets/b6654b80-f383-408d-9820-6fe53279ce14

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-10 22:10:15 +00:00
Yegor
c5fbe83809
[web] robustify safaridriver launch sequence (#162919)
Improve safaridriver launch sequence as follows:

- Fix retry: the previous version would call `_startDriverProcess`
recursively from within a listener to the stderr output. But by then the
outer `_startDriverProcess` call would have completed its future, so the
retry mechanism would kick in while tests are already running.
- Wait for `safaridriver` server process to start listening and
responding to WebDriver commands (using `/status` as the smoke test).
- Smoke-test the driver session by attempting to list all windows
(`WebDriver.windows`).
- When `safaridriver` fails to pass all of the above checks, both close
the session and kill the `safaridriver` process. Killing the process
alone leaves Safari windows open. Closing the session alone leaves
`safaridriver` processes open.
- When tests are finished use `quit()` instead of `window.close()`,
because the latter does not close the session.
2025-02-10 21:27:40 +00:00
engine-flutter-autoroll
4fdcb400bc
Roll Skia from 180ed4fc263d to 8c377e8bedd2 (4 revisions) (#162998)
https://skia.googlesource.com/skia.git/+log/180ed4fc263d..8c377e8bedd2

2025-02-10 bungeman@google.com SkTypeface_fontconfig::onMakeClone to
keep pattern
2025-02-10 kylechar@chromium.org Add SingleOwner to DawnResourceProvider
2025-02-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from b4c8dd090b72 to cd5e835851d1 (1 revision)
2025-02-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from ffb7575c7d58 to ef2ef1072427 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,jamesgk@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-10 19:24:42 +00:00
gaaclarke
58bc9643b5
[Impeller] rrect_blur: scale max radius clamp by transform (#161238)
migrated PR https://github.com/flutter/engine/pull/54350

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-10 19:23:16 +00:00
Jason Simmons
a5ed6aea7a
Remove the redirects from src/build_overrides to src/flutter/build_overrides (#162553)
These were created when the buildroot and flutter/engine were separate
repositories. They are no longer needed in the monorepo.
2025-02-10 19:21:57 +00:00
engine-flutter-autoroll
e7cb7a30bb
Roll Skia from 22f96cc60dec to 180ed4fc263d (2 revisions) (#162974)
https://skia.googlesource.com/skia.git/+log/22f96cc60dec..180ed4fc263d

2025-02-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from fe735af98e27 to 21597fbbfeb0 (12 revisions)
2025-02-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 19cc3648535f to a1770b70c6be (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,jamesgk@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-10 09:49:12 +00:00
Robert Ancell
99690cb8c7
Drop link to engine.version which is no longer checked in. (#162497)
The engine SHA is the same as the Flutter SHA since they were merged in
the monorepo.
2025-02-10 04:43:36 +00:00
engine-flutter-autoroll
829fe68e9d
Roll Skia from d25aea76dbc7 to 8e83e49cba3a (27 revisions) (#162911)
https://skia.googlesource.com/skia.git/+log/d25aea76dbc7..8e83e49cba3a

2025-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c32804ca5a39 to d7a3a302691b (3 revisions)
2025-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 483be92cf076 to e9cda7f685da (10 revisions)
2025-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from ecff3b887f5d to fe735af98e27 (6 revisions)
2025-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 863d392cd025 to 2acbf990918f (32 revisions)
2025-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from f1d4fcb60688 to c32804ca5a39 (14 revisions)
2025-02-06 kjlubick@google.com Minor cleanups in SkEdgeBuilder
2025-02-06 kjlubick@google.com SkBlitter cleanups
2025-02-06 kjlubick@google.com Small MaskFilter cleanups
2025-02-06 nicolettep@google.com Revert "fix image serialization for
MSKPs on Android using derived generators"
2025-02-06 bungeman@google.com Fix FontMgrFontConfig_Fontations_AllBold
test
2025-02-06 kjlubick@google.com Remove redundant pis from src/
2025-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 46d51c9afa5d to f1d4fcb60688 (2 revisions)
2025-02-06 lokokung@google.com [dawn][headers] Use renamed
wgpu::ImageCopyTexture structure.
2025-02-06 danieldilan@google.com [png] Allow fInterlaceBuffer to fail
on malloc instead of abort
2025-02-06 bungeman@google.com Correct "proxy" terminology, remove
setProxy
2025-02-06 robertphillips@google.com [graphite] Add Vulkan serialization
for Android-style Precompile keys
2025-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from aa94da0253a2 to 483be92cf076 (12 revisions)
2025-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from aac2fe5e6d52 to ecff3b887f5d (10 revisions)
2025-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 28a2e8a45f16 to 5017ce3c800e (1 revision)
2025-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 83cddb9b590f to 863d392cd025 (24 revisions)
2025-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 4d67b5012a2f to 46d51c9afa5d (9 revisions)
2025-02-05 jvanverth@google.com [graphite] Address some clip atlas bugs.
2025-02-05 robertphillips@google.com [graphite] Precompile cleanup
2025-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from c83c11cec8f5 to 8b3338080c3c
2025-02-05 jmbetancourt@google.com fix image serialization for MSKPs on
Android using derived generators
2025-02-05 nscobie@google.com Correct CtsEnforcement::kApiLevel_V to
kApiLevel_202404
2025-02-05 lokokung@google.com [dawn][headers] Use
InstanceDescriptor.capabilities.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,kjlubick@google.com,nicolettep@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-02-08 01:05:01 +00:00
Jonah Williams
53bcdf2cda
[Android] Make PVC1 and PVC2 share a platform view registry. (#162857)
This avoids the insanity of having to register everything twice. Since
the object is shared a registration on pvc1 will automatically apply to
pvc2.
2025-02-08 01:05:00 +00:00
Jonah Williams
ec7cdbd126
[Android] Add missing API level check for hcpp (#162901)
Requires API 34
2025-02-07 21:52:35 +00:00
Mouad Debbar
a33904a57a
[web] Move frame_reference.dart to the html/ folder (#162608)
The `frame_reference.dart` file is only used by the HTML renderer. I'm
moving the file to the `html/` folder so that we don't forget to delete
with the rest of the HTML renderer code.
2025-02-07 18:35:43 +00:00
engine-flutter-autoroll
892f9c13a2
Roll Skia from 4bdf90faf708 to d25aea76dbc7 (38 revisions) (#162746)
Roll Skia from 4bdf90faf708 to d25aea76dbc7 (38 revisions)

https://skia.googlesource.com/skia.git/+log/4bdf90faf708..d25aea76dbc7

2025-02-05 kjlubick@google.com Cleanups related to Masks and RRects
2025-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 9fa954563726 to 4d67b5012a2f (4 revisions)
2025-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 957bafb51066 to aa94da0253a2 (7 revisions)
2025-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 16948351755e to aac2fe5e6d52 (9 revisions)
2025-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 86cf34f50cbe to 28a2e8a45f16 (1 revision)
2025-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 7132f397c4b2 to 83cddb9b590f (20 revisions)
2025-02-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 6fe9d7e0521b to 9fa954563726 (6 revisions)
2025-02-04 bungeman@google.com [pdf] Do not scale miterLimit
2025-02-04 briansalomon@gmail.com [graphite] list MtlGraphiteTypesPriv.h
in bazel/gn sources
2025-02-04 robertphillips@google.com [graphite] Add
PrecompileContext::precompile option
2025-02-04 hcm@google.com Merge 3 release notes into RELEASE_NOTES.md
2025-02-04 kjlubick@google.com Apply clang-tidy suggestion to
GrProcessorUnitTest.cpp
2025-02-04 lokokung@google.com [dawn][header] Use wgpu::StringView
instead of const char*.
2025-02-04 hcm@google.com Update Skia milestone to 135
2025-02-04 lokokung@google.com [dawn][headers] Use PassTimestampWrites.
2025-02-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 2e4b45a53a0e to 6fe9d7e0521b (10 revisions)
2025-02-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 44b5f0a59f2a to 957bafb51066 (6 revisions)
2025-02-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from f69f215a2ce4 to 16948351755e (9 revisions)
2025-02-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from acd89d9f169a to 7132f397c4b2 (15 revisions)
2025-02-03 egdaniel@google.com [Graphite] Update Vulkan buffer barriers.
2025-02-03 kjlubick@google.com Update skottie-base to include
skottie-dev files
2025-02-03 renatopereyra@google.com [Ganesh] Update Intel GPU mappings
in Vulkan backend
2025-02-03 jvanverth@google.com [graphite] Set up atlas-based clipping.
2025-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from de6d9c09f769 to 2e4b45a53a0e (30 revisions)
2025-02-03 robertphillips@google.com [graphite] Fix ContextOptions.h
#includes
2025-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 938de304bdcb to de6d9c09f769 (14 revisions)
2025-02-03 fmalita@google.com [skottie] Drop motion blur support
2025-02-03 robertphillips@google.com Make the Ganesh/Graphite DM
precompilation options more distinct
2025-02-03 robertphillips@google.com [graphite] Add API to return
Android-specific keys back to the user
2025-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from c469d593acab to acd89d9f169a (1 revision)
2025-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 53594a79cc60 to f69f215a2ce4 (13 revisions)
2025-02-01 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
ANGLE from 439dfe5e2c51 to 44b5f0a59f2a (14 revisions)
2025-02-01 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 6bc6697d10a4 to c469d593acab (10 revisions)
2025-01-31 egdaniel@google.com [Graphite] Use Dawn
disable_lazy_clear_for_mapped_at_creation_buffer toggle
2025-01-31 fmalita@google.com [skottie] Visible track matte adjustments
2025-01-31 robertphillips@google.com Actually draw the new gradient
interpolation types
2025-01-31 bwils@google.com Skottie no longer checks version is set
2025-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from e330d9595d80 to 439dfe5e2c51 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,kjlubick@google.com,nicolettep@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
...
2025-02-07 17:15:20 +00:00
gaaclarke
68e785e868
Fixed translated text's subpixel alignment. (#162824)
fixes https://github.com/flutter/flutter/issues/162776
fixes https://github.com/flutter/flutter/issues/149652

Previously we weren't calculating the subpixel offset correctly. We
weren't using the transform of the object being drawn to get global
coordinates, now we are.

## Video of https://github.com/flutter/flutter/issues/149652 after PR



https://github.com/user-attachments/assets/3e9063d5-f70c-46d0-a7a4-892819b247b8



## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-07 15:50:50 +00:00
Jonah Williams
f0396970e9
[Android] HC++ wire up dart platform channel code and integration test. (#162751)
Use the PlatformViewController2 to register a platform view, allow the
dart side platform view logic to opt into this new platform view. Wires
up an integration test with android_engine_test.
2025-02-07 03:09:24 +00:00
Harry Terkelsen
db7e82bdfb
chore(canvaskit): remove SurfaceFrame from Surface (#162825)
SurfaceFrame is no longer used. This is a cleanup in preparation for a
larger refactor of `Surface` to improve performance.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-06 23:59:30 +00:00
Harry Terkelsen
1b095a030d
[canvaskit] Resize to exactly the requested dimensions (#162708)
Adds a `SurfaceResizeStrategy` to `Surface`. The default option,
`onlyGrow`, implements the current behavior of only re-allocating the
Surface when the requested size is larger than the currently allocated
Surface. This PR adds the option of `SurfaceResizeStrategy.exact` which
always reallocates the Surface and resizes the underlying
OffscreenCanvas. This options performs better in practice since having
the OffScreenCanvas larger than the actual rendered size causes calls to
`createImageBitmap` to be slower than if the OffscreenCanvas is exactly
the size of the bitmap being created.

Fixes https://github.com/flutter/flutter/issues/162700

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-06 20:11:37 +00:00